#metabrainz

/

      • Nyanko-sensei has quit
      • 2021-01-21 02151, 2021

      • antlarr joined the channel
      • 2021-01-21 02108, 2021

      • Nyanko-sensei joined the channel
      • 2021-01-21 02126, 2021

      • flamingspinach has quit
      • 2021-01-21 02139, 2021

      • flamingspinach joined the channel
      • 2021-01-21 02158, 2021

      • flamingspinach has quit
      • 2021-01-21 02117, 2021

      • flamingspinach joined the channel
      • 2021-01-21 02105, 2021

      • BrainzGit has left the channel
      • 2021-01-21 02124, 2021

      • BrainzGit joined the channel
      • 2021-01-21 02136, 2021

      • sumedh joined the channel
      • 2021-01-21 02158, 2021

      • blinky42 has quit
      • 2021-01-21 02148, 2021

      • Nyanko-sensei has quit
      • 2021-01-21 02117, 2021

      • Nyanko-sensei joined the channel
      • 2021-01-21 02118, 2021

      • sumedh has quit
      • 2021-01-21 02131, 2021

      • sumedh joined the channel
      • 2021-01-21 02141, 2021

      • zas
        bitmap: "it'd be nice to bump pg from 12.3 -> 12.5 so we can schedule some downtime for those I guess" -> when?
      • 2021-01-21 02152, 2021

      • yvanzo
        reosarevok: thanks for the phrasing, also fixed lookup forms descriptions after your early comments.
      • 2021-01-21 02149, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1872 (master…MBS-11330): MBS-11330: Split root/types.js into smaller files https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-21 02110, 2021

      • reosarevok
        bitmap: ^ I'd like comments on this, still officially a draft
      • 2021-01-21 02132, 2021

      • reosarevok
        yvanzo: you too if you want :) Just assuming bitmap has more specific ideas since it was his idea to begin with
      • 2021-01-21 02133, 2021

      • ruaok
        moooin!
      • 2021-01-21 02145, 2021

      • ruaok
        Mr_Monkey: I've updated beta.lb.org with the latest and greatest.
      • 2021-01-21 02155, 2021

      • ruaok
        the rec feedback now loads correctly.
      • 2021-01-21 02104, 2021

      • Mr_Monkey
        Heh, already did it last night :)
      • 2021-01-21 02111, 2021

      • Mr_Monkey
        But yes, good to see it all working
      • 2021-01-21 02112, 2021

      • ruaok
        have another look -- if you/re happy, I can release.
      • 2021-01-21 02123, 2021

      • ruaok
        ah, I didn't see that. ok.
      • 2021-01-21 02128, 2021

      • ruaok
        so, release then?
      • 2021-01-21 02127, 2021

      • Mr_Monkey
        OK for me
      • 2021-01-21 02120, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1873 (master…MBS-11340): MBS-11340: Allow more characters on Spotify user URLs https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-21 02101, 2021

      • Gazooo79494 has quit
      • 2021-01-21 02145, 2021

      • Gazooo79494 joined the channel
      • 2021-01-21 02123, 2021

      • ruaok
        lb production updated!
      • 2021-01-21 02147, 2021

      • alastairp
        cool, new features! bug fixes!
      • 2021-01-21 02139, 2021

      • ruaok
        alastairp: iliekcomputers : can one of you two please push the release notes?
      • 2021-01-21 02149, 2021

      • ruaok
        tag is pushed.
      • 2021-01-21 02159, 2021

      • BrainzGit
        [listenbrainz-server] release v-2021-01-21.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-21 02110, 2021

      • iliekcomputers
        done.
      • 2021-01-21 02134, 2021

      • iliekcomputers
        thanks ruaok for the release!
      • 2021-01-21 02124, 2021

      • ruaok
        thank you!
      • 2021-01-21 02150, 2021

      • D4RK-PH0_ joined the channel
      • 2021-01-21 02109, 2021

      • alastairp
        I think we're getting better at this
      • 2021-01-21 02105, 2021

      • Nyanko-sensei has quit
      • 2021-01-21 02120, 2021

      • ruaok posts a tweet
      • 2021-01-21 02104, 2021

      • _lucifer
        alastairp: Hi! I was trying to prepare the CB for consul upgrade. I think cron jobs for CB are run in the same container as the website. Is that right?
      • 2021-01-21 02118, 2021

      • alastairp
        hi _lucifer. that might be the case, I'm not sure
      • 2021-01-21 02129, 2021

      • alastairp
        however it makes sense that we split it out into a separate container like LB and AB
      • 2021-01-21 02147, 2021

      • ruaok
        pristine___: spark-request-consumer updated in case it was necessary. :)
      • 2021-01-21 02158, 2021

      • ruaok
        TFW you mark a sentry issue as fixed and it instantly marks it as a regression.
      • 2021-01-21 02139, 2021

      • ruaok
        ah, time to restart the spotify reader
      • 2021-01-21 02132, 2021

      • BrainzGit
        [critiquebrainz] amCap1712 opened pull request #336 (master…consul): Prepare for consul upgrade https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-01-21 02141, 2021

      • ruaok
        ok, hopefully we're on track now for making sentry quieter.
      • 2021-01-21 02150, 2021

      • ruaok
        I'll start the next round of that on monday.
      • 2021-01-21 02159, 2021

      • iliekcomputers
        at this point i'd like to move the stats observability emails to an IRC channel too possibly, maybe #metabrainz-observability or something
      • 2021-01-21 02153, 2021

      • alastairp
        personally I'd prefer email :)
      • 2021-01-21 02108, 2021

      • ruaok
        zas: any idea why PRIVATE_IP in this context is blank?
      • 2021-01-21 02108, 2021

      • ruaok
      • 2021-01-21 02121, 2021

      • ruaok
        (and CONSUL_PORT as well)
      • 2021-01-21 02137, 2021

      • ruaok
        it should be getting set by sourcing services.sh .
      • 2021-01-21 02138, 2021

      • iliekcomputers
        alastairp: hmm. maybe i should just improve my filters instead :D
      • 2021-01-21 02148, 2021

      • iliekcomputers
        def less work
      • 2021-01-21 02117, 2021

      • alastairp
        iliekcomputers: what's the result that you're trying to achieve?
      • 2021-01-21 02104, 2021

      • iliekcomputers
        initially the emails were there so that we'd get active notifications when the cron jobs succeeded.
      • 2021-01-21 02139, 2021

      • iliekcomputers
        they've been stable now for a long enough time that it'd probably be ok if the records existed without notifications
      • 2021-01-21 02152, 2021

      • iliekcomputers
        so that when i need to look at them, i can, but i don't get notifications
      • 2021-01-21 02156, 2021

      • alastairp
        ah, I thought your focus was on notifications when things fail
      • 2021-01-21 02138, 2021

      • D4RK-PH0_ has quit
      • 2021-01-21 02141, 2021

      • Nyanko-sensei joined the channel
      • 2021-01-21 02127, 2021

      • zas
        ruaok: may be because it's a subprocess, vars aren't exported
      • 2021-01-21 02138, 2021

      • zas
        or because of whitespace before =
      • 2021-01-21 02100, 2021

      • zas
      • 2021-01-21 02121, 2021

      • Etua joined the channel
      • 2021-01-21 02117, 2021

      • Etua has quit
      • 2021-01-21 02140, 2021

      • Etua joined the channel
      • 2021-01-21 02136, 2021

      • Etua1 joined the channel
      • 2021-01-21 02136, 2021

      • Etua has quit
      • 2021-01-21 02136, 2021

      • Etua1 is now known as Etua
      • 2021-01-21 02126, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #548 (master…snyk-upgrade-5f7a37754b4a06a43c29636fea313d34): [Snyk] Upgrade debug from 3.1.0 to 3.2.7 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-01-21 02159, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1855 (master…MBS-11324): MBS-11324: Trim input in the barcode otherlookups field https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-21 02136, 2021

      • sumedh has quit
      • 2021-01-21 02114, 2021

      • travis-ci joined the channel
      • 2021-01-21 02114, 2021

      • travis-ci
        Project bookbrainz-site build #3615: passed in 4 min 25 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-01-21 02114, 2021

      • travis-ci has left the channel
      • 2021-01-21 02130, 2021

      • lorenzuru has quit
      • 2021-01-21 02132, 2021

      • reg[m] has quit
      • 2021-01-21 02133, 2021

      • SamThursfield[m] has quit
      • 2021-01-21 02135, 2021

      • kepstin has quit
      • 2021-01-21 02136, 2021

      • joshuaboniface has quit
      • 2021-01-21 02144, 2021

      • maxlath[m] has quit
      • 2021-01-21 02144, 2021

      • goldenshimmer has quit
      • 2021-01-21 02145, 2021

      • MagnusSvensson[m has quit
      • 2021-01-21 02111, 2021

      • nobodyrocks[m] has quit
      • 2021-01-21 02111, 2021

      • devorizon[m] has quit
      • 2021-01-21 02150, 2021

      • MagnusSvensson[m joined the channel
      • 2021-01-21 02100, 2021

      • adhi001 joined the channel
      • 2021-01-21 02146, 2021

      • adhi001
        Guys, just found this - https://observablehq.com/@d3/versor-dragging, would it be better than the present data visualization presentation? The library too looks good, we can make use of other animations too.
      • 2021-01-21 02121, 2021

      • _lucifer
        adhi001, you'll need to provide more context
      • 2021-01-21 02119, 2021

      • adhi001
        I thought this can be used in listenbrainz artist origins data representation
      • 2021-01-21 02101, 2021

      • _lucifer
        ishaanshah and iliekcomputers worked on that. they'll be able to answer that.
      • 2021-01-21 02103, 2021

      • adhi001
        Oh okay
      • 2021-01-21 02156, 2021

      • CatQuest
        bwahaha I want this t-shirt so bad https://explicitshirtstore.com/the-south-butt-t-s…
      • 2021-01-21 02159, 2021

      • CatQuest
        lmao
      • 2021-01-21 02118, 2021

      • CatQuest
        maybe to obvious. maybe better a hoodie https://explicitshirtstore.com/the-south-butt-t-s…
      • 2021-01-21 02120, 2021

      • CatQuest
        :DDDD
      • 2021-01-21 02131, 2021

      • reg[m] joined the channel
      • 2021-01-21 02131, 2021

      • SamThursfield[m] joined the channel
      • 2021-01-21 02132, 2021

      • kepstin joined the channel
      • 2021-01-21 02132, 2021

      • goldenshimmer joined the channel
      • 2021-01-21 02132, 2021

      • lorenzuru joined the channel
      • 2021-01-21 02132, 2021

      • maxlath[m] joined the channel
      • 2021-01-21 02132, 2021

      • joshuaboniface joined the channel
      • 2021-01-21 02138, 2021

      • nobodyrocks[m] joined the channel
      • 2021-01-21 02138, 2021

      • devorizon[m] joined the channel
      • 2021-01-21 02128, 2021

      • sumedh joined the channel
      • 2021-01-21 02159, 2021

      • Etua1 joined the channel
      • 2021-01-21 02116, 2021

      • Etua has quit
      • 2021-01-21 02116, 2021

      • Etua1 is now known as Etua
      • 2021-01-21 02154, 2021

      • _lucifer
        alastairp: i have made the changes for consul upgrade of CB. does AB also need something similiar?
      • 2021-01-21 02155, 2021

      • _lucifer
        i saw that most of the changes for CB and LB are already present in AB.
      • 2021-01-21 02147, 2021

      • iliekcomputers
        adhi001: i think the map is more maintainable in the long term for us + personally I prefer the map where I can click whatever country I want without needing to drag as I'd have to in the globe.
      • 2021-01-21 02100, 2021

      • alastairp
        _lucifer: we have the split into separate services, but not the new base image version
      • 2021-01-21 02105, 2021

      • alastairp
        feel free to make that change too!
      • 2021-01-21 02150, 2021

      • alastairp
        other projects that need this - sir, artwork-redirect, and mb2wikidatabot
      • 2021-01-21 02105, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1225 (master…unused-config): Remove unused configuration options https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-21 02126, 2021

      • blinky42 joined the channel
      • 2021-01-21 02125, 2021

      • alastairp
        Mr_Monkey: js tests fail because eslint has errors and returns an error status code. If we want the test execution to pass but then report it as a degraded status in jenkins we should add `|| true` to the end of the test command
      • 2021-01-21 02147, 2021

      • Mr_Monkey
        OK, thanks
      • 2021-01-21 02110, 2021

      • Mr_Monkey
        I'm actually looking into why the lint command fails, but I was thinking about what you propose
      • 2021-01-21 02101, 2021

      • alastairp
        ✖ 55 problems (10 errors, 45 warnings)
      • 2021-01-21 02154, 2021

      • alastairp
      • 2021-01-21 02104, 2021

      • alastairp
        you should also add this to the docker cp commands, because if the test command fails and doesn't create the file, the cp will also fail causing the test to completely fail and meaning that there are no stats for that job run
      • 2021-01-21 02104, 2021

      • alastairp
        ruaok: Mr_Monkey: ishaanshah: shivam-kapila: iliekcomputers: I'm merging https://github.com/metabrainz/listenbrainz-server…, which combines the postgres and timescale databases in development which will mean that if you have local user data or messybrainz data it will disappear the next time you update. If this is a problem let me know and we can work out how to migrate data
      • 2021-01-21 02143, 2021

      • alastairp
        any timescale/listen data that you have stored will stay there
      • 2021-01-21 02117, 2021

      • Mr_Monkey
        I'm fine with nuking any local data I have
      • 2021-01-21 02102, 2021

      • shivam-kapila
        No issues for me too
      • 2021-01-21 02105, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #1250 (master…jenkins-javascript-linting-issue): Suppress javascript CI tests errors https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-21 02114, 2021

      • ruaok
        alastairp: fine by me
      • 2021-01-21 02141, 2021

      • alastairp
        nice 👍
      • 2021-01-21 02144, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1227 (master…combine-db): LB-765: In development, use a single postgres server for all databases https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-21 02100, 2021

      • alastairp
        Mr_Monkey: interestingly, jenkins says "JSLint Warnings: 55 warnings from one analysis", but eslint says "✖ 55 problems (10 errors, 45 warnings)"
      • 2021-01-21 02133, 2021

      • alastairp
        so it's possible that jenkins isn't correctly separating them by category (or the jslint output format doesn't support it, or the jenkins output parser doesn't support it)
      • 2021-01-21 02129, 2021

      • alastairp
        what's more, https://ci.metabrainz.org/job/listenbrainz-js/186… says that there is only one high-priority warning
      • 2021-01-21 02125, 2021

      • Mr_Monkey
        Hm. That's not ideal.
      • 2021-01-21 02115, 2021

      • shivam-kapila
        My local sytem has 34GB logs. I am sure I dotn need it but I dont havr much idea about utilities to help in this case
      • 2021-01-21 02129, 2021

      • Mr_Monkey
        Doesn't look like there's any concept of severity in the jslint-xml format as opposed to other formats
      • 2021-01-21 02151, 2021

      • shivam-kapila
        Anyone with some idea?
      • 2021-01-21 02151, 2021

      • alastairp
        Mr_Monkey: oh? :( maybe we can install a different plugin in jenkins to handle a different format
      • 2021-01-21 02140, 2021

      • alastairp
        Mr_Monkey: I use this for uniquing a list preserving order: https://stackoverflow.com/a/480227
      • 2021-01-21 02102, 2021

      • alastairp
        I don't think in this case it matters, I thought about it when I told you about the other way
      • 2021-01-21 02131, 2021

      • alastairp
        while now in python dictionaries are guaranteed to be in order, it didn't use to be the case and I don't like the magicness of it