Ok, pushed the change for the first, let's let the test run
2021-01-22 02244, 2021
alastairp
right, was just checking if consul-template was actually connecting to a server. so, you're seeing that the container comes up, but the config file that you want isn't there?
2021-01-22 02257, 2021
ruaok
corect.
2021-01-22 02245, 2021
ruaok
running `run-consul-template -config /etc/consul-template.conf` just hangs, eats all keyboard IO and produces no config file
2021-01-22 02258, 2021
reosarevok
And commented on the second. If you want a second commit let me know
2021-01-22 02213, 2021
reosarevok
yvanzo: another for you it seems: https://tickets.metabrainz.org/browse/MBBE-33 - although we don't currently https them automatically either. Maybe we should add a MBS ticket for that
2021-01-22 02214, 2021
BrainzBot
MBBE-33: Update Rateyourmusic URLs to use HTTPS
2021-01-22 02257, 2021
reosarevok
(only one or two days of decoda for artists for my bot...)
2021-01-22 02205, 2021
reosarevok
(we had so many, jeez)
2021-01-22 02258, 2021
alastairp
ruaok: what env vars are you setting in the startup?
reosarevok: yes, we should have https normalization deployed before running the script.
2021-01-22 02259, 2021
reosarevok
Ok, will add a ticket
2021-01-22 02219, 2021
reosarevok
Can deal with that next week
2021-01-22 02256, 2021
alastairp
ruaok: no, it defaults to the correct port if CONSUL_PORT isn't set. however it does need DEPLOY_ENV, because that's used in the consul template file (line 2)
MBS-11345: Error when submitting edit: deadlock detected
2021-01-22 02224, 2021
sumedh has quit
2021-01-22 02220, 2021
diru1100 has quit
2021-01-22 02228, 2021
sumedh joined the channel
2021-01-22 02224, 2021
bitmap
reosarevok: in the json fmt the count properties are only useful for paged lists (where it's a count of all results) or usage counts (e.g. for tags). this 'count' inside release searches is definitely errant
2021-01-22 02201, 2021
v6lur_ joined the channel
2021-01-22 02253, 2021
bitmap
the only other case where they're useful is when they provide a count of something that's not loaded, e.g. track-count is given even if you don't have inc=recordings
2021-01-22 02257, 2021
bitmap
so something like medium-count might make sense (but not 'count'), but I guess we only have track-count for lookups because it's cached in the medium table
any idea how we can have this type of error generate an error message?
2021-01-22 02246, 2021
d4rkie joined the channel
2021-01-22 02253, 2021
alastairp
ruaok: consul-template doesn't appear to throw an error if the env isn't there. We could update the run-consul-template script to emit a warning if that's the case, though I don't know if MBS uses that variable
2021-01-22 02247, 2021
ruaok
any indication that something went wrong would be a good start.
2021-01-22 02215, 2021
alastairp
I guess it doesn't consider that it's "wrong"
2021-01-22 02242, 2021
alastairp
I only worked it out because I was running the consul server and I saw it trying to request the variable LB..json instead of LB.prod.json
2021-01-22 02237, 2021
alastairp
let's check up with zas, perhaps we could have some pre-processing that reads the template file, looks for things that are env variables, and checks if they're set. Should be doable with grep
2021-01-22 02226, 2021
D4RK-PH0_ has quit
2021-01-22 02235, 2021
ruaok
if it didn't consider it wrong, why didn't it generate a file?
2021-01-22 02251, 2021
alastairp
because it couldn't find the variable in consul
2021-01-22 02256, 2021
ruaok
if the file is wrong, that is one thing. but no filte generated and no error is a bit hard to debug
2021-01-22 02242, 2021
alastairp
yeah, I see what you mean
2021-01-22 02258, 2021
ruaok
well, I got the indexer working now. it took me all day to deploy one stupid container. :(
