bitmap, yvanzo ^ guess we never tested the alias form for RGs. Also why the hell do we do this :D
2021-02-03 03444, 2021
reosarevok
Maybe we should hotfix after all tho, this is not only an annoyance but literally blocks alias editing for RGs. Not that people do it much, but.
2021-02-03 03454, 2021
reosarevok grumbles
2021-02-03 03424, 2021
BestSteve has quit
2021-02-03 03428, 2021
BestSteve joined the channel
2021-02-03 03410, 2021
NirriN joined the channel
2021-02-03 03434, 2021
NirriN has quit
2021-02-03 03443, 2021
scory joined the channel
2021-02-03 03416, 2021
NirriN joined the channel
2021-02-03 03416, 2021
nawcom has quit
2021-02-03 03410, 2021
nawcom joined the channel
2021-02-03 03444, 2021
NirriN has quit
2021-02-03 03453, 2021
scory has quit
2021-02-03 03449, 2021
yvanzo
reosarevok: reviewed PRs 1887, 1888 and 1890; These are the only ones to be applied as hotfix?
2021-02-03 03436, 2021
ruaok
moooin!
2021-02-03 03435, 2021
reosarevok
yvanzo: I'd say so :)
2021-02-03 03425, 2021
yvanzo
reosarevok: I updated docker server configs for Italian localization (forgot to do it on Monday).
2021-02-03 03444, 2021
reosarevok
Thanks
2021-02-03 03402, 2021
Gazooo7949440 has quit
2021-02-03 03405, 2021
sampsyo has quit
2021-02-03 03445, 2021
Gazooo7949440 joined the channel
2021-02-03 03415, 2021
yvanzo
reosarevok: I would be happy to merge them asap (maybe just after adding a test for rym on recording).
2021-02-03 03401, 2021
sampsyo joined the channel
2021-02-03 03422, 2021
reosarevok
yvanzo: how would we test rym on recording?
2021-02-03 03430, 2021
reosarevok
(there's no recording URL to test)
2021-02-03 03449, 2021
yvanzo
reosarevok: just with any RYM URL (single release for example) and only_valid_...: []
2021-02-03 03434, 2021
yvanzo
(single release or work)
2021-02-03 03421, 2021
reosarevok
But shouldn't only_valid still include work or whatever?
2021-02-03 03449, 2021
reosarevok
Since that will be valid
2021-02-03 03433, 2021
reosarevok
Or does input_entity_type change the results of only_valid_entity_types ?
2021-02-03 03458, 2021
yvanzo
Oh right :P
2021-02-03 03415, 2021
reosarevok
And as such, we're already testing all others :D
2021-02-03 03424, 2021
reosarevok
(so is there anything to add?)
2021-02-03 03438, 2021
reosarevok
I mean I could make one input_entity_type: 'recording' but
2021-02-03 03443, 2021
yvanzo
reosarevok: You’re right, denying recording for known URL patterns is already tested, and there is nothing else that would potentially match it on RYM. Approved :)
reosarevok: The test for 1890 could be added later on as we just hand-tested it.
2021-02-03 03401, 2021
reosarevok
I expect that'd require a selenium test or something?
2021-02-03 03412, 2021
reosarevok
I'm still not sure why the hell that's hardcoded to "rg", by the way
2021-02-03 03425, 2021
yvanzo
Hand-testing is ok at release time, having a CI test is to avoid regressions in the future.
2021-02-03 03417, 2021
reosarevok
But I guess it's not sensible to look into changing that now *even if it was doable* (and it might not be, maybe we have stuff in edit data json or somewhere also stored as "rg")
2021-02-03 03431, 2021
reosarevok
So probably better to just do this for now
2021-02-03 03445, 2021
reosarevok
I should make sure nothing breaks with RG alias edit display just in case
2021-02-03 03402, 2021
reosarevok
Seems to work fine
2021-02-03 03411, 2021
reosarevok
If you want to merge then that's ok with me
2021-02-03 03451, 2021
reosarevok
(I'd also be ok with waiting for bitmap but these are small changes so there's probably no need)
2021-02-03 03435, 2021
reosarevok
yvanzo: merge these to master, then master into beta, then beta into prod?
Thought I broke something, but "There were unauthenticated packages and -y was used without --allow-unauthenticated"
2021-02-03 03432, 2021
reosarevok
Have you gotten this before?
2021-02-03 03410, 2021
Rohan_Pillai has quit
2021-02-03 03409, 2021
yvanzo
reosarevok: not the first time yarn's signature gets broken, it's yearly, at least.
2021-02-03 03425, 2021
iliekcomputers
shameless plug, but if it helps the environment, worth it. we should consider using Stripe Climate. https://stripe.com/en-ie/climate
2021-02-03 03431, 2021
yvanzo
reosarevok: docker/yarn_pubkey.txt needs to be updated
2021-02-03 03423, 2021
reosarevok
yvanzo: hmm, ok. Where do I get the latest pubkey from?
2021-02-03 03423, 2021
reosarevok
iliekcomputers: how does this work? We don't get a lot of payments I expect, but
2021-02-03 03458, 2021
iliekcomputers
I'm not sure what volume of donations we get via stripe, i figure it's not a large fraction, but it essentially earmarks 1-5% of that volume for carbon capture, based on what we choose.
2021-02-03 03450, 2021
reosarevok
I expect it's close to nothing but I'd be in favor of doing this I guess if we already have this set up anyway
CatQuest make a kniting refrence noone thinks is funny
2021-02-03 03446, 2021
reosarevok
Yeah, that new key worked
2021-02-03 03453, 2021
reosarevok
CatQuest: knitting seems hard.
2021-02-03 03457, 2021
reosarevok
(unrelated to puns, but)
2021-02-03 03437, 2021
reosarevok
Updating beta
2021-02-03 03429, 2021
Mr_Monkey
Continuing on this *thread*: What do pirates knit with?
2021-02-03 03436, 2021
Mr_Monkey
YARRRRN !
2021-02-03 03413, 2021
reosarevok
Updating prod
2021-02-03 03408, 2021
kuno
hm, I cannot authenticate with ListenBrainz via OAuth? the OAuth flow only gives me access to the MusicBrainz API, not ListenBrainz?
2021-02-03 03409, 2021
shivam-kapila
kuno: for accessing any of the *brainz projects you only neex a musicbtainz account
2021-02-03 03419, 2021
shivam-kapila
need*
2021-02-03 03406, 2021
kuno
I have a MusicBrainz account, and I authenticated it with via OAuth. So I have a refresh token and an access token. But it seems the access token doesn't work with the ListenBrainz API endpoints.
2021-02-03 03413, 2021
iliekcomputers
kuno: yeah, the ListenBrainz API doesn't support OAuth. you need to use the ListenBrainz user token in listenbrainz.org/user/profile
iliekcomputers: and presumably that token is not available via some API, so I cannot automate obtaining that token using my OAuth credentials.
2021-02-03 03434, 2021
iliekcomputers
not right now, it isn't. would appreciate a ticket about it though.
2021-02-03 03439, 2021
iliekcomputers
what are you trying to do?
2021-02-03 03414, 2021
kuno
I'm trying to make it easy to submit to listenbrainz in my media player by using 'Login with MusicBrainz' button
2021-02-03 03428, 2021
kuno
it's not terribly important, because I'm the only user of it ;)
2021-02-03 03427, 2021
iliekcomputers
ah.
2021-02-03 03402, 2021
iliekcomputers
yep, that's not possible right now. Most clients just ask the user to input their token from the link right now.
2021-02-03 03422, 2021
iliekcomputers
but as you said, it's not the easiest way of authentication ig
2021-02-03 03407, 2021
kuno
I guess my OAuth stuff isn't wasted, I'll still need it later to get user tags/ratings.
2021-02-03 03421, 2021
alastairp
yeah, we've talked a few times about moving user accounts to metabrainz and then allowing that as an oauth provider for all services. I'd really like to see it happen
2021-02-03 03400, 2021
alastairp
see that for example, CB and MeB.org are oauth providers. so you can go officebrainz -> MeB -> musicBrainz -> auth -> auth -> auth
2021-02-03 03416, 2021
alastairp
but it's silly to have these multiple hops in place for everything
in hindsight, I think that I should have added oauth as the main auth mechanism, but it was late and we wanted to get something working so I just hacked it
