#metabrainz

/

      • reosarevok
        But I was wondering whether it would be better to have each dated relationship group once, and whether that'd be better for Google or worse. Is this something you feel we should try to contact them about?
      • 2021-02-08 03905, 2021

      • reosarevok
        Or should we just keep it simple and try to fix the oldest<->newest code and leave it be?
      • 2021-02-08 03908, 2021

      • CatQuest
        honestly more accurate date the better imho
      • 2021-02-08 03920, 2021

      • CatQuest
        isn't that what they use us for?
      • 2021-02-08 03930, 2021

      • bitmap
        I couldn't find any emails related to that specific issue but from the code it looked intentional, so
      • 2021-02-08 03935, 2021

      • ruaok
        reosarevok: if you still have Vicky Tardiff's email ,mail her. can't hurt.
      • 2021-02-08 03940, 2021

      • CatQuest
        +1
      • 2021-02-08 03941, 2021

      • reosarevok
        Ok, will do :)
      • 2021-02-08 03947, 2021

      • reosarevok
        Let's see what they say
      • 2021-02-08 03958, 2021

      • reosarevok
        Is she the main contact for JSON-LD?
      • 2021-02-08 03903, 2021

      • ruaok
        yeah.
      • 2021-02-08 03908, 2021

      • ruaok
        lots of others have moved on.
      • 2021-02-08 03910, 2021

      • reosarevok
        (I did contact for something else not that long ago, so)
      • 2021-02-08 03921, 2021

      • reosarevok
        Ok, perfect, that's probably enough for now
      • 2021-02-08 03925, 2021

      • Freso
        Alright!
      • 2021-02-08 03934, 2021

      • Freso
        That wraps up this meeting then. :)
      • 2021-02-08 03942, 2021

      • Freso
        Thank you everyone for your time!
      • 2021-02-08 03945, 2021

      • Mr_Monkey
        Thank you !
      • 2021-02-08 03951, 2021

      • zas
        Thanks!
      • 2021-02-08 03955, 2021

      • Freso
        Stay hydrated, stay hand-washed, stay safe!
      • 2021-02-08 03959, 2021

      • Freso
        </BANG>
      • 2021-02-08 03901, 2021

      • yvanzo
        Thanks!
      • 2021-02-08 03928, 2021

      • yvanzo
        bitmap, reosarevok: are you up for updating beta soon?
      • 2021-02-08 03943, 2021

      • reosarevok
        Do we have enough to put there?
      • 2021-02-08 03945, 2021

      • reosarevok
        If so, sure
      • 2021-02-08 03902, 2021

      • bitmap
        I'm free to go over some PRs if you'd like
      • 2021-02-08 03944, 2021

      • yvanzo
        reosarevok: Which links might be broken with https://github.com/metabrainz/musicbrainz-server/… ?
      • 2021-02-08 03930, 2021

      • reosarevok
        saved edit search links as in "someone bookmarked the search with a different ID order, earlier it worked 50% of the time, now it never works"
      • 2021-02-08 03954, 2021

      • reosarevok
        IMO it's not worthy of coding a fix, but you might disagree :)
      • 2021-02-08 03935, 2021

      • reosarevok
        bitmap: https://github.com/metabrainz/musicbrainz-server/… seems ready for merge but maybe make the change yvanzo suggested?
      • 2021-02-08 03936, 2021

      • CatQuest
        i think it was what jesus was talking about earlier? don't quote me on it
      • 2021-02-08 03950, 2021

      • bitmap
        okay
      • 2021-02-08 03907, 2021

      • bitmap
        I thiink I was just copying _urlprefix there but I can change both
      • 2021-02-08 03920, 2021

      • reosarevok
        The Gospel According to CatQuest
      • 2021-02-08 03926, 2021

      • reosarevok
        Well, no, that'd be quoting you on it
      • 2021-02-08 03929, 2021

      • CatQuest
        :DDDDDD
      • 2021-02-08 03917, 2021

      • yvanzo
        reosarevok: actually, it does not seem to break anything.
      • 2021-02-08 03928, 2021

      • reosarevok
        Oh. Well, even better
      • 2021-02-08 03908, 2021

      • shivam-kapila joined the channel
      • 2021-02-08 03947, 2021

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #1900 (master…MBS-9573_fix-edit-search-form-selected-options): MBS-9573: Sort edit type keys in edit search select option values https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03939, 2021

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1886 (master…no-caa-redirect): Link directly to the IA for CAA thumbnails https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03906, 2021

      • diru1100
        I didn't know there are multiple types of unlimited. https://usercontent.irccloud-cdn.com/file/6b69tC1…
      • 2021-02-08 03918, 2021

      • MajorLurker has quit
      • 2021-02-08 03928, 2021

      • alastairp
        diru1100: in the US at least, there are different royalty rates for "radio" and on demand. It's likely that their free tier uses the radio rates, which means there are some strict requirements that they have to fulfill
      • 2021-02-08 03957, 2021

      • alastairp
        can't play more than x items from the same album in a row, can't play songs by the same artist more than x times in y songs
      • 2021-02-08 03955, 2021

      • diru1100
        But it's a paid tier. In India Amazon music comes with prime subscription.
      • 2021-02-08 03912, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1893 (master…MBS-11365): MBS-11365: Allow Resident Advisor /podcast URLs for releases https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03955, 2021

      • reosarevok
        yvanzo, bitmap: should I just squash all the commits for the Perl copyright and license or do you feel it's better to merge separately?
      • 2021-02-08 03955, 2021

      • bitmap
        I'd prefer merging separately in this case just to keep the commits a reasonable size
      • 2021-02-08 03954, 2021

      • yvanzo
        go for it :)
      • 2021-02-08 03926, 2021

      • reosarevok
        Ok
      • 2021-02-08 03943, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1896 (master…consistent-license-block): Make Perl license block consistent https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03900, 2021

      • alastairp
      • 2021-02-08 03927, 2021

      • yvanzo
        reosarevok: please wait a bit before merging eslint fun
      • 2021-02-08 03947, 2021

      • reosarevok
        Sure :)
      • 2021-02-08 03956, 2021

      • reosarevok
      • 2021-02-08 03902, 2021

      • reosarevok
        (mostly small)
      • 2021-02-08 03911, 2021

      • reosarevok goes for a short walk, still reachable on IRC tho
      • 2021-02-08 03942, 2021

      • reosarevok
        Back soon and I can merge / release beta if we want :)
      • 2021-02-08 03956, 2021

      • reosarevok
        (just haven't left the house today)
      • 2021-02-08 03958, 2021

      • NirriN joined the channel
      • 2021-02-08 03958, 2021

      • yvanzo
        bitmap: there is 1878 too :)
      • 2021-02-08 03931, 2021

      • NirriN has quit
      • 2021-02-08 03902, 2021

      • ShivamAwasthi has quit
      • 2021-02-08 03901, 2021

      • Gazooo794944007 has quit
      • 2021-02-08 03944, 2021

      • Gazooo794944007 joined the channel
      • 2021-02-08 03926, 2021

      • BrainzGit
        [bookbrainz-site] the-good-boy opened pull request #553 (master…myBranch): fix(collection-form):Position of "Add another collaborator" button https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-02-08 03944, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1885 (master…MBS-11354): MBS-11354: Don't show arrows unless we want ordering https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03913, 2021

      • reosarevok
        Why the hell is the shipit icon a hamster?
      • 2021-02-08 03930, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1895 (master…eslint-fun): More eslint rules for CI https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03918, 2021

      • reosarevok
        zas, ruaok: is https://tickets.metabrainz.org/browse/MBS-11372 something you just changed recently?
      • 2021-02-08 03919, 2021

      • BrainzBot
        MBS-11372: SSL connect issues to metabrainz.org:443
      • 2021-02-08 03951, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1902 (master…MBS-11368): MBS-11368: Set nameVariation in EditMedium if rec name != track name https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03957, 2021

      • zas
        reosarevok: yes, I'll have a look
      • 2021-02-08 03901, 2021

      • reosarevok
        Thanks
      • 2021-02-08 03949, 2021

      • reosarevok
        bitmap: made the requested changes in https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-08 03932, 2021

      • reosarevok
        yvanzo: for https://github.com/metabrainz/musicbrainz-server/… - should it be (?:/.*)?
      • 2021-02-08 03905, 2021

      • yvanzo
        reosarevok: yes, no need to capture any group in this regexp, even for the first parenthesis.
      • 2021-02-08 03931, 2021

      • alastairp
        reosarevok: it's a squirrel, not a hamster
      • 2021-02-08 03900, 2021

      • reosarevok
        alastairp: why the hell is the shipit icon a squirrel? :D
      • 2021-02-08 03911, 2021

      • yvanzo
        it's not just a squirrel, it has a hat
      • 2021-02-08 03940, 2021

      • alastairp
        one might even say it's a secret _shipit_ squirrel
      • 2021-02-08 03942, 2021

      • reosarevok
        Oh. That explains everything
      • 2021-02-08 03927, 2021

      • zas
        bitmap: ping
      • 2021-02-08 03957, 2021

      • reosarevok
        zas: is this something yvanzo or I can help with if bitmap is not around?
      • 2021-02-08 03904, 2021

      • reosarevok
        (I see you set priority to high, so)
      • 2021-02-08 03932, 2021

      • zas
        well, dunno.
      • 2021-02-08 03938, 2021

      • zas
      • 2021-02-08 03939, 2021

      • BrainzBot
        MBS-11372: SSL connect issues to metabrainz.org:443
      • 2021-02-08 03940, 2021

      • alastairp
        reosarevok: glad to help
      • 2021-02-08 03904, 2021

      • zas
        the problem appeared because I switched accepted ciphers to safe today's default
      • 2021-02-08 03958, 2021

      • zas
        but they use a (very) old system, with, likely old openssl not supporting one of enabled ciphers.
      • 2021-02-08 03959, 2021

      • zas
        I could re-add missing ciphers, but frankly the right way to fix it is to upgrade (at least) ssl libs.
      • 2021-02-08 03945, 2021

      • reosarevok
        That sounds sensible. Is this something we need to update, or them? We should at the very least document what's the minimum needed, but
      • 2021-02-08 03921, 2021

      • zas
        Well, that's the question, we are perhaps too strict now, and they prolly have to upgrade anyway
      • 2021-02-08 03909, 2021

      • zas
        I'll use a wider range of ciphers, but not sure it will suffice, ciphers tend to deprecate quite fast nowaday
      • 2021-02-08 03948, 2021

      • kepstin
        consider checking the ssl config using e.g. https://www.ssllabs.com/ssltest/ if you haven't yet, just to make sure there's not a config oversight
      • 2021-02-08 03932, 2021

      • ohrstrom has quit
      • 2021-02-08 03936, 2021

      • kepstin
        but yeah, does look like a supported tls version issue to me :/
      • 2021-02-08 03930, 2021

      • reosarevok
        Overall Rating A
      • 2021-02-08 03942, 2021

      • reosarevok
        Fancy
      • 2021-02-08 03900, 2021

      • zas
        kepstin: I did already, and our setup is correct, but old clients are likely to fail... (this is what happens). I'll re-enable older ciphers for now to support older clients.
      • 2021-02-08 03917, 2021

      • reosarevok
        zas: put a blog post out, say "you have a month to update"?
      • 2021-02-08 03922, 2021

      • reosarevok
        Then take them off again?
      • 2021-02-08 03922, 2021

      • zas
        likely
      • 2021-02-08 03934, 2021

      • zas
        I re-included weak ciphers, we still grade A, but with warnings. Not sure it will be enough to fix reporter's problem, let's wait his answer about that.
      • 2021-02-08 03951, 2021

      • BrainzGit
        [critiquebrainz] dependabot-preview[bot] opened pull request #342 (master…dependabot/npm_and_yarn/marked-2.0.0): [Security] Bump marked from 1.1.1 to 2.0.0 https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-02-08 03931, 2021

      • d4rkie joined the channel
      • 2021-02-08 03906, 2021

      • Nyanko-sensei has quit
      • 2021-02-08 03946, 2021

      • diru1100 has quit
      • 2021-02-08 03909, 2021

      • yvanzo
        reosarevok: may we update beta now?
      • 2021-02-08 03900, 2021

      • yvanzo
        doing so
      • 2021-02-08 03936, 2021

      • reosarevok
        Sorry, just finished washing dishes :D
      • 2021-02-08 03951, 2021

      • reosarevok
        Yeah, I guess? I was thinking on waiting for bitmap to review some more stuff but we can release more on Wed
      • 2021-02-08 03942, 2021

      • reosarevok
        Want me to take over or are you ok with doing the release?
      • 2021-02-08 03933, 2021

      • yvanzo
        Ok, go ahead.
      • 2021-02-08 03957, 2021

      • reosarevok
        Ok! What did you do so far, if anything?
      • 2021-02-08 03934, 2021

      • yvanzo
        We should really stick to release beta on Monday, or we cannot complain about beta not being used to report potential regressions. :P
      • 2021-02-08 03950, 2021

      • reosarevok
        Sure, I like the idea of releasing Monday :)
      • 2021-02-08 03955, 2021

      • reosarevok
        So let's do it
      • 2021-02-08 03920, 2021

      • yvanzo
        I did nothing but chatting on IRC so far. :)
      • 2021-02-08 03932, 2021

      • reosarevok
        Ok
      • 2021-02-08 03933, 2021

      • yvanzo
        Oops
      • 2021-02-08 03937, 2021

      • reosarevok
        ?
      • 2021-02-08 03917, 2021

      • yvanzo
        reosarevok: we forgot about merging back production into master after last release.
      • 2021-02-08 03930, 2021

      • reosarevok
        Hmm.
      • 2021-02-08 03936, 2021

      • yvanzo
        I just did.
      • 2021-02-08 03943, 2021

      • reosarevok
        I thought there was nothing to merge because it was all from prod?
      • 2021-02-08 03951, 2021

      • reosarevok
        eh. all from master originally
      • 2021-02-08 03953, 2021

      • yvanzo
        There was nothing but the git tag.
      • 2021-02-08 03907, 2021

      • reosarevok
        I kinda got the impression we only had to do that if we merged directly to beta
      • 2021-02-08 03909, 2021

      • reosarevok
        Guess not :)
      • 2021-02-08 03937, 2021

      • reosarevok
        Ok, starting from your new pushed master
      • 2021-02-08 03947, 2021

      • reosarevok
        No new translations, anyway
      • 2021-02-08 03915, 2021

      • reosarevok
        I like the pot updates such as: #: DB:link_type/name:8 DB:link_type/name:227 -> #: DB:link_type/name:227 DB:link_type/name:8
      • 2021-02-08 03904, 2021

      • yvanzo
        Good night!
      • 2021-02-08 03909, 2021

      • reosarevok
        Going to bed? Ok! Night )
      • 2021-02-08 03940, 2021

      • reosarevok
        (huh, how come language frequency for Hungarian and Danish changed?)
      • 2021-02-08 03929, 2021

      • reosarevok
        Updating beta
      • 2021-02-08 03932, 2021

      • rdswift_ joined the channel
      • 2021-02-08 03940, 2021

      • rdswift has quit
      • 2021-02-08 03946, 2021

      • rdswift_ is now known as rdswift
      • 2021-02-08 03918, 2021

      • _lucifer has quit
      • 2021-02-08 03932, 2021

      • _lucifer joined the channel
      • 2021-02-08 03935, 2021

      • Leftmost has quit
      • 2021-02-08 03948, 2021

      • Leftmost joined the channel
      • 2021-02-08 03916, 2021

      • reosarevok
        Done :)
      • 2021-02-08 03942, 2021

      • d4rkie has quit
      • 2021-02-08 03920, 2021

      • Nyanko-sensei joined the channel