#metabrainz

/

      • ruaok
        tag v-2021-02-10.0 pushed.
      • 2021-02-10 04109, 2021

      • ruaok
        will deploy to beta now.
      • 2021-02-10 04109, 2021

      • reosarevok
        ruaok: no changes outside beta since last Wed
      • 2021-02-10 04114, 2021

      • reosarevok
        So not a code change
      • 2021-02-10 04120, 2021

      • reosarevok
        zas: did you make any changes?
      • 2021-02-10 04125, 2021

      • zas
        I didn't
      • 2021-02-10 04130, 2021

      • ruaok
        seems ok now. just a wobble.
      • 2021-02-10 04141, 2021

      • ruaok
        I wish we could work out what causes them and fix them
      • 2021-02-10 04144, 2021

      • Mr_Monkey
        Probably top radio show airing time in venezuela or something…
      • 2021-02-10 04151, 2021

      • zas
        pg issue?
      • 2021-02-10 04142, 2021

      • zas
      • 2021-02-10 04126, 2021

      • zas
        ^^ cause ?
      • 2021-02-10 04140, 2021

      • ruaok
        _lucifer: Mr_Monkey alastairp : beta updated. -web-beta and -follow-dispatcher-beta were both restarted.
      • 2021-02-10 04147, 2021

      • ruaok
        plz help sanity check?
      • 2021-02-10 04137, 2021

      • Mr_Monkey
        It beta be working !
      • 2021-02-10 04145, 2021

      • ruaok
        groan.
      • 2021-02-10 04155, 2021

      • _lucifer
        the playlists websockets feature is not working.
      • 2021-02-10 04128, 2021

      • ruaok
        seems not sure if beta is configured 100% correctly for that. any idea what is amiss?
      • 2021-02-10 04101, 2021

      • _lucifer
        the config probably needs to be updated.
      • 2021-02-10 04123, 2021

      • Mr_Monkey
        _lucifer: Works for me on beta.
      • 2021-02-10 04133, 2021

      • Mr_Monkey
        Perhaps reload the page without cache
      • 2021-02-10 04143, 2021

      • _lucifer
        huh! i'll try in incognito then
      • 2021-02-10 04127, 2021

      • ruaok
        Mr_Monkey: got playlist you can invite me to for testing?
      • 2021-02-10 04156, 2021

      • _lucifer
      • 2021-02-10 04114, 2021

      • Mr_Monkey
      • 2021-02-10 04143, 2021

      • _lucifer
        i am getting http error on adding collaborator, i'll delete my cache and test again
      • 2021-02-10 04107, 2021

      • ruaok
        `Error HTTP Error Forbidden` while trying to add a track to that playlist, Mr_Monkey
      • 2021-02-10 04135, 2021

      • Mr_Monkey
        Hm. Maybe something not working with collaborating, rather than WS
      • 2021-02-10 04138, 2021

      • CatQuest
        it's working beta?
      • 2021-02-10 04142, 2021

      • CatQuest
        :D
      • 2021-02-10 04157, 2021

      • _lucifer
        websockets working for me now :D
      • 2021-02-10 04117, 2021

      • shivam-kapila
        ruaok: anything in browser console?
      • 2021-02-10 04120, 2021

      • _lucifer
        adding track working as well
      • 2021-02-10 04127, 2021

      • Mr_Monkey
        As collaborator?
      • 2021-02-10 04138, 2021

      • _lucifer
        no as owner
      • 2021-02-10 04149, 2021

      • ruaok
        shivam-kapila: the 403, nothing else.
      • 2021-02-10 04102, 2021

      • Mr_Monkey
        I can't seem to add remove or move tracks as collaborator
      • 2021-02-10 04118, 2021

      • Mr_Monkey
        So that's an issue confirmed.
      • 2021-02-10 04124, 2021

      • shivam-kapila
        _lucifer: can you add me as colab to your playlist you listed above
      • 2021-02-10 04127, 2021

      • Mr_Monkey
        Let me test on prod, see if that's a tregressions
      • 2021-02-10 04103, 2021

      • _lucifer
        shivam-kapila: done
      • 2021-02-10 04149, 2021

      • shivam-kapila
        Mr_Monkey: collab adding didnt work for me on prod
      • 2021-02-10 04152, 2021

      • Mr_Monkey
        I'm getting the same 403s on prod, doesn't seem to be a regression. New WS update feature works for my own playlists, but as collaborator I don't see the changes reflected.
      • 2021-02-10 04153, 2021

      • Mr_Monkey
        I'll debug this collaborator issue locally, but there's no regression I can see on beta ruaok
      • 2021-02-10 04123, 2021

      • ruaok
        should I wait or proceed with the release, knowing that we're likely going to do another one soon?
      • 2021-02-10 04124, 2021

      • Mr_Monkey
        You can proceed I think. Ill get on debugging that today
      • 2021-02-10 04128, 2021

      • ruaok
      • 2021-02-10 04146, 2021

      • ruaok
        this is a spurious test failure that I can't repeat right now. but maybe related?
      • 2021-02-10 04150, 2021

      • Mr_Monkey
        Yeah, I was going to add a ticket for that
      • 2021-02-10 04155, 2021

      • ruaok
        ok, I'll proceed with the update.
      • 2021-02-10 04107, 2021

      • Mr_Monkey
        It's the list of collaborators that's not sorted, from what I gather
      • 2021-02-10 04111, 2021

      • ruaok
        yea.
      • 2021-02-10 04118, 2021

      • Mr_Monkey
        So not really an issue, but something we discussed
      • 2021-02-10 04127, 2021

      • ruaok
        don't bother with the ticket. I'lll just fix it after the release.
      • 2021-02-10 04117, 2021

      • BrainzGit
        [data-set-hoster] alastair merged pull request #3 (master…master): Use open-ended versions so that downstream projects can pin exact versions https://github.com/metabrainz/data-set-hoster/pul…
      • 2021-02-10 04130, 2021

      • Mr_Monkey
        OK
      • 2021-02-10 04104, 2021

      • Darkloke joined the channel
      • 2021-02-10 04101, 2021

      • _lucifer
      • 2021-02-10 04103, 2021

      • alastairp
        _lucifer: data-set-hoster tag v-2021-02-10.0 pushed
      • 2021-02-10 04134, 2021

      • _lucifer
        seems that pytest fails at just finding the illegal character in .py file
      • 2021-02-10 04120, 2021

      • alastairp
        _lucifer: in python 2 you need the https://stackoverflow.com/questions/41680533/is-c… header
      • 2021-02-10 04125, 2021

      • alastairp
        if there are utf-8 characters
      • 2021-02-10 04145, 2021

      • ruaok
        starting the release.
      • 2021-02-10 04131, 2021

      • Darkloke has quit
      • 2021-02-10 04108, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1905 (master…MBS-11375): MBS-11375: Use top-align for release event tables in Edit release https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-10 04134, 2021

      • ruaok
        updated.
      • 2021-02-10 04154, 2021

      • ruaok
        alastairp or iliekcomputers : please publish the changelog.
      • 2021-02-10 04148, 2021

      • alastairp
        on it
      • 2021-02-10 04100, 2021

      • _lucifer
      • 2021-02-10 04109, 2021

      • _lucifer
        ERROR: Service 'test' failed to build: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
      • 2021-02-10 04110, 2021

      • BrainzGit
        [listenbrainz-server] release v-2021-02-10.0 has been published by github-actions[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-10 04143, 2021

      • alastairp
        done!
      • 2021-02-10 04147, 2021

      • ruaok
        thx
      • 2021-02-10 04154, 2021

      • alastairp
        _lucifer: oh yeah, I've run into that before!
      • 2021-02-10 04116, 2021

      • _lucifer
        does it make sense to host own our images?
      • 2021-02-10 04117, 2021

      • alastairp
        not much we can do on travis I guess
      • 2021-02-10 04141, 2021

      • _lucifer
        yeah right
      • 2021-02-10 04141, 2021

      • alastairp
      • 2021-02-10 04159, 2021

      • alastairp
        our jenkins does a docker login, so it has higher rate limits
      • 2021-02-10 04140, 2021

      • _lucifer
        :D, what work is needed for it?
      • 2021-02-10 04129, 2021

      • alastairp
        I got some items working, I can't rememer what was next
      • 2021-02-10 04109, 2021

      • alastairp
        I wanted to merge everything together into a single run file, which mostly worked. however on jenkins you can only show logs for one test run
      • 2021-02-10 04146, 2021

      • alastairp
        we also need to integrate BU#44 into this, because there will be changes, and something similar to LB#1256
      • 2021-02-10 04102, 2021

      • alastairp
        I think that was most of it
      • 2021-02-10 04117, 2021

      • tesuYP joined the channel
      • 2021-02-10 04120, 2021

      • tesuYP
        /!\ this channel has moved to ##hamradio /!\
      • 2021-02-10 04130, 2021

      • HepaR joined the channel
      • 2021-02-10 04133, 2021

      • HepaR
        /!\ this channel has moved to ##hamradio /!\
      • 2021-02-10 04143, 2021

      • HepaR has quit
      • 2021-02-10 04144, 2021

      • tesuYP has quit
      • 2021-02-10 04107, 2021

      • alastairp
        no it hasn't!
      • 2021-02-10 04122, 2021

      • ContessaCq joined the channel
      • 2021-02-10 04129, 2021

      • ContessaCq
        /!\ this channel has moved to #nyymit /!\
      • 2021-02-10 04101, 2021

      • nukedclxyc joined the channel
      • 2021-02-10 04101, 2021

      • nukedclxyc has quit
      • 2021-02-10 04112, 2021

      • _lucifer
        Freso, can you take a look at the spamming :)
      • 2021-02-10 04120, 2021

      • ContessaCq has quit
      • 2021-02-10 04137, 2021

      • zas
        bitmap, yvanzo: can you check what happens with mb ws & website?
      • 2021-02-10 04148, 2021

      • jpXnH joined the channel
      • 2021-02-10 04152, 2021

      • jpXnH
        /!\ this channel has moved to #nyymit /!\
      • 2021-02-10 04135, 2021

      • jpXnH has quit
      • 2021-02-10 04146, 2021

      • CatQuest
        it's in #musicbrainz too
      • 2021-02-10 04147, 2021

      • cyberlardhn joined the channel
      • 2021-02-10 04148, 2021

      • cyberlardhn
        /!\ this channel has moved to #nyymit /!\
      • 2021-02-10 04151, 2021

      • CatQuest
        ug
      • 2021-02-10 04155, 2021

      • nurupofb joined the channel
      • 2021-02-10 04158, 2021

      • nurupofb
        /!\ this channel has moved to #nyymit /!\
      • 2021-02-10 04133, 2021

      • nurupofb has quit
      • 2021-02-10 04145, 2021

      • zas
        hmmm, last issue was only on cage, 1mn request time...
      • 2021-02-10 04105, 2021

      • zas
        load average: 9.38, 45.78, 31.05
      • 2021-02-10 04114, 2021

      • zas
        what is running on cage already?
      • 2021-02-10 04127, 2021

      • zas
        jenkins
      • 2021-02-10 04135, 2021

      • cyberlardhn has quit
      • 2021-02-10 04112, 2021

      • ruaok
        we may need to find another home for jenkins.
      • 2021-02-10 04125, 2021

      • ruaok
        clearly the two do not play well with each other.
      • 2021-02-10 04108, 2021

      • alastairp
        :(
      • 2021-02-10 04154, 2021

      • Sigyn joined the channel
      • 2021-02-10 04154, 2021

      • Sigyn
        ** Warning: if there is any bot in #metabrainz which should be exempted from Sigyn, contact staffers before it gets caught **
      • 2021-02-10 04126, 2021

      • Mr_Monkey
        So it looks like the collaborative playlists aren't really fully implemented and we just didn't realise. Go us!
      • 2021-02-10 04132, 2021

      • Mr_Monkey
      • 2021-02-10 04141, 2021

      • _lucifer
        lol
      • 2021-02-10 04107, 2021

      • Mr_Monkey
        No mention of collaborators in the playlist item add/move/delete API endpoints
      • 2021-02-10 04110, 2021

      • atj
        At least it's a helpful error message
      • 2021-02-10 04126, 2021

      • ruaok
        lol, at least we now reminded ourselves.
      • 2021-02-10 04132, 2021

      • Mr_Monkey
        If only the helpful error message made it back all the way to the front-end to be displayed to the user… :)
      • 2021-02-10 04148, 2021

      • Mr_Monkey
        But that's another bug for another time !
      • 2021-02-10 04133, 2021

      • zas
        alastairp: can you re-run jenkins container with --cpus="6" on cage?
      • 2021-02-10 04155, 2021

      • alastairp
        sure
      • 2021-02-10 04159, 2021

      • ruaok
        what was it before? 4, right?
      • 2021-02-10 04112, 2021

      • alastairp
        we configure jenkins to have only 4 workers
      • 2021-02-10 04122, 2021

      • alastairp
        but there's no docker-level resource restrictions
      • 2021-02-10 04112, 2021

      • ruaok
        zas: did you remove the lb dump private files?
      • 2021-02-10 04117, 2021

      • zas
        nope
      • 2021-02-10 04117, 2021

      • _lucifer
        what's the JDK its using?
      • 2021-02-10 04143, 2021

      • _lucifer
        before 8u192, Java didn't play with docker
      • 2021-02-10 04150, 2021

      • _lucifer
        *play nice
      • 2021-02-10 04153, 2021

      • ruaok
        zas: oh, I found them. totally not what I expected.
      • 2021-02-10 04132, 2021

      • alastairp
        _lucifer: 11, I think
      • 2021-02-10 04119, 2021

      • _lucifer
        that's good!
      • 2021-02-10 04119, 2021

      • _lucifer
        i tested locally the python 2 change, adding the header works. thanks!
      • 2021-02-10 04128, 2021

      • ruaok
        zas: on the LB dumps issue: if an old dump fails for whatever reason, we stop the dump process BUT we don't clean up the dirty files. then for the next run, we sync the whole dir and that copies out the failed dump.
      • 2021-02-10 04150, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #1275 (master…websockets_server_port): Clean up: Correction of websockets port in config template https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-10 04104, 2021

      • _lucifer
        alastairp: can you fast-forward the your mbdb-test branch to my fork's mbdb-test branch.
      • 2021-02-10 04123, 2021

      • _lucifer
        after that 44 should be ready to be merged.
      • 2021-02-10 04128, 2021

      • alastairp
        yes, one sec
      • 2021-02-10 04128, 2021

      • alastairp
        restarting jenkins
      • 2021-02-10 04102, 2021

      • alastairp
        _lucifer: pushed
      • 2021-02-10 04110, 2021

      • alastairp
        what order should we merge 44 and 46?
      • 2021-02-10 04115, 2021

      • alastairp
        zas: registrator on cage restarted when I started jenkins. not sure if I made it shut down or not?
      • 2021-02-10 04158, 2021

      • _lucifer
        alastairp: 44 first, i'll rebase 46 then to make it ready for .erging