#metabrainz

/

      • travis-ci joined the channel
      • 2021-02-11 04216, 2021

      • travis-ci
        Project bookbrainz-site build #3643: passed in 67 min 6 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-02-11 04216, 2021

      • travis-ci has left the channel
      • 2021-02-11 04215, 2021

      • ZaphodBeeblebrox joined the channel
      • 2021-02-11 04223, 2021

      • CatQuest has quit
      • 2021-02-11 04254, 2021

      • v6lur has quit
      • 2021-02-11 04232, 2021

      • CardinalWolseley has quit
      • 2021-02-11 04255, 2021

      • tmesis joined the channel
      • 2021-02-11 04236, 2021

      • tmesis has quit
      • 2021-02-11 04221, 2021

      • tmesis joined the channel
      • 2021-02-11 04218, 2021

      • tmesis has quit
      • 2021-02-11 04202, 2021

      • CardinalWolseley joined the channel
      • 2021-02-11 04205, 2021

      • reosarevok
        yvanzo: did your work on entity attributes include any validation? https://tickets.metabrainz.org/browse/MBS-11377 asks for it
      • 2021-02-11 04206, 2021

      • BrainzBot
        MBS-11377: Work Identifier Validation
      • 2021-02-11 04212, 2021

      • reosarevok
        I expect not, but just in case
      • 2021-02-11 04233, 2021

      • CardinalWolseley has quit
      • 2021-02-11 04200, 2021

      • yvanzo
        mo’’in’
      • 2021-02-11 04209, 2021

      • yvanzo
        reosarevok: no
      • 2021-02-11 04224, 2021

      • reosarevok
        Ok :)
      • 2021-02-11 04254, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1863 (master…MBS-11329): MBS-11329: Return privileges as a number in internal editor JSON https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-11 04211, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1899 (master…MBS-11370): MBS-11370: display track lengths of 0 ms or -1 ms as unknown https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-11 04256, 2021

      • Darkloke joined the channel
      • 2021-02-11 04246, 2021

      • BrainzGit
        [brainzutils-python] release v1.16.0 has been published by github-actions[bot]: https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-11 04249, 2021

      • alastairp
        _lucifer: I just tagged BU v1.16.0
      • 2021-02-11 04219, 2021

      • _lucifer
        great, thanks!
      • 2021-02-11 04211, 2021

      • _lucifer
        the dev instance is still up for CB at http://bono.metabrainz.org:666/ for testing but the MB database is currently down on bono.
      • 2021-02-11 04215, 2021

      • alastairp
        "up 5 seconds"
      • 2021-02-11 04240, 2021

      • _lucifer
        its been like that for over an hour now.
      • 2021-02-11 04250, 2021

      • alastairp
        ah, right
      • 2021-02-11 04208, 2021

      • ruaok
        moooin!
      • 2021-02-11 04236, 2021

      • alastairp
        db_1 | 2021-02-11 09:13:48.527 UTC [1] LOG: startup process (PID 24) was terminated by signal 6: Aborted
      • 2021-02-11 04249, 2021

      • alastairp
        mmm, so it appears to be trying to start up, and then gets shut down again, and repeats
      • 2021-02-11 04205, 2021

      • alastairp
        ruaok: ^ musicbrainz-docker on bono, any thoughts?
      • 2021-02-11 04217, 2021

      • ruaok
        I haven't a clue -- odd.
      • 2021-02-11 04221, 2021

      • _lucifer
      • 2021-02-11 04226, 2021

      • _lucifer
        it started here
      • 2021-02-11 04258, 2021

      • ruaok
        let me shut it down and restart, maybe that will help.
      • 2021-02-11 04202, 2021

      • alastairp
        yeah, I just down'd it
      • 2021-02-11 04216, 2021

      • ruaok
        ah ok.
      • 2021-02-11 04218, 2021

      • ruaok leaves it
      • 2021-02-11 04232, 2021

      • alastairp
        _lucifer: by any chance you didn't try and start it up yourself yesterday while it was still running?
      • 2021-02-11 04255, 2021

      • _lucifer
        alastairp: i think i might have done something stupid yesterday while cleaning up my containers
      • 2021-02-11 04209, 2021

      • alastairp
        yeah :) it's possible that something got confused
      • 2021-02-11 04217, 2021

      • _lucifer
        the timeline aligns with 😓
      • 2021-02-11 04248, 2021

      • alastairp
        nope, still has the error:
      • 2021-02-11 04249, 2021

      • alastairp
        db_1 | 2021-02-11 09:24:32.123 UTC [25] LOG: invalid primary checkpoint record
      • 2021-02-11 04259, 2021

      • alastairp
        I'm trying https://stackoverflow.com/questions/8799474/postg…, but if that doesn't work it might be less work to just blow it away and reload
      • 2021-02-11 04219, 2021

      • alastairp
        looks good now
      • 2021-02-11 04222, 2021

      • ijc has quit
      • 2021-02-11 04230, 2021

      • ijc joined the channel
      • 2021-02-11 04236, 2021

      • _lucifer
        yup, thanks :D
      • 2021-02-11 04201, 2021

      • Clint has quit
      • 2021-02-11 04216, 2021

      • BenOckmore has quit
      • 2021-02-11 04216, 2021

      • pprkut has quit
      • 2021-02-11 04223, 2021

      • _lucifer
      • 2021-02-11 04243, 2021

      • BenOckmore joined the channel
      • 2021-02-11 04254, 2021

      • yvanzo has quit
      • 2021-02-11 04200, 2021

      • pprkut joined the channel
      • 2021-02-11 04216, 2021

      • _lucifer
      • 2021-02-11 04218, 2021

      • yvanzo joined the channel
      • 2021-02-11 04244, 2021

      • Clint joined the channel
      • 2021-02-11 04237, 2021

      • _lucifer
        other errors i found in sentry were dupliates of these with different entity ids, so i think both issues are now fixed?
      • 2021-02-11 04237, 2021

      • ruaok
      • 2021-02-11 04212, 2021

      • SothoTalKer_ joined the channel
      • 2021-02-11 04201, 2021

      • SothoTalKer has quit
      • 2021-02-11 04245, 2021

      • alastairp
        !m _lucifer
      • 2021-02-11 04245, 2021

      • BrainzBot
        You're doing good work, _lucifer!
      • 2021-02-11 04223, 2021

      • alastairp
        _lucifer: I'm busy the next 2 days, but if you give me a list of PRs in CB to merge I'll be able to do a release
      • 2021-02-11 04251, 2021

      • blup joined the channel
      • 2021-02-11 04259, 2021

      • alastairp
        the merged entities fix is completely in BU? so we just need the version upgrades?
      • 2021-02-11 04205, 2021

      • _lucifer
        alastairp: i think first we should do https://github.com/metabrainz/critiquebrainz/pull…. it may reveal issues in other PRs.
      • 2021-02-11 04207, 2021

      • _lucifer
        yes
      • 2021-02-11 04235, 2021

      • BrainzGit
        [critiquebrainz] alastair merged pull request #339 (master…uwsgi-logging): Disable uwsgi request logging https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-02-11 04235, 2021

      • BrainzGit
        [critiquebrainz] alastair merged pull request #342 (master…dependabot/npm_and_yarn/marked-2.0.0): [Security] Bump marked from 1.1.1 to 2.0.0 https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-02-11 04235, 2021

      • BrainzGit
        [critiquebrainz] alastair merged pull request #316 (master…CB-388): CB-388: Reduce scope of mocks https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-02-11 04236, 2021

      • alastairp
        _lucifer: I think #326 is basically ready, could you give it a look over? I think 330 is probably good too
      • 2021-02-11 04243, 2021

      • ZaphodBeeblebrox has quit
      • 2021-02-11 04215, 2021

      • alastairp
        I think we can release just those ones for now, then I'll try and review all of the other open ones too and get them merged in the coming week for another release
      • 2021-02-11 04221, 2021

      • atj has quit
      • 2021-02-11 04205, 2021

      • atj joined the channel
      • 2021-02-11 04211, 2021

      • _lucifer
        #326 looks good.
      • 2021-02-11 04226, 2021

      • _lucifer
        sure, let's do that.
      • 2021-02-11 04248, 2021

      • _lucifer
        let me update the BU versions PR as well. we should release that too due to the bug fixes.
      • 2021-02-11 04213, 2021

      • alastairp
        I'd like to update translations too. jesus2099 did some updates to the french one ages ago and I still didn't get them done
      • 2021-02-11 04229, 2021

      • alastairp
        (translations - related to 326, we should update transifex)
      • 2021-02-11 04248, 2021

      • alastairp
        ok, how about we just do the version upgrade, test it, and release it
      • 2021-02-11 04202, 2021

      • _lucifer
        that works too.
      • 2021-02-11 04210, 2021

      • alastairp
        then we can pick up another 4-5 PRs and maybe consider releasing tomorrow if we can get them in a working state
      • 2021-02-11 04230, 2021

      • _lucifer
        👍
      • 2021-02-11 04202, 2021

      • Gazooo794944007 has quit
      • 2021-02-11 04244, 2021

      • Gazooo794944007 joined the channel
      • 2021-02-11 04202, 2021

      • reosarevok
        Updating beta
      • 2021-02-11 04224, 2021

      • CardinalWolseley joined the channel
      • 2021-02-11 04203, 2021

      • CardinalWolseley has quit
      • 2021-02-11 04249, 2021

      • reosarevok
      • 2021-02-11 04250, 2021

      • BrainzBot
        MBS-11379: Beta redirect breaks origin in "Confirm Form Submission"
      • 2021-02-11 04257, 2021

      • c1e0 joined the channel
      • 2021-02-11 04224, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1907 (master…MBS-11378): MBS-11378: Use lp_attributes for gender https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-11 04253, 2021

      • _lucifer
      • 2021-02-11 04254, 2021

      • alastairp
        _lucifer: nice, thanks
      • 2021-02-11 04249, 2021

      • alastairp
        shall we do a release, then?
      • 2021-02-11 04209, 2021

      • _lucifer
        yes
      • 2021-02-11 04228, 2021

      • _lucifer
      • 2021-02-11 04237, 2021

      • BrainzGit
        [critiquebrainz] alastair merged pull request #341 (master…fix-versions): Pin package versions and upgrade brainzutils https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-02-11 04219, 2021

      • BrainzGit
        [critiquebrainz] release v-2021-02-11.0 has been published by github-actions[bot]: https://github.com/metabrainz/critiquebrainz/rele…
      • 2021-02-11 04210, 2021

      • alastairp
        building
      • 2021-02-11 04222, 2021

      • alastairp
        _lucifer: building CB I get
      • 2021-02-11 04223, 2021

      • alastairp
        ERROR: requests 2.23.0 has requirement urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1, but you'll have urllib3 1.26.3 which is incompatible.
      • 2021-02-11 04230, 2021

      • alastairp
        though it seems to have built cleanly anyway
      • 2021-02-11 04233, 2021

      • alastairp
        ah, we're still using the old 2019 base image, which has the old version of pip
      • 2021-02-11 04211, 2021

      • _lucifer
        ah yes, i removed the pip install line because i saw we were fixing it everywhere
      • 2021-02-11 04220, 2021

      • _lucifer
        *pip upgrade
      • 2021-02-11 04229, 2021

      • alastairp
        only if we use the correct base image though :)
      • 2021-02-11 04250, 2021

      • _lucifer
        should i update the base image or upgrade pip?
      • 2021-02-11 04257, 2021

      • alastairp
        base image
      • 2021-02-11 04201, 2021

      • _lucifer
        on it
      • 2021-02-11 04216, 2021

      • alastairp
      • 2021-02-11 04244, 2021

      • alastairp
        3.8-20201201, because that still has consul 0.16 (until we merge #336)
      • 2021-02-11 04239, 2021

      • alastairp
        oh, interesting
      • 2021-02-11 04239, 2021

      • BrainzGit
        [critiquebrainz] amCap1712 opened pull request #343 (master…fix-versions): Upgrade base python image https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-02-11 04202, 2021

      • alastairp
        but that image actually only has pip 20.2.3. sigh
      • 2021-02-11 04215, 2021

      • alastairp
        (the change came in 20.3). I guess we did that intentionally?
      • 2021-02-11 04222, 2021

      • alastairp
        I'll be glad once we clean up all of this
      • 2021-02-11 04258, 2021

      • _lucifer
        lb will be using 20.2.4 after we merge #1271.
      • 2021-02-11 04243, 2021

      • alastairp
        right. but keep in mind that the reason we added these version ranges is so that it would actually work with pip >= 20.3
      • 2021-02-11 04255, 2021

      • alastairp
        so I guess it makes sense that we actually test it like that ;)
      • 2021-02-11 04207, 2021

      • _lucifer
        right, its working with pip 21
      • 2021-02-11 04222, 2021

      • _lucifer
        because i did all the testing with upgrading to latest pip
      • 2021-02-11 04230, 2021

      • c1e0_ joined the channel
      • 2021-02-11 04236, 2021

      • alastairp
        do you follow? I understand that it's really convoluted atm, which is annoying. It'll clear up once we merge a few more PRs
      • 2021-02-11 04239, 2021

      • alastairp
        oh cool.
      • 2021-02-11 04247, 2021

      • alastairp
        I'd prefer to do that for now, then
      • 2021-02-11 04207, 2021

      • alastairp
        can you add to 343 to install a specific version of pip 21? (whatever is the latest version)
      • 2021-02-11 04213, 2021

      • c1e0 has quit
      • 2021-02-11 04237, 2021

      • c1e0 joined the channel
      • 2021-02-11 04226, 2021

      • c1e0_ has quit
      • 2021-02-11 04219, 2021

      • ruaok
        ishaanshah: you about?
      • 2021-02-11 04221, 2021

      • alastairp
        _lucifer: interesting. pip 21 actually installed a different version of urllib3 automatically. I guess that's fine then
      • 2021-02-11 04201, 2021

      • alastairp
        _lucifer: I see CB install both psycopg2 _and_ psycopg2-binary. any idea?
      • 2021-02-11 04253, 2021

      • alastairp
        ah, we didn't move https://github.com/metabrainz/brainzutils-python/… to requirements_dev
      • 2021-02-11 04257, 2021

      • _lucifer
        we can do some dependency cleanup in all of the projects. i'll take that up over the weekend
      • 2021-02-11 04210, 2021

      • alastairp
        yeah 😓
      • 2021-02-11 04230, 2021

      • v6lur joined the channel
      • 2021-02-11 04208, 2021

      • BrainzGit
        [brainzutils-python] alastair opened pull request #51 (master…psycopg2-testonly): Don't install psycopg2 in requirements/dependencies https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-11 04204, 2021

      • BrainzGit
        [brainzutils-python] alastair merged pull request #51 (master…psycopg2-testonly): Don't install psycopg2 in requirements/dependencies https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-11 04220, 2021

      • _lucifer
        alastairp: updated the PR, also the test and dev images. https://ci.metabrainz.org/job/critiquebrainz-pyte… seems to be fine
      • 2021-02-11 04236, 2021

      • BrainzGit
        [brainzutils-python] release v1.16.1 has been published by github-actions[bot]: https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-11 04242, 2021

      • _lucifer
        there's no requests issue now
      • 2021-02-11 04209, 2021

      • alastairp
        cool 👍
      • 2021-02-11 04224, 2021

      • alastairp
        could you open a ticket to try and unify the Dockerfiles in CB? Not sure why we have 3 of them