I was looking into it more, and validate_auth_header is making me think. the behaviour of the (True) is very opaque, but this is turning into a bigger task that we shouldn't do in this PR
2021-02-15 04600, 2021
alastairp
I don't like that None as a return value of validate_auth_header means something special, and we're propagating that behaviour into the is_visible_by function too
It think it's OK to leave as-is in this PR, but I'd like to open a ticket to improve the behaviour of the current authenticated user in the API
2021-02-15 04604, 2021
ruaok
+1
2021-02-15 04634, 2021
alastairp
in the webapp we have this built-in AnonymousUser which is provided by the login tool that we have, this way we can do stuff like `user.is_authenticated` (which I see is what I wrote in my original suggested method). this way we absolutely know that we're working with a user, rather than a dict, or None, or...
2021-02-15 04632, 2021
ruaok
outsidecontext: can you please have a look at the GSoC ideas page for picard? I know zas is quite busy at the moment and we should really flesh out the ideas page.
2021-02-15 04625, 2021
outsidecontext
ruaok: will do, but also low on time currently. But I should be able to take a look this week if this works timewise
2021-02-15 04647, 2021
ruaok
on or before the 19th would be ideal.
2021-02-15 04604, 2021
ruaok
and you know that GSoC projects are half the size they used to be, yes?
2021-02-15 04638, 2021
outsidecontext
ok, that is doable. but nope, don't know about current GSoC procedures :)
2021-02-15 04601, 2021
outsidecontext
is it half the time or how are they organized?
2021-02-15 04618, 2021
ruaok
that is the most important thing to know -- projects are now taking up half the time over a larger period of time.
2021-02-15 04635, 2021
outsidecontext
ok
2021-02-15 04636, 2021
ruaok
organized much in the same way as before, just not as in depth.
2021-02-15 04647, 2021
Mr_Monkey
Yeah that anonymous user sounds way better alastairp. Indeed for another PR.
2021-02-15 04613, 2021
reosarevok
yvanzo, bitmap: https://tickets.metabrainz.org/browse/MBS-11384 exists because we just check whether the area is marked as of type country (which Europe and [Worldwide] unsurprisingly are not). Should we pass is_release_country_area to JS for this check?
2021-02-15 04614, 2021
BrainzBot
MBS-11384: Some (release) countries are untranslated
2021-02-15 04632, 2021
reosarevok
I expect that's the actual condition for whether something is in the l_countries context
ruaok: "@brainzbot retest this please" is the magic. I wonder if we can make the check phase a bit more flexible
2021-02-15 04643, 2021
alastairp
Test phrase: `.*test\W+this\W+please.*`
2021-02-15 04613, 2021
alastairp
happy to take suggestions for changes. perhaps .*test.* is easier
2021-02-15 04624, 2021
ruaok
ah, thanks.
2021-02-15 04625, 2021
Mr_Monkey
Since you're taking suggestions, I propose `Ph'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn`
2021-02-15 04636, 2021
ruaok
well, I haven't been able to trip that test failure with that PR. should we merge it and see how it goes?
2021-02-15 04649, 2021
ruaok
Mr_Monkey: super easy, lets do that!
2021-02-15 04641, 2021
shivam-kapila
and how to remember that Mr_Monkey XD
2021-02-15 04624, 2021
alastairp
Mr_Monkey: sounds like you're volunteering to be the person to trigger tests when someone asks you to do so
2021-02-15 04617, 2021
Mr_Monkey
Oh easy peasy, just read it once in the Necronomicon, burning the ancient words in you rmind of minds, melting all in its wake, slowly but inevitably replacing avery living moment with Ph'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn.
2021-02-15 04619, 2021
Mr_Monkey
Easy.
2021-02-15 04615, 2021
alastairp
keep in mind that ruaok can't even memorise "test this please" :)
2021-02-15 04622, 2021
Mr_Monkey
Lol
2021-02-15 04601, 2021
goapunk has quit
2021-02-15 04607, 2021
alastairp
OK, I changed it to `(.*test.*please.*)|(.*please.*test.*)`
2021-02-15 04618, 2021
alastairp
so you still have to be nice to it, but it doesn't matter in which order
yvanzo: ready for release -- how should we proceed?
2021-02-15 04618, 2021
iliekcomputers
yeah, i think that bug has been there since last summer at least
2021-02-15 04619, 2021
Mr_Monkey
So if you're playing something on spotify, the page should reflect that when you open it, with whatever you are playing. It shouldn't try to play any of the songs automatically, not sure what's causing this
2021-02-15 04625, 2021
Mr_Monkey
Agh
2021-02-15 04658, 2021
ruaok
it never happens on my listens page, but it happens on the playlist page. so, I've not seen it longer than we've had playlists.
2021-02-15 04618, 2021
iliekcomputers
weird, i've seen it on the listens page quite often
2021-02-15 04628, 2021
Mr_Monkey
Autoplay?
2021-02-15 04636, 2021
ruaok
not saying it doesn't happen to others, but it doesn't happen to me on the listens page.
2021-02-15 04640, 2021
iliekcomputers
yep.
2021-02-15 04624, 2021
yvanzo
ruaok: just release as usual, no need to set RABBITMQ_SERVICE for now.
2021-02-15 04651, 2021
ruaok
won't I need to restart the containers when we start the migration?
2021-02-15 04603, 2021
ruaok
I'd prefer to only do one restart if necessary.
2021-02-15 04612, 2021
yvanzo
oh ok
2021-02-15 04621, 2021
yvanzo
yes that will require recreating containers.
2021-02-15 04642, 2021
ruaok
I cant wait until you're ready... as long as we still have time.
2021-02-15 04647, 2021
ruaok
or we just delay until tomorrow.
2021-02-15 04605, 2021
CatQuest
[17:12] <Mr_Monkey> Since you're taking suggestions, I propose `Ph'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn`
2021-02-15 04605, 2021
CatQuest
lmao
2021-02-15 04621, 2021
shivam-kapila
> weird, i've seen it on the listens page quite often
