#metabrainz

/

      • ruaok
        ?
      • 2021-02-15 04648, 2021

      • _lucifer
      • 2021-02-15 04620, 2021

      • _lucifer
        I am getting this error while trying to run the website. however the logs show that Flask_Uploads is installed successfully
      • 2021-02-15 04634, 2021

      • ruaok
        'flask_uploads ?
      • 2021-02-15 04649, 2021

      • ruaok
        was there a copy pasta error omitting the last ' ?
      • 2021-02-15 04605, 2021

      • _lucifer
        yes
      • 2021-02-15 04609, 2021

      • ruaok
        ok
      • 2021-02-15 04624, 2021

      • ruaok
        what branch are you running from?
      • 2021-02-15 04600, 2021

      • _lucifer
        its based on meb master with commits to upgrade it to lastest BU and pip
      • 2021-02-15 04629, 2021

      • ruaok
        do you have a branch I can pull to test with?
      • 2021-02-15 04606, 2021

      • _lucifer
      • 2021-02-15 04616, 2021

      • ruaok
        thx
      • 2021-02-15 04604, 2021

      • atj
        is the live update disabled in beta LB?
      • 2021-02-15 04621, 2021

      • ruaok
        for playlists? that PR hasn't been merged.
      • 2021-02-15 04633, 2021

      • atj
        For listens
      • 2021-02-15 04634, 2021

      • ruaok
        which means, that no, its still broken.
      • 2021-02-15 04655, 2021

      • atj
        On live LB when the track changes the page goes blank.
      • 2021-02-15 04607, 2021

      • shivam-kapila
        Uh oh
      • 2021-02-15 04629, 2021

      • atj
        Sorry, I haven't tested live recently
      • 2021-02-15 04632, 2021

      • ruaok
        I've not seen that. can you reproduce it?
      • 2021-02-15 04643, 2021

      • atj
        I was just testing beta to see if it was fixed :)
      • 2021-02-15 04653, 2021

      • CatQuest
        iliekcomputers: that dude hpparently has made the mandelbrot set in ascii :D https://thatjdanisso.cool/mandelbrot
      • 2021-02-15 04606, 2021

      • _lucifer
        atj, you mean when a new track is added?
      • 2021-02-15 04612, 2021

      • atj
        Yeah, it's a know issue
      • 2021-02-15 04615, 2021

      • atj
        *known
      • 2021-02-15 04648, 2021

      • atj
        It was mentioned by a couple of people (including myself) late last week
      • 2021-02-15 04614, 2021

      • ruaok
        atj: did you open a ticket for it?
      • 2021-02-15 04623, 2021

      • _lucifer
        ruaok, its the ws issue for which we merged the pr today
      • 2021-02-15 04639, 2021

      • _lucifer
        *websockets
      • 2021-02-15 04654, 2021

      • ruaok
        oh, I see.
      • 2021-02-15 04600, 2021

      • ruaok
        atj: does it still happen on beta??
      • 2021-02-15 04606, 2021

      • ruaok
        I guess it should be fixed now. :)
      • 2021-02-15 04608, 2021

      • atj
        ruaok: no, but nothing happens :)
      • 2021-02-15 04616, 2021

      • atj
        I have to manually refresh the page
      • 2021-02-15 04634, 2021

      • ruaok
        well, yes, clients are not submitting to beta, but to prod.
      • 2021-02-15 04657, 2021

      • ruaok
        sounds like we're on track for that being fixed today or tomorrow.
      • 2021-02-15 04658, 2021

      • atj
        ruaok: OK, makes sense
      • 2021-02-15 04607, 2021

      • ruaok
        _lucifer: I confirm your issue.
      • 2021-02-15 04626, 2021

      • atj
        Sorry, I thought it was an MB style beta so submissions would update on both
      • 2021-02-15 04641, 2021

      • atj
        Bad assumption
      • 2021-02-15 04612, 2021

      • atj
        sorry shivam-kapila, ignore me :)
      • 2021-02-15 04629, 2021

      • ruaok
        in theory it works the same, but your clients would need to submit to beta.lb.org. or we would need to run the spotify recording in beta as well.
      • 2021-02-15 04655, 2021

      • shivam-kapila
        atj: Np. Whats better than active contributors :)
      • 2021-02-15 04658, 2021

      • HenryG has quit
      • 2021-02-15 04602, 2021

      • atj
        right, seems my musicplayer doesn't allow me to change the submission host
      • 2021-02-15 04608, 2021

      • ruaok
        _lucifer: that problem happens on master as well. it may be related to the versions I upgraded recently. I didn't go back to ensure that develop.sh worked ok. sorry. :(
      • 2021-02-15 04658, 2021

      • _lucifer
        no worries. what's the version in prod right now?
      • 2021-02-15 04640, 2021

      • ruaok
      • 2021-02-15 04646, 2021

      • HenryG joined the channel
      • 2021-02-15 04608, 2021

      • ruaok
        maybe there has been a release of the package in the meantime.
      • 2021-02-15 04623, 2021

      • _lucifer
        huh, its the same version we currently are using.
      • 2021-02-15 04642, 2021

      • _lucifer
      • 2021-02-15 04648, 2021

      • ruaok tries the latest commit
      • 2021-02-15 04606, 2021

      • _lucifer
        its the latest commit actually :)
      • 2021-02-15 04620, 2021

      • ruaok
        wtf?
      • 2021-02-15 04630, 2021

      • _lucifer
        could it be pip?
      • 2021-02-15 04633, 2021

      • ruaok
        does it have to be a full hash?
      • 2021-02-15 04650, 2021

      • _lucifer
        no i don't think so
      • 2021-02-15 04603, 2021

      • ruaok
        trying the full hash now, just in case.
      • 2021-02-15 04610, 2021

      • alastairp
        _lucifer: what you pasted isn't an error though, right?
      • 2021-02-15 04627, 2021

      • alastairp
        it's just saying "hey, this doesn't look like a branch, so I'll treat it as a commit"
      • 2021-02-15 04636, 2021

      • _lucifer
      • 2021-02-15 04646, 2021

      • alastairp
        well, wait a moment
      • 2021-02-15 04650, 2021

      • _lucifer
        no that's the later one, confirming the version
      • 2021-02-15 04652, 2021

      • alastairp
        that's two different things
      • 2021-02-15 04627, 2021

      • _lucifer
        there were two pastes, one with the error second with the version being used
      • 2021-02-15 04647, 2021

      • alastairp
        what gets installed?
      • 2021-02-15 04653, 2021

      • ruaok
        going with the full commit gives me a different error.
      • 2021-02-15 04612, 2021

      • _lucifer
        alastairp, yes. the module flask_uploads gets installed. the logs show that but the web container fails to run with the error that No mudule named 'flask_uploads`.
      • 2021-02-15 04637, 2021

      • alastairp
        the problem is the syntax of the dependency in requirements.txt
      • 2021-02-15 04606, 2021

      • alastairp
        -e means that it's an "editable" install, it clones the repo into . (/code), and then adds a .egg-link file to python's site-packages
      • 2021-02-15 04631, 2021

      • alastairp
        when you run in dev, we mount into /code with a volume, now the cloned repo is no longer there
      • 2021-02-15 04650, 2021

      • alastairp
        requirements.txt line should be
      • 2021-02-15 04653, 2021

      • ruaok
        d'oh.
      • 2021-02-15 04653, 2021

      • alastairp
      • 2021-02-15 04654, 2021

      • _lucifer
        oh that makes sense. so removing the -e should be enough
      • 2021-02-15 04601, 2021

      • ruaok
        thanks for catching that.
      • 2021-02-15 04644, 2021

      • _lucifer
        thanks alastairp!
      • 2021-02-15 04606, 2021

      • alastairp
        and that's why it works in prod, because there's no volume over /code
      • 2021-02-15 04651, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1911 (master…MBS-11384): MBS-11384 / MBS-11385: Ensure all country context names are translated https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-15 04623, 2021

      • alastairp
        the first thing I do in a case like this is look at /usr/local/lib/python3.8/dist-packages to try and find the dependency
      • 2021-02-15 04643, 2021

      • alastairp
        because no matter what pip install says, if it's not there you're not going to have much luck doing an import
      • 2021-02-15 04645, 2021

      • Mr_Monkey
        Ah, I found the cause of youtube player issue: "Note: A third parameter value, search, has been deprecated and will no longer be supported as of 15 November 2020."
      • 2021-02-15 04645, 2021

      • Mr_Monkey
      • 2021-02-15 04643, 2021

      • shivam-kapila
        Mr_Monkey OP
      • 2021-02-15 04612, 2021

      • alastairp
        Mr_Monkey: is that the same issue as the thing we found with the playlist iframe that went away?
      • 2021-02-15 04619, 2021

      • alastairp
        was it removed on the same date?
      • 2021-02-15 04637, 2021

      • Mr_Monkey
        Mmm, not sure.
      • 2021-02-15 04647, 2021

      • alastairp
        mid-nov sounds about right
      • 2021-02-15 04632, 2021

      • Mr_Monkey goes implement yet another API
      • 2021-02-15 04623, 2021

      • Mr_Monkey
        Ah, and it looks like we now need to use an API key
      • 2021-02-15 04646, 2021

      • Mr_Monkey
        Presumably with some rate limiting tied to keys
      • 2021-02-15 04604, 2021

      • shivam-kapila
        react-youtube API requests had a key with them
      • 2021-02-15 04616, 2021

      • shivam-kapila
        I saw it in networks tab today morning itself
      • 2021-02-15 04605, 2021

      • Mr_Monkey
        I don't think that's the same thing. I think that's a key representing the embedded player. That API had no auth.
      • 2021-02-15 04621, 2021

      • shivam-kapila
        I removed the keya and it said "Unauthorised access". But what you said is possible
      • 2021-02-15 04619, 2021

      • yvanzo
        ruaok: I provisioned PRs to migrate SIR-test/SIR/CAA each at a time, so we can do LB on tomorrow.
      • 2021-02-15 04601, 2021

      • Mr_Monkey
        ruaok: We'll have to discuss getting an API key for LB to use Youtube's API (to search for videos) and how their quotas would work for us: https://developers.google.com/youtube/v3/getting-…
      • 2021-02-15 04627, 2021

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, CB-408 (alastair)
      • 2021-02-15 04642, 2021

      • CatQuest
        hi freso!
      • 2021-02-15 04658, 2021

      • Mr_Monkey
        Hi everyone !
      • 2021-02-15 04609, 2021

      • CatQuest
        well yea them too
      • 2021-02-15 04639, 2021

      • Freso
        <BANG>
      • 2021-02-15 04639, 2021

      • Freso
        It’s Single Awareness Monday!
      • 2021-02-15 04639, 2021

      • Freso
      • 2021-02-15 04639, 2021

      • Freso
        No mailed in reviews today, so…
      • 2021-02-15 04639, 2021

      • Freso
        reosarevok: Go!
      • 2021-02-15 04645, 2021

      • reosarevok
        Hi!
      • 2021-02-15 04604, 2021

      • reosarevok
        Last week I spent a fair amount of time working on MBS-11381
      • 2021-02-15 04605, 2021

      • BrainzBot
        MBS-11381: Add a way to add and update timeline events through the website https://tickets.metabrainz.org/browse/MBS-11381
      • 2021-02-15 04615, 2021

      • reosarevok
        So that I can finally update the timeline without having to play with the live DB
      • 2021-02-15 04636, 2021

      • reosarevok
        I also spent quite a bit of time with bitmap and yvanzo thinking about MBS GSoC ideas
      • 2021-02-15 04632, 2021

      • HorusHorrendus has quit
      • 2021-02-15 04635, 2021

      • reosarevok
        Other than that, more eslint fixes for MBS and a fair amount of small patches for small issues
      • 2021-02-15 04644, 2021

      • reosarevok
        CatQuest: what about you?
      • 2021-02-15 04650, 2021

      • CatQuest
        just a sec
      • 2021-02-15 04604, 2021

      • CatQuest
        Meow! `😺`
      • 2021-02-15 04608, 2021

      • Freso
        (Other people up for reviews today: Mr_Monkey, ruaok, zas, Freso, yvanzo, bitmap, alastairp, diru1100, shivam-kapila, _lucifer – anyone else who wants to give review, let me know ASAP!)
      • 2021-02-15 04610, 2021

      • CatQuest
        This week is Karneval!
      • 2021-02-15 04616, 2021

      • HorusHorrendus joined the channel
      • 2021-02-15 04616, 2021

      • CatQuest
        Today is also the last day of Lupercalia and on Sunday I'll be celebrating my 17th MusicBrainz Anniversary! 🎂
      • 2021-02-15 04629, 2021

      • CatQuest
        I am working on INST-977 as we speak ( a complicated ticket, it requires a lot of research!)
      • 2021-02-15 04629, 2021

      • CatQuest
      • 2021-02-15 04629, 2021

      • CatQuest
        fin, go alastairp ?
      • 2021-02-15 04630, 2021

      • BrainzBot
        INST-977: Improve ektara/gopichan https://tickets.metabrainz.org/browse/INST-977
      • 2021-02-15 04636, 2021

      • Freso
        🎉 🎉 🎉
      • 2021-02-15 04638, 2021

      • shivam-kapila
        🎉
      • 2021-02-15 04656, 2021

      • CatQuest
        :D
      • 2021-02-15 04602, 2021

      • alastairp
        hi
      • 2021-02-15 04654, 2021

      • alastairp
        last week we did a bunch of planning, I had some in-depth discussions with ruaok about LB cron tasks / data dumps, we came up with some good improvements to try and improve the reliability of these processes
      • 2021-02-15 04615, 2021

      • alastairp
        I worked a lot with _lucifer on version upgrades, we released a new BU which is slowly being rolled out in all downstream projects
      • 2021-02-15 04637, 2021

      • alastairp
        we made a CB release which fixed some very long running bugs (e.g. reviews of mbids with redirects)
      • 2021-02-15 04653, 2021

      • alastairp
        I also started reviewing and merging a few other CB PRs that had been piling up
      • 2021-02-15 04617, 2021

      • alastairp
        and I also spent some time finishing the BU PR which allows us to post statistics to granfa, that's ready for merging
      • 2021-02-15 04625, 2021

      • alastairp
        Mr_Monkey: ?
      • 2021-02-15 04631, 2021

      • Mr_Monkey
        Hai!
      • 2021-02-15 04636, 2021

      • reosarevok
        Beebi hai!
      • 2021-02-15 04656, 2021

      • Mr_Monkey
        Last week I refreshed and continued the BB PR that adds author credits
      • 2021-02-15 04640, 2021

      • Mr_Monkey
        I also worked on ListenBrainz, enabling collaborative playlists, fixing some front-end bugs, fiding new bugs , … :)
      • 2021-02-15 04602, 2021

      • Mr_Monkey
        Also worked on fixing mistakes with a previous Webpack-related PR I made
      • 2021-02-15 04606, 2021

      • alastairp
        !m Mr_Monkey for writing more python!
      • 2021-02-15 04606, 2021

      • BrainzBot
        You're doing good work, Mr_Monkey for writing more python!!
      • 2021-02-15 04614, 2021

      • Mr_Monkey
        Yay !
      • 2021-02-15 04625, 2021

      • Mr_Monkey
        Also reviewed PRs for LB and BB.
      • 2021-02-15 04640, 2021

      • Mr_Monkey
        And more debugging on LB.
      • 2021-02-15 04642, 2021

      • Mr_Monkey
        That's mostly it for me !
      • 2021-02-15 04650, 2021

      • Mr_Monkey
        shivam-kapila: go !
      • 2021-02-15 04652, 2021

      • Freso
        Mostly? :p
      • 2021-02-15 04622, 2021

      • shivam-kapila
        Thanks Mr_Monkey
      • 2021-02-15 04624, 2021

      • Mr_Monkey
        ( Freso: I noted a time entry with "LB React", and of course can't remember chat it was about :) )