ruaok: i think its ready to be deployed. alastairp: sanity check please
2021-02-16 04751, 2021
atj
My suggestion would be that you have a simple boolean field to flag an image as potentially offensive. Then you can have an profile option to enable/disable display of such images, with the default to not display for anonymous users.
2021-02-16 04709, 2021
alastairp
looks good to me ruaok _lucifer
2021-02-16 04728, 2021
alastairp
do we know what version of flask was used previously?
2021-02-16 04700, 2021
alastairp
if it was on 0.9mumble then there _may_ be some incompatible upgrades, but I don't know the app enough to know if this was the case
2021-02-16 04725, 2021
ruaok
not that old. I recently upgraded pacakges.
2021-02-16 04735, 2021
alastairp
yeah, I see that the BU dependency is recent
2021-02-16 04700, 2021
ZaphodBeeblebrox really goes now
2021-02-16 04722, 2021
alastairp
mmm
2021-02-16 04729, 2021
alastairp
yeah, looks like flask didn't change since v0.15, so looks good to me đź‘Ť
alastairp: https://ci.metabrainz.org/job/listenbrainz-integr… the test to call our production labs api endpoint for recording lookup times out during testing. I personally think we should not be doing that in running integration tests. we should have a test for fetching the metadata with mocks and all that, but we should disable the metadata fetching during testing since it adds nothing to the tests and hitting a
2021-02-16 04701, 2021
ruaok
production API for testing is questionable in the first place. Thoughts? How would you disable this?
in this case I'm adding a flag to get_paylist with fetch_metadata, which allows the tests to pass a False flag in order to skip this issue for the one test we have failing now.
2021-02-16 04734, 2021
iliekcomputers
ruaok: did you get a chance to look at stripe.com/climate ? I'd love to get your opinion on us participating.
2021-02-16 04726, 2021
ruaok
oh, I wanted to figure out what that number was for 2020, but then got angry at QuickBooks for never allowing the sorts of simple queries I want. let me see if I can do that after I submit this fix.
2021-02-16 04749, 2021
iliekcomputers
yeah, I think we could even mention that x% of donations via stripe go to carbon capture. wonder if that'd increase donations :)
$20,859 in stripe transactions last year. 1% of that would be $208.
2021-02-16 04727, 2021
iliekcomputers
+++
2021-02-16 04729, 2021
iliekcomputers
nice.
2021-02-16 04748, 2021
_lucifer
ruaok: alastairp: i think that listenbrainz_spark is using flask (and BU) only for logging and loading config values. but the sentry_sdk comes with a PysparkIntegration so its easy to use it directly instead. that way we can remove the BU dependency from spark. do you think its worthwhile to make the shift?
Mr_Monkey: alastairp ^^ see what you think, but I hope that should improve testing and fix the failing test.
2021-02-16 04721, 2021
alastairp
ruaok: and even the floating point data in AB isn't a single user-provided input
2021-02-16 04739, 2021
atj
that's a fun bug
2021-02-16 04752, 2021
ruaok
woo. all tests for 1288 pass. thoughts on the fix, alastairp ?
2021-02-16 04745, 2021
bitmap has quit
2021-02-16 04753, 2021
bitmap_ joined the channel
2021-02-16 04717, 2021
bitmap_ is now known as bitmap
2021-02-16 04710, 2021
Mr_Monkey
If we test the metadata fetching in another way, as you suggest, then this does look good. Thanks for looking at it, I was scratching my brain at those test failures yesterday.
2021-02-16 04736, 2021
ruaok
well, the previous method didn't test the metadata fetching either. :)
2021-02-16 04704, 2021
ruaok
let me merge that branch into yours and then add a test for the metadata fetch.
gah. not sure I care to write this test. this test will soon be thrown away when we add the more nuanced service layer that is missing. we're not losing a test, so I'm all for merging and moving on.
2021-02-16 04702, 2021
ruaok
Mr_Monkey: there are open conversations on PR 1276. have a look, please?
2021-02-16 04759, 2021
Mr_Monkey
OK
2021-02-16 04715, 2021
Mr_Monkey
All converstions closed, pushed a small docstrings change.
2021-02-16 04753, 2021
ruaok
it would be nice to add another couple of tests...
2021-02-16 04731, 2021
ruaok
wait, I take that back. what I was thinking would already be covered by other tests.
