Good morning. Got a mail reagarding org application deadline(19 feb) so putting it here :)
2021-02-17 04818, 2021
Piyush joined the channel
2021-02-17 04809, 2021
Piyush has quit
2021-02-17 04826, 2021
mugen joined the channel
2021-02-17 04830, 2021
mugen has left the channel
2021-02-17 04837, 2021
mugen joined the channel
2021-02-17 04817, 2021
d4rkie joined the channel
2021-02-17 04826, 2021
Nyanko-sensei has quit
2021-02-17 04825, 2021
sampsyo has quit
2021-02-17 04800, 2021
ZaphodBeeblebrox is now known as CatQuest
2021-02-17 04803, 2021
sampsyo joined the channel
2021-02-17 04833, 2021
mugen has quit
2021-02-17 04826, 2021
yvanzo
mo’’in’
2021-02-17 04805, 2021
adhawkins has quit
2021-02-17 04804, 2021
yvanzo
bitmap: CAA-indexer 'master' branch has an unreleased/undeployed patch (about S3), so I’m not sure it is okay to merge a new PR onto it, override the current image and deploy. Your review would be welcome too, see comments.
thanks for the stats review ruaok, lots of good small things to improve
2021-02-17 04832, 2021
ruaok
yay, very believable. thanks!
2021-02-17 04848, 2021
alastairp
ruaok: I was looking at the PR that you opened for metadata on playlists
2021-02-17 04856, 2021
mugen joined the channel
2021-02-17 04823, 2021
alastairp
what was the motivation for introducing the query parameter to skip lookup? Is this something that you absolutely want to make available on the public endpoint?
2021-02-17 04816, 2021
ruaok
main motivation was for making it easier to write tests, but as I thought about it, I can see use cases where someone might skip the metadata lookup step.
2021-02-17 04821, 2021
alastairp
if we think that this is useful, then that's fine. however I'm not sure it makes the tests any easier to understand, we're just just swapping "remember to mock this method on a test that uses get()" with "remember to pass in metadata=false on a test that uses get"
2021-02-17 04833, 2021
alastairp
and theoretically we should have a test that includes the metadata test anyway (mocked) to ensure that this code flow works. I think this is what you mentioned about delaying until we stop using this webservice lookup in this codeflow?
2021-02-17 04834, 2021
ruaok
it is certainly easier than writing a freaking mock. tests are now 2 lines shorter, which feels like a win to me. (and shorter simpler tests is something that you keep emphasising)
2021-02-17 04827, 2021
ruaok
mas o menos. given that we need to go back and clean up the service layer, if I were to write a test right now, we'd toss that test out and have to replace it with something better later.
2021-02-17 04842, 2021
ruaok
not enthused to write tests that didn't exist before and that won't live long.
2021-02-17 04848, 2021
alastairp
sure
2021-02-17 04824, 2021
alastairp
for me, I really can't see a difference between the mental effort required to remember to copy a @mock line from an existing test and remembering to add fetch_metadata="false" to the get
2021-02-17 04834, 2021
alastairp
but the tests are still working, and we have new useful functionality, so that's fine for now
2021-02-17 04844, 2021
ruaok
honestly, if we're going to quibble over sufficiently testing the playlist feature, there are large aspects that have zero tests right now. perhaps we should focus on those before getting into the weeds on the existing tests.
2021-02-17 04853, 2021
atj
Have you considered using a testing library that stores HTTP requests and replays them, or is that not feasible?
2021-02-17 04808, 2021
atj
Much easier than mocking IME
2021-02-17 04819, 2021
alastairp
atj: we don't have one of those yet. it's an option, but would require integration of a new feature anyway
2021-02-17 04848, 2021
ruaok
right now, I want to be doing less infrastructure improvements and get back to working on some actual user facing features. which I haven't done this year, so it seems
2021-02-17 04805, 2021
atj
you mean you don't enjoy writing bash scripts ruaok?!
I don't have admin on https://github.com/metabrainz/brainzutils-python/. Can someone with admin add the issue-link magic so that we can link to jira with BU-nn, or give me admin on the github repo?
2021-02-17 04813, 2021
alastairp
ruaok: yvanzo: ^
2021-02-17 04842, 2021
ruaok
you should be admin now
2021-02-17 04845, 2021
alastairp
I am, thanks
2021-02-17 04837, 2021
alastairp
_lucifer: careful, I might have to ask you to slow down on new PRs...
2021-02-17 04854, 2021
adk0971 joined the channel
2021-02-17 04800, 2021
adk0971 has quit
2021-02-17 04838, 2021
adk0971 joined the channel
2021-02-17 04849, 2021
yvanzo
ruaok: do you still need 'ruaok' user for RabbitMQ?
2021-02-17 04809, 2021
ruaok
yes, it is useful for cleaning out queues and whatnot.
2021-02-17 04804, 2021
yvanzo
we could create an 'admin' user in docker server configs instead if you prefer
2021-02-17 04818, 2021
ruaok
sure, lets do that.
2021-02-17 04840, 2021
yvanzo
ok, will do
2021-02-17 04810, 2021
alastairp
iliekcomputers: I'm considering removing messybrainz-server from livegrep as the repo is archived, the code is in the LB repo so search on msb-specific code should keep working. it keeps on throwing up false positives when searching for old code/dependencies
2021-02-17 04815, 2021
shivam-kapila
Picard has a proposed hindi project. Nice :)
2021-02-17 04831, 2021
iliekcomputers
alastairp: sounds good to me
2021-02-17 04801, 2021
alastairp
zas: can we remove messybrainz-server repo from livegrep? It's been archived and the code moved into another repository
I see no docs in syswiki, is this something that I could have done if there were instructions?
2021-02-17 04828, 2021
_lucifer
alastairp: :DD
2021-02-17 04818, 2021
ruaok
shivam-kapila: outsidecontext : the hindi translation of Picard is actually not a project we can accept. any accepted project HAS to include some coding.
2021-02-17 04833, 2021
ruaok
we either remove it or couple it with something that requires coding.
zas: should I add a page on syswiki with link to the repo and server login details?
2021-02-17 04811, 2021
zas
yup
2021-02-17 04841, 2021
adk0971 has quit
2021-02-17 04808, 2021
alastairp
zas: what's the server?
2021-02-17 04833, 2021
adk0971 joined the channel
2021-02-17 04835, 2021
sumedh joined the channel
2021-02-17 04810, 2021
iliekcomputers
alastairp: i'm not sure if you have access but livegrep.metabrainz.org would work for ssh, no?
2021-02-17 04811, 2021
ruaok
I dont even have access. :)
2021-02-17 04801, 2021
adk0971 has quit
2021-02-17 04811, 2021
iliekcomputers
#leastprivilege
2021-02-17 04822, 2021
iliekcomputers
:)
2021-02-17 04826, 2021
ruaok
yvanzo: shall we pick a time for the release today?
2021-02-17 04801, 2021
yvanzo
ruaok: whenever you are free, can be now.
2021-02-17 04816, 2021
ruaok
now is good.
2021-02-17 04822, 2021
ruaok
let me update the tag on my image.
2021-02-17 04830, 2021
yvanzo
ok
2021-02-17 04848, 2021
ruaok
do you have the upgrade steps documented somewhere?
2021-02-17 04811, 2021
yvanzo
I will compile notes for LB
2021-02-17 04816, 2021
ruaok
thx
2021-02-17 04837, 2021
antlarr2 joined the channel
2021-02-17 04845, 2021
antlarr has quit
2021-02-17 04854, 2021
mugen joined the channel
2021-02-17 04843, 2021
outsidecontext
ruaok: ok, I'll remove it. I haven't edited the page yet, the project was there from last year. I wasn't involved in the discussion, was it acceptable back then?
2021-02-17 04807, 2021
ruaok
naw, it should've never been there, but no big deal.
ruaok: if we can merge this, I'll use it to add a proper docs page for the stats PR
2021-02-17 04811, 2021
ruaok
ok, I'll look at it when I'm idle during this release process.
2021-02-17 04823, 2021
ruaok
yvanzo: I'm sanity checking your PRs and I've found that listenbrainz-websockets-{beta|prod|test} is also a consumer. can you please add that to the consumer PR?
2021-02-17 04807, 2021
ruaok
I also found another producer. should I update the PRs instead? your call.
2021-02-17 04803, 2021
ruaok
listenbrainz-websockets-{beta|prod|test} -> consumer and listenbrainz-api-compat-prod -> producer.
2021-02-17 04806, 2021
yvanzo
thanks, I will add them both
2021-02-17 04813, 2021
ruaok
thank you!
2021-02-17 04818, 2021
ruaok
ok, both look good.
2021-02-17 04831, 2021
yvanzo
ruaok: updated
2021-02-17 04839, 2021
ruaok
approved.
2021-02-17 04814, 2021
yvanzo
so, just to confirm, the other containers are not using RabbitMQ? labs-api-prod, api-compat-nginx, cron, timescale, mbid-mapping, typesense, redis
