ruaok: alastairp: i am trying to fix the failing test here https://ci.metabrainz.org/job/listenbrainz-spark-…. It seems to happen because the test mocks subprocess.Popen which is also patched during sentry initialization. I have guarded the sentry_initialization so that it only happens in case there is a `LOG_SENTRY` variable in `config`. However, it still fails. How is the config set during spark tests?
yvanzo: not sure I asked clearly enough. Has the RMQ service name been renamed so that a service (listenbrainz spark) that doesn't know how to connect to the temporary service will now connect to the new service?
2021-02-18 04956, 2021
yvanzo
ruaok: no, rabbitmq-prince is the new service.
2021-02-18 04908, 2021
lks joined the channel
2021-02-18 04945, 2021
yvanzo
ruaok: ListenBrainz images need RABBITMQ_SERVICE set to 'rabbitmq-prince' to connect to it.
2021-02-18 04910, 2021
ruaok
yes, understood.
2021-02-18 04949, 2021
yvanzo
Replacing that env var to just use consul-template instead would need a patch to LB and rebuilding images again.
2021-02-18 04911, 2021
ruaok
we have one service whose setup has not been patched at all, that is why i am asking.
2021-02-18 04955, 2021
yvanzo
There currently are 3 connections using 'caa' user and 1 using 'lb' user to the old 'rabbitmq' on 'trille'.
2021-02-18 04950, 2021
yvanzo
CAA-indexer is not possibly doing that, so maybe the 'lb' connection doesn't come from an LB container either.
2021-02-18 04922, 2021
ruaok
oh, never mind. the spark request consumer is not part of the consul world, it needs to be manually updated in a much more complicated process. ok, I'll get that process going.
2021-02-18 04951, 2021
ruaok
zas says that the telegraf configuration will automatically pick up the change an reconfigure once the rabbitmq service as defined by consul changes from rabbitmq to rabbitmq-prince.
I'm almost done double checking that this is right. lol. :)
2021-02-18 04947, 2021
ruaok
shit, sorry.
2021-02-18 04956, 2021
ruaok
62673 is the correct port. :(
2021-02-18 04903, 2021
ruaok
zas? ^^
2021-02-18 04918, 2021
zas
ok :) fixing it
2021-02-18 04921, 2021
ruaok
thx
2021-02-18 04925, 2021
zas
shoot again
2021-02-18 04932, 2021
ruaok
works, thanks!!
2021-02-18 04900, 2021
BrainzGit
[musicbrainz-server] reosarevok opened pull request #1922 (master…MBS-5680): MBS-5680: Allow inc=artist-credits in combination with rels incs that have ACs https://github.com/metabrainz/musicbrainz-server/…
2021-02-18 04908, 2021
v6lur joined the channel
2021-02-18 04908, 2021
chaban has quit
2021-02-18 04908, 2021
reosarevok has quit
2021-02-18 04908, 2021
alastairp has quit
2021-02-18 04908, 2021
zas has quit
2021-02-18 04908, 2021
ruaok has quit
2021-02-18 04926, 2021
alastairp joined the channel
2021-02-18 04906, 2021
ruaok joined the channel
2021-02-18 04921, 2021
reosarevok joined the channel
2021-02-18 04921, 2021
zas joined the channel
2021-02-18 04922, 2021
chaban joined the channel
2021-02-18 04930, 2021
yvanzo
I just closed the 3 connections for 'caa' on old trille instance and they did not reopen.
2021-02-18 04951, 2021
yvanzo
However, the connection for 'lb' cannot be closed: it's still getting reopened.
2021-02-18 04927, 2021
zas
yvanzo: as said; if it is telegraf it will just remove this instance from its config when the container will be stopped
