#metabrainz

/

      • d4rkie has quit
      • 2021-02-22 05334, 2021

      • Nyanko-sensei joined the channel
      • 2021-02-22 05354, 2021

      • BrainzGit has quit
      • 2021-02-22 05311, 2021

      • BrainzGit joined the channel
      • 2021-02-22 05354, 2021

      • BrainzGit has quit
      • 2021-02-22 05313, 2021

      • BrainzGit joined the channel
      • 2021-02-22 05355, 2021

      • BrainzGit has left the channel
      • 2021-02-22 05322, 2021

      • BrainzGit joined the channel
      • 2021-02-22 05355, 2021

      • BrainzGit has quit
      • 2021-02-22 05315, 2021

      • BrainzGit joined the channel
      • 2021-02-22 05355, 2021

      • BrainzGit has left the channel
      • 2021-02-22 05326, 2021

      • BrainzGit joined the channel
      • 2021-02-22 05355, 2021

      • BrainzGit has quit
      • 2021-02-22 05326, 2021

      • BrainzGit joined the channel
      • 2021-02-22 05336, 2021

      • yokel has quit
      • 2021-02-22 05331, 2021

      • yokel joined the channel
      • 2021-02-22 05343, 2021

      • Darkloke joined the channel
      • 2021-02-22 05331, 2021

      • flamingspinach_ joined the channel
      • 2021-02-22 05302, 2021

      • flamingspinach has quit
      • 2021-02-22 05303, 2021

      • djinni` has quit
      • 2021-02-22 05308, 2021

      • yvanzo
        mo’’in’
      • 2021-02-22 05358, 2021

      • shivam-kapila
        Good morning
      • 2021-02-22 05316, 2021

      • djinni` joined the channel
      • 2021-02-22 05326, 2021

      • flamingspinach_ has quit
      • 2021-02-22 05349, 2021

      • flamingspinach joined the channel
      • 2021-02-22 05309, 2021

      • Darkloke has quit
      • 2021-02-22 05332, 2021

      • Cyna[m]
        Good morning
      • 2021-02-22 05303, 2021

      • flamingspinach_ joined the channel
      • 2021-02-22 05334, 2021

      • flamingspinach has quit
      • 2021-02-22 05331, 2021

      • d4rkie joined the channel
      • 2021-02-22 05356, 2021

      • Nyanko-sensei has quit
      • 2021-02-22 05312, 2021

      • flamingspinach_ has quit
      • 2021-02-22 05335, 2021

      • flamingspinach joined the channel
      • 2021-02-22 05334, 2021

      • d4rkie has quit
      • 2021-02-22 05329, 2021

      • Nyanko-sensei joined the channel
      • 2021-02-22 05325, 2021

      • blinky42 has quit
      • 2021-02-22 05314, 2021

      • blinky42 joined the channel
      • 2021-02-22 05315, 2021

      • iliekcomputers
        good morning!
      • 2021-02-22 05302, 2021

      • ruaok
        mooin!
      • 2021-02-22 05337, 2021

      • alastairp
        hi there
      • 2021-02-22 05308, 2021

      • alastairp
        ruaok: got anything you need to release today in LB? I was thinking we could do 1271 and 1237
      • 2021-02-22 05316, 2021

      • ruaok
        not really
      • 2021-02-22 05312, 2021

      • okno_ joined the channel
      • 2021-02-22 05340, 2021

      • okno_ has quit
      • 2021-02-22 05305, 2021

      • okno_ joined the channel
      • 2021-02-22 05344, 2021

      • okno_ has quit
      • 2021-02-22 05310, 2021

      • okno_ joined the channel
      • 2021-02-22 05328, 2021

      • alastairp
      • 2021-02-22 05332, 2021

      • alastairp
        > An open source multi-tool for exploring and publishing data
      • 2021-02-22 05352, 2021

      • alastairp
        this is interesting. I've seen it come up a whole bunch of times on twitter and hacker news in the last few months
      • 2021-02-22 05318, 2021

      • alastairp
        I wonder if it could be useful for any of our needs, it seems like some of its functionality is really close to data-set-hoster
      • 2021-02-22 05327, 2021

      • BrainzGit
        [musicbrainz-docker] yvanzo opened pull request #185 (master…fix-createdb-dev): MBVM-66: Fix running createdb.sh in development setup https://github.com/metabrainz/musicbrainz-docker/…
      • 2021-02-22 05353, 2021

      • yvanzo
        Cyna[m]: that should fix it ^
      • 2021-02-22 05336, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1271 (master…versions): Pin package versions and update brainzutils https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-22 05333, 2021

      • alastairp
        iliekcomputers: ruaok: do we have any tools for checking all of the LB services on test or beta? I'm thinking stuff like compat api, and end-to-end listen ingest
      • 2021-02-22 05347, 2021

      • alastairp
        we're not running the timescale writer on test, right?
      • 2021-02-22 05301, 2021

      • ruaok
        We don't. We're not.
      • 2021-02-22 05338, 2021

      • alastairp
        I was thinking that it'd be great to be able to deploy a full stack on test, especially when we make major changes, and then run something through all of the pipelines before we deploy on prod
      • 2021-02-22 05342, 2021

      • iliekcomputers
        my personal opinion here is that metrics in production systems that you could look at during deploys would be much more valuable (and possibly less effort to develop and when deploying)
      • 2021-02-22 05311, 2021

      • iliekcomputers
        looking at graphs of number of listens from each of the pipelines or something for 5 minutes after each deploy
      • 2021-02-22 05341, 2021

      • alastairp
        iliekcomputers: In this case I'm specifically thinking about these two PRs that I want to deploy today, which include upgrading a bunch of software versions, and also redoing the entire app startup stack
      • 2021-02-22 05317, 2021

      • alastairp
        so it kind of seems that there's no way to check for example that the timescale writer will start up again, other than actually deploying it and checking live in prod
      • 2021-02-22 05339, 2021

      • alastairp
        I've tested it locally and it starts, so that's definitely 95% of the concerns solved
      • 2021-02-22 05342, 2021

      • iliekcomputers
        beta should be good for that, no? it should have everything other than spotify-reader iirc. But there's no end-to-end pipeline testing
      • 2021-02-22 05358, 2021

      • alastairp
        as far as I understand beta runs off the main listen db, right? so no timescale writer or spotify reader?
      • 2021-02-22 05358, 2021

      • alastairp
        anyway, I've tested everything locally and it seems good, so maybe I'm overthinking it
      • 2021-02-22 05300, 2021

      • iliekcomputers
        it should still have timescale writer for listens submitted to beta. It does run off the main DB.
      • 2021-02-22 05335, 2021

      • iliekcomputers
        alastairp: yeah, it's very easy to revert changes, so I wouldn't be very concerned.
      • 2021-02-22 05339, 2021

      • alastairp
        I guess my preference is to test early and fix things before deploying, rather than deploy and rely on stats to tell us that it's broken and then have to fix things/rollback live
      • 2021-02-22 05332, 2021

      • BrainzGit
        [listenbrainz-server] yvanzo opened pull request #1291 (master…rabbitmq-consul-kv): Replace RABBITMQ_SERVICE environment variable with Consul key-value pair https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-22 05344, 2021

      • okno_ has quit
      • 2021-02-22 05304, 2021

      • reosarevok
      • 2021-02-22 05305, 2021

      • BrainzBot
        MBS-10519: Make it easier to follow links whose titles only contain non-printable characters
      • 2021-02-22 05320, 2021

      • reosarevok
        Is there a way to programmatically check whether something is non-printable?
      • 2021-02-22 05345, 2021

      • alastairp
        restarting LB beta
      • 2021-02-22 05324, 2021

      • alastairp
        looks good to me with version upgrades
      • 2021-02-22 05335, 2021

      • alastairp
        building prod image now
      • 2021-02-22 05326, 2021

      • BrainzGit
        [critiquebrainz] alastair merged pull request #336 (master…consul): Prepare for consul upgrade https://github.com/metabrainz/critiquebrainz/pull…
      • 2021-02-22 05309, 2021

      • BrainzGit
        [acousticbrainz-server] alastair merged pull request #388 (master…master): Prepare for Consul upgrade https://github.com/metabrainz/acousticbrainz-serv…
      • 2021-02-22 05338, 2021

      • sumedh joined the channel
      • 2021-02-22 05305, 2021

      • atj
        reosarevok: the joys of unicode
      • 2021-02-22 05329, 2021

      • atj
        I'm not aware of any "non-printable" classification
      • 2021-02-22 05359, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo merged pull request #1285 (master…fix-epoch-bp): use recommendation feedback in BP player https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-22 05329, 2021

      • alastairp
        zas: yvanzo: regarding trille maintenance, do we understand how much downtime there might be? Should we move critiquebrainz to a different server while it's down?
      • 2021-02-22 05346, 2021

      • yvanzo
        reosarevok, atj: There are non-printable characters in ASCII, there is even a class to match them in regular expressions.
      • 2021-02-22 05312, 2021

      • atj
        yvanzo: what's the class?
      • 2021-02-22 05321, 2021

      • atj
        I know there's a class for whitespace
      • 2021-02-22 05316, 2021

      • yvanzo
        see control characters
      • 2021-02-22 05348, 2021

      • reosarevok
        yvanzo, bitmap: do you have any good idea on how to avoid https://tickets.metabrainz.org/browse/MBS-10498 ?
      • 2021-02-22 05349, 2021

      • BrainzBot
        MBS-10498: The cached recent entities shown in the autocomplete can contain merged or removed entities that break edit submissions
      • 2021-02-22 05357, 2021

      • BrainzGit
        [acousticbrainz-server] alastair merged pull request #391 (master…master): fixed typo in readme.md https://github.com/metabrainz/acousticbrainz-serv…
      • 2021-02-22 05357, 2021

      • BrainzGit
        [acousticbrainz-server] alastair merged pull request #393 (master…versions): Pin package versions https://github.com/metabrainz/acousticbrainz-serv…
      • 2021-02-22 05306, 2021

      • Darkloke joined the channel
      • 2021-02-22 05324, 2021

      • testy joined the channel
      • 2021-02-22 05324, 2021

      • testy has quit
      • 2021-02-22 05346, 2021

      • Darkloke has quit
      • 2021-02-22 05308, 2021

      • Darkloke joined the channel
      • 2021-02-22 05319, 2021

      • yvanzo
        alastairp: No idea. But in any case, it would be nice to better handle dumped data.
      • 2021-02-22 05322, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1926 (master…MBS-10470): MBS-10470: Rename "IRC" link in footer to "Chat (IRC)" https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-22 05310, 2021

      • bitmap
        reosarevok: I already have a working patch for that in my relationship editor branch, I mentioned it last week
      • 2021-02-22 05326, 2021

      • reosarevok
        Oh, ok, sorry
      • 2021-02-22 05330, 2021

      • reosarevok
        Forgot
      • 2021-02-22 05332, 2021

      • bitmap
        it just stores the mbids instead and re-fetches them on page load
      • 2021-02-22 05341, 2021

      • reosarevok
        Wanna link it as resolved by? :)
      • 2021-02-22 05359, 2021

      • zas
        alastairp: if everything goes well, down time should be few minutes; but we never know, it'd be safer to ensure there are backups and move the service elsewhere.
      • 2021-02-22 05340, 2021

      • alastairp
        database is on main db master
      • 2021-02-22 05347, 2021

      • alastairp
        so it's just the web container, which we can move
      • 2021-02-22 05312, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1927 (master…MBS-10452): MBS-10452: Implement tagger links for releases on recording pages https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-22 05342, 2021

      • yvanzo
        alastairp: there is a data volume attached to it, with 11GB of daily dumps.
      • 2021-02-22 05354, 2021

      • _lucifer
        the latest cb database dump failed in case that's related, alastairp
      • 2021-02-22 05356, 2021

      • alastairp
        oh, right!
      • 2021-02-22 05308, 2021

      • alastairp
        I think that's copied to ftp any
      • 2021-02-22 05311, 2021

      • alastairp
        anyway
      • 2021-02-22 05322, 2021

      • alastairp
        _lucifer: unrelated I think, but thanks for the notification, I'll check it out
      • 2021-02-22 05342, 2021

      • yvanzo
        What are these dumps for? Should they be backed up?
      • 2021-02-22 05317, 2021

      • _lucifer
        yvanzo: these are cb reviews dumps
      • 2021-02-22 05338, 2021

      • yvanzo
        It's copied to ftp indeed. Maybe dumps in this volume should be rotated then?
      • 2021-02-22 05322, 2021

      • iliekcomputers
        daft punk broke up :(
      • 2021-02-22 05340, 2021

      • alastairp
        broken up for scrap?
      • 2021-02-22 05352, 2021

      • diru1100 joined the channel
      • 2021-02-22 05318, 2021

      • alastairp
        zas: https://github.com/metabrainz/docker-consul-templ… this is the place where CONSUL_PORT is used, right?
      • 2021-02-22 05334, 2021

      • alastairp
        I think it's already in place in run-consul-template, so we just need to add the env variable
      • 2021-02-22 05344, 2021

      • zas
        yes, please do, we have to make it explicit everywhere
      • 2021-02-22 05350, 2021

      • alastairp
        👍
      • 2021-02-22 05347, 2021

      • BrainzGit
        [musicbrainz-docker] yvanzo merged pull request #185 (master…fix-createdb-dev): MBVM-66: Fix running createdb.sh in development setup https://github.com/metabrainz/musicbrainz-docker/…
      • 2021-02-22 05349, 2021

      • shivam-kapila
        Freso: Hi. I dont have anything for review this week. Please take me off the list this time. Thanks
      • 2021-02-22 05323, 2021

      • BrainzGit
        [listenbrainz-server] yvanzo merged pull request #1291 (master…rabbitmq-consul-kv): Replace RABBITMQ_SERVICE environment variable with Consul key-value pair https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-22 05355, 2021

      • sumedh has quit
      • 2021-02-22 05327, 2021

      • CatQuest
        I'm sure *everyone* here has seen this but just incase: https://xkcd.com/2425/
      • 2021-02-22 05305, 2021

      • sumedh joined the channel
      • 2021-02-22 05305, 2021

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, GSoC (ruaok)
      • 2021-02-22 05310, 2021

      • Freso
        <BANG>
      • 2021-02-22 05310, 2021

      • Freso
        It’s Be Humble Monday!
      • 2021-02-22 05310, 2021

      • Freso
      • 2021-02-22 05310, 2021

      • Freso
        I’ve received one mailed in review, so Mr_Monkey, go!
      • 2021-02-22 05310, 2021

      • Freso
        Mr_Monkey says…
      • 2021-02-22 05310, 2021

      • Freso
        """
      • 2021-02-22 05310, 2021

      • Freso
        Hi everyone! I’m a bit sick today and laying low.
      • 2021-02-22 05311, 2021

      • Freso
        Last week for the most part I worked on author credits for BookBrainz. An alpha version of sorts is up for testing on test.bookbrainz.org
      • 2021-02-22 05312, 2021

      • Freso
        I also worked on ListenBrainz: the last bits needed for collaborative playlists deployment, reviewing PRs, and figuring out why the Youtube player doesn’t work on LB.
      • 2021-02-22 05313, 2021

      • Freso
        Turns out the way we use it for searching tracks has been deprecated since November.
      • 2021-02-22 05314, 2021

      • Freso
        I drafted a document for how to proceed in order to fix it, using the Youtube API. It requires a fair amount of refactoring on the server and client side.
      • 2021-02-22 05315, 2021

      • Freso
        I also helped new contributors getting set up to work on BookBrainz.
      • 2021-02-22 05316, 2021

      • Freso
        And finally, spent some time looking into some data entries in BookBrainz following this discussion and related activity:
      • 2021-02-22 05316, 2021

      • Freso
      • 2021-02-22 05317, 2021

      • Freso
        """
      • 2021-02-22 05317, 2021

      • Freso
        Other people up for reviews: yvanzo, zas, Freso, bitmap, ruaok, reosarevok, alastairp, _lucifer, CatQuest – anyone else who want to give a review, let me know ASAP!
      • 2021-02-22 05318, 2021

      • Freso
        yvanzo: Take it away!
      • 2021-02-22 05330, 2021

      • yvanzo
        Hi all!
      • 2021-02-22 05352, 2021

      • yvanzo
        Last week I mostly worked on maintenance operations for RabbitMQ.