last week I was still fixing bugs in the relationship editor / autocomplete components and working on integrating them into the release relationship editor, while trying to resolve parts of MBS-7981
later in the week I submitted a fix for MBS-11410 and did some investigation into MBS-10896, the latter of which I think I have a good idea on how to resolve so that we can remove a lot of lock contention on the vote table
other than that, I was helping test gitzconsul a bit more, which I need to follow up on today, and was continuing to tidy up commits from the relationship editor branch so I can submit those in smaller pieces
2021-03-01 06014, 2021
bitmap
fin! zas: goo
2021-03-01 06018, 2021
zas
Hey
2021-03-01 06037, 2021
zas
usual bunch of required upgrades
2021-03-01 06057, 2021
zas
I also refined few blacklists to save a bit of bandwidth / cpu
2021-03-01 06023, 2021
zas
I reviewed a bunch of Picard PRs (a new release should occur tomorrow)
2021-03-01 06028, 2021
Freso
(Only myself left on my list – last call for anyone else who want to give review!!)
2021-03-01 06050, 2021
zas
and worked on stabilizing gitzconsul (thanks bitmap for the feedback)
2021-03-01 06003, 2021
zas
that's it for me. Freso?
2021-03-01 06014, 2021
Freso
👋
2021-03-01 06059, 2021
Freso
Mostly the usual. Lurking around and such. Also attended board meeting and noted that the board approved of a new hire. :p Welcome _lucifer! :)
2021-03-01 06009, 2021
_lucifer
thanks Freso :D
2021-03-01 06013, 2021
Freso
fin.
2021-03-01 06029, 2021
Freso
Which wraps up tonight’s reviews! Thank you everyone who gave one. :)
a) is this private data or could it be in, say, the subscriptions page and b) what would we even consider "last activity date"
2021-03-01 06051, 2021
reosarevok
I guess if we just take "date of last edit", for example, then it's public as it is and might be fine - if we also list "date they last tagged or rated", then not so much
2021-03-01 06001, 2021
Freso
We could show a "last edit/vote" which is semi-public data anyway?
2021-03-01 06011, 2021
CatQuest
personally I don't care about subscriptions, but going ot a n users accoutn ans seeing they where last active in, say 2009 will hlep with "shoudl i message thme with this edit"
2021-03-01 06014, 2021
CatQuest
or no"
2021-03-01 06015, 2021
zas
bitmap: MBS-11417 (btw, not sure if it should be MBS or MBH)
I don’t think we should show when they last opened a page/renewed their session.
2021-03-01 06008, 2021
yvanzo
the first ticket is about showing it to editor/admin, there is no privacy concerns in this case, but it should not degrade performances
2021-03-01 06009, 2021
reosarevok
I agree that the info is useful - "last login" is effectively pointless since if everything goes well, you can go for months without that changing
2021-03-01 06011, 2021
CatQuest
yea that seesm. resuoure intensive for no great gain too
2021-03-01 06023, 2021
CatQuest
actually years :D
2021-03-01 06029, 2021
Freso
But showing last edit and/or vote date is probably fine, since that data could be found out anyway.
2021-03-01 06034, 2021
reosarevok
(I'm not sure why we even display it, given that)
2021-03-01 06000, 2021
reosarevok
ruaok: I'd like your call on this re: what's ok to display
2021-03-01 06010, 2021
Freso
And yeah, for last refreshed session date, that should be fine to show to user admins, I guess. (Or something less invasive like what the ticket actually suggest.)
2021-03-01 06054, 2021
yvanzo
this is not a presence network, just link to your twitter status or favorite social network from your MB profile if you want that.
2021-03-01 06001, 2021
ruaok
date of last edit seems sane.
2021-03-01 06059, 2021
reosarevok
yvanzo: I assume we *want* to give people some idea of when the user was last active since we display last login date
2021-03-01 06003, 2021
reosarevok
It's just mostly useless
2021-03-01 06016, 2021
reosarevok
(wait, we display those for everyone, right? Or is it an account admin thing)
2021-03-01 06032, 2021
Freso
I think ruaok gave his answer? So let’s go with that? :)
2021-03-01 06046, 2021
yvanzo
reosarevok: we don't show last login date, but to admins.
2021-03-01 06051, 2021
reosarevok
Oh. Huh. TIL
2021-03-01 06006, 2021
reosarevok
Well, at the very least I'll make it so admins can say last edit date too then
2021-03-01 06007, 2021
reosarevok
Thans
2021-03-01 06010, 2021
reosarevok
*Thanks
2021-03-01 06019, 2021
Freso
Alright.
2021-03-01 06032, 2021
Freso
No additional topics have popped up, so this wraps up this meeting!
2021-03-01 06053, 2021
Freso
Thank you everyone for your time! Remember to stay safe and be kind to yourselves! ❤️
2021-03-01 06055, 2021
Freso
</BANG>
2021-03-01 06059, 2021
Mr_Monkey
Thanks !
2021-03-01 06006, 2021
shivam-kapila
Thank you
2021-03-01 06012, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
yvanzo, bitmap: AFAICT all works in that branch. I think the WIP was probably because I meant to ask you two (esp. bitmap who wrote the changed code) whether this was the right and safe way of doing it
