(I found it in the newspaper last week, I think it's the most apropos of our current times I've seen)
2021-03-08 06706, 2021
bouhormq
Hi everyone, my name is Salim and I'm a 3rd year CS student at the Polytechnic University of Catalonia in Barcelona, interested in working on a BookBrainz project for GSOC21. Looking forward to contributing to the repo and getting to know more about the community! =D (y)
2021-03-08 06707, 2021
CatQuest
Else I'm updating mb-wikidata genre links and Fiddling about with stuff, last week did bookbrainz stuff, will do mb stuff this week
2021-03-08 06708, 2021
CatQuest
â™’
2021-03-08 06708, 2021
CatQuest
fin, go
2021-03-08 06716, 2021
CatQuest
shivam-kapila:
2021-03-08 06722, 2021
shivam-kapila
Hi
2021-03-08 06737, 2021
Freso
bouhormq: We’re currently in a meeting. Stick around for the next 20 or so minutes, then meeting should be over. :)
2021-03-08 06747, 2021
alastairp
bon dia bouhormq, we're in the middle of our weekly meeting but we'll say hi soon
2021-03-08 06750, 2021
alastairp
^ what he said
2021-03-08 06700, 2021
bouhormq
Perfect!
2021-03-08 06710, 2021
shivam-kapila
Last week along with the LB team on the hack sprint
2021-03-08 06721, 2021
Freso
(Feel free to lurk/listen in to the meeting too.)
2021-03-08 06725, 2021
bouhormq
Thanks! =D
2021-03-08 06734, 2021
shivam-kapila
I primarily worked on react side of things creating components regarding similarity scores and similar users
2021-03-08 06740, 2021
Freso
(Only myself, _lucifer, and alastairp left on my list. Last call for anyone else who may want to give review. :))
2021-03-08 06730, 2021
shivam-kapila
I also noticed numpy upgrade borking the tests and shot a PR to resolve it
Not a lot going on last week. I got back into MusicBrainz editing though, and also did some BB editing. Otherwise mostly lurking about etc.; trying to get a couple of assignments done with for my Astronomy and Databases classes.
2021-03-08 06722, 2021
Freso
fin.
2021-03-08 06729, 2021
_lucifer
iliekcomputers: yes, this PR is unrelated to tha
2021-03-08 06731, 2021
Freso
_lucifer: Go!
2021-03-08 06733, 2021
iliekcomputers
Oh sorry, meeting.
2021-03-08 06752, 2021
_lucifer
Hi all!
2021-03-08 06712, 2021
Freso
iliekcomputers: _lucifer is second-to-last to review, and no further agenda items. We’ll be done soon. :)
2021-03-08 06713, 2021
CatQuest
hi
2021-03-08 06736, 2021
_lucifer
I worked on the spark side of user similarity things while ruaok took care of the webserver side.
2021-03-08 06759, 2021
_lucifer
We hopefully will be able to get it merged this week.
2021-03-08 06739, 2021
_lucifer
i also worked on improving the the spotify reader to handle users who delete revoke lb auth better
2021-03-08 06723, 2021
_lucifer
it hasn't go as expected till now, ended up releasing bug fixes thrice till now
2021-03-08 06728, 2021
_lucifer
that's it for me
2021-03-08 06731, 2021
_lucifer
alastairp: next
2021-03-08 06736, 2021
_lucifer
?
2021-03-08 06741, 2021
alastairp
hi
2021-03-08 06735, 2021
alastairp
last week I spent some time on Monday making plans for the hackweek, but I didn't manage to work on it as much as I had hoped. I did some work related to a task with shivam-kapila - we should talk tomorrow to see if we can integrate it, shivam-kapila :)
2021-03-08 06703, 2021
shivam-kapila
Sure sure
2021-03-08 06715, 2021
alastairp
on wednesday _lucifer and I finally finished rolling out the new consul-template changes, so we're now on 0.18 over all of the meb webapps
2021-03-08 06745, 2021
alastairp
we've seen a few issues come up over the last week around visibility of app startup that I'd like to tackle next, but I think we're doing well
2021-03-08 06735, 2021
alastairp
based on a discussion with ruaok I also started to write a planning doc about rolling oauth out over all MeB sites in a uniform way, we'll be meeting with _lucifer about putting together some prototypes for this and will hopefully have interesting news in the coming weeks
2021-03-08 06741, 2021
alastairp
Freso: that's me, thanks
2021-03-08 06746, 2021
Freso
Alright!
2021-03-08 06745, 2021
Freso
No one else has come forward about wanting to give review, so this wraps up tonight’s Reviews!
2021-03-08 06755, 2021
Freso
Thank you everyone who gave a review. :)
2021-03-08 06711, 2021
Freso
Additionally, we have no additional items on tonight’s agenda, so this also wraps up the meeting.
2021-03-08 06712, 2021
CatQuest
:)
2021-03-08 06724, 2021
Freso
Thank you everyone for your time! Stay safe out there, and if you’re in the northern hemisphere and have pollen allergies, remember to start checking the numbers and consider whether it is time to start taking your antihistamines. 🤧
2021-03-08 06730, 2021
Freso
</BANG>
2021-03-08 06742, 2021
yvanzo
Thanks!
2021-03-08 06753, 2021
shivam-kapila
Thanks
2021-03-08 06716, 2021
_lucifer
iliekcomputers: hey!
2021-03-08 06749, 2021
_lucifer
i released the bugfix. sentry is clear and i do not see errors on listens page. but I do not have a premium account to test if BP works
2021-03-08 06741, 2021
iliekcomputers
is spotify reader importing stuff?
2021-03-08 06749, 2021
iliekcomputers
my listens are ~8 hours behind :/
2021-03-08 06703, 2021
iliekcomputers
have we essentially broken the spotify connection for a bunch of users because we refreshed the token but weren't able to save it in the db?
2021-03-08 06722, 2021
iliekcomputers
>We imported your listens about 7 hours ago and the last song we imported was listened to about 8 hours ago.
2021-03-08 06744, 2021
_lucifer
😨
2021-03-08 06713, 2021
iliekcomputers
_lucifer: can you look at spotify reader logs?
2021-03-08 06720, 2021
iliekcomputers
is there anything there?
2021-03-08 06736, 2021
_lucifer
alastairp, iliekcomputers, its empty like spark reader
2021-03-08 06701, 2021
_lucifer
should i try restarting it?
2021-03-08 06739, 2021
iliekcomputers
i've unlinked and linked my spotify, let's wait and see if it picks some listens up
2021-03-08 06709, 2021
iliekcomputers
i see a bunch of internal server errors on the listens page now
2021-03-08 06750, 2021
iliekcomputers
it's not importing anything as far as i can see
2021-03-08 06709, 2021
alastairp
_lucifer: is the reader one of the services you restarted?
2021-03-08 06712, 2021
_lucifer
sentry shows nothing
2021-03-08 06722, 2021
_lucifer
alastairp: i restarted all services
2021-03-08 06728, 2021
iliekcomputers
let's roll back to the version we had before today imo
2021-03-08 06757, 2021
_lucifer
iliekcomputers, i had rolled back reader immediately after the release
2021-03-08 06703, 2021
alastairp
yes, looks like it may be the same issue we were seeing on the spark reader
ok, no problem, let's just add both keys to consul
2021-03-08 06711, 2021
_lucifer
🤦
2021-03-08 06721, 2021
alastairp
then no matter which version of the template file we have it'll get the right key
2021-03-08 06735, 2021
_lucifer
on it
2021-03-08 06736, 2021
alastairp
and we can remove the old one in a week when everything is back to the same version
2021-03-08 06759, 2021
iliekcomputers
:(
2021-03-08 06751, 2021
iliekcomputers
from the admin page, we have ~1687 users with correct spotify tokens etc, so i assume that's ok, it's just that the reader has not been running for ~8 hours
2021-03-08 06718, 2021
iliekcomputers
the metrics system could be used to set up some alerts on stuff like this
2021-03-08 06724, 2021
ShivamAwasthi has quit
2021-03-08 06729, 2021
alastairp
iliekcomputers: yeah, I was just thinking that - for non-web containers we don't have a good monitoring system. metrics would be an easy way of seeing if something isn't right
2021-03-08 06751, 2021
alastairp
it might be possible that we can have some kind of thing that monitors processes inside a container
2021-03-08 06713, 2021
iliekcomputers
yep. the graph + something that sends a telegram message if the number of listens imported is too low
2021-03-08 06731, 2021
alastairp
the other good takeaway from this that I'd like to write down somewhere is that "restart a container" isn't just restart it, but also verify that the thing inside the container is running :)
2021-03-08 06739, 2021
iliekcomputers
yep :)
2021-03-08 06711, 2021
iliekcomputers
another thing to consider here is that we were releasing too many complicated-ish PRs in one release
2021-03-08 06719, 2021
alastairp
I'm just thinking out loud, what about actually exposing an http interface on all internal apps that we can monitor? does that make sense? is it easier to just use stats module for this?
2021-03-08 06725, 2021
iliekcomputers
more moving parts -> more confusion -> more breakages
2021-03-08 06728, 2021
ShivamAwasthi joined the channel
2021-03-08 06742, 2021
ShivamAwasthi has quit
2021-03-08 06700, 2021
iliekcomputers
what do you mean by http interface? Like an endpoint we can go to manually?
2021-03-08 06701, 2021
alastairp
for sure, we removed some things and added new things too. so maybe we should have releaesed the removal PR immediately (or held off on merging until we had released everything else)
2021-03-08 06741, 2021
iliekcomputers
I think if we have the stats in grafana, it should be easy to create alerts on it. i'd much rather it's a push notification than some page we need to go to ourselves.
2021-03-08 06751, 2021
alastairp
I mean, for example the spotify reader does its thing, but also exposes an http endpoint on :8000 that we can hit with a monitoring software to see that it's up (or even to get metrics)
2021-03-08 06709, 2021
alastairp
right - not something that we go to, our existing monitoring stuff can do that for us
we were thinking, what should the behaviour be on a webapp, should we get errors logged to stdout, and then we need to go digging into a container to find the error
2021-03-08 06720, 2021
alastairp
or should the webapp start up, but when you visit it we get an error page saying "error with config file"
