So shall I make a parent component with name UserListModals?
2021-03-11 07020, 2021
Mr_Monkey
The new parent component should probably have a boolean flag for each sub-component (currently only FollowerFollowingModal and SimilarUsersModal) so that we can show either or both components (and maybe others in the future)
2021-03-11 07032, 2021
Mr_Monkey
I think that'll be the most flexible solution
2021-03-11 07045, 2021
Mr_Monkey
As for the name…
2021-03-11 07017, 2021
Mr_Monkey
something in the vein of UserNetwork, maybe?
2021-03-11 07023, 2021
Rohan_Pillai has quit
2021-03-11 07033, 2021
Mr_Monkey
That's not great.
2021-03-11 07045, 2021
shivam-kapila
but sounds better.
2021-03-11 07056, 2021
Mr_Monkey
UserSocialNetwork is a bit more descriptive
2021-03-11 07038, 2021
Mr_Monkey
But good call, better to refactor now rather than duplicate code :)
2021-03-11 07050, 2021
shivam-kapila
:)
2021-03-11 07038, 2021
Mr_Monkey
ruaok: Hi !
2021-03-11 07038, 2021
Mr_Monkey
It looks like the API key we use on LB to import from LastFM is not valid anymore, the endpoint returns error #26: "API Key Suspended - This application is not allowed to make requests to the web services"
2021-03-11 07004, 2021
Mr_Monkey
Reported in LB-832 , and I just confirmed it myself
Mr_Monkey: could you do me a favor and hack up a teeny PR that disables last.m import for right now? Maybe removing the import button from the import page and replacing it with a "broken, working on fixing it" message?
2021-03-11 07039, 2021
ruaok
and then I'll get that out with our release today (hopefully).
2021-03-11 07024, 2021
Mr_Monkey
OK
2021-03-11 07009, 2021
iliekcomputers
did they say why they disabled the API key?
2021-03-11 07028, 2021
ruaok
"high traffic"
2021-03-11 07058, 2021
shivam-kapila
ugh why doesnt 1.4000000000000001 round off
2021-03-11 07013, 2021
shivam-kapila
or 0.8999999999999999
2021-03-11 07052, 2021
shivam-kapila
ruaok: I think we should limit the similar users list length, say 20
shivam-kapila: limit the list of what we display or what we fetch?
2021-03-11 07002, 2021
ruaok
_lucifer: ping.
2021-03-11 07010, 2021
_lucifer
pong
2021-03-11 07011, 2021
shivam-kapila
I would say limit the API response, and paginate it like we do for other endpoints
2021-03-11 07000, 2021
ruaok
shivam-kapila: the list is internally limited already and the data is fairly small, so pagination is overkill. I'd like to see how this evolves. for now I think things are well setup.
2021-03-11 07015, 2021
ruaok
_lucifer: how goes addressing the last bits on the user-similarity PR?
2021-03-11 07030, 2021
ruaok
it would be nice to merge that and get the last.fm disable fix out all in one go today.
2021-03-11 07038, 2021
shivam-kapila
so for now we display all the similar users or would you like to limit on frontend side
2021-03-11 07016, 2021
_lucifer
ruaok, i am adding comments currently. should be done soon :)
2021-03-11 07034, 2021
ruaok
shivam-kapila: limit on the front end as you see fit.
ruaok: dunno, I need to understand what it implies technically, also that's free for us now, but do we get any guarantee it will be in the future. At this point I don't even know what it is.... I'll do my homework on this and will come back to you whenever I'll know enough about it
LB-825: Import recommendation feedback to spark cluster
2021-03-11 07016, 2021
pristine___
The love/hate uses msid so I guess you should create a dump of these similar to listens dump and then we can map them with mbid msid mapping on the cluster
2021-03-11 07045, 2021
pristine___
Though we may lose some feedback. Because of the mapping
2021-03-11 07055, 2021
ruaok
can you please spell that out in detail on the ticket?
2021-03-11 07016, 2021
Rohan_Pillai joined the channel
2021-03-11 07017, 2021
ruaok
yep, understood. after I do this data dump improvements, I go back to the MBID mapping mines
2021-03-11 07029, 2021
ruaok
that process is going to run for eons and eons.
2021-03-11 07028, 2021
pristine___
> can you please spell that out in detail on the ticket?
2021-03-11 07032, 2021
pristine___
Should I?
2021-03-11 07054, 2021
ruaok
yes, please.
2021-03-11 07015, 2021
pristine___
Okay, will do :)
2021-03-11 07024, 2021
pristine___
By evening!
2021-03-11 07026, 2021
Darkloke has quit
2021-03-11 07057, 2021
alastairp
> Catalunya levantará el confinamiento comarcal el próximo lunes, 15 de marzo, aunque solo para aquellos desplazamientos que se realicen con el grupo burbuja de convivencia.
2021-03-11 07059, 2021
alastairp
finally!
2021-03-11 07016, 2021
ruaok
woo, finally!
2021-03-11 07049, 2021
alastairp
though I don't understand if that implies that you _have_ to travel with someone in your burbuja in order to leave? 🤷
2021-03-11 07024, 2021
ruaok
I'm guessing that you may only travel with people in your burbuja.
2021-03-11 07030, 2021
alastairp
might not be around on monday. I have a long bike ride to do
2021-03-11 07038, 2021
ruaok
which means my trip to Olot is on. Woo.
2021-03-11 07047, 2021
alastairp
oh yeah, that's such a nice area
2021-03-11 07032, 2021
Divyansh joined the channel
2021-03-11 07050, 2021
sumedh joined the channel
2021-03-11 07020, 2021
prabal has quit
2021-03-11 07059, 2021
SomalRudra has quit
2021-03-11 07011, 2021
iliekcomputers
did they ease lockdown in spain?
2021-03-11 07034, 2021
iliekcomputers
here the government says expect it until end of may ☠️
2021-03-11 07012, 2021
shivam-kapila
whats lockdown 🤔
2021-03-11 07028, 2021
iliekcomputers
sometimes i wonder if moving to europe was a mistake
2021-03-11 07030, 2021
iliekcomputers
😂
2021-03-11 07055, 2021
jmp_music__ has quit
2021-03-11 07037, 2021
alastairp
iliekcomputers: each region controls their own rules. Catalunya has been a bit stricter than others. There is still a restriction that we can't pass between regions until at least after easter (they don't want a repeat of Christmas/NY)
2021-03-11 07012, 2021
alastairp
catalunya is made up of ~40 comarques (~=county), and for the last 2-3 months we haven't been able to go from one to another - a big problem because Barcelona city is its own comarca because of the population. much easier for other people to travel
alastairp: a thought for you... right now we have jenkins test for each commit. and at points like now when we push several commits in quick succession, we'll have to wait for pointless builds to finish. we'll never look at the builds and thus are wasting loads of cpu time and our wall time.
2021-03-11 07008, 2021
ruaok
I think it might be nicer if we explicitly asked for tests. or test automatically if a commit is an hour old or so.
2021-03-11 07010, 2021
Mr_Monkey
chaban: Regarding LB-776 , if you add yourself as collaborator of a playlist you own, it adds your name to the collaborators, correct? (that's an issue i'll have a look into). Now if you refresh the page you should see that your name isn't in the collaborators anymore. Can you please confirm?
