not sure I'm for such "centralization", but ok. So now, how can those rewrites can be tested?
2021-03-11 07014, 2021
bitmap
Cyna[m]: okay :)
2021-03-11 07010, 2021
bitmap
can we install them to test.mb? that would make it easier
2021-03-11 07031, 2021
zas
yes (don't they work there already?)
2021-03-11 07008, 2021
zas
also the way they are written make extensive of (evil) nginx if, most should be moved to map
2021-03-11 07040, 2021
zas
plus we need improve matches to prevent useless matches
2021-03-11 07058, 2021
bitmap
oh, I guess they are
2021-03-11 07011, 2021
bitmap
though I think the config file is shared between prod, beta, & test
2021-03-11 07003, 2021
zas
for example, we have tons of sequential matches for ^/news/, but each query is tested against each, even if it doesn't start with /news/
2021-03-11 07030, 2021
zas
ok, I could use a different rewrite file for test.mb.o
2021-03-11 07004, 2021
zas
or we could use a prefixed file with a default, I'll look into this
2021-03-11 07017, 2021
bitmap
that would be nice, and if you let me know how I can easily reload it to test changes, I could work on improving it and removing evil nginx stuff
2021-03-11 07055, 2021
zas
that's the point: easily, no, you need to reload gateway nginx process (HUPit)
2021-03-11 07015, 2021
zas
(after you sync rewrite file ofc)
2021-03-11 07017, 2021
reosarevok
I mean, you could test on the main file for all it matters, because it's broken anyway
2021-03-11 07032, 2021
CatQuest
how do I "follow" people?
2021-03-11 07038, 2021
bitmap
ok, maybe I can set something up locally then
2021-03-11 07038, 2021
reosarevok
But I guess if you need to reset nginx then it doesn't help
2021-03-11 07014, 2021
bouhormq has quit
2021-03-11 07033, 2021
zas
also, to see what nginx does, you need to enable rewrite_log, and that's not a good idea on prod (at all)
2021-03-11 07002, 2021
bitmap
we should probably have a small nginx Dockerfile in the mbs repo that can test the config
2021-03-11 07048, 2021
ShivamAwasthi has quit
2021-03-11 07015, 2021
reosarevok
zas: I guess even if we had a first check for "skip all other rules if this doesn't match", that would still flood the rewrite_log?
2021-03-11 07022, 2021
reosarevok
(since it'd still be at least one line per page load)
2021-03-11 07040, 2021
reosarevok
I mean, a lot less than with 450 or whatever lines per load, but
2021-03-11 07039, 2021
zas
perhaps, but rewrite_log isn't meant to run on prod anyway (we can enable it on test.mb.o though)
2021-03-11 07045, 2021
bitmap
zas: I can work in it tonight, hopefully get a small docker container working and hook it into our CI
2021-03-11 07050, 2021
bitmap
*on it
2021-03-11 07010, 2021
reosarevok
zas: sure, I know :) Just wondering in general
2021-03-11 07021, 2021
reosarevok
But yeah, for testing at least it would be sensible
2021-03-11 07051, 2021
zas
bitmap: ok, on my side I'll see how to split rewrite configs between test.mb.o and the rest
2021-03-11 07000, 2021
bitmap
btw, we talked about restarting PG earlier in the week, we ought to schedule a day to do it so it doesn't slip by again
2021-03-11 07042, 2021
bitmap
to fix the logging config and upgrade pg_amqp
2021-03-11 07051, 2021
shivam-kapila
> the UI is coming soon.
2021-03-11 07051, 2021
shivam-kapila
real soon :crossed_fingers:
2021-03-11 07028, 2021
shivam-kapila
Mr_Monkey: how is the PR overall?
2021-03-11 07050, 2021
CatQuest
I'd be SO cool to finally have proper social features on lb!
2021-03-11 07041, 2021
bouhormq joined the channel
2021-03-11 07013, 2021
Mr_Monkey forgot to click submit…
2021-03-11 07035, 2021
Mr_Monkey
Soz
2021-03-11 07046, 2021
dpmittal
Hello everyone! My name is Divya Prakash Mittal and I wish to contribute to ListenBrainz in GSoC 2021. I was able to set up the dev instance locally after going through docs and was looking at the "good-first-bug" JIRAs and I felt that I can take up some like LB-773 and LB-783 but they were assigned so I wanted to know if it's in progress or can I take them up?
MBS-11436: Beta: ISE on user's collection subscription pages
2021-03-11 07051, 2021
reosarevok
So let's fix this one before releasing beta
2021-03-11 07021, 2021
bitmap
want me to do this one or are you already on it?
2021-03-11 07050, 2021
reosarevok
I'm taking a look, maybe look at the zas stuff and I can ask if I get stuck
2021-03-11 07014, 2021
BrainzGit joined the channel
2021-03-11 07046, 2021
reosarevok
Oh, yeah, with all this I forgot brainzgit :D
2021-03-11 07003, 2021
reosarevok
Well, thanks, whoever brought it back (yvanzo?)
2021-03-11 07013, 2021
yvanzo
yes, just restarted it (on williams), see syswiki :)
2021-03-11 07016, 2021
reosarevok
I know how to do it, I just got distracted :)
2021-03-11 07019, 2021
reosarevok
Thanks!
2021-03-11 07040, 2021
reosarevok
(I only know how to do it *because of syswiki*, but :D )
2021-03-11 07047, 2021
yvanzo
You’re welcome :)
2021-03-11 07028, 2021
bouhormq has quit
2021-03-11 07013, 2021
bitmap
Cyna[m]: re: your google doc, I left some questions on it which might help you expand it. there isn't much to comment on atm since it appears to be generic and not tailored to MB
2021-03-11 07026, 2021
Cyna[m]
Yep
2021-03-11 07057, 2021
Cyna[m]
It is not tailored to it yet :). Thanks I will have a look and add details specific to MB
