18:51 PM
Mr_Monkey
Latency acceptable.
2021-03-11 07024, 2021
18:51 PM
shivam-kapila
2021-03-11 07028, 2021
18:51 PM
shivam-kapila
Regarding this
2021-03-11 07056, 2021
18:51 PM
shivam-kapila
the user can be of type ListenBrainz or SimilarUser
2021-03-11 07011, 2021
18:52 PM
ruaok
let me know if I should deploy your work to beta, Mr_Monkey, shivam-kapila.
2021-03-11 07015, 2021
18:52 PM
ruaok
I'd love to see it in action
2021-03-11 07016, 2021
18:52 PM
shivam-kapila
TS complaints if I do user.similarityScore
2021-03-11 07040, 2021
18:52 PM
shivam-kapila
ruaok: Its lacking tests and I am working on that
2021-03-11 07048, 2021
18:52 PM
ruaok
fine for beta.
2021-03-11 07005, 2021
18:53 PM
ShivamAwasthi has quit
2021-03-11 07021, 2021
18:53 PM
shivam-kapila
then in 5 minutes we can do that after I resolve this one (provided Mr_Monkey gives a green flag)
2021-03-11 07027, 2021
18:53 PM
ruaok
k
2021-03-11 07037, 2021
18:53 PM
shivam-kapila
> TS complaints if I do user.similarityScore
2021-03-11 07037, 2021
18:53 PM
shivam-kapila
Mr_Monkey any idea how to resolve this
2021-03-11 07010, 2021
18:54 PM
shivam-kapila
2021-03-11 07010, 2021
18:54 PM
Mr_Monkey
2021-03-11 07024, 2021
18:54 PM
shivam-kapila
yes
2021-03-11 07057, 2021
18:54 PM
Mr_Monkey
I have an idea
2021-03-11 07041, 2021
18:55 PM
Mr_Monkey
Hang on
2021-03-11 07035, 2021
18:58 PM
Mr_Monkey
2021-03-11 07046, 2021
18:58 PM
Mr_Monkey
how about that shivam-kapila ?
2021-03-11 07051, 2021
19:00 PM
shivam-kapila
bingo
2021-03-11 07015, 2021
19:01 PM
Mr_Monkey
In `SimilarityScore` can we also `(user as SimilarUser).similarityScore` or are these two pieces of info sometimes separate?
2021-03-11 07055, 2021
19:01 PM
shivam-kapila
I did `(user as SimilarUser).similarityScore`
2021-03-11 07058, 2021
19:01 PM
shivam-kapila
and it worked
2021-03-11 07023, 2021
19:09 PM
shivam-kapila
Mr_Monkey: pushed. please verify if its ready for beta
2021-03-11 07055, 2021
19:10 PM
dpmittal_ joined the channel
2021-03-11 07049, 2021
19:11 PM
Mr_Monkey
Yeah, let's try it in beta ! ruaok, all yours
2021-03-11 07039, 2021
19:12 PM
ruaok
what was the branch name
2021-03-11 07040, 2021
19:12 PM
ruaok
?
2021-03-11 07055, 2021
19:12 PM
shivam-kapila
similar-users-modal
2021-03-11 07004, 2021
19:13 PM
shivam-kapila
2021-03-11 07026, 2021
19:14 PM
ruaok
thx. builing.
2021-03-11 07028, 2021
19:14 PM
ruaok
+d
2021-03-11 07007, 2021
19:16 PM
ruaok ponders out loud
2021-03-11 07018, 2021
19:16 PM
ruaok
if see more and more open source packages asking for donations.
2021-03-11 07007, 2021
19:17 PM
ruaok
I wonder if we should allow each team member to pick some open source projects they think are important to us and then have MeB make a yearly donation to that project.
2021-03-11 07022, 2021
19:17 PM
ruaok
anyone interested?
2021-03-11 07047, 2021
19:17 PM
ruaok
2021-03-11 07052, 2021
19:17 PM
ruaok
build fail, shivam-kapila
2021-03-11 07003, 2021
19:18 PM
shivam-kapila
this is ignorable
2021-03-11 07008, 2021
19:18 PM
shivam-kapila
its a test fail
2021-03-11 07021, 2021
19:18 PM
shivam-kapila
`js/src/follow/FollowerFollowingModal.test.tsx:28:8`
2021-03-11 07031, 2021
19:18 PM
ruaok
no, the docker images fail to build.
2021-03-11 07045, 2021
19:18 PM
shivam-kapila
wait I will fix this temporarily
2021-03-11 07020, 2021
19:19 PM
reosarevok
ruaok: so, how do I make it look like the Estonian Nature Fund is both somehow open source and important to us?
2021-03-11 07056, 2021
19:20 PM
BrainzGit
2021-03-11 07034, 2021
19:21 PM
AkshatTiwari[m] joined the channel
2021-03-11 07019, 2021
19:24 PM
_lucifer
ruaok, that would be great. if we can, I think we should definitely donate to open source projects relevant to us :D
2021-03-11 07021, 2021
19:25 PM
ruaok
I think everyone but reo should think about how to donate $100 -$200 per person.
2021-03-11 07059, 2021
19:25 PM
shivam-kapila
ruaok: build succeeded for me. Pushed
2021-03-11 07035, 2021
19:26 PM
ruaok tries again
2021-03-11 07052, 2021
19:26 PM
shivam-kapila
hope this fix works
2021-03-11 07021, 2021
19:27 PM
shivam-kapila
whos the olders team member after ruaok here?
2021-03-11 07021, 2021
19:27 PM
reosarevok
bitmap: please move that branch to target beta :)
2021-03-11 07028, 2021
19:27 PM
shivam-kapila
oldest*
2021-03-11 07032, 2021
19:27 PM
reosarevok
shivam-kapila: older as in age or time in the team?
2021-03-11 07039, 2021
19:27 PM
shivam-kapila
time
2021-03-11 07040, 2021
19:27 PM
Mr_Monkey
I agree, donations in the name of the team members is a great idea !
2021-03-11 07024, 2021
19:28 PM
shivam-kapila
_lucifer: query for android app gsoc project in #musicbrainz
2021-03-11 07041, 2021
19:28 PM
reosarevok
shivam-kapila: then maybe bitmap?
2021-03-11 07041, 2021
19:28 PM
_lucifer
shivam-kapila, please redirect them here :)
2021-03-11 07048, 2021
19:28 PM
shivam-kapila
oh they are here
2021-03-11 07003, 2021
19:29 PM
reosarevok
I guess alastairp has been around forever, and so have I, but maybe not officially in the team that long?
2021-03-11 07005, 2021
19:29 PM
shivam-kapila
Hil AkshatTiwari[m]. please ask your query here
2021-03-11 07023, 2021
19:29 PM
shivam-kapila
_lucifer can help you regarding the MB app
2021-03-11 07026, 2021
19:29 PM
bitmap
reosarevok: whoops, fixed
2021-03-11 07045, 2021
19:29 PM
reosarevok
bitmap: once tests pass, let's merge these PRs
2021-03-11 07047, 2021
19:29 PM
alastairp
I'm sure in ruaok's mind I've been officially in the team for years
2021-03-11 07006, 2021
19:30 PM
reosarevok
Then I can do a release
2021-03-11 07006, 2021
19:30 PM
shivam-kapila
reosarevok: now I understand why you are ruaok's best freind :p
2021-03-11 07007, 2021
19:30 PM
alastairp
I represented MeB at the first music hack day in boston in... 2010? 2011?
2021-03-11 07017, 2021
19:30 PM
AkshatTiwari[m] has left the channel
2021-03-11 07019, 2021
19:30 PM
shivam-kapila
thats so cool
2021-03-11 07032, 2021
19:30 PM
shivam-kapila
_lucifer: they left :/
2021-03-11 07027, 2021
19:31 PM
AkshatTiwari[m] joined the channel
2021-03-11 07034, 2021
19:31 PM
shivam-kapila
lol
2021-03-11 07002, 2021
19:32 PM
ruaok
beta updated
2021-03-11 07010, 2021
19:32 PM
AkshatTiwari[m]
_lucifer:
2021-03-11 07012, 2021
19:32 PM
AkshatTiwari[m]
Is the musicbrainz android app open for development for gsoc 2021?
2021-03-11 07059, 2021
19:32 PM
_lucifer
AkshatTiwari[m]: yes
2021-03-11 07011, 2021
19:33 PM
ruaok
shivam-kapila: the "users similar to you" component seems empty
2021-03-11 07029, 2021
19:33 PM
shivam-kapila
is the similar-users API in beta?
2021-03-11 07037, 2021
19:33 PM
shivam-kapila
beta only I mean
2021-03-11 07058, 2021
19:33 PM
shivam-kapila
2021-03-11 07012, 2021
19:34 PM
ruaok
2021-03-11 07018, 2021
19:34 PM
AkshatTiwari[m]
Great then! I really like the apps and the community here. Hope to be useful. Hi everyone btw :)
2021-03-11 07024, 2021
19:34 PM
ruaok
I guess you didn't merge master recently. I'll do that.
2021-03-11 07051, 2021
19:34 PM
shivam-kapila
oops. sorry for that
2021-03-11 07003, 2021
19:35 PM
ruaok
np
2021-03-11 07014, 2021
19:35 PM
ruaok
no merge conflicts
2021-03-11 07003, 2021
19:40 PM
BrainzGit
2021-03-11 07013, 2021
19:40 PM
shivam-kapila
ruaok: lemme know if its emtpy
2021-03-11 07021, 2021
19:40 PM
shivam-kapila
I will hardcode the APIBASE
2021-03-11 07028, 2021
19:42 PM
ruaok
the endpoint wasn't there since you hadn't merged. the API should be fine.
2021-03-11 07013, 2021
19:43 PM
shivam-kapila
yeah. I noticed the SImilar Users PR merged
2021-03-11 07003, 2021
19:44 PM
ruaok
2021-03-11 07006, 2021
19:44 PM
ruaok
endpoint is there.
2021-03-11 07032, 2021
19:44 PM
ruaok
still empty box for me.
2021-03-11 07026, 2021
19:45 PM
shivam-kapila
2021-03-11 07000, 2021
19:46 PM
shivam-kapila
2021-03-11 07058, 2021
19:46 PM
reosarevok
yvanzo: there's one more beta PR, in case you didn't see that one
2021-03-11 07007, 2021
19:49 PM
shivam-kapila
ruaok: do we want that hard coded fix for now?
2021-03-11 07009, 2021
19:49 PM
_lucifer
2021-03-11 07014, 2021
19:50 PM
ruaok
shivam-kapila: sure, but the URL is available to the JS, so it should be an easy fix. Mr_Monkey know how?
2021-03-11 07026, 2021
19:50 PM
n86cc joined the channel
2021-03-11 07054, 2021
19:50 PM
yvanzo
reosarevok: I was just looking at it, do you think 2 levels are enough?
2021-03-11 07010, 2021
19:51 PM
reosarevok
So far I can't think of anywhere we do more
2021-03-11 07018, 2021
19:51 PM
reosarevok
We might be forgetting something, but if so it's easy to modify
2021-03-11 07026, 2021
19:51 PM
reosarevok
(and I expect someone will complain :p )
2021-03-11 07029, 2021
19:51 PM
yvanzo
Maybe release or series?
2021-03-11 07051, 2021
19:51 PM
reosarevok
Hmm
2021-03-11 07055, 2021
19:51 PM
Mr_Monkey
shivam-kapila: Why is it using beta.lb rather than beta-api.lb?
2021-03-11 07014, 2021
19:52 PM
Mr_Monkey
The apiURL passed to the page is beta-api.lb, I can confirm that
2021-03-11 07014, 2021
19:52 PM
shivam-kapila
the api service is set to this.APIService = new APIService(`${window.location.origin}/1`);
2021-03-11 07021, 2021
19:52 PM
reosarevok
Only case I can think with 3 is if we do release is in release group is in series
2021-03-11 07030, 2021
19:52 PM
Mr_Monkey
Mmm
2021-03-11 07033, 2021
19:52 PM
reosarevok
But that's effectively 2 anywhere I can think of rn
2021-03-11 07046, 2021
19:52 PM
Mr_Monkey
That's not correct :)
2021-03-11 07059, 2021
19:52 PM
shivam-kapila
okay I will pick the prop
2021-03-11 07009, 2021
19:53 PM
Mr_Monkey
Search for `this.APIService = new APIService(` in the codebase to find a good example
2021-03-11 07015, 2021
19:53 PM
reosarevok
Since we don't use series rels in JS, I think
2021-03-11 07022, 2021
19:53 PM
reosarevok
yvanzo: lemme test
2021-03-11 07058, 2021
19:53 PM
Mr_Monkey
There's three of them to fix shivam-kapila : in FollowButton, FollowerFollowingModal and UserSocialNetwork
2021-03-11 07014, 2021
19:54 PM
shivam-kapila
cool
2021-03-11 07046, 2021
19:55 PM
shivam-kapila
the followbutton one works for now
2021-03-11 07057, 2021
19:55 PM
shivam-kapila
I will fix in UserSocialNetworj
2021-03-11 07027, 2021
19:58 PM
ruaok
_lucifer: looks very promising. left some comments.
2021-03-11 07022, 2021
20:00 PM
_lucifer
ruaok, i used different fields for the link and the message because i thought that would make it easier for displaying on the front end.
2021-03-11 07053, 2021
20:00 PM
shivam-kapila
ruaok: I pushed the fix again
2021-03-11 07006, 2021
20:01 PM
_lucifer
i thought there could be issues with styling if we used html directly but Mr_Monkey can tell if that's ok?
2021-03-11 07007, 2021
20:01 PM
astroanax has quit
2021-03-11 07014, 2021
20:01 PM
reosarevok
yvanzo, bitmap: the only problem I could see would be if we used this to load data for RelatedSeries for a series linked to a RG linked to a release
2021-03-11 07048, 2021
20:01 PM
reosarevok
But we don't currently have RelatedSeries for release views (why, anyway?)
2021-03-11 07005, 2021
20:02 PM
reosarevok
I'm not sure if that *would* be a problem, either
2021-03-11 07013, 2021
20:02 PM
reosarevok
bitmap: would it? :)
2021-03-11 07019, 2021
20:02 PM
n86cc has quit
2021-03-11 07022, 2021
20:02 PM
reosarevok
I think it's fine to merge with 2 for now, anyway
2021-03-11 07041, 2021
20:02 PM
n86cc joined the channel
2021-03-11 07046, 2021
20:02 PM
_lucifer
in either case, I'll add a couple of tests tomorrow and finish it.
2021-03-11 07051, 2021
20:02 PM
bitmap
showing RG relationships for an RG linked to a series?
2021-03-11 07053, 2021
20:02 PM
Mr_Monkey
_lucifer: good call, more flexible that way
2021-03-11 07007, 2021
20:03 PM
reosarevok
bitmap: no, showing series rels for the series linked to a RG linked to a release
2021-03-11 07027, 2021
20:03 PM
reosarevok
2021-03-11 07006, 2021
20:04 PM
reosarevok
That's the most steps I can think of, but I don't think they'd be loaded recursively anyway in that case
2021-03-11 07023, 2021
20:04 PM
reosarevok
(and we don't do it rn anyway)
2021-03-11 07045, 2021
20:04 PM
yvanzo
I wonder why we had a recursion there then.
2021-03-11 07035, 2021
20:05 PM
bitmap
I don't think it would be a problem there
2021-03-11 07043, 2021
20:05 PM
bitmap
the RG isn't linked via a relationship
2021-03-11 07032, 2021
20:06 PM
yvanzo
+1
