The jest.runAllTimers goes hand in hand with `jest.useFakeTimers();` called at the top of the file and allows to replace existing timeouts by fake timeouts.
but limiting the error messages is a good idea I guess. So a ticket could be helpful
adhi001
Okay, I'll create a ticket for now.
iliekcomputers
big plus to limiting error messages
shivam-kapila
a simple trick could be: if the most recent error is exactly same, don't queue up a new alert.
adhi001
Just to let the user know that errors are still there, could we pop the top most error when a new error comes and consistently show three error messages? This way the error popping animation would let the user know that these errors keep coming.
@shivam-kapila
shivam-kapila
Lets imagine a case where the alerts are different and occur as in the above case, too many in a few seconds but all different
this wont give the user a chance to notice any of them
This might not happen as of now. but can be a possible scenario
adhi001
Yeah, makes sense
Cyna[m]
reosarevok bitmap do i18n / translations work on email send to users ?
bitmap
we don't currently translate those, no
if you mean things like modbot emails
v6lur joined the channel
Cyna[m]
Yea.. also we are looking for P2P messages between editors as well right ?.
I mean it was part of the notifications jira I looked into
bitmap
yes, I think ideally a notification would just be a message (from a system user) that you can't reply to
at least that would be enough to cover the functionality we want
Cyna[m]
Ok
mckean_ joined the channel
mckean has quit
Can you help me understand this lib/MusicBrainz/Server/Email/Role.pm ?. I dont understand what the notification email is about. there is no template in it that would help me identify either
bitmap
that's a Moose role (which can be used by a class) to help implement email sending
_lucifer: I was going through the metabrainz wiki and planning to start working on the proposal and found this https://wiki.musicbrainz.org/Development/Summer... . This is great but wanted to know if there's a google doc/word format you would recommend for the proposal?