The jest.runAllTimers goes hand in hand with `jest.useFakeTimers();` called at the top of the file and allows to replace existing timeouts by fake timeouts.
but limiting the error messages is a good idea I guess. So a ticket could be helpful
2021-03-12 07140, 2021
adhi001
Okay, I'll create a ticket for now.
2021-03-12 07111, 2021
iliekcomputers
big plus to limiting error messages
2021-03-12 07154, 2021
shivam-kapila
a simple trick could be: if the most recent error is exactly same, don't queue up a new alert.
2021-03-12 07142, 2021
adhi001
Just to let the user know that errors are still there, could we pop the top most error when a new error comes and consistently show three error messages? This way the error popping animation would let the user know that these errors keep coming.
2021-03-12 07151, 2021
adhi001
@shivam-kapila
2021-03-12 07116, 2021
shivam-kapila
Lets imagine a case where the alerts are different and occur as in the above case, too many in a few seconds but all different
2021-03-12 07128, 2021
shivam-kapila
this wont give the user a chance to notice any of them
2021-03-12 07153, 2021
shivam-kapila
This might not happen as of now. but can be a possible scenario
2021-03-12 07101, 2021
adhi001
Yeah, makes sense
2021-03-12 07125, 2021
Cyna[m]
reosarevok bitmap do i18n / translations work on email send to users ?
2021-03-12 07125, 2021
bitmap
we don't currently translate those, no
2021-03-12 07152, 2021
bitmap
if you mean things like modbot emails
2021-03-12 07103, 2021
v6lur joined the channel
2021-03-12 07102, 2021
Cyna[m]
Yea.. also we are looking for P2P messages between editors as well right ?.
2021-03-12 07121, 2021
Cyna[m]
I mean it was part of the notifications jira I looked into
2021-03-12 07112, 2021
bitmap
yes, I think ideally a notification would just be a message (from a system user) that you can't reply to
2021-03-12 07148, 2021
bitmap
at least that would be enough to cover the functionality we want
2021-03-12 07125, 2021
Cyna[m]
Ok
2021-03-12 07139, 2021
mckean_ joined the channel
2021-03-12 07140, 2021
mckean has quit
2021-03-12 07146, 2021
Cyna[m]
Can you help me understand this lib/MusicBrainz/Server/Email/Role.pm ?. I dont understand what the notification email is about. there is no template in it that would help me identify either
2021-03-12 07136, 2021
bitmap
that's a Moose role (which can be used by a class) to help implement email sending
_lucifer: I was going through the metabrainz wiki and planning to start working on the proposal and found this https://wiki.musicbrainz.org/Development/Summer_o… . This is great but wanted to know if there's a google doc/word format you would recommend for the proposal?
