#metabrainz

/

      • _lucifer
        Mr_Monkey: looks good!
      • 2021-03-15 07456, 2021

      • _lucifer
        !m Mr_Monkey
      • 2021-03-15 07457, 2021

      • BrainzBot
        You're doing good work, Mr_Monkey!
      • 2021-03-15 07451, 2021

      • Mr_Monkey
        I found a thin thread that could allow us to put the fake timers back. That would be good 'cause otherwise we're adding something like 25 seconds to the build :/
      • 2021-03-15 07434, 2021

      • _lucifer
        yeah, true.
      • 2021-03-15 07400, 2021

      • shivam-kapila
        Oh is travis back?
      • 2021-03-15 07409, 2021

      • alastairp
        thanks Mr_Monkey!
      • 2021-03-15 07400, 2021

      • Freso
        For any US-timed folks, a reminder: meeting starts in ~20 minutes! :) (ping: bitmap, … just bitmap?)
      • 2021-03-15 07418, 2021

      • bitmap
        yep, thanks for the reminder :)
      • 2021-03-15 07402, 2021

      • Freso
        You’ll get another one in 2 weeks :p
      • 2021-03-15 07424, 2021

      • yvanzo
        bitmap, reosarevok: in case of emergency... https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-15 07403, 2021

      • probhav has quit
      • 2021-03-15 07416, 2021

      • alastairp
        Mr_Monkey: so if page x fails to import 3 times, it'll stop and not try page x+1?
      • 2021-03-15 07427, 2021

      • alastairp
        x-1, I guess
      • 2021-03-15 07421, 2021

      • Mr_Monkey
        Correct. That's what I gathered would be the safest way, asking the user the try again.
      • 2021-03-15 07422, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1985 (master…MBS-11447): MBS-11447: Use to_json_object on language in Work::Create https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-15 07430, 2021

      • alastairp
        agreed
      • 2021-03-15 07403, 2021

      • reosarevok
        Seems sensible
      • 2021-03-15 07404, 2021

      • Mr_Monkey
        Clearly if the fetch fails 3/4 times something's wrong and continuing is likely to give the same error
      • 2021-03-15 07457, 2021

      • alastairp
        did you confirm if we were doing what we thought, and retrying all previous pages in case of an error?
      • 2021-03-15 07437, 2021

      • Mr_Monkey
        I have not. I still need to do more testing
      • 2021-03-15 07417, 2021

      • alastairp
        nice
      • 2021-03-15 07420, 2021

      • alastairp
        (not nice)
      • 2021-03-15 07428, 2021

      • D4RK-PH0_ joined the channel
      • 2021-03-15 07443, 2021

      • probhav joined the channel
      • 2021-03-15 07404, 2021

      • ShivamAwasthi joined the channel
      • 2021-03-15 07400, 2021

      • Freso
        <BANG>
      • 2021-03-15 07401, 2021

      • Freso
        It’s World Sleep Monday!
      • 2021-03-15 07401, 2021

      • Freso
      • 2021-03-15 07401, 2021

      • Freso
        People on my list for reviews today: reosarevok, alastairp, _lucifer, Mr_Monkey, Freso, yvanzo, bitmap, zas, ruaok, CatQuest, shivam-kapila – anyone else who want to give reviews, let me know ASAP!
      • 2021-03-15 07401, 2021

      • Freso
        I haven’t received any mailed in reviews, so…
      • 2021-03-15 07401, 2021

      • Freso
        reosarevok: Go!
      • 2021-03-15 07408, 2021

      • reosarevok
        Hi!
      • 2021-03-15 07421, 2021

      • reosarevok
        Last week I kept fixing small tickets, plus a lot of code review
      • 2021-03-15 07434, 2021

      • reosarevok
        Plus a fair amount of fixing small stuff that slipped through code review
      • 2021-03-15 07445, 2021

      • reosarevok
        Plus more of that today (small hotfix to come today or tomorrow)
      • 2021-03-15 07411, 2021

      • reosarevok
        That's because bitmap made a huge change that should make stuff more stable and less messy, but changed a billion things
      • 2021-03-15 07417, 2021

      • reosarevok
        I expect he'll talk about it anyway
      • 2021-03-15 07443, 2021

      • reosarevok
        This week we are also deciding what to do for the schema change, and I assume most of next month will involve some of that work
      • 2021-03-15 07449, 2021

      • reosarevok
        That's it for me. CatQuest? :)
      • 2021-03-15 07453, 2021

      • ashutosh3 joined the channel
      • 2021-03-15 07456, 2021

      • CatQuest
        Meow! `😺`
      • 2021-03-15 07402, 2021

      • CatQuest
        Have worked intensely on editing this large "beat" box release, and in doing so I've found a couple of bugs in mb here and there - reo and bitmap? fixed/are fixing these
      • 2021-03-15 07414, 2021

      • CatQuest
        else it's brighter here and this week it's spring equinox! so happy equinox to anyone celebrating that! 🌅
      • 2021-03-15 07414, 2021

      • CatQuest
      • 2021-03-15 07414, 2021

      • CatQuest
        fin, go bitmap
      • 2021-03-15 07417, 2021

      • bitmap
        hey
      • 2021-03-15 07433, 2021

      • shivam-kapila
        (Freso: somebody had pinged that they want to join meeting. I dont remember their name. But they work on rust bindings iirc)
      • 2021-03-15 07447, 2021

      • bitmap
        last week I worked on adding materialized tables to speed up the listing of release groups on artist pages. this is currently quite slow for popular artists and frequently spams the PG logs
      • 2021-03-15 07409, 2021

      • CatQuest
        > [11:18] <okno_> Hello, @Freso could you add me to the monday meeting
      • 2021-03-15 07410, 2021

      • bitmap
        the new tables should make retrieving things almost instant. I hope to include them in the next schema change
      • 2021-03-15 07428, 2021

      • bitmap
        in MBS-11431 I fixed another form of slow query spamming the logs related to entity duplicate checking
      • 2021-03-15 07429, 2021

      • BrainzBot
        MBS-11431: Speed up /ws/js/check_duplicates https://tickets.metabrainz.org/browse/MBS-11431
      • 2021-03-15 07447, 2021

      • zas
        !m bitmap
      • 2021-03-15 07447, 2021

      • BrainzBot
        You're doing good work, bitmap!
      • 2021-03-15 07449, 2021

      • bitmap
        that's already deployed to prod since it just involved creating indexes
      • 2021-03-15 07456, 2021

      • Nyanko-sensei has quit
      • 2021-03-15 07411, 2021

      • bitmap
        also in the week, I worked on UI improvements to the user tag pages in https://github.com/metabrainz/musicbrainz-server/… (which is reosarevok's PR and resolves tag page timeouts),
      • 2021-03-15 07441, 2021

      • bitmap
        spent time finishing the PR for MBS-10866 and making some regression fixes once it was deployed to beta, as reosarevok mentioned,
      • 2021-03-15 07442, 2021

      • BrainzBot
        MBS-10866: TypeError was shown for a recording page https://tickets.metabrainz.org/browse/MBS-10866
      • 2021-03-15 07408, 2021

      • bitmap
        fixed MBS-10976 so nerds can add Klingon script releases again,
      • 2021-03-15 07409, 2021

      • BrainzBot
        MBS-10976: Unicode Private Use Area characters are stripped during edit process https://tickets.metabrainz.org/browse/MBS-10976
      • 2021-03-15 07423, 2021

      • bitmap
        and did other misc. tasks like code review and moving the postgres-williams container
      • 2021-03-15 07400, 2021

      • CatQuest
        :o
      • 2021-03-15 07401, 2021

      • reosarevok
        To pink?
      • 2021-03-15 07401, 2021

      • bitmap
        this week I'd like to continue focusing on MB website performance, particularly release pages and area queries
      • 2021-03-15 07419, 2021

      • bitmap
        to williams :P
      • 2021-03-15 07429, 2021

      • bitmap
        fin! zas go
      • 2021-03-15 07434, 2021

      • zas
        Hey
      • 2021-03-15 07443, 2021

      • Freso
        (People still up: alastairp, _lucifer, Mr_Monkey, Freso, yvanzo ruaok, shivam-kapila, okno_ – anyone else who want to give reviews, let me know ASAP!)
      • 2021-03-15 07430, 2021

      • zas
        I did usual tasks, upgrades, supervision, etc...
      • 2021-03-15 07451, 2021

      • zas
        Also Picard PR reviews (soon beta 3)
      • 2021-03-15 07456, 2021

      • joshuaboniface has quit
      • 2021-03-15 07458, 2021

      • SamThursfield[m] has quit
      • 2021-03-15 07459, 2021

      • AkshatTiwari[m] has quit
      • 2021-03-15 07400, 2021

      • bitmunch has quit
      • 2021-03-15 07409, 2021

      • reg[m] has quit
      • 2021-03-15 07409, 2021

      • lorenzuru has quit
      • 2021-03-15 07414, 2021

      • zas
        I also plan to deploy gitzconsul this week.
      • 2021-03-15 07423, 2021

      • zas
        fin. alastairp ?
      • 2021-03-15 07427, 2021

      • alastairp
        hello
      • 2021-03-15 07440, 2021

      • Cyna[m] has quit
      • 2021-03-15 07440, 2021

      • goldenshimmer has quit
      • 2021-03-15 07402, 2021

      • alastairp
        after releasing new LB startup scripts the other week we found some issues with visibility of startup of services and interaction with consul
      • 2021-03-15 07424, 2021

      • kepstin has quit
      • 2021-03-15 07425, 2021

      • alastairp
        last week I worked with _lucifer to improve the way that we render config files and report unexpected restarts
      • 2021-03-15 07454, 2021

      • alastairp
        thanks to atj and ruaok for reviewing that. it'll be ready to release this week
      • 2021-03-15 07413, 2021

      • alastairp
        I'll be back to normal hours on MeB work this week! (finally)
      • 2021-03-15 07417, 2021

      • alastairp
        _lucifer: next?
      • 2021-03-15 07430, 2021

      • _lucifer
        Hi all!
      • 2021-03-15 07415, 2021

      • _lucifer
        I worked with ruaok to finish up the user similarity PR and with alastairp on the startup reporting.
      • 2021-03-15 07417, 2021

      • CatQuest
        hi!
      • 2021-03-15 07457, 2021

      • _lucifer
        Further, I contributed to the last fm importer fix which was subsequently completed by Mr_Monkey today.
      • 2021-03-15 07409, 2021

      • _lucifer
        I also worked on an endpoint for approved users to post notifications on other's users timeline and adding sentry to the lb frontend.
      • 2021-03-15 07420, 2021

      • _lucifer
        That's it for me. Mr_Monkey nect?
      • 2021-03-15 07424, 2021

      • Mr_Monkey
        Yo!
      • 2021-03-15 07443, 2021

      • Mr_Monkey
        Last week on ListenBrain I continued work on the new feed page, fixed a couple of bugs with the playlist feature, did some issue triage and started looking into the reports and charts pages that are currently broken for some old browsers.
      • 2021-03-15 07412, 2021

      • Mr_Monkey
        Possibly the same Iterator issue atj previously ran into when working on the punycode thing.
      • 2021-03-15 07403, 2021

      • Mr_Monkey
        On the BookBrainz side, I continued working on the author credits feature, deployed an published a new release, reviewed some PRs and welcome a score of new contributors.
      • 2021-03-15 07412, 2021

      • Mr_Monkey
        Welcome new contributors !
      • 2021-03-15 07426, 2021

      • CatQuest
        \o/
      • 2021-03-15 07427, 2021

      • Mr_Monkey
        That's it for me. yvanzo go !
      • 2021-03-15 07431, 2021

      • yvanzo
        Hi!
      • 2021-03-15 07439, 2021

      • Freso
        (People still up: Freso, ruaok, shivam-kapila, okno_ – anyone else who want to give reviews, let me know ASAP!)
      • 2021-03-15 07448, 2021

      • yvanzo
        Last week I repaired dumping search indexes which are back to FTP since Wednesday.
      • 2021-03-15 07458, 2021

      • yvanzo
        (There still is a glitch about it, I will try to fix before it breaks again.)
      • 2021-03-15 07416, 2021

      • yvanzo
        Fixed a bug in annotation trimming (and caused a new one but there already is a patch for it).
      • 2021-03-15 07435, 2021

      • yvanzo
        Also temporarily blocked access to a release with 12OO+ tracks at musicbrainz.org because someone/something was hammering our servers by repeatedly requesting its page.
      • 2021-03-15 07411, 2021

      • yvanzo
        This release is not blocked anymore but the source issue is still there: Medium with a very large number of tracks cannot be loaded.
      • 2021-03-15 07439, 2021

      • yvanzo
        (Addressing it is not trivial: It might be just query optimization but it more likely requires paging tracks.)
      • 2021-03-15 07449, 2021

      • CatQuest
        :(
      • 2021-03-15 07451, 2021

      • yvanzo
        In the meantime, we are able to face potential DoS caused by repeated heavy requests for the same entity.
      • 2021-03-15 07422, 2021

      • yvanzo
        Fin, go Freso!
      • 2021-03-15 07427, 2021

      • Freso
        o/
      • 2021-03-15 07438, 2021

      • CatQuest
        :D
      • 2021-03-15 07447, 2021

      • Freso
        Mostly did lurking around and such.
      • 2021-03-15 07403, 2021

      • Freso
        Don’t have much else to add at this point. :
      • 2021-03-15 07405, 2021

      • Freso
        :\
      • 2021-03-15 07428, 2021

      • Freso
        fin. okno_, are you around/here? shivam-kapila, go for now.
      • 2021-03-15 07441, 2021

      • yvanzo
        Get better! Be safe!
      • 2021-03-15 07456, 2021

      • shivam-kapila
        thanks
      • 2021-03-15 07425, 2021

      • shivam-kapila
        Hi everyone. I didnt do much last week and continued my work on similar users UI
      • 2021-03-15 07449, 2021

      • shivam-kapila
        I had to hand it over to Mr_Monkey as I am having exams. Thanks for helping
      • 2021-03-15 07459, 2021

      • shivam-kapila
        Thats it ruaok go
      • 2021-03-15 07420, 2021

      • ruaok
        hey
      • 2021-03-15 07450, 2021

      • ruaok
        I finished off the similiar users feature and nearly completed the feedback dump feature needed to import user feedback to spark.
      • 2021-03-15 07457, 2021

      • Freso
        (Only okno_ left on my list. If you’re around okno_, please provide a sign of life. If not, we’ll move on in the agenda after ruaok. This also means last call for anyone else who may want to give review!)
      • 2021-03-15 07430, 2021

      • yvanzo
        He seems to be away, let’s move on.
      • 2021-03-15 07431, 2021

      • ruaok
        lots of PRs, lots of various discussions and the usual MeB admin work. And some minor work on coordinating GSoC.
      • 2021-03-15 07454, 2021

      • ruaok
        not a bad week, but sadly I have more meetings on this week. I'm still hoping to pound out some code.
      • 2021-03-15 07401, 2021

      • ruaok
        fin. back to freso.
      • 2021-03-15 07423, 2021

      • Freso
        Yeah, no okno_ or others saying they want to give review, so…
      • 2021-03-15 07431, 2021

      • Freso
        Thanks everyone who gave review!
      • 2021-03-15 07446, 2021

      • Freso
        ??? (bitmap/ruaok?): MB schema change
      • 2021-03-15 07402, 2021

      • ruaok
        bitmap I guess. I didn't put it there.
      • 2021-03-15 07406, 2021

      • ruaok
        (but should've)
      • 2021-03-15 07411, 2021

      • reosarevok
        Hi!
      • 2021-03-15 07413, 2021

      • bitmap
        reosarevok did
      • 2021-03-15 07416, 2021

      • reosarevok
        I put it there, but
      • 2021-03-15 07417, 2021

      • bitmap
        (thanks reosarevok)
      • 2021-03-15 07419, 2021

      • ruaok
        ok. :)
      • 2021-03-15 07437, 2021

      • reosarevok
        Anyway, bitmap, wanna introduce it?
      • 2021-03-15 07443, 2021

      • bitmap
        sure
      • 2021-03-15 07405, 2021

      • bitmap
        we usually announce schema changes in mid march iirc so we'd like to decide on some tickets and do that asap if possible
      • 2021-03-15 07439, 2021

      • bitmap
        https://gist.github.com/mwiencek/8015985a5a93387a… was what I was working with -- most of these are trivial
      • 2021-03-15 07400, 2021

      • yvanzo
        +bump perl requirement?
      • 2021-03-15 07411, 2021

      • reosarevok
        Of those, the only non-trivial ones are
      • 2021-03-15 07413, 2021

      • reosarevok
      • 2021-03-15 07421, 2021

      • reosarevok
        Which would both be cool but I'd drop them for this time
      • 2021-03-15 07423, 2021

      • ruaok
        mbids for artist_credits. hmmm.