yes, in addition to any trivial schema changes, we'd like to bump the versions of node.js and perl required
2021-03-15 07433, 2021
CatQuest
:O@
2021-03-15 07436, 2021
ruaok
I've wanted those many times, they will make life easier.
2021-03-15 07449, 2021
CatQuest
reosarevok: i want both of those
2021-03-15 07451, 2021
bitmap
I'd love to work on that one
2021-03-15 07405, 2021
ruaok
but there was a reason for NOT using them when we designed the schema in 2008. and I don't recall what it was. nor are any of the people around who would know.
2021-03-15 07409, 2021
reosarevok
CatQuest: I know, but we have one month to write all the code and one to test, so that might need to wait for the next one
2021-03-15 07425, 2021
reosarevok
ruaok: I suspect the reason is that the ACs are a) not super stable and b) a lot
2021-03-15 07426, 2021
CatQuest
lol why did we not have this conversation in january!
2021-03-15 07437, 2021
alastairp
ruaok: off the top of my head it feels like it might be something that changes quite a bit
2021-03-15 07446, 2021
alastairp
oh, that's basically what reosarevok said
2021-03-15 07452, 2021
CatQuest
hm
2021-03-15 07452, 2021
yvanzo
ruaok: would be very helpful to restore the rationale behind that.
2021-03-15 07454, 2021
bitmap
one reason I see is that we currently assume ACs are immutable, i.e. can be cached forever
2021-03-15 07457, 2021
ruaok
then this change is now fine?
2021-03-15 07411, 2021
CatQuest
wait but they have some kind of rowid right? you can link to "edit a n artistcredit"
2021-03-15 07426, 2021
bitmap
if we add mbids that would seem to imply you could edit them while keeping the mbid constant
2021-03-15 07434, 2021
CatQuest
hm
2021-03-15 07434, 2021
reosarevok
CatQuest: yes, they have a row id :)
2021-03-15 07456, 2021
reosarevok
bitmap: yes, I would expect if I edit an AC with Edit AC, the MBID wouldn't change
2021-03-15 07405, 2021
reosarevok
But I guess nowadays it would?
2021-03-15 07414, 2021
CatQuest
who uses "edit AC" amiright?
2021-03-15 07428, 2021
reosarevok
Hopefully someone, now that I made it so you can actually see what it changes :D
2021-03-15 07435, 2021
CatQuest
lol
2021-03-15 07442, 2021
bitmap
well, the row ID would change for sure. we use a `find_or_insert` method to swap them (and then deleted any unused ones)
2021-03-15 07406, 2021
bitmap
I don't think we ever actually UPDATE rows in the artist_credit_name table outside of upgrade scripts
2021-03-15 07411, 2021
reosarevok
So that find_or_insert would need to either keep gid, or if merging, add a redirect?
2021-03-15 07417, 2021
reosarevok
Sounds doable, but
2021-03-15 07421, 2021
bitmap
yeah
2021-03-15 07454, 2021
Etua joined the channel
2021-03-15 07411, 2021
bitmap
it might also complicate keeping some materialized tables up to date, but
2021-03-15 07442, 2021
yvanzo
It seems that point should be more discussed/detailed?
2021-03-15 07404, 2021
ruaok
yeah, outside of this meeting, methinks.
2021-03-15 07409, 2021
bitmap
right
2021-03-15 07411, 2021
reosarevok
None of these seem super problematic, so if they would also be useful for LB I'd say let's try it...
2021-03-15 07426, 2021
reosarevok
ruaok: can we tentatively announce but say we might decide not to do it after further consideration?
2021-03-15 07436, 2021
reosarevok
I guess the main issue is unexpected new changes, not not doing some
2021-03-15 07439, 2021
v6lur joined the channel
2021-03-15 07440, 2021
reosarevok
(re: announcing early)
2021-03-15 07453, 2021
ruaok
lets talk about it tomorrow and then announce the changes after the meeting.
2021-03-15 07402, 2021
ruaok
or close the meeting and talk about it now.
2021-03-15 07410, 2021
ruaok
fine by me if I can get a 5 mins break.
2021-03-15 07422, 2021
reosarevok
We should quickly talk about min perl version
2021-03-15 07426, 2021
reosarevok
I think?
2021-03-15 07438, 2021
bitmap
we can probably do that after the meeting
2021-03-15 07444, 2021
yvanzo
+1
2021-03-15 07401, 2021
reosarevok
Ok :) In that case, anything in that list that seems like a bad idea that needs to be decided in the meeting?
2021-03-15 07404, 2021
ruaok
agreed.
2021-03-15 07406, 2021
reosarevok
If not I guess we're done(ish)
2021-03-15 07411, 2021
Freso
So no decisive decision on the AC MBID, but other than that everything on that list?
2021-03-15 07416, 2021
ruaok will be back in a few mins
2021-03-15 07429, 2021
Freso
Oh, and other than the two reosarevok already noted.
2021-03-15 07436, 2021
CatQuest
so reos snippet? becasue i'm aaaall for per medium artwork <3
2021-03-15 07444, 2021
CatQuest
aw
2021-03-15 07447, 2021
reosarevok
Freso: Probably, but I guess we'll discuss a bit more after the meeting :)
2021-03-15 07457, 2021
reosarevok
Some need tickets made still too so :)
2021-03-15 07408, 2021
yvanzo
Freso: only finished/merged stuff for now, the rest is proposed but to be decided.
2021-03-15 07422, 2021
Freso
Alright.
2021-03-15 07431, 2021
Freso
But it sounds like that’s all for now?
2021-03-15 07435, 2021
reosarevok
I think so
2021-03-15 07441, 2021
Freso
And no further items on the agenda.
2021-03-15 07450, 2021
Freso
And no okno_ that’s showed up that I’ve noticed.
2021-03-15 07456, 2021
Freso
So I think this wraps up the meeting!
2021-03-15 07412, 2021
reg[m] joined the channel
2021-03-15 07414, 2021
Freso
Thank you for your time everyone! Stay safe out there!
