#metabrainz

/

      • bitmap
        I can't remember the last time one of our (ancient) deps broke due to a perl upgrade
      • 2021-03-15 07410, 2021

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #1984 (production…mbs-11446-trim-n): MBS-11446: Keep blank lines in annotation https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-15 07444, 2021

      • reosarevok
        bitmap: what about node, what to?
      • 2021-03-15 07403, 2021

      • yvanzo
        latest LTS?
      • 2021-03-15 07418, 2021

      • bitmap
        there's a new LTS release in april, should probably go with that.
      • 2021-03-15 07426, 2021

      • reosarevok
        Ok
      • 2021-03-15 07427, 2021

      • bitmap
        v16?
      • 2021-03-15 07431, 2021

      • yvanzo
        yes
      • 2021-03-15 07454, 2021

      • bitmap
        let's do that
      • 2021-03-15 07418, 2021

      • reosarevok
        Perfect
      • 2021-03-15 07427, 2021

      • bitmap
        does perl 5.32.x seem ok if all tests pass/deps compile?
      • 2021-03-15 07431, 2021

      • reosarevok
        +1
      • 2021-03-15 07432, 2021

      • Etua has quit
      • 2021-03-15 07441, 2021

      • bitmap
        or I'm fine with 5.30.x if you prefer
      • 2021-03-15 07448, 2021

      • Etua joined the channel
      • 2021-03-15 07402, 2021

      • yvanzo
        bitmap: keep a perl version that we can have in our base image maybe? :P
      • 2021-03-15 07406, 2021

      • reosarevok
        Is 5.32 available from debian / ubuntu?
      • 2021-03-15 07436, 2021

      • yvanzo
        focal has 5.30
      • 2021-03-15 07438, 2021

      • bitmap
        I doubt from the official repoos
      • 2021-03-15 07406, 2021

      • bitmap
        lol repoos. stupid keyboard
      • 2021-03-15 07417, 2021

      • reosarevok
        yvanzo: what's the highest still easy to get into the vm? 5.30?
      • 2021-03-15 07427, 2021

      • yvanzo
        focal (ubuntu 20.04 - latest LTS)
      • 2021-03-15 07453, 2021

      • bouhormq joined the channel
      • 2021-03-15 07455, 2021

      • reosarevok
        Then maybe let's do 5.30, unless there's something very special added in between
      • 2021-03-15 07455, 2021

      • yvanzo
        reosarevok: into the vm and into our images for production :)
      • 2021-03-15 07455, 2021

      • bitmap
        I'm hoping there's a popular/well-supported apt repo we could use though
      • 2021-03-15 07414, 2021

      • bouhormq has quit
      • 2021-03-15 07418, 2021

      • bitmap
        ok, that's a good argument for 5.30 then
      • 2021-03-15 07403, 2021

      • bitmap
        so perl 5.30, node v16 it is
      • 2021-03-15 07425, 2021

      • yvanzo
        alright
      • 2021-03-15 07429, 2021

      • reosarevok
        Neat
      • 2021-03-15 07437, 2021

      • yvanzo
        perl 5.30 is in debian sid
      • 2021-03-15 07459, 2021

      • bitmap
        anything else we should discuss from https://gist.github.com/mwiencek/8015985a5a93387a… ?
      • 2021-03-15 07430, 2021

      • reosarevok
        We should see what has tickets and add the missing ones
      • 2021-03-15 07436, 2021

      • bitmap
        do we want/expect to support cardinalities other than 0/1?
      • 2021-03-15 07459, 2021

      • reosarevok
        Maybe, but not higher than 255
      • 2021-03-15 07422, 2021

      • reosarevok
        Oh, postgres has no tinyint to begin with
      • 2021-03-15 07439, 2021

      • reosarevok
        Were you considering an ENUM or?
      • 2021-03-15 07443, 2021

      • bitmap
        yeah. we could use a bit string if we only need a byte
      • 2021-03-15 07450, 2021

      • bitmap
        smallint is two bytes
      • 2021-03-15 07450, 2021

      • BenOckmore has quit
      • 2021-03-15 07409, 2021

      • reosarevok
        You suggested possibly wanting a third type (shown for editing but not display IIRC?) recently
      • 2021-03-15 07414, 2021

      • reosarevok
        So maybe we should play it safe
      • 2021-03-15 07426, 2021

      • yvanzo
        ratings/reviews for place? ^^
      • 2021-03-15 07438, 2021

      • yvanzo
        tripbrainz? :)
      • 2021-03-15 07442, 2021

      • bitmap
        a byte would be 255
      • 2021-03-15 07455, 2021

      • goldenshimmer joined the channel
      • 2021-03-15 07456, 2021

      • SamThursfield[m] joined the channel
      • 2021-03-15 07456, 2021

      • kepstin joined the channel
      • 2021-03-15 07456, 2021

      • AkshatTiwari[m] joined the channel
      • 2021-03-15 07456, 2021

      • bitmunch joined the channel
      • 2021-03-15 07456, 2021

      • joshuaboniface joined the channel
      • 2021-03-15 07456, 2021

      • lorenzuru joined the channel
      • 2021-03-15 07402, 2021

      • Cyna[m] joined the channel
      • 2021-03-15 07436, 2021

      • BenOckmore joined the channel
      • 2021-03-15 07442, 2021

      • reosarevok
        Oh, now I got it
      • 2021-03-15 07456, 2021

      • reosarevok
        Sorry, I was thinking of "a bit"
      • 2021-03-15 07404, 2021

      • reosarevok
        yvanzo: place, not area :)
      • 2021-03-15 07423, 2021

      • reosarevok
        bitmap: I think it's safe to say we won't have 255 cardinalities
      • 2021-03-15 07439, 2021

      • bitmap
        I'm not sure/don't think PG has column types below 1 byte, at least
      • 2021-03-15 07452, 2021

      • yvanzo
        what is "root column to the link_type table" for?
      • 2021-03-15 07455, 2021

      • bitmap
        (even boolean uses 1 byte last time I checked the docs)
      • 2021-03-15 07443, 2021

      • bitmap
        yvanzo: like how link_attribute_type has a root column referring to the top-most type
      • 2021-03-15 07422, 2021

      • bitmap
        we currently use a recursive query to calculate those
      • 2021-03-15 07445, 2021

      • bitmap
        I can't imagine it's slow given the size oof the table, but having it stored is more convenient
      • 2021-03-15 07400, 2021

      • reosarevok
        oof
      • 2021-03-15 07409, 2021

      • yvanzo
        ooof
      • 2021-03-15 07432, 2021

      • bitmap
        that's the eighth time I've oof'd today alone
      • 2021-03-15 07457, 2021

      • ruaok
        oof
      • 2021-03-15 07401, 2021

      • yvanzo
        bitmap: ok, there is no ticket associated to it, right?
      • 2021-03-15 07418, 2021

      • bitmap
        not as oof yet
      • 2021-03-15 07404, 2021

      • bitmap
        do either of you want to claim any of these?
      • 2021-03-15 07427, 2021

      • bitmap
        then the owner can make their own tickets :)
      • 2021-03-15 07456, 2021

      • yvanzo
        :D
      • 2021-03-15 07402, 2021

      • yvanzo
        ooof ;)
      • 2021-03-15 07407, 2021

      • reosarevok
        !recall oh no.
      • 2021-03-15 07407, 2021

      • BrainzBot
      • 2021-03-15 07431, 2021

      • Etua has quit
      • 2021-03-15 07441, 2021

      • Etua1 joined the channel
      • 2021-03-15 07454, 2021

      • reosarevok
      • 2021-03-15 07455, 2021

      • BrainzBot
        MBS-5423: Finish "Log Statistics" work other than schema changes, merge, integrate
      • 2021-03-15 07419, 2021

      • reosarevok
        Or is that unrelated to drop statistics.log_statistic
      • 2021-03-15 07401, 2021

      • bitmap
        that's related, so yes (unless we still have a planned use for this table)
      • 2021-03-15 07435, 2021

      • yvanzo
        Any example of visible cardinality from the website? You seem to be very at ease with it :)
      • 2021-03-15 07401, 2021

      • Etua1 is now known as Etua
      • 2021-03-15 07448, 2021

      • reosarevok
        yvanzo: we don't show all recordings of a work in the relationship editor when editing a work (or a release) because of cardinality
      • 2021-03-15 07412, 2021

      • bitmap
        yvanzo: I don't think the actual number is visible except from the attribute doc page / admin forms
      • 2021-03-15 07430, 2021

      • reosarevok
        Oh, the number itself? Also from relationship type edits
      • 2021-03-15 07450, 2021

      • bitmap
        but we use it to indicate if one side of a relationship has many or few relationships
      • 2021-03-15 07406, 2021

      • CatQuest
        personally I wish a work/UUID/edit *did* show all those
      • 2021-03-15 07409, 2021

      • yvanzo
        of a relationship or of a relationship type?
      • 2021-03-15 07416, 2021

      • CatQuest
        well they do if you add them there :D
      • 2021-03-15 07419, 2021

      • bitmap
        one side of a relationship type, sorry
      • 2021-03-15 07429, 2021

      • CatQuest
        could be a separate lazy load tab?
      • 2021-03-15 07449, 2021

      • bitmap
        CatQuest: that's something we were thinking about, yeah
      • 2021-03-15 07411, 2021

      • bitmap
        using it to determine whether to use paging/lazy-loading rather than hiding it altogether
      • 2021-03-15 07412, 2021

      • CatQuest
        oh!
      • 2021-03-15 07421, 2021

      • yvanzo
        so 1 is many and 0 is few?
      • 2021-03-15 07421, 2021

      • reosarevok
        we were?
      • 2021-03-15 07428, 2021

      • reosarevok
        I didn't remember, but that doesn't sound bad :p
      • 2021-03-15 07436, 2021

      • CatQuest
        :o
      • 2021-03-15 07451, 2021

      • bitmap
        yes, didn't you mention earlier that we did? :P
      • 2021-03-15 07402, 2021

      • CatQuest
        wait if ya's listening to me I have other ideas too!
      • 2021-03-15 07406, 2021

      • CatQuest
        ..
      • 2021-03-15 07408, 2021

      • yvanzo
        < reosarevok> oof
      • 2021-03-15 07411, 2021

      • yvanzo
        he did ^
      • 2021-03-15 07417, 2021

      • CatQuest
        if I can remember :D
      • 2021-03-15 07422, 2021

      • ashutosh3 has quit
      • 2021-03-15 07456, 2021

      • yvanzo
        bitmap: last, edit_data_type_info is a current function, why replacing it with a script?
      • 2021-03-15 07418, 2021

      • yvanzo
        (or generating it with a script?)
      • 2021-03-15 07424, 2021

      • bitmap
        that one wasn't clear, sorry
      • 2021-03-15 07447, 2021

      • bitmap
        we never had a script to create the function on mirrors, I only added it to the prod DB
      • 2021-03-15 07415, 2021

      • bitmap
        soo we should have it be created during the schema change. not that it's used anywhere
      • 2021-03-15 07428, 2021

      • yvanzo
        ok, thanks.
      • 2021-03-15 07453, 2021

      • Rohan_Pillai joined the channel
      • 2021-03-15 07427, 2021

      • reosarevok
        bitmap: can't edit your gist, should we link created tickets to it somehow, or do we just put them into the fix version?
      • 2021-03-15 07453, 2021

      • bitmap
        I could create a google doc instead if that helps
      • 2021-03-15 07456, 2021

      • yvanzo
        I think I got it all but cardinality change, so I cannot take this one.
      • 2021-03-15 07424, 2021

      • reosarevok
        The cardinality change would probably currently only involve changing the type of the column, no?
      • 2021-03-15 07430, 2021

      • yvanzo
        let's just create tickets for each point.
      • 2021-03-15 07434, 2021

      • reosarevok
        (we can later decide to do more stuff with it, but)
      • 2021-03-15 07442, 2021

      • reosarevok
        bitmap: if you want, that might help
      • 2021-03-15 07444, 2021

      • bitmap
        right. the cardinality one is just about saving a few measly bytes
      • 2021-03-15 07405, 2021

      • CatQuest
        ok. unpopular opinion. how hard would "dynamic attributes" be?
      • 2021-03-15 07409, 2021

      • yvanzo
        I mean: the cardinality itself seems to be underdocumented.
      • 2021-03-15 07425, 2021

      • yvanzo
        CatQuest: that already is in current schema.
      • 2021-03-15 07435, 2021

      • CatQuest
        yes reo jsut told me in a pm
      • 2021-03-15 07441, 2021

      • reosarevok
        Yeah, that doesn't need a schema change, just... time
      • 2021-03-15 07447, 2021

      • CatQuest
        i was so sure it was schema since it hadn't ben done :o
      • 2021-03-15 07450, 2021

      • CatQuest
        awww
      • 2021-03-15 07413, 2021

      • CatQuest
        honestly dynamic atributes and alt tracklists are the 2 most wanted tickets anyway for m
      • 2021-03-15 07418, 2021

      • reosarevok
        (relatedly, those big unfinished things are why this list is "a lot of small, easy changes, often backend and not very relevant to users but make stuff work better")
      • 2021-03-15 07425, 2021

      • CatQuest
        that and maybe merge vocal-tree into instruments
      • 2021-03-15 07434, 2021

      • CatQuest
        oohhh
      • 2021-03-15 07452, 2021

      • reosarevok
        (to some degree it is "let's show we can actually *finish* a schema change for once" :p )
      • 2021-03-15 07453, 2021

      • CatQuest
        making stuff work better is always a mega plus
      • 2021-03-15 07402, 2021

      • CatQuest
        espeically if it means the big unfinished thing will be easier to make later
      • 2021-03-15 07407, 2021

      • CatQuest
        loi
      • 2021-03-15 07415, 2021

      • yvanzo
        reosarevok: that and react migration.
      • 2021-03-15 07415, 2021

      • CatQuest
        it's on overtime for sure
      • 2021-03-15 07419, 2021

      • reosarevok
        yvanzo: sure :)
      • 2021-03-15 07428, 2021

      • CatQuest
        yep was gonna say
      • 2021-03-15 07431, 2021

      • CatQuest
        that damn react
      • 2021-03-15 07432, 2021

      • CatQuest
        :P
      • 2021-03-15 07435, 2021

      • bitmap
      • 2021-03-15 07446, 2021

      • reosarevok
        CatQuest: probably the most user-wanted change this year is recording year, but that's already in on the main site
      • 2021-03-15 07452, 2021

      • CatQuest
        how is the ETA on react anyway? andy % on how much is left?
      • 2021-03-15 07455, 2021

      • yvanzo
        CatQuest: damn helpful for the future of MB :)
      • 2021-03-15 07457, 2021

      • Rohan_Pillai has quit
      • 2021-03-15 07402, 2021

      • reosarevok
        Andy Percent sounds like a DJ