#metabrainz

/

      • hijef joined the channel
      • 2021-03-16 07512, 2021

      • hijef has quit
      • 2021-03-16 07512, 2021

      • hijef joined the channel
      • 2021-03-16 07553, 2021

      • adhawkins_ joined the channel
      • 2021-03-16 07548, 2021

      • heyoni_ joined the channel
      • 2021-03-16 07558, 2021

      • BenOckmo1 joined the channel
      • 2021-03-16 07536, 2021

      • yef has quit
      • 2021-03-16 07536, 2021

      • BenOckmore has quit
      • 2021-03-16 07536, 2021

      • adhawkins has quit
      • 2021-03-16 07536, 2021

      • heyoni__ has quit
      • 2021-03-16 07537, 2021

      • kgz has quit
      • 2021-03-16 07537, 2021

      • adhawkins_ is now known as adhawkins
      • 2021-03-16 07541, 2021

      • hijef is now known as yef
      • 2021-03-16 07513, 2021

      • kgz joined the channel
      • 2021-03-16 07514, 2021

      • davic has quit
      • 2021-03-16 07500, 2021

      • adhi001 joined the channel
      • 2021-03-16 07502, 2021

      • kgz has quit
      • 2021-03-16 07506, 2021

      • SothoTalKer_ joined the channel
      • 2021-03-16 07554, 2021

      • SothoTalKer has quit
      • 2021-03-16 07523, 2021

      • SothoTalKer_ has quit
      • 2021-03-16 07510, 2021

      • shivam-kapila
        Mr_Monkey: those endpoints are not moved to API space yet. There's a corresponding task in planning doc too
      • 2021-03-16 07500, 2021

      • SothoTalKer joined the channel
      • 2021-03-16 07531, 2021

      • kgz joined the channel
      • 2021-03-16 07558, 2021

      • RikkoM joined the channel
      • 2021-03-16 07523, 2021

      • Rohan_Pillai joined the channel
      • 2021-03-16 07557, 2021

      • bitmap
        ruaok: zas: does https://wiki.musicbrainz.org/Development/Summer_o… still sound like something useful to have in the musicbrainz schema?
      • 2021-03-16 07545, 2021

      • bitmap
        we have a 'log_statistic' table that's been unused since 2012. sadly I don't know where to find plaintext's unfinished gsoc work for this. it might've been on the old review board :\
      • 2021-03-16 07523, 2021

      • bitmap
        I'm proposing dropping the table. we do have the "mb_top_stuff.html" page that zas worked on now, at least. (but maybe the "collaborative filtering" suggestion would still be useful?)
      • 2021-03-16 07547, 2021

      • Rohan_Pillai has quit
      • 2021-03-16 07526, 2021

      • yvanzo
        zas: We want to update Perl requirement for MBS based on the version available in the next base image for MBS containers. We referred to Ubuntu focal 20.04 (latest LTS). Is it realistic as bionic base image is not in use yet? Or can we plan to skip bionic or upgrade to focal directly? Would there be any issue with using a different base image for some containers?
      • 2021-03-16 07529, 2021

      • bitmap
        moin yvanzo
      • 2021-03-16 07530, 2021

      • bitmap
      • 2021-03-16 07554, 2021

      • bitmap
        probably worth adding to the list
      • 2021-03-16 07558, 2021

      • yvanzo
        +1
      • 2021-03-16 07550, 2021

      • yvanzo
        good night bitmap :)
      • 2021-03-16 07519, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1986 (production…MBS-11448): MBS-11448: Pass Place->new() call through to_json_object https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-16 07542, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1985 (production…MBS-11447): MBS-11447: Use to_json_object on language in Work::Create https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-16 07502, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1982 (production…mbs-11445): MBS-11445: Fix 502 on auto-editor election pages https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-16 07533, 2021

      • reosarevok
        Sigh, found at least one more error that should be hotfixed. I need to use this sentry thing more
      • 2021-03-16 07545, 2021

      • reosarevok
        yvanzo: are you around for possible reviews in a bit?
      • 2021-03-16 07539, 2021

      • yvanzo
        reosarevok: yup
      • 2021-03-16 07501, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1987 (production…MBS-11461): MBS-11461: Add TO_JSON to ExampleRelationships https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-16 07518, 2021

      • reosarevok
        yvanzo: ^ that's one, looking through sentry to see if I find more
      • 2021-03-16 07521, 2021

      • reosarevok
        Not for the json stuff, hopefully that's it
      • 2021-03-16 07535, 2021

      • reosarevok
        Did find that something still seems broken with area localization though, wtf. Looking into it
      • 2021-03-16 07536, 2021

      • c1e0 joined the channel
      • 2021-03-16 07558, 2021

      • reosarevok
        Ok, I think that seems to be related to autocomplete stored results before the last patch
      • 2021-03-16 07502, 2021

      • reosarevok
        So probably safe
      • 2021-03-16 07531, 2021

      • sumedh joined the channel
      • 2021-03-16 07511, 2021

      • probhav joined the channel
      • 2021-03-16 07548, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1988 (master…MBS-11452): MBS-11452 / MBS-11462: Fixes to user tabs display https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-16 07521, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1987 (production…MBS-11461): MBS-11461: Add TO_JSON to ExampleRelationships https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-16 07512, 2021

      • reosarevok
        yvanzo: anything you'd want to check / do before I hotfix?
      • 2021-03-16 07546, 2021

      • RikkoM has quit
      • 2021-03-16 07555, 2021

      • c1e0_ joined the channel
      • 2021-03-16 07558, 2021

      • yvanzo
        reosarevok: no, and it does not seem needed to update musicbrainz-docker as fixed bugs affect edit or edit data only which is not replicated.
      • 2021-03-16 07505, 2021

      • reosarevok
        Ok!
      • 2021-03-16 07555, 2021

      • reosarevok
        So basically, just merge prod into beta and master, release both beta and prod, tag
      • 2021-03-16 07501, 2021

      • reosarevok
        And update the blog post?
      • 2021-03-16 07506, 2021

      • yvanzo
        yup, prod into master, and master into beta :)
      • 2021-03-16 07547, 2021

      • c1e0 has quit
      • 2021-03-16 07522, 2021

      • Rohan_Pillai joined the channel
      • 2021-03-16 07533, 2021

      • reosarevok
        Updating beta
      • 2021-03-16 07559, 2021

      • probhav has quit
      • 2021-03-16 07510, 2021

      • reosarevok
        Updating prod
      • 2021-03-16 07536, 2021

      • reosarevok
        yvanzo: would you suggest adding a separate ticket for adding the view in https://github.com/metabrainz/musicbrainz-server/… ? (for the schema change post)
      • 2021-03-16 07555, 2021

      • probhav joined the channel
      • 2021-03-16 07504, 2021

      • reosarevok
        Update done
      • 2021-03-16 07545, 2021

      • yvanzo
        Thanks!
      • 2021-03-16 07526, 2021

      • reosarevok
        Tagged, updated blog
      • 2021-03-16 07537, 2021

      • reosarevok
        No worries! :)
      • 2021-03-16 07514, 2021

      • c1e0_ has quit
      • 2021-03-16 07514, 2021

      • yvanzo
        reosarevok: that db view is just a way to implement MBS-11268, right?
      • 2021-03-16 07515, 2021

      • BrainzBot
        MBS-11268: Show “Set track durations” on release/discids page https://tickets.metabrainz.org/browse/MBS-11268
      • 2021-03-16 07549, 2021

      • yvanzo
        Oh, for SC blog post, sure.
      • 2021-03-16 07506, 2021

      • probhav has quit
      • 2021-03-16 07500, 2021

      • BrainzGit
        [listenbrainz-server] Solai-Adithya opened pull request #1345 (master…master): LB-838: Limit Error Messages https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-16 07517, 2021

      • akashgp09 joined the channel
      • 2021-03-16 07551, 2021

      • ruaok
        moooin!
      • 2021-03-16 07502, 2021

      • ruaok
        bitmap: yea, drop log_statistic -- all points agreed.
      • 2021-03-16 07533, 2021

      • Mr_Monkey
        shivam-kapila: thanks for the info, hadn't seen that in the doc.
      • 2021-03-16 07533, 2021

      • Mr_Monkey
        Well the UserSocialNetwork component can't work properly until that's resolved. I'll see if it's within my python-fu to do that.
      • 2021-03-16 07515, 2021

      • _lucifer
        Mr_Monkey: if you want, i can do that.
      • 2021-03-16 07529, 2021

      • Mr_Monkey
        Yes please ! :)
      • 2021-03-16 07537, 2021

      • _lucifer
        👍
      • 2021-03-16 07538, 2021

      • Mr_Monkey
        It'll be done better and safer than if I try
      • 2021-03-16 07508, 2021

      • Mr_Monkey
        I'm still struggling with the tests on the front-end PR, so that's a big help, thanks
      • 2021-03-16 07506, 2021

      • c1e0_ joined the channel
      • 2021-03-16 07558, 2021

      • akashgp09 has quit
      • 2021-03-16 07535, 2021

      • c1e0 joined the channel
      • 2021-03-16 07529, 2021

      • c1e0_ has quit
      • 2021-03-16 07516, 2021

      • c1e0_ joined the channel
      • 2021-03-16 07534, 2021

      • c1e0 has quit
      • 2021-03-16 07509, 2021

      • c1e0 joined the channel
      • 2021-03-16 07547, 2021

      • c1e0_ has quit
      • 2021-03-16 07527, 2021

      • c1e0_ joined the channel
      • 2021-03-16 07548, 2021

      • c1e0 has quit
      • 2021-03-16 07532, 2021

      • reosarevok
      • 2021-03-16 07533, 2021

      • BrainzBot
        MBS-11464: Drop table statistics.log_statistic
      • 2021-03-16 07536, 2021

      • c1e0 joined the channel
      • 2021-03-16 07538, 2021

      • c1e0_ has quit
      • 2021-03-16 07517, 2021

      • reosarevok
        bitmap, yvanzo: https://tickets.metabrainz.org/browse/MBS-10962 seems to be https://tickets.metabrainz.org/browse/MBS-11460 but for releases - is this something we should do too then?
      • 2021-03-16 07518, 2021

      • BrainzBot
        MBS-10962: Speed up listing artist's releases
      • 2021-03-16 07518, 2021

      • BrainzBot
        MBS-11460: Add materialized tables to fetch release groups by artist or track artist
      • 2021-03-16 07548, 2021

      • reosarevok
        Also, adding https://tickets.metabrainz.org/browse/MBS-10647 to the list which is also super minor
      • 2021-03-16 07549, 2021

      • BrainzBot
        MBS-10647: Add [no label] to b_del_label_special trigger for labels
      • 2021-03-16 07559, 2021

      • reosarevok
        (looking through other schema change tickets)
      • 2021-03-16 07536, 2021

      • reosarevok
        bitmap: did you ever research https://tickets.metabrainz.org/browse/MBS-10438 ?
      • 2021-03-16 07536, 2021

      • BrainzBot
        MBS-10438: Investigate if materialized status columns are needed on edit_artist and edit_label
      • 2021-03-16 07548, 2021

      • reosarevok
        https://tickets.metabrainz.org/browse/MBS-10208 is marked as a schema change, but I have an open implementation. Adding a gid_redirect would be a schema change though and we might want to do so?
      • 2021-03-16 07549, 2021

      • BrainzBot
        MBS-10208: Allow merging collections
      • 2021-03-16 07541, 2021

      • reosarevok
        Everything else is older than the last schema change, so I won't keep looking further back for now :)
      • 2021-03-16 07502, 2021

      • reosarevok
        I added those 4 to a new section at the bottom of https://docs.google.com/document/d/1gwZlu52ukLTE3…
      • 2021-03-16 07534, 2021

      • reosarevok
        I'll start putting together a blog post, we can then add / remove those before publication once bitmap is around
      • 2021-03-16 07541, 2021

      • reosarevok
        ruaok: we should set a date
      • 2021-03-16 07547, 2021

      • reosarevok
        May 17?
      • 2021-03-16 07532, 2021

      • c1e0 has quit
      • 2021-03-16 07559, 2021

      • ruaok
        Are you asking me out???
      • 2021-03-16 07503, 2021

      • reosarevok
        😏
      • 2021-03-16 07526, 2021

      • ruaok looks around for flowers or chocolates
      • 2021-03-16 07538, 2021

      • ruaok
        but yes, may 17 sounds right.
      • 2021-03-16 07548, 2021

      • reosarevok
        Our chocolate relationship is strictly professional
      • 2021-03-16 07502, 2021

      • reosarevok
        Ok, will keep putting the chocolates together
      • 2021-03-16 07508, 2021

      • reosarevok
        ... the blog post. The blog post together.
      • 2021-03-16 07518, 2021

      • reosarevok might have gotten hungry
      • 2021-03-16 07526, 2021

      • ruaok
        lol.
      • 2021-03-16 07549, 2021

      • reosarevok
        "Number of runned tests does not match plan"
      • 2021-03-16 07505, 2021

      • reosarevok grumbles at himself and at grammar
      • 2021-03-16 07514, 2021

      • ruaok
        spestinglish?
      • 2021-03-16 07557, 2021

      • Rohan_Pillai has quit
      • 2021-03-16 07515, 2021

      • reosarevok
        Sigh, it's not our string so I can't fix it
      • 2021-03-16 07501, 2021

      • reosarevok
        And the maintainer of the Perl package was last active on github in 2018 or so
      • 2021-03-16 07505, 2021

      • reosarevok
        Well, runned it is
      • 2021-03-16 07532, 2021

      • reosarevok
        Also "Some test were not executed, The test died prematurely."
      • 2021-03-16 07536, 2021

      • reosarevok rolls his eyes
      • 2021-03-16 07512, 2021

      • Mr_Monkey
        RIP test
      • 2021-03-16 07502, 2021

      • reosarevok
        bitmap: "Given how small this table is, the recursive query to find the root IDs is already very fast. A better idea might be to add an index on the parent column." - should this index be added during the schema change?
      • 2021-03-16 07523, 2021

      • _lucifer
      • 2021-03-16 07525, 2021

      • reosarevok
        bitmap, yvanzo: is there any reason not to also move all other clearly-always-small INTEGER cols to SMALLINT?
      • 2021-03-16 07544, 2021

      • reosarevok
        In the same link_type table that's child_order and priority
      • 2021-03-16 07550, 2021

      • reosarevok
        (child_order should probably be SMALLINT everywhere)
      • 2021-03-16 07527, 2021

      • reosarevok
        Also autoeditor_election.status (possibly also autoeditor_election.yes_votes and autoeditor_election.no_votes, but)
      • 2021-03-16 07515, 2021

      • reosarevok
        language.frequency
      • 2021-03-16 07540, 2021

      • reosarevok
        Possibly link.attribute_count (but maybe there's some insane edge case)
      • 2021-03-16 07509, 2021

      • reosarevok
        I was going to say medium.track_count but... I'm not sure that won't hit 30k anymore :p
      • 2021-03-16 07540, 2021

      • reosarevok
        script.frequency
      • 2021-03-16 07503, 2021

      • reosarevok
        That seems to be about it
      • 2021-03-16 07520, 2021

      • reosarevok
        If the point is to save on DB size, we have a lot more languages than link types :)
      • 2021-03-16 07503, 2021

      • alastairp
      • 2021-03-16 07508, 2021

      • alastairp
        anyone see this?