bitmap: would that be useful to support auth in replication mode? (or possibly to proxy auth to mb.o?)
2021-03-17 07635, 2021
reosarevok
yvanzo: there's two more ISEs connected to the TO_JSON stuff, in case you want to review. Not sure whether to hotfix, or wait a bit more to see if more appear :D
2021-03-17 07646, 2021
reosarevok
(you're off today for your moving, right?)
2021-03-17 07640, 2021
Rohan_Pillai joined the channel
2021-03-17 07610, 2021
yvanzo
(will be mostly off during daytime mostly, I’m not loading a truck or something like that yet)
2021-03-17 07649, 2021
yvanzo
reosarevok: approved both, feel free to release right away, mainly for the release edits.
2021-03-17 07643, 2021
yvanzo
reosarevok: can we update the SC blog post before that?
reosarevok: about formatting: some ticket references are followed with a dash, some other with a colon, please unify.
2021-03-17 07657, 2021
reosarevok
Sure :)
2021-03-17 07605, 2021
yvanzo
reosarevok: also <code> formatting is often missing, sometimes the affected code is not mentioned either.
2021-03-17 07623, 2021
reosarevok
Yes, I'm working on that now :) Also on reordering the entries by ticket number
2021-03-17 07656, 2021
yvanzo
I added actual release dates for the first tickets, see google doc. (They did not have any description in WP draft at that time).
2021-03-17 07604, 2021
reosarevok
Ok, will look into it too
2021-03-17 07612, 2021
yvanzo
I’m not sure it’s worth mentioning it might not be relevant to mirrors anymore. Maybe bitmap will just want to split the list instead, or not take it into account at all.
2021-03-17 07655, 2021
reosarevok
Ok, let's see
2021-03-17 07621, 2021
reosarevok
The 2019 post had a link to a Jira fix version with all the tickets
2021-03-17 07626, 2021
reosarevok
That probably doesn't work this time though?
2021-03-17 07632, 2021
reosarevok
Since some are already out in MBS
2021-03-17 07647, 2021
reosarevok
Should I add a label or something? Or just trust that the blog is enough as a list...
2021-03-17 07649, 2021
yvanzo
About ACs, what is changed, what is postponed?
2021-03-17 07647, 2021
reosarevok
"The change was released as an optional extension to the main MusicBrainz server schema on Dec 16, 2020, but it will be made the default in this schema change." does something like that seem reasonable for the recording date stuff?
2021-03-17 07620, 2021
reosarevok
bitmap edited the blog for the AC ticket to:
2021-03-17 07621, 2021
reosarevok
MBS-11456: Add MBIDs and redirect tables for artist credits. Adds a gid column to the artist_credit table, and a new artist_credit_gid_redirect table. The MBIDs will allow public identification of artist credits outside of MusicBrainz, and open the door to useful features in the future.
yvanzo: so, does "This adds materialized tables recording_first_release_date and release_first_release_date which are updated via triggers whenever the earliest date changes." seem correct? That's what I understood but just in case :)
2021-03-17 07626, 2021
reosarevok
Prod updated
2021-03-17 07618, 2021
yvanzo
reosarevok: correct :)
2021-03-17 07636, 2021
c1e0 joined the channel
2021-03-17 07657, 2021
akashgp09 joined the channel
2021-03-17 07658, 2021
yvanzo
reosarevok: Ok thanks, does not seem worth adding another ticket about ACs for now.
2021-03-17 07617, 2021
reosarevok
Nice
2021-03-17 07624, 2021
reosarevok
I think the blog post is kinda-sorta done
2021-03-17 07652, 2021
reosarevok
Saved draft and closed - can you take a quick look and see if I missed something? :)
2021-03-17 07603, 2021
mckean has quit
2021-03-17 07645, 2021
reosarevok
Waiting for daily cron to finish before I update the cron container
2021-03-17 07604, 2021
reosarevok
Probably not even needed, but we might as well keep it updated
2021-03-17 07625, 2021
Rohan_Pillai joined the channel
2021-03-17 07627, 2021
reosarevok
Tagged and updated blog in the meantime
2021-03-17 07603, 2021
yvanzo
reosarevok: "main MusicBrainz Server schema" vs "main schema" is a bit unclear, maybe replace with "schema for master replication servers" and "schema for slave replication servers"?
I'll be watching this carefully. monetizing APIs is hard IMHO, especially if you still have open options.
2021-03-17 07636, 2021
yvanzo
reosarevok: Maybe have bitmap’s double-check wording for these already released changes ^ but the rest looks nice, thanks! :)
2021-03-17 07651, 2021
yvanzo
off now
2021-03-17 07618, 2021
Rohan_Pillai has quit
2021-03-17 07641, 2021
Rohan_Pillai joined the channel
2021-03-17 07656, 2021
sumedh has quit
2021-03-17 07657, 2021
Mr_Monkey
Mornin' !
2021-03-17 07642, 2021
RikkoM has quit
2021-03-17 07631, 2021
Mr_Monkey
I was trying to update test.LB but there were some uncommitted changes in docker-server-configs on lemmy.
2021-03-17 07631, 2021
Mr_Monkey
I committed the change but did not see it is not on the master branch and now I don't know what I should be doing.
2021-03-17 07631, 2021
Mr_Monkey
Can I ask that we collectively avoid leaving docker-server-configs in a dirty state on production nodes (barring emergencies)? It makes it harder for other people to deploy things.
2021-03-17 07604, 2021
Mr_Monkey
Now, who was working on the branch `add-spark-dumps-key`, and what should I do? Revert the commit, I suppose, but then what to do with the changes?
2021-03-17 07650, 2021
Mr_Monkey
I assume ruaok, alastairp or _lucifer ?
2021-03-17 07602, 2021
iliekcomputers
another thing i've picked up doing is prepending my name on branches (param-new-feature) so it's easy to know that it's my branch.
2021-03-17 07618, 2021
Mr_Monkey
Good touch
2021-03-17 07633, 2021
ruaok
that's me
2021-03-17 07612, 2021
Mr_Monkey
Can I leave it with you? (I can revert my commit at least)
2021-03-17 07630, 2021
ruaok
I have a feeling that we were active at the same time. :(
2021-03-17 07658, 2021
Mr_Monkey
Uh oh. That's another issue then :)
2021-03-17 07613, 2021
ruaok
nope, I failed to clean up. sorry. I'll take care of it.
2021-03-17 07632, 2021
Mr_Monkey
But if we're doing everything on master (pushing the changes to the node file there and pulling it on Lemmy) we won't run into these issues
2021-03-17 07625, 2021
ruaok
sometimes that isn't possible since we don't have a duplicate production env.
2021-03-17 07652, 2021
ruaok
and I was working on adding a new dump type that I can't debug on my own machine.
2021-03-17 07657, 2021
Mr_Monkey
Hm, I see.
2021-03-17 07630, 2021
ruaok
server configs on lemmy now on master. affected branch deleted.
2021-03-17 07636, 2021
Mr_Monkey
Merci !
2021-03-17 07618, 2021
ruaok
I think we need a better way to deal with version number upgrades, which is a similar problem.
2021-03-17 07635, 2021
ruaok
those tend to stick around uncommited.
2021-03-17 07641, 2021
CatQuest
wait you can add review of a *place*???
2021-03-17 07653, 2021
CatQuest
you implemented that already?
2021-03-17 07601, 2021
iliekcomputers
CatQuest: yeah, that was a GSoC project ferbncode mentored ~two years ago I think
