#metabrainz

ruaok: My workflow is always push the version upgrade to master (from my local machine or github website) then on the prod machine do `./scripts/update_services.sh $version $container`. No mess no fuss

and that works really well when you're releasing software that you can fully test on your own setup. I wish my life was that easy.

that's enough for a farm?

haha, it's not even enough for a n appartment here

(thoguh a farm further away. who knows)

i'm sure kicking buckets is something yo ucna do for free

iliekcomputers: well, if it's not in the best state of repair, yes :D

CatQuest: it's just about enough for a flat in the city, but middle-of-nowhere is cheaper :D

indeed

unfortunately here, middle-of-nowhere doesn't always have good or evne possible internet

Oh, "good" probably not

A lot of those here use 4G mobile net

That's surprisingly decent nowadays tho

i get ~10 mbit on 4G in my home :D

I mean, if you want to download a 50GB videogame, then it's a bit meh

But for programming or Spotify or whatever it works fine

At least in my experience of countryside net here

Maybe even a bit longer :D

and when you're finally done, there's a new 20 GB patch :D

To be fair even if Estonia is quite empty, I suspect you can get a lot more into the middle of nowhere in Norway / Sweden

If you go north long enough :p

[listenbrainz-server] mayhem merged pull request #1339 (master…lastfm-fix): Set retry limit for LastFMImporter https://github.com/metabrainz/listenbrainz-serv...

Mr_Monkey: one merge conflict in https://github.com/metabrainz/listenbrainz-serv... can you please have a look?

I've merged #1339 already. resolve and feel free to merge. I'll do the release after.

Sure. I'll make a note again here that #1339 hasn't been re-reviewed, so hopefully I didn't shit myself on that code and everything works as expected :)

Merge conflict resolved, waiting for JS tests to pass.

Oh. Should we get another set of eyes before proceeding?

reosarevok: I'll leave the api email to support@ for you.

Ok

alastairp and _lucifer, if you have some time please take another look at https://github.com/metabrainz/listenbrainz-serv... so we can deploy that

And thank you !

Mr_Monkey: looks good to me and much better than the old retry logic :D

i see you also found a way around the timers issues, noice!

ok, time for a release then.

[listenbrainz-server] mayhem merged pull request #1346 (master…reactivate-lastfm-importer): Re-enable LastFM importer https://github.com/metabrainz/listenbrainz-serv...

_lucifer: should I update the spotify-reader as well?

ruaok, no not yet.

k

beta updated.

CatQuest: you about?

who wants to test the last.fm import?

woah

ok, seems to work fine. time to push to prod. ;)

Woo !

production updated.

[listenbrainz-server] release v-2021-03-17.0 has been published by github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

oh hey, I was just going to ask what the deploy state of LB was, because I wanted to finish some open reviews

buen timing

_lucifer: what's the story with spotify reader? how can we move this along?

alastairp, i am working on it as we speak. need to add one test and fix another.

great. I'll be around this afternoon to review too 👍

sorry that I wasn't very present yesterday when you were trying to sort out the test image cleanup stuff. did you get any further on that?

no worries, i moved cleanup to after running tests and got this output https://www.irccloud.com/pastebin/Tncrd3m5/

i intend to further debug this after completing the spotify reader fix

it feels like this is because we have 4 images for each of the test runs (so they have a different project), but we're filtering on label, and so it's trying to delete images for other runs too?

maybe we can filter on name as well to prevent this from happening

where are you getting this output from? when you run it locally, or when you run on CI?

or we can modify the label as well, like ListenBrainz Javascript for js test

CI

the label is in the Dockerfile, so it's the same for each of the tests

I am printing the images it finds so the first 4 lines are from that

ah, right!

yeah, but only integration and unit tests use the same Dockerfile

ah, good point. and I hope that we can merge these together shortly anyway

I think the easiest fix is just going to be to add a name wildcard match to the filter. I think it's the right thing to do here

makes sense

do you know why this none:none item is turning up?

it's matching the label I guess? but hasn't been tagged for some reason

intermediate layer? or maybe something that wasn't removed properly

no, i don't know why that happens. yeah, that' possible

OK

could be images from other CI runs on branches that don't have labels yet

I'm just popping off to lunch. back in 30-45m, and maybe we can both look at this together

but the label wouldn't match then 🤔

sure

[musicbrainz-server] reosarevok opened pull request #1993 (master…MBS-11455): MBS-11455: Hide view links on stats when logged out https://github.com/metabrainz/musicbrainz-serve...

Mr_Monkey: Hi. Do you need any help for #1320? I have some free time today (waana freshen up mood after viva cc _lucifer :p)

_lucifer: Thanks for moving the enpoints on 1320, I liked our little exchange of skills between PRs :)

Hah, timing !

shivam-kapila: I think we're done, actually, but I still need to build and try locally and deploy on beta. If you have time to review the PR I'd appreciate that

Sure thing. I can help with testing and review.

Thank you !

I'm struggling with some webpack config and transpilation for old firefox versions and it's doing my head in, so help on that is welcome :D

Mr_Monkey: me as well! :D

On that = on pr 1320

Mr_Monkey: sure. I will try to look into it

[11:56] <reosarevok> Oh, "good" probably not

[11:56] <reosarevok> A lot of those here use 4G mobile net

4g = not "good"

#justestonianthings

I'll be lucky to get 4G levels in *oslo* ffs :D

ruaok: I'm around I can test some last.fm stuff!

we have "4G" here but its slower than 3G by most international standards :(

its deployed, all set!

oh. well I cna still test :D

importing fro mlastfm right?

yerp

hm. it's been made more dificult to fidn the "import" page tbh. I didn't find a button in the menu-bar, or my user page/userdropdown

oh there it is

ooh "Sending page 8 of 80"

the import is going really fast though 👍 already done

1543022 total :D

hm so i cna recomend things to "my followers" but right now yo ucant follow anyone uness it's by doing some database magic (becasue you cna but the gui to follow someoen hasn't been written just yet)

right?

(also I would love a "recommend this *album*(release)" feature)

you can follow any user by going to their profile.

no magic needed.

There is a follow button next to their name on their profile

🤔

don't see anything https://beta.listenbrainz.org/user/Mr_Monkey

Ah, that's not expected

I don't see it either, let me see why

Ah well of course I don't see it on my page, but I do see it on yours:

You have to be logged in to see too

but I am logged in

nope still no

what is the url of the follow button

https://beta.listenbrainz.org/user/shivam-kapila. Can you try this?

I see it there at least

reosarevok: re-reviewed the blog post and it lgtm. was there anything else we needed before publishing?