#metabrainz

/

      • Mr_Monkey
        ruaok: My workflow is always push the version upgrade to master (from my local machine or github website) then on the prod machine do `./scripts/update_services.sh $version $container`. No mess no fuss
      • 2021-03-17 07614, 2021

      • ruaok
        and that works really well when you're releasing software that you can fully test on your own setup. I wish my life was that easy.
      • 2021-03-17 07636, 2021

      • ruaok notes that data dumps are the bane of his existence
      • 2021-03-17 07643, 2021

      • iliekcomputers
        that's enough for a farm?
      • 2021-03-17 07631, 2021

      • mckean_ joined the channel
      • 2021-03-17 07641, 2021

      • CatQuest
        haha, it's not even enough for a n appartment here
      • 2021-03-17 07648, 2021

      • CatQuest
        (thoguh a farm further away. who knows)
      • 2021-03-17 07607, 2021

      • ruaok notes that "buying a farm" can also mean to "kick the bucket"
      • 2021-03-17 07632, 2021

      • CatQuest
        i'm sure kicking buckets is something yo ucna do for free
      • 2021-03-17 07640, 2021

      • reosarevok
        iliekcomputers: well, if it's not in the best state of repair, yes :D
      • 2021-03-17 07658, 2021

      • dseomn_ joined the channel
      • 2021-03-17 07610, 2021

      • reosarevok
        CatQuest: it's just about enough for a flat in the city, but middle-of-nowhere is cheaper :D
      • 2021-03-17 07624, 2021

      • CatQuest
        indeed
      • 2021-03-17 07645, 2021

      • CatQuest
        unfortunately here, middle-of-nowhere doesn't always have good or evne possible internet
      • 2021-03-17 07625, 2021

      • mckean has quit
      • 2021-03-17 07625, 2021

      • dseomn has quit
      • 2021-03-17 07626, 2021

      • dseomn_ is now known as dseomn
      • 2021-03-17 07624, 2021

      • reosarevok
        Oh, "good" probably not
      • 2021-03-17 07629, 2021

      • reosarevok
        A lot of those here use 4G mobile net
      • 2021-03-17 07634, 2021

      • reosarevok
        That's surprisingly decent nowadays tho
      • 2021-03-17 07632, 2021

      • Rotab
        i get ~10 mbit on 4G in my home :D
      • 2021-03-17 07637, 2021

      • reosarevok
        I mean, if you want to download a 50GB videogame, then it's a bit meh
      • 2021-03-17 07647, 2021

      • reosarevok
        But for programming or Spotify or whatever it works fine
      • 2021-03-17 07659, 2021

      • reosarevok
        At least in my experience of countryside net here
      • 2021-03-17 07609, 2021

      • reosarevok remembers waiting 12 hours to play Witcher 3
      • 2021-03-17 07656, 2021

      • reosarevok
        Maybe even a bit longer :D
      • 2021-03-17 07606, 2021

      • Rohan_Pillai has quit
      • 2021-03-17 07629, 2021

      • RikkoM joined the channel
      • 2021-03-17 07638, 2021

      • Rotab
        and when you're finally done, there's a new 20 GB patch :D
      • 2021-03-17 07604, 2021

      • reosarevok
        To be fair even if Estonia is quite empty, I suspect you can get a lot more into the middle of nowhere in Norway / Sweden
      • 2021-03-17 07612, 2021

      • reosarevok
        If you go north long enough :p
      • 2021-03-17 07630, 2021

      • RikkoM has quit
      • 2021-03-17 07629, 2021

      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #1339 (master…lastfm-fix): Set retry limit for LastFMImporter https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07615, 2021

      • ruaok
        Mr_Monkey: one merge conflict in https://github.com/metabrainz/listenbrainz-server… can you please have a look?
      • 2021-03-17 07634, 2021

      • ruaok
        I've merged #1339 already. resolve and feel free to merge. I'll do the release after.
      • 2021-03-17 07648, 2021

      • Etua joined the channel
      • 2021-03-17 07640, 2021

      • Mr_Monkey
        Sure. I'll make a note again here that #1339 hasn't been re-reviewed, so hopefully I didn't shit myself on that code and everything works as expected :)
      • 2021-03-17 07659, 2021

      • Mr_Monkey
        Merge conflict resolved, waiting for JS tests to pass.
      • 2021-03-17 07619, 2021

      • Etua has quit
      • 2021-03-17 07623, 2021

      • ruaok
        Oh. Should we get another set of eyes before proceeding?
      • 2021-03-17 07613, 2021

      • ruaok
        reosarevok: I'll leave the api email to support@ for you.
      • 2021-03-17 07619, 2021

      • akashgp09 has quit
      • 2021-03-17 07619, 2021

      • reosarevok
        Ok
      • 2021-03-17 07628, 2021

      • Mr_Monkey
        alastairp and _lucifer, if you have some time please take another look at https://github.com/metabrainz/listenbrainz-server… so we can deploy that
      • 2021-03-17 07643, 2021

      • Mr_Monkey
        And thank you !
      • 2021-03-17 07649, 2021

      • _lucifer
        Mr_Monkey: looks good to me and much better than the old retry logic :D
      • 2021-03-17 07624, 2021

      • _lucifer
        i see you also found a way around the timers issues, noice!
      • 2021-03-17 07650, 2021

      • ruaok
        ok, time for a release then.
      • 2021-03-17 07620, 2021

      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #1346 (master…reactivate-lastfm-importer): Re-enable LastFM importer https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07645, 2021

      • ruaok
        _lucifer: should I update the spotify-reader as well?
      • 2021-03-17 07611, 2021

      • _lucifer
        ruaok, no not yet.
      • 2021-03-17 07620, 2021

      • ruaok
        k
      • 2021-03-17 07622, 2021

      • c1e0_ is now known as c1e0
      • 2021-03-17 07656, 2021

      • ruaok
        beta updated.
      • 2021-03-17 07607, 2021

      • ruaok
        CatQuest: you about?
      • 2021-03-17 07616, 2021

      • ruaok
        who wants to test the last.fm import?
      • 2021-03-17 07624, 2021

      • ruaok
        woah
      • 2021-03-17 07625, 2021

      • ruaok
      • 2021-03-17 07640, 2021

      • sumedh has quit
      • 2021-03-17 07647, 2021

      • ruaok
        ok, seems to work fine. time to push to prod. ;)
      • 2021-03-17 07639, 2021

      • Mr_Monkey
        Woo !
      • 2021-03-17 07652, 2021

      • ruaok
        production updated.
      • 2021-03-17 07604, 2021

      • BrainzGit
        [listenbrainz-server] release v-2021-03-17.0 has been published by github-actions[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07653, 2021

      • D4RK-PH0_ has quit
      • 2021-03-17 07631, 2021

      • Nyanko-sensei joined the channel
      • 2021-03-17 07619, 2021

      • akashgp09 joined the channel
      • 2021-03-17 07608, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1992 (master…MBS-11454): MBS-11454: Don't consider hasTooEarlyFormat a blocking error https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-17 07604, 2021

      • alastairp
        oh hey, I was just going to ask what the deploy state of LB was, because I wanted to finish some open reviews
      • 2021-03-17 07610, 2021

      • alastairp
        buen timing
      • 2021-03-17 07637, 2021

      • alastairp
        _lucifer: what's the story with spotify reader? how can we move this along?
      • 2021-03-17 07652, 2021

      • _lucifer
        alastairp, i am working on it as we speak. need to add one test and fix another.
      • 2021-03-17 07607, 2021

      • alastairp
        great. I'll be around this afternoon to review too 👍
      • 2021-03-17 07629, 2021

      • alastairp
        sorry that I wasn't very present yesterday when you were trying to sort out the test image cleanup stuff. did you get any further on that?
      • 2021-03-17 07615, 2021

      • c1e0 has quit
      • 2021-03-17 07629, 2021

      • _lucifer
        no worries, i moved cleanup to after running tests and got this output https://www.irccloud.com/pastebin/Tncrd3m5/
      • 2021-03-17 07651, 2021

      • _lucifer
        i intend to further debug this after completing the spotify reader fix
      • 2021-03-17 07648, 2021

      • alastairp
        it feels like this is because we have 4 images for each of the test runs (so they have a different project), but we're filtering on label, and so it's trying to delete images for other runs too?
      • 2021-03-17 07656, 2021

      • alastairp
        maybe we can filter on name as well to prevent this from happening
      • 2021-03-17 07607, 2021

      • c1e0 joined the channel
      • 2021-03-17 07620, 2021

      • alastairp
        where are you getting this output from? when you run it locally, or when you run on CI?
      • 2021-03-17 07625, 2021

      • _lucifer
        or we can modify the label as well, like ListenBrainz Javascript for js test
      • 2021-03-17 07627, 2021

      • _lucifer
        CI
      • 2021-03-17 07644, 2021

      • alastairp
        the label is in the Dockerfile, so it's the same for each of the tests
      • 2021-03-17 07645, 2021

      • _lucifer
        I am printing the images it finds so the first 4 lines are from that
      • 2021-03-17 07652, 2021

      • alastairp
        ah, right!
      • 2021-03-17 07616, 2021

      • _lucifer
        yeah, but only integration and unit tests use the same Dockerfile
      • 2021-03-17 07644, 2021

      • alastairp
        ah, good point. and I hope that we can merge these together shortly anyway
      • 2021-03-17 07604, 2021

      • alastairp
        I think the easiest fix is just going to be to add a name wildcard match to the filter. I think it's the right thing to do here
      • 2021-03-17 07613, 2021

      • _lucifer
        makes sense
      • 2021-03-17 07614, 2021

      • alastairp
        do you know why this none:none item is turning up?
      • 2021-03-17 07626, 2021

      • alastairp
        it's matching the label I guess? but hasn't been tagged for some reason
      • 2021-03-17 07647, 2021

      • alastairp
        intermediate layer? or maybe something that wasn't removed properly
      • 2021-03-17 07652, 2021

      • _lucifer
        no, i don't know why that happens. yeah, that' possible
      • 2021-03-17 07658, 2021

      • alastairp
        OK
      • 2021-03-17 07613, 2021

      • _lucifer
        could be images from other CI runs on branches that don't have labels yet
      • 2021-03-17 07616, 2021

      • alastairp
        I'm just popping off to lunch. back in 30-45m, and maybe we can both look at this together
      • 2021-03-17 07641, 2021

      • _lucifer
        but the label wouldn't match then 🤔
      • 2021-03-17 07643, 2021

      • _lucifer
        sure
      • 2021-03-17 07644, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1993 (master…MBS-11455): MBS-11455: Hide view links on stats when logged out https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-17 07622, 2021

      • shivam-kapila
        Mr_Monkey: Hi. Do you need any help for #1320? I have some free time today (waana freshen up mood after viva cc _lucifer :p)
      • 2021-03-17 07647, 2021

      • Mr_Monkey
        _lucifer: Thanks for moving the enpoints on 1320, I liked our little exchange of skills between PRs :)
      • 2021-03-17 07655, 2021

      • Mr_Monkey
        Hah, timing !
      • 2021-03-17 07625, 2021

      • Mr_Monkey
        shivam-kapila: I think we're done, actually, but I still need to build and try locally and deploy on beta. If you have time to review the PR I'd appreciate that
      • 2021-03-17 07602, 2021

      • shivam-kapila
        Sure thing. I can help with testing and review.
      • 2021-03-17 07651, 2021

      • akashgp09 has quit
      • 2021-03-17 07628, 2021

      • Mr_Monkey
        Thank you !
      • 2021-03-17 07609, 2021

      • Mr_Monkey
        I'm struggling with some webpack config and transpilation for old firefox versions and it's doing my head in, so help on that is welcome :D
      • 2021-03-17 07614, 2021

      • _lucifer
        Mr_Monkey: me as well! :D
      • 2021-03-17 07616, 2021

      • Mr_Monkey
        On that = on pr 1320
      • 2021-03-17 07657, 2021

      • akashgp09 joined the channel
      • 2021-03-17 07605, 2021

      • shivam-kapila
        Mr_Monkey: sure. I will try to look into it
      • 2021-03-17 07646, 2021

      • CatQuest
        [11:56] <reosarevok> Oh, "good" probably not
      • 2021-03-17 07646, 2021

      • CatQuest
        [11:56] <reosarevok> A lot of those here use 4G mobile net
      • 2021-03-17 07646, 2021

      • CatQuest
        4g = not "good"
      • 2021-03-17 07646, 2021

      • CatQuest
        #justestonianthings
      • 2021-03-17 07659, 2021

      • CatQuest
        I'll be lucky to get 4G levels in *oslo* ffs :D
      • 2021-03-17 07646, 2021

      • CatQuest
        ruaok: I'm around I can test some last.fm stuff!
      • 2021-03-17 07659, 2021

      • _lucifer
        we have "4G" here but its slower than 3G by most international standards :(
      • 2021-03-17 07605, 2021

      • ruaok
        its deployed, all set!
      • 2021-03-17 07631, 2021

      • CatQuest
        oh. well I cna still test :D
      • 2021-03-17 07607, 2021

      • CatQuest
        importing fro mlastfm right?
      • 2021-03-17 07608, 2021

      • akashgp09 has quit
      • 2021-03-17 07615, 2021

      • ruaok
        yerp
      • 2021-03-17 07600, 2021

      • CatQuest
        hm. it's been made more dificult to fidn the "import" page tbh. I didn't find a button in the menu-bar, or my user page/userdropdown
      • 2021-03-17 07608, 2021

      • CatQuest
        oh there it is
      • 2021-03-17 07633, 2021

      • CatQuest
        ooh "Sending page 8 of 80"
      • 2021-03-17 07653, 2021

      • CatQuest
        the import is going really fast though 👍 already done
      • 2021-03-17 07613, 2021

      • CatQuest
        1543022 total :D
      • 2021-03-17 07600, 2021

      • CatQuest
        hm so i cna recomend things to "my followers" but right now yo ucant follow anyone uness it's by doing some database magic (becasue you cna but the gui to follow someoen hasn't been written just yet)
      • 2021-03-17 07607, 2021

      • CatQuest
        right?
      • 2021-03-17 07602, 2021

      • CatQuest
        (also I would love a "recommend this *album*(release)" feature)
      • 2021-03-17 07604, 2021

      • ruaok
        you can follow any user by going to their profile.
      • 2021-03-17 07611, 2021

      • ruaok
        no magic needed.
      • 2021-03-17 07654, 2021

      • sumedh joined the channel
      • 2021-03-17 07632, 2021

      • Mr_Monkey
        There is a follow button next to their name on their profile
      • 2021-03-17 07641, 2021

      • CatQuest
        🤔
      • 2021-03-17 07613, 2021

      • CatQuest
      • 2021-03-17 07658, 2021

      • Mr_Monkey
        Ah, that's not expected
      • 2021-03-17 07629, 2021

      • Mr_Monkey
        I don't see it either, let me see why
      • 2021-03-17 07606, 2021

      • Mr_Monkey
        Ah well of course I don't see it on my page, but I do see it on yours:
      • 2021-03-17 07622, 2021

      • Mr_Monkey
      • 2021-03-17 07631, 2021

      • Mr_Monkey
        You have to be logged in to see too
      • 2021-03-17 07656, 2021

      • CatQuest
        but I am logged in
      • 2021-03-17 07609, 2021

      • CatQuest tries signing out nad in again
      • 2021-03-17 07638, 2021

      • CatQuest
        nope still no
      • 2021-03-17 07648, 2021

      • CatQuest
        what is the url of the follow button
      • 2021-03-17 07643, 2021

      • shivam-kapila
      • 2021-03-17 07624, 2021

      • reosarevok
        I see it there at least
      • 2021-03-17 07635, 2021

      • RikkoM joined the channel
      • 2021-03-17 07654, 2021

      • bitmap
        reosarevok: re-reviewed the blog post and it lgtm. was there anything else we needed before publishing?