#metabrainz

/

      • alastairp
        where we catch it and do update_last_updated to set the error message
      • 2021-03-17 07615, 2021

      • _lucifer
        yes
      • 2021-03-17 07651, 2021

      • alastairp
        so, we say that success updates will happen at https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07607, 2021

      • alastairp
        and failure updates will happen in that try/catch
      • 2021-03-17 07654, 2021

      • alastairp
        I'm not too worried about that. maybe in hindsight I'd move the update in 330-339 into process_one_user and then raise SpotifyListenBrainzError
      • 2021-03-17 07625, 2021

      • _lucifer
        i'd like to keep success and failure together
      • 2021-03-17 07630, 2021

      • alastairp
        yeah, agreed
      • 2021-03-17 07646, 2021

      • _lucifer
        yeah, either move failure to process_one_user or move success to process_all
      • 2021-03-17 07652, 2021

      • alastairp
        OK, let's do that then. try/except in process_one_user, where we do the error handling in the except
      • 2021-03-17 07612, 2021

      • alastairp
        by error handling I mean we update the error message in the row/set active=false
      • 2021-03-17 07629, 2021

      • _lucifer
        makes sense, understood.
      • 2021-03-17 07632, 2021

      • CatQuest
      • 2021-03-17 07659, 2021

      • CatQuest slinks away again
      • 2021-03-17 07642, 2021

      • _lucifer
        alastairp, next consideration, do we want to notify user in case of `invalid_grant`?
      • 2021-03-17 07605, 2021

      • alastairp
        is this just a more specific case of "authentication failed" ?
      • 2021-03-17 07610, 2021

      • _lucifer
        i would yes, hopefully this should occur only when the user revokes the permissions explicitly from spotify ui
      • 2021-03-17 07652, 2021

      • alastairp
        I think that's a good error message to be able to report: "You revoked permissions"
      • 2021-03-17 07604, 2021

      • alastairp
        so if catching invalid_grant allows us to report that, then let's do it
      • 2021-03-17 07654, 2021

      • Rohan_Pillai joined the channel
      • 2021-03-17 07615, 2021

      • c1e0_ joined the channel
      • 2021-03-17 07621, 2021

      • shivam-kapila
        Mr_Monkey: added docstrings
      • 2021-03-17 07626, 2021

      • Mr_Monkey
        Neat ! I'll look at it thanks
      • 2021-03-17 07653, 2021

      • c1e0 has quit
      • 2021-03-17 07637, 2021

      • shivam-kapila
        CatQuest: nothing strange. Can you try logging in incognito once
      • 2021-03-17 07605, 2021

      • shivam-kapila
        Mr_Monkey: is the webpack build error for old firefox resolved?
      • 2021-03-17 07615, 2021

      • Mr_Monkey
        Just this second actually :)
      • 2021-03-17 07633, 2021

      • shivam-kapila
        perfect timing :)
      • 2021-03-17 07635, 2021

      • Mr_Monkey
        Had to find which library was causing the issue and make sure we transpile it
      • 2021-03-17 07653, 2021

      • shivam-kapila
        which one was it?
      • 2021-03-17 07616, 2021

      • Mr_Monkey
        A couple of D3 dependencies: d3-scale, d3-arrays and something called internmap
      • 2021-03-17 07650, 2021

      • Mr_Monkey
        Hours of work that ends up in a one line fix. Classic.
      • 2021-03-17 07610, 2021

      • shivam-kapila
        those are these commits
      • 2021-03-17 07617, 2021

      • shivam-kapila
        the best*
      • 2021-03-17 07653, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #1349 (master…monkey-fix-old-firefox-bug): Fix charts and reports pages for old browsers https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07628, 2021

      • sumedh has quit
      • 2021-03-17 07654, 2021

      • c1e0_ has quit
      • 2021-03-17 07641, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1338 (master…LB-826): LB-826: changed config.sh to spark_config.sh https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07657, 2021

      • Mr_Monkey
        ruaok or alastairp: https://github.com/metabrainz/listenbrainz-server… is ready to be merged and deployed, pending one last look at the python bit, if you have a few minutes
      • 2021-03-17 07627, 2021

      • alastairp
        cool, let me look at it after I get these other ones merged
      • 2021-03-17 07656, 2021

      • BrainzGit
        [listenbrainz-server] alastair opened pull request #1350 (master…cleanup-gitignore): Delete items from .gitignore from previous tech stacks https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07633, 2021

      • Rohan_Pillai
        hi @alastairp. I'm Rohan, I had a couple of things I wanted to run by you about my GSoC proposal. is now a good time to talk?
      • 2021-03-17 07656, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo merged pull request #1345 (master…master): LB-838: Limit Error Messages https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-17 07624, 2021

      • alastairp
        Rohan_Pillai: hi, how can I help you?
      • 2021-03-17 07607, 2021

      • Mr_Monkey
      • 2021-03-17 07615, 2021

      • v6lur joined the channel
      • 2021-03-17 07641, 2021

      • _lucifer
        alastairp, regarding https://github.com/metabrainz/listenbrainz-server… it seems, we are notifying the user in case of 500s. should we be doing that?
      • 2021-03-17 07643, 2021

      • Rohan_Pillai
        i was looking into AcousticBrainz. the idea involving identifying bad submissions.https://wiki.musicbrainz.org/Developm…
      • 2021-03-17 07601, 2021

      • Mr_Monkey
        The daily activity graph doesn't seem to work on FF44 still, but the other ones do
      • 2021-03-17 07606, 2021

      • _lucifer
        (according to the current code, the user is notified if there is a SpotifyAPIError but not if SpotifyListenbrainzError)
      • 2021-03-17 07651, 2021

      • alastairp
        _lucifer: I think that "there was an error reading from spotify, we'll try again soon" is about as detailed as I think we should get here
      • 2021-03-17 07652, 2021

      • Rohan_Pillai
        The current similarity engine is based on Spotify Annoy. But that's a approximate nearest neighbour algorithm not a clustering algorithm.
      • 2021-03-17 07607, 2021

      • v6lur has quit
      • 2021-03-17 07620, 2021

      • v6lur joined the channel
      • 2021-03-17 07613, 2021

      • alastairp
        Rohan_Pillai: right, at the moment I'm suggesting ideas using the tools that we have available in AcousticBrainz. If you have further thoughts on clustering algorithms better suited to this task then it'd be great to talk about that
      • 2021-03-17 07614, 2021

      • v6lur has quit
      • 2021-03-17 07615, 2021

      • v6lur joined the channel
      • 2021-03-17 07631, 2021

      • Rohan_Pillai
        yeah thats what i wanted to talk about, is it alright if i do not incorporate the current system in my proposal?
      • 2021-03-17 07622, 2021

      • alastairp
        that's fine, as long as you can show why a different process would be better than what we've suggested in the idea
      • 2021-03-17 07618, 2021

      • Rohan_Pillai
        and if a submission is incorrectly marks should i just label it as incorrect or go as far as recommend it automatically be removed from the DB?
      • 2021-03-17 07648, 2021

      • alastairp
        at the moment we don't want to delete anything from the database, so a flag on the lowlevel table would be better
      • 2021-03-17 07655, 2021

      • alastairp
        Rohan_Pillai: an addition to this if you want to add it to your proposal: we also want to add the idea of a "good" submission. That is, if we have 5 submissions that are all similar, but a user just wants one representative submission then which one should they use?
      • 2021-03-17 07606, 2021

      • alastairp
        maybe your suggested tool can also identify such a file?
      • 2021-03-17 07652, 2021

      • Rohan_Pillai
        yeah thats a great idea!
      • 2021-03-17 07630, 2021

      • Rohan_Pillai
        i will try incorporating that and submit a draft on the forum this weekend
      • 2021-03-17 07643, 2021

      • alastairp
        great, thanks for making a submission!
      • 2021-03-17 07657, 2021

      • Rohan_Pillai has quit
      • 2021-03-17 07652, 2021

      • Rohan_Pillai joined the channel
      • 2021-03-17 07643, 2021

      • jasondk joined the channel
      • 2021-03-17 07610, 2021

      • Rohan_Pillai has quit
      • 2021-03-17 07614, 2021

      • v6lur has quit
      • 2021-03-17 07652, 2021

      • adhi001 has quit
      • 2021-03-17 07659, 2021

      • rdswift
        bitmap, reosarevok: What threshhold do you use to trigger the 504 response when requesting a release with a large number of tracks? Misty_Pond had a question in #musicbrainz about receiving the 504 response for https://musicbrainz.org/release/8f390aa7-28a7-464… (225 tracks over 10 discs) and I speculated that it might be due to the new changes.
      • 2021-03-17 07650, 2021

      • dpmittal_ has quit
      • 2021-03-17 07613, 2021

      • rdswift
        Also, https://community.metabrainz.org/t/release-add-co… in case you haven't seen it.
      • 2021-03-17 07647, 2021

      • Sophist-UK joined the channel