#metabrainz

Artist page time-out: https://community.metabrainz.org/t/524798 https://musicbrainz.org/artist/e383fed3-2e50-45...

shivam-kapila: again https://www.irccloud.com/pastebin/gzCXY8x2/ (from ingognito, includes logging in and oauth )

Mr_Monkey: !!!!

https://test.listenbrainz.org/user/CatCat/chart... I.. See. CHARTS!

https://test.listenbrainz.org/user/CatCat/repor... also works!!!!!!

the reports one has one large weirdly blank 0- mon tue wed etc thing .but might be soem ff faff

https://test.listenbrainz.org/user/CatCat/repor... works great! i cna see graph as well

these graphs are gorgeous! i'm glad that i cna finally see them

hmm! the "daily activity on all time, year, month and week seem to work fien here

it srangly says Hour (undefined) but :D

but still shows digets so idk

bitmap: It seems these materialized tables can be huge and take a lot of time to regenerate, so slave-only triggers seem to be the most efficient option for a small mirror even though it implies redundant calls.

msaaddev (if you ever read backlogs): Hi Saad, welcome. It’s under https://github.com/metabrainz/musicbrainz-server as linked from the gsoc/doc pages.

yvanzo: you're supposed to be on holiday :D

(but if you are taking the ISE, feel free)

derer du jo reosarevok

I'm just curious to know, what happens after a PR is merged? Is deployment instant? (In ListenBrainz)

Mostly the PRs are merget closer to a release. The PRs are actually put in prod when a version is released (unless its a teeny tiny bit that doesn't need a new release)

[musicbrainz-server] reosarevok opened pull request #1994 (master…MBS-11473): MBS-11473: Don't try to filter open edits for user if logged out https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] reosarevok opened pull request #1995 (master…MBS-11476): MBS-11476: Don't show own open edits in /edit/open https://github.com/metabrainz/musicbrainz-serve...

Moin !

CatQuest: Yay ! Progress !

Good afternoon

That should also fix other potential issues with FF44 in the future

now we jsut need the "follow" button to work and we're all there! :D

moioioin!

CatQuest: can you share the browser details. I will try to reproduce it

reosarevok: won’t have time to complete, unassigned it.

Ok, I'll do it later :)

CatQuest: This is what I see on FF 44, the button is right there next to the user's name. Do you see nothing at all there? https://usercontent.irccloud-cdn.com/file/Z2vY0...

Mr_Monkey: nothing at all, shivam-kapila i pasted an updated error log last night (ase adress as the old one)

same*

let me try..

Well, it doesn't seem to be a FF44 thing. Maybe an extension/script?

wait

wait

is it called #.follow-button?

omg it was adbloc plus that cblocked it :tearS:

…

yea and i removed that and now i see it and i cna follow and it works jsut liek in the video (was it ilike?) psoted

🤦

But why would it block that?

becasue i have a script to re move "social" bttons becasue i find thme useless and in the way :D

(i ssupect the "follow button" trigers it)

!recall oh no.

:D

I'm sure not the only one subscribing to that so maybe possible put this information in the documentation possible?

or lemme see

should we rename the button to prevent this from happening again?

it's called "Fanbou's Social Blocing List"

I mean…if users just block all social buttons on their own then the button should be hidden.

that was waht I was thinking

to be fair, it _is_ a social feature

so the blocking list is doing exactly what it says on the tin

usually we block those for facebook, reddit twitter etc. not on-sirte social

on-site social features

and we'll get no end of mails to support@ because of it.

yea

derp, "Fanboy's" not bou

wow it's soo cool to finally see this map thing no people's pages

artists and recordings :O

so remind me is it recordings as in recorded at or "the artist is from $country"

(for the map i mean)

it'd be interesting ot have this for events too. if listenbrainz had artist pages we coudl have a map of "where this artist has toured" etc

[listenbrainz-server] alastair merged pull request #1350 (master…cleanup-gitignore): Delete items from .gitignore from previous tech stacks https://github.com/metabrainz/listenbrainz-serv...

maybe we can report it upstream https://github.com/ryanbr/fanboy-adblock/issues ?

is dpmittal on github in IRC?

I've seen them ,yes!

was gci member and came around interested in gsoc

muhuhua

oh. should the follow button also show on pages like user/charts and user/reports ? it shows on /playlist /recomendations etc

Yeah, eventually

aha

Along with user similarity score

yea I read soemthing about how it's low because "noone is similar2 or smth

hmm so this page shows (0) followers/following https://beta.listenbrainz.org/feed but that's known right?

Well, not if you are following people

i folledyou and reo but no showing :/

reload the page, maybe?

i mena i followed before i even went to this page but

nope

hm maye i followed on test :D let's try again

ok followed yo uand reo let's see

no. doenst show anything as following

.. wat

Bug confirmed, I see the same issue in FF44

`SyntaxError: JSON.parse: unexpected character at line 3 column 1 of the JSON data`

ok so I did press "follow" on you and or reo, it thne says "ufollow" as i hover over it. but whne i go some other page, i go bakc ot reo and.. it just says "follow"

refreshing on reo's page and it will say "follow2 like I hadn't clicked it

alastairp, is the documentation on readthedocs auto generated when master is updated?

good question

it does say here https://readthedocs.org/ that it auto updates but i was wondering if its something opt in etc.

CatQuest: I think the issue with the follower/following thing might go away after we merge and deploy this PR: https://github.com/metabrainz/listenbrainz-serv...

I'll ask you to test after it's deployed and we can take it from there.

👍

Looks like session cookies aren't working well on FF44

(Maybe)

ruaok: https://alexwlchan.net/2019/10/adventures-with-...

thx, perefect timing.

Running a large, fixed number of tasks: ... "It would be better if we could keep the pool “topped up” – as one task finishes, we schedule the next one."

yeah, so it looks like you can still just push stuff onto the futures queue, and pop work off

but it's only 10 lines instead of 100

(I exagerate)

yep

[listenbrainz-server] alastair merged pull request #1337 (master…LB-773): LB-773: Remove pytz dependency https://github.com/metabrainz/listenbrainz-serv...

_lucifer: sorry - to follow up this. for a while docs were failing because of that issue with new versions of pip and our dependencies

what would you prefer? I think it makes sense to update when we push to production, rather than to master

I'm looking at the logs, apparently it ran just fine 6 minutes ago (my merge just above?)

if on failing it keeps showing the last master, i think thats ok but production works too.