Spotify and Youtube - Access Token + Refresh Token
2021-03-22 08127, 2021
_lucifer
Deezer - Non-expiring Access Token
2021-03-22 08127, 2021
_lucifer
Apple Music - Expiring Access Token, refresh manually (need to confirm this one, Mr_Monkey found something in Apple docs which suggest that the usual refresh token process might be possible)
2021-03-22 08124, 2021
_lucifer
Mr_Monkey, ruaok, alastairp: I think we can use this schema for storing user tokens to external services.
2021-03-22 08113, 2021
alastairp
so you'd put specific implementation details (token, refresh token, etc) in auth_details?
2021-03-22 08100, 2021
_lucifer
yes because they differ across most services
2021-03-22 08123, 2021
_lucifer
if the user opts for only playback say using deezer or apple music, we probably do not need to store their access tokens in the database so that column is optional
2021-03-22 08124, 2021
Mr_Monkey
I don't see that optional column; am i missing something?
2021-03-22 08128, 2021
_lucifer
use of refresh tokens and permissions also varies across services
2021-03-22 08101, 2021
Mr_Monkey
ah, you mean the whole auth_details is optional
2021-03-22 08151, 2021
alastairp
for a service with no expiring token, would `token_expires` be null?
now that I look at it again, even `token_expires` can be moved into `auth_details`. I am not sure whether its better to have a column allowing NULL values or move it into `JSONB`. thoughts?
2021-03-22 08145, 2021
_lucifer
the same logic can be applied to `access_token` and `refresh_token` as to whether they should have their own columns with NULL allowed or kept in JSONB.
2021-03-22 08101, 2021
Etua joined the channel
2021-03-22 08124, 2021
Etua has quit
2021-03-22 08148, 2021
sumedh has quit
2021-03-22 08144, 2021
CatQuest has quit
2021-03-22 08113, 2021
shivam-kapila heard of deezer for thr 1st time
2021-03-22 08119, 2021
sumedh joined the channel
2021-03-22 08142, 2021
ruaok
I'm ok with `access_token` and `refresh_token` being in JSONB.
reosarevok, yvanzo: is there a good reason we don't store the email until it's verified? seems like it'd make the system less confusing
2021-03-22 08135, 2021
yvanzo
Hi bitmap, I don’t see any but then we should check permissions always depend on having verified email, not just on having email.
2021-03-22 08112, 2021
c1e0_ has quit
2021-03-22 08128, 2021
c1e0_ joined the channel
2021-03-22 08150, 2021
outsidecontext
zas: looks like I can't be around for the meeting today :(
2021-03-22 08125, 2021
zas
outsidecontext: can you send a mail to freso @ meb to summarize weblate advantages over transifex? At least it will give people matter to think about, and we can wait you're around to discuss this in details
2021-03-22 08132, 2021
_lucifer
alastairp, around?
2021-03-22 08139, 2021
alastairp
hello!
2021-03-22 08156, 2021
_lucifer
are you available to debug the jenkins issue?
2021-03-22 08128, 2021
alastairp
in ~30 minutes?
2021-03-22 08143, 2021
_lucifer
works for me 👍
2021-03-22 08115, 2021
outsidecontext
zas: yes, will do
2021-03-22 08138, 2021
alastairp
outsidecontext: thanks for that. is this related to the forum thread?
2021-03-22 08159, 2021
outsidecontext
yes
2021-03-22 08112, 2021
alastairp
I think this might have been started by me making a mistake with deploying jesus' CB translations
2021-03-22 08131, 2021
alastairp
I'll have a quick look at the thread later today and see if I can make another release
2021-03-22 08106, 2021
outsidecontext
alastairp: we wanted to try weblate for Picard as a pilot project, basically.
2021-03-22 08140, 2021
outsidecontext
zas: if it's ok let's move this discussion to next week, dealing with some work trouble here right now and won't be able to get something written down. I can prepare something for the next meeting
2021-03-22 08155, 2021
zas
ok, np
2021-03-22 08103, 2021
HenryG has quit
2021-03-22 08145, 2021
HenryG joined the channel
2021-03-22 08153, 2021
Zhele_ has quit
2021-03-22 08104, 2021
yvanzo
zas: would it be feasible to host our own instance of weblate?
2021-03-22 08148, 2021
Nizar joined the channel
2021-03-22 08104, 2021
zas
I guess so, but we need resources for that, prolly a VM, and time, backups, etc...
2021-03-22 08128, 2021
reosarevok
bitmap: I dunno, tbh. I expected it was a conscious decision not to store data that might be made up or whatever
2021-03-22 08137, 2021
reosarevok
But it might just be a historical accident
2021-03-22 08122, 2021
yvanzo
I did test weblate with docker last year but did not complete using MB OAuth with it.
2021-03-22 08101, 2021
c1e0_ is now known as c1e0
2021-03-22 08140, 2021
alastairp
_lucifer: sorry, time got away on me
2021-03-22 08141, 2021
alastairp
what's up
2021-03-22 08117, 2021
_lucifer
hi!
2021-03-22 08138, 2021
CatQuest
honestly the faster we move ovv from transifex the better
2021-03-22 08139, 2021
_lucifer
I looking on the pending PRs and thought to discuss and move ahead the Jenkins image cleanup one. Last time, we were discussing filtering on name so that different projects don't clean each others images.
2021-03-22 08152, 2021
alastairp
yes, right
2021-03-22 08113, 2021
alastairp
(we might have to postpone this discussion during meeting time, are you planning on finishing for the day after meeting or can you stay around?)
2021-03-22 08117, 2021
reosarevok
I dunno, transifex isn't that awful
2021-03-22 08122, 2021
reosarevok
But I'm not against a change either
2021-03-22 08149, 2021
_lucifer
i can stay around for another hour after the meeting
but this turns into 'listenbrainzunittest_jenkinsbuild_jenkis_[job jame]-1238'
2021-03-22 08102, 2021
alastairp
which is huge
2021-03-22 08117, 2021
_lucifer
yeah, the job name seems redundant.
2021-03-22 08153, 2021
alastairp
I think we should use BUILD_TAG, then. we might just be able to do COMPOSE_PROJECT_NAME_ORIGINAL=${BUILD_TAG}, because I think it contains all of the information
2021-03-22 08112, 2021
alastairp
I bring it up just to clean up the names of the containers/images
2021-03-22 08117, 2021
_lucifer
makes sense.
2021-03-22 08155, 2021
alastairp
so now going back to the filter, maybe we should just filter on label _and_ project name
2021-03-22 08155, 2021
_lucifer
we also have some none:none in the output when we list images.
2021-03-22 08125, 2021
alastairp
do you have a `docker image ls` command that reproduces this?
2021-03-22 08141, 2021
_lucifer
yes, i also have a build on ci showing that. let me find that
2021-03-22 08115, 2021
yvanzo
reosarevok: It’s not that awful indeed but it has a few hiccups and doesn’t allow for MB auth.
2021-03-22 08132, 2021
alastairp
this is the --format {{.Repository}}:{{.Tag}} bit, so it strikes me that there's an image layer around which matches the label filter, but doesn't have a tag for some reason
2021-03-22 08146, 2021
reosarevok
yvanzo: sure, not saying we can't improve on it, just wanna make sure it's an improvement :)
2021-03-22 08159, 2021
alastairp
filtering based on the name will solve this, but it also means that we might leave it behind and not pick it up with the filter
People up for reviews: yvanzo, bitmap, zas, alastairp, Mr_Monkey, Freso, reosarevok, _lucifer, ruaok, shivam-kapila, CatQuest – anyone else who want to give review, let me know ASAP!
2021-03-22 08109, 2021
Freso
I haven’t received any mailed in reviews, so…
2021-03-22 08109, 2021
Freso
yvanzo: Go!
2021-03-22 08112, 2021
alastairp
I'm going to add to this PR right now a filter to include the repository too
2021-03-22 08115, 2021
yvanzo
Hi all!
2021-03-22 08119, 2021
alastairp
we can continue after meeting
2021-03-22 08122, 2021
_lucifer
👍
2021-03-22 08123, 2021
yvanzo
Sorry alastairp and _lucifer for interrupting ;)
2021-03-22 08141, 2021
yvanzo
Last week I helped reosarevok with scheduling schema changes.
2021-03-22 08100, 2021
yvanzo
Also fixed a regression I caused in annotation formatting.
2021-03-22 08118, 2021
yvanzo
Plus reviewed some PRs and that’s all.
2021-03-22 08123, 2021
yvanzo
Go reosarevok?
2021-03-22 08126, 2021
reosarevok
Hi!
2021-03-22 08154, 2021
reosarevok
Last week I spent quite a bit of time putting together schema change tickets and preparing a blog post for them (with help from the team, thanks all)
2021-03-22 08117, 2021
reosarevok
I also fixed a bunch of ISEs that slipped past testing / review from a huge bitmap PR and hotfixed them
2021-03-22 08132, 2021
c1e0
Hi folks!
2021-03-22 08132, 2021
reosarevok
And started working on some smaller schema change tickets
2021-03-22 08141, 2021
Freso
Hi c1e0!!
2021-03-22 08150, 2021
reosarevok
Plus the usual triaging
2021-03-22 08154, 2021
reosarevok
And fixing small old stuff
2021-03-22 08109, 2021
reosarevok
I plan to do the same this week, plus hopefully some hiking and birdwatching
2021-03-22 08126, 2021
reosarevok
Since I need to take some days half-off or I'll go over my hour limit, lol
