#metabrainz

/

      • mfl is now known as moufl
      • 2021-03-22 08109, 2021

      • shivam-kapila
        Thanks
      • 2021-03-22 08126, 2021

      • okno_
        Thanks
      • 2021-03-22 08159, 2021

      • yvanzo
        Thanks everyone!
      • 2021-03-22 08126, 2021

      • shivam-kapila
        c1e0: glad I could help :)
      • 2021-03-22 08100, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #2011 (master…MBS-11510): MBS-11510: Stop overwriting titles in disableBecauseDiscIDs https://github.com/metabrainz/musicbrainz-server/…
      • 2021-03-22 08144, 2021

      • ShivamAwasthi has quit
      • 2021-03-22 08105, 2021

      • CatQuest
        so wepblate is pretty awesoem for actially working for me :D https://hosted.weblate.org/translate/f-droid/priv…
      • 2021-03-22 08130, 2021

      • pristine___
        ruaok: the month should be in two digits, for example 01, 02, 03, will be easier to deal with python, also user folder can be names as `listens` since it contains listen feedback
      • 2021-03-22 08147, 2021

      • Mr_Monkey
        ruaok: BB currently has no way of surfacing its docs (served on readthedocs) on the website itself, nor any system set up for internationalization. Do you think that would constitute a significant enough amount of coding for a SoC project?
      • 2021-03-22 08108, 2021

      • pristine___
        also the spark dump have timestamp in this format https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-22 08133, 2021

      • pristine___
        we should do that in the feedback dump for spark as well, rn I see unix timestamp in the feedback dump
      • 2021-03-22 08150, 2021

      • ruaok
        Mr_Monkey: I would rather stay away from low-coding projects. we've tried it before and got a lot of pushback from the gsoc team.
      • 2021-03-22 08155, 2021

      • ruaok
        pristine___: ok, will fix.
      • 2021-03-22 08155, 2021

      • yvanzo
        reosarevok: I did review the large PR about refactoring reports if that matters :)
      • 2021-03-22 08134, 2021

      • Mr_Monkey
        Understood.
      • 2021-03-22 08109, 2021

      • pristine___
        yeah, spark can directly use timestamp of the format `2021-03-22 18:50:05.883913`
      • 2021-03-22 08149, 2021

      • ruaok
        what is it now, pristine___ ?
      • 2021-03-22 08119, 2021

      • pristine___
        > we should do that in the feedback dump for spark as well, rn I see unix timestamp in the feedback dump
      • 2021-03-22 08129, 2021

      • pristine___
        was explaining this comment of mine, nothing much
      • 2021-03-22 08114, 2021

      • ruaok
        sorry, what is the format now? unix number of seconds since 1970?
      • 2021-03-22 08124, 2021

      • ruaok hates timestamps in python
      • 2021-03-22 08153, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #569 (master…master): fix (Collections) : Create Collection Button should not be there when viewing someone else's collection https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-03-22 08126, 2021

      • pristine___
        > unix number of seconds since 1970?
      • 2021-03-22 08127, 2021

      • pristine___
        yes
      • 2021-03-22 08132, 2021

      • shivam-kapila
        Time and again this troubles you ruaok
      • 2021-03-22 08148, 2021

      • pristine___
        `{"user_id":3906,"recording_mbid":"e189a0ab-7742-4391-aef0-9237bce53b36","rating":"love","created":1611668465}`
      • 2021-03-22 08149, 2021

      • ruaok
        not much hope in sight.
      • 2021-03-22 08122, 2021

      • ruaok
        pristine___: I've fixed both month and day in the pathnames have 03 -- that ok?
      • 2021-03-22 08153, 2021

      • pristine___
        yup, thanks
      • 2021-03-22 08122, 2021

      • ruaok
        let me do the timestamp, then I'll create a new dump for you to examine, ok?
      • 2021-03-22 08127, 2021

      • ruaok
        lets get this done today
      • 2021-03-22 08140, 2021

      • c1e0 has quit
      • 2021-03-22 08127, 2021

      • pristine___
        the recommendation feedback format looks good, you asked to open a ticket for listen feedback format, am doing it now,
      • 2021-03-22 08154, 2021

      • ruaok
        don't worry now.
      • 2021-03-22 08157, 2021

      • Zhele joined the channel
      • 2021-03-22 08158, 2021

      • ruaok
        the code is done for both of them.
      • 2021-03-22 08126, 2021

      • ruaok
        did you see the data dump in the files on the FTP site? they should be there.
      • 2021-03-22 08133, 2021

      • pristine___
        yes
      • 2021-03-22 08152, 2021

      • pristine___
        > also user folder can be names as `listens` since it contains listen feedback
      • 2021-03-22 08104, 2021

      • pristine___
        `{"user_id":4515,"recording_msid":"90d30adc-8e2b-460c-82bd-a9acdc592645","score":1,"created":1612224092}` is what we have in the `data.json` file in the `user` folder which I think contains listen feedback
      • 2021-03-22 08127, 2021

      • pristine___
        I am still thinking on it, we will need more info to join it with the mapping
      • 2021-03-22 08142, 2021

      • ruaok
        pristine___: this is the format I have now:
      • 2021-03-22 08146, 2021

      • ruaok
      • 2021-03-22 08104, 2021

      • ruaok
      • 2021-03-22 08133, 2021

      • ruaok
      • 2021-03-22 08154, 2021

      • ruaok
        > I am still thinking on it, we will need more info to join it with the mapping
      • 2021-03-22 08155, 2021

      • pristine___
        ./feedback/
      • 2021-03-22 08155, 2021

      • pristine___
        ./user
      • 2021-03-22 08155, 2021

      • pristine___
        ./user/2021
      • 2021-03-22 08155, 2021

      • pristine___
        ./user/2021/03
      • 2021-03-22 08155, 2021

      • pristine___
        ./user/2021/03/12
      • 2021-03-22 08155, 2021

      • pristine___
        ./user/2021/03/12/data.json
      • 2021-03-22 08156, 2021

      • pristine___
        ./recommendation
      • 2021-03-22 08156, 2021

      • pristine___
        ./recommendation/2021
      • 2021-03-22 08157, 2021

      • pristine___
        ./recommendation/2021/03
      • 2021-03-22 08157, 2021

      • pristine___ has quit
      • 2021-03-22 08159, 2021

      • iliekcomputers
        Freso: reosarevok: she got banned ^
      • 2021-03-22 08126, 2021

      • iliekcomputers
        ruaok: ^
      • 2021-03-22 08139, 2021

      • CatQuest
        that really sucks. re gsoc pushback :(
      • 2021-03-22 08142, 2021

      • ruaok
        not sure what to do about it.
      • 2021-03-22 08152, 2021

      • CatQuest
        wait wat
      • 2021-03-22 08158, 2021

      • CatQuest
        oh no
      • 2021-03-22 08109, 2021

      • CatQuest
        !recall oh no.
      • 2021-03-22 08109, 2021

      • BrainzBot
      • 2021-03-22 08136, 2021

      • ruaok has forgotten all his irc foo
      • 2021-03-22 08159, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #575 (master…IG-Work-2): Feat (Core | BB-333) Implement a RelationshipType enum https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-03-22 08104, 2021

      • MusicbrainzB0T2 has quit
      • 2021-03-22 08157, 2021

      • reosarevok
        "The ban on pristine from #metabrainz has been lifted" says sigyn
      • 2021-03-22 08106, 2021

      • ruaok
        I lifted it.
      • 2021-03-22 08122, 2021

      • reosarevok
        How did you do it? I messaged sigyn to remove it as per https://github.com/freenode/Sigyn
      • 2021-03-22 08129, 2021

      • reosarevok
        But I guess you did it in some other way?
      • 2021-03-22 08142, 2021

      • pristine___
        Thanks
      • 2021-03-22 08146, 2021

      • pristine___ joined the channel
      • 2021-03-22 08117, 2021

      • CatQuest
        pristine is still magic, replies before rejoining!
      • 2021-03-22 08119, 2021

      • ruaok
        so, what else needs doing in the dump?
      • 2021-03-22 08148, 2021

      • ruaok
        pristine___: ^
      • 2021-03-22 08113, 2021

      • MusicbrainzB0T joined the channel
      • 2021-03-22 08123, 2021

      • pristine___
        ruaok: the ticket mentions that the field for recording mbid should be called `mb_recording_mbid` but it is `recording_mbid` in the data.json file
      • 2021-03-22 08125, 2021

      • adhawkins has quit
      • 2021-03-22 08136, 2021

      • pristine___
      • 2021-03-22 08136, 2021

      • BrainzBot
        LB-825: Import recommendation feedback to spark cluster
      • 2021-03-22 08102, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #554 (master…snyk-upgrade-25d5d6c413209d68a2ffe8e43341112c): [Snyk] Upgrade http-status from 1.2.0 to 1.5.0 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-03-22 08127, 2021

      • ruaok
      • 2021-03-22 08130, 2021

      • ruaok
        pristine___: ^
      • 2021-03-22 08145, 2021

      • ruaok
        file structure look ok now?
      • 2021-03-22 08115, 2021

      • pristine___
        yes, recommendation feedback looks good, just give me few mins for listen feedback
      • 2021-03-22 08156, 2021

      • pristine___
        ruaok: one sec. what is this user_id? as per the ticket we need user_name
      • 2021-03-22 08155, 2021

      • adhawkins joined the channel
      • 2021-03-22 08125, 2021

      • pristine___
        also it should be `feedback` not `rating` as per the ticket
      • 2021-03-22 08144, 2021

      • mckean has quit
      • 2021-03-22 08122, 2021

      • ruaok
        the listens part of ticket didn't exist when I coded this. ;p
      • 2021-03-22 08143, 2021

      • ruaok
        I just used the field name from the DB.
      • 2021-03-22 08158, 2021

      • pristine___
        yeah, but recommendation feedback ticket was in place by then, nevamind, its good to do it now than later
      • 2021-03-22 08105, 2021

      • travis-ci joined the channel
      • 2021-03-22 08106, 2021

      • travis-ci
        Project bookbrainz-site build #3776: passed in 17 min 23 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-03-22 08106, 2021

      • travis-ci has left the channel
      • 2021-03-22 08134, 2021

      • mckean joined the channel
      • 2021-03-22 08135, 2021

      • pristine___
        ruaok: https://tickets.metabrainz.org/browse/LB-847, I was wondering if it is possible to get all the required data just from recording_msid
      • 2021-03-22 08136, 2021

      • BrainzBot
        LB-847: Import listen feedback to spark cluster
      • 2021-03-22 08101, 2021

      • ruaok
        elaborate please?
      • 2021-03-22 08111, 2021

      • pristine___
        can you read the ticket?
      • 2021-03-22 08125, 2021

      • pristine___
        point 2
      • 2021-03-22 08155, 2021

      • pristine___
        we rn only have recording msid in the db (lemmy) to determine a recording for listens feedback
      • 2021-03-22 08100, 2021

      • ruaok
        don't we have the mapping already loaded in the DB?
      • 2021-03-22 08135, 2021

      • ruaok
        this data should already exist in spark, no?
      • 2021-03-22 08145, 2021

      • ruaok
        because this metadata really doesn't belong in this dump file. we should have the MBID mapping in spark, so let's use it.
      • 2021-03-22 08117, 2021

      • ruaok
        if the join on the mapping doesn't resolve, fine. once we migrate to MBIDs these problems go away.
      • 2021-03-22 08102, 2021

      • Zhele has quit
      • 2021-03-22 08146, 2021

      • Zhele joined the channel
      • 2021-03-22 08149, 2021

      • pristine___
        okay, cool
      • 2021-03-22 08153, 2021

      • pristine___
        sounds good
      • 2021-03-22 08105, 2021

      • ruaok
        I'll run a full dump in a sec once containers upload
      • 2021-03-22 08136, 2021

      • pristine___
        okay, here till 9 :)
      • 2021-03-22 08138, 2021

      • pristine___
        > because this metadata really doesn't belong in this dump file. we should have the MBID mapping in spark, so let's use it.
      • 2021-03-22 08148, 2021

      • pristine___
        makes sense, nice
      • 2021-03-22 08118, 2021

      • travis-ci joined the channel
      • 2021-03-22 08118, 2021

      • travis-ci
        Project bookbrainz-site build #3779: passed in 15 min 46 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-03-22 08118, 2021

      • travis-ci has left the channel
      • 2021-03-22 08116, 2021

      • ruaok
      • 2021-03-22 08149, 2021

      • pristine___
        > also it should be `feedback` not `rating` as per the ticket
      • 2021-03-22 08106, 2021

      • pristine___
        should we do this also?
      • 2021-03-22 08139, 2021

      • ruaok
        already done
      • 2021-03-22 08118, 2021

      • pristine___
        ooo, the link you shared, i see it as `rating`
      • 2021-03-22 08127, 2021

      • pristine___
        not sure what's happening
      • 2021-03-22 08138, 2021

      • ruaok
        the recommendation dump has a field called "rating", yes? and the listens should have "feedback". Do I understand that right?
      • 2021-03-22 08122, 2021

      • pristine___
        both the dump should have `feedback` in my opinion, because it is feedback in the end
      • 2021-03-22 08113, 2021

      • pristine___
        also one last thing, the `user` folder can be renamed to `listens`, ignore if you have already done :p my laptop is not opening files all of a sudden
      • 2021-03-22 08148, 2021

      • pristine___
        okay, I gotta go and cook dinner, I think things are in place now
      • 2021-03-22 08105, 2021

      • ruaok
      • 2021-03-22 08135, 2021

      • nifemi joined the channel
      • 2021-03-22 08124, 2021

      • davic has quit
      • 2021-03-22 08104, 2021

      • nifemi has quit
      • 2021-03-22 08155, 2021

      • BrainzGit
        [musicbrainz-docker] yvanzo merged pull request #187 (master…patch-1): Bump BASE_IMAGE_DATE to fix Sir Dockerfile build https://github.com/metabrainz/musicbrainz-docker/…
      • 2021-03-22 08127, 2021

      • mckean has quit
      • 2021-03-22 08116, 2021

      • kellnerd joined the channel
      • 2021-03-22 08143, 2021

      • mckean joined the channel
      • 2021-03-22 08131, 2021

      • kellnerd has left the channel
      • 2021-03-22 08120, 2021

      • ljunkie has quit
      • 2021-03-22 08125, 2021

      • ljunkie joined the channel
      • 2021-03-22 08130, 2021

      • ljunkie has quit
      • 2021-03-22 08157, 2021

      • ljunkie joined the channel
      • 2021-03-22 08116, 2021

      • adhi001 has quit