I guess I could just make a generic ticket listing all the different bits that are affected, or one ticket per chunk
2021-03-23 08212, 2021
c1e0 joined the channel
2021-03-23 08213, 2021
yvanzo
hi reosarevok: as you prefer, these chunks will be merged/released at the same time anyway.
2021-03-23 08215, 2021
davic joined the channel
2021-03-23 08254, 2021
adhi001 joined the channel
2021-03-23 08256, 2021
CatQuest
hommik 🙋
2021-03-23 08209, 2021
sumedh joined the channel
2021-03-23 08250, 2021
ruaok
mooin!
2021-03-23 08216, 2021
sumedh has quit
2021-03-23 08226, 2021
Madtrick joined the channel
2021-03-23 08236, 2021
iliekcomputers
alastairp: you merged the metrics PR, exciting!
2021-03-23 08229, 2021
ruaok
indeed, I am very much looking forward to using that.
2021-03-23 08223, 2021
alastairp
iliekcomputers: yes, hoping that I could make a release so that in the meeting yesterday I could say "oh, and I deployed metrics and got it running in LB"
If anyone is in the mood to write some doc, many entities still needs to be documented. Let me know if you are interested !
2021-03-23 08233, 2021
Madtrick1 joined the channel
2021-03-23 08207, 2021
Madtrick has quit
2021-03-23 08222, 2021
Madtrick1 has quit
2021-03-23 08250, 2021
Madtrick joined the channel
2021-03-23 08209, 2021
Madtrick has left the channel
2021-03-23 08239, 2021
Madtrick joined the channel
2021-03-23 08253, 2021
Madtrick has left the channel
2021-03-23 08212, 2021
Madtrick joined the channel
2021-03-23 08238, 2021
adhi001 has quit
2021-03-23 08232, 2021
nifemi joined the channel
2021-03-23 08202, 2021
nifemi has quit
2021-03-23 08245, 2021
Nizar joined the channel
2021-03-23 08244, 2021
Madtrick has quit
2021-03-23 08210, 2021
Madtrick joined the channel
2021-03-23 08233, 2021
adhi001 joined the channel
2021-03-23 08234, 2021
Etua joined the channel
2021-03-23 08200, 2021
Etua has quit
2021-03-23 08250, 2021
shivam-kapila
Good evening Mr_Monkey. Whats left for #$1320?
2021-03-23 08255, 2021
shivam-kapila
#1320*
2021-03-23 08220, 2021
Etua joined the channel
2021-03-23 08233, 2021
c1e0_ joined the channel
2021-03-23 08221, 2021
c1e0 has quit
2021-03-23 08202, 2021
Mr_Monkey
Hai shivam-kapila. I think just a review from alastair , when he finds some time.
2021-03-23 08218, 2021
nifemi joined the channel
2021-03-23 08229, 2021
milkii has quit
2021-03-23 08203, 2021
ruaok
alastairp: I've been working with the ThreadPoolExecutor... its a bit ... different. had I written my own and suffered more of your ridicule, I would've been done already. 🤣
2021-03-23 08247, 2021
goldenshimmer has quit
2021-03-23 08253, 2021
piti has quit
2021-03-23 08226, 2021
kepstin has quit
2021-03-23 08256, 2021
reg[m] has quit
2021-03-23 08210, 2021
joshuaboniface has quit
2021-03-23 08213, 2021
Cyna[m] has quit
2021-03-23 08227, 2021
piti joined the channel
2021-03-23 08241, 2021
bharatkalluri[m] has quit
2021-03-23 08255, 2021
lorenzuru has quit
2021-03-23 08256, 2021
AkshatTiwari[m] has quit
2021-03-23 08256, 2021
bitmunch has quit
2021-03-23 08212, 2021
SamThursfield[m] has quit
2021-03-23 08214, 2021
BrainzGit has quit
2021-03-23 08201, 2021
milkii joined the channel
2021-03-23 08259, 2021
alastairp
is that a comment or a complaint? :)
2021-03-23 08232, 2021
ruaok
a complaining comment. :)
2021-03-23 08254, 2021
alastairp
I'll be interested to see how it turns out
2021-03-23 08218, 2021
ruaok
you and me both. been debugging all afternoon.
2021-03-23 08228, 2021
alastairp
I know you can bash out low-level pool management code, I've seen it multiple times. if this is shorter then maybe that's a positive?
2021-03-23 08201, 2021
ruaok
I think once we have the knowledge of how to make this work, this will be easier in the long run.
2021-03-23 08218, 2021
ruaok
the documentation is a bit too pythonic to really make it clear what is expected.
2021-03-23 08237, 2021
alastairp
right, it kind of says "do this and magic will happen" ?
2021-03-23 08204, 2021
ruaok
yes. the futures list... or is a dict? is.. muddy.
2021-03-23 08236, 2021
ruaok
I have yet to see a thread fire off. after several hours of trying.
2021-03-23 08248, 2021
ruaok
the only threads running are the ones I create by hand, lol.
I guess the container ending will cause... whatever. I don't care. those items will not get ack'ed and thus for the next run will be re-run until acked.
2021-03-23 08228, 2021
alastairp
right, so if there are no more items on the queue it just hangs around a bit more
2021-03-23 08241, 2021
ruaok
so far. yes.
2021-03-23 08253, 2021
ruaok
I've not implemented the historical listen lookup yet.
2021-03-23 08208, 2021
ruaok
the priority queue is also interesting.
2021-03-23 08223, 2021
ruaok
you can't do (priority, dict) and do a put()
2021-03-23 08234, 2021
ruaok
if the two priorities are equal, it will compare the dict and fail.
2021-03-23 08254, 2021
ruaok
so, priorities need to be unique. sigh.
2021-03-23 08221, 2021
ruaok
so i used positive priorities for incoming listens and negative priorities for historical listens.
2021-03-23 08223, 2021
joshuaboniface joined the channel
2021-03-23 08200, 2021
ruaok
hacky. I wonder why they implemented it like this.
2021-03-23 08226, 2021
Cyna[m] joined the channel
2021-03-23 08221, 2021
_lucifer
you can wrap it inside a class that ignores comparision on dict
2021-03-23 08214, 2021
ruaok
yeah, but I find that decision for the default a bit questionable.
2021-03-23 08218, 2021
_lucifer
that happens because they break ties on priority values by comparing the values. since `dict`s are unordered the error occurs.
chaban: do you feel https://tickets.metabrainz.org/browse/MBS-10667 is a problem then? As in, should all rels with the same entity be grouped first, in your opinion, and only if all the relationships match between two entities then the two entities should be grouped?
2021-03-23 08207, 2021
BrainzBot
MBS-10667: Release-URLs are sometimes split across multiple relationship groups
2021-03-23 08222, 2021
Madtrick1 joined the channel
2021-03-23 08222, 2021
reosarevok
I'm not sure whether either option is better than the other, personally :)
2021-03-23 08209, 2021
Madtrick has quit
2021-03-23 08233, 2021
Cyna[m]
reosarevok: any ticket open which I can pick up ?
2021-03-23 08248, 2021
Cyna[m]
for MB
2021-03-23 08207, 2021
CatQuest
reosarevok: I'm not chaban, but I would actually except that "thekirkz" link was grouped together with all the things, and then the "tnsrecords" one alone as download for free because that would be clearer. , everything is on the same link after all so no matter if I want to stream or download or buy there is one link. that there is a *second* link (which may or may not do other things should only be grouped whne it does exactly the same
2021-03-23 08207, 2021
CatQuest
as the other one)
2021-03-23 08239, 2021
sumedh has quit
2021-03-23 08228, 2021
Cyna[m]
reosarevok, bitmap you on ?
2021-03-23 08254, 2021
Cyna[m]
Im not very good at UI styling. here is a propotype of a simple notification clickable. Clicking on the notification area opens up a preview of past notifications with its preview and clicking on clear reverts back to main page. https://www.figma.com/proto/HVBTB4PAk7MBkfEqhkk9K…
2021-03-23 08214, 2021
Cyna[m]
Do let me know if this does not work or any of your suggestions :)
Picard question regarding this tag: https://picard-docs.musicbrainz.org/en/appendices… - the docs show it using the ID3 frame `TXXX:Artists` (lowercase), but Picard seems to write `TXXX:ARTISTS` (all caps). Which is correct?
Depending on which info you are interested in there is too much data squeezed in one-size-fits-all layout. Say, you want to know which roles a person had, in that case grouping by instrument would be harder to read than grouping by person then showing the instruments.
