[listenbrainz-server] amCap1712 opened pull request #1360 (master…timeline-notification): User Timeline: send notification events and potential bugfix https://github.com/metabrainz/listenbrainz-server…
2021-03-26 08551, 2021
sumedh has quit
2021-03-26 08525, 2021
_lucifer
Freso: since the GSoC student application period is approaching, GSoC proposals from earlier years should probably be removed from the forums (like it was done previous year).
_lucifer: Hai ! Should I remove the `playlist_created` event type in PR #1359 ? If I understand PR #1342 correctly we won't need it in the end.
2021-03-26 08500, 2021
_lucifer
Mr_Monkey, yeah, i think it isn't needed. #1359 only adds the notification event, for now it'll be playlist creation only but we should probably be able to use it for some other events as well if needed.
2021-03-26 08532, 2021
Mr_Monkey
And we definitely won't need a specific playlist_created event if we're using notifications for it. OK, I'll remove it.
2021-03-26 08549, 2021
Mr_Monkey
Done.
2021-03-26 08530, 2021
ruaok
Mr_Monkey: I saw the notification service gsoc proposal come in...
2021-03-26 08503, 2021
ruaok
in 2015 it was decided that the MeB community really needs site-wide notifications and that that was pretty critical for our community.
2021-03-26 08527, 2021
ruaok
and then we took almost no action and people have largely stopped asking for it.
2021-03-26 08535, 2021
ruaok
but the need clearly exists still.
2021-03-26 08548, 2021
ruaok
so, implementing it only for BB is... not ideal.
2021-03-26 08533, 2021
ruaok
but given the limited scope of GSoC, it is unclear if there is much room for us to change our approach....
2021-03-26 08527, 2021
Mr_Monkey
The project in question is about subscriptions more than notifications, unless I'm looking at the wrong one
2021-03-26 08554, 2021
ruaok
and it is just sending emails?
2021-03-26 08518, 2021
Mr_Monkey
That's the idea for the project, haven't read the particular proposal yet
2021-03-26 08527, 2021
Mr_Monkey
Which proposal are you looking at by the way?
2021-03-26 08540, 2021
Mr_Monkey
The one posted today?
2021-03-26 08541, 2021
ruaok
prabals
2021-03-26 08546, 2021
ruaok
yes
2021-03-26 08519, 2021
ruaok
ok, then that might be a decent fit for when we get around to creating the site wide notification. we can plug those BB notifications into the new system later.
2021-03-26 08527, 2021
ruaok
but moving accounts first.
2021-03-26 08505, 2021
Mr_Monkey
Yeah. The base of the project is to add a way to subscribe to entities and users first, and that we need regardless of the notification mechanism, so I think we're good.
2021-03-26 08522, 2021
ruaok
ok, kewl.
2021-03-26 08517, 2021
ruaok
sigh. banks. my banks online banking site has been down all week. why are banks consistently providing worse service than metadata hippies??
_lucifer: done. left some comments, but it looks quite sane. well done on the research. I'm actually surprised at how many services allow recording of history.
2021-03-26 08556, 2021
ruaok
hopefully we can get lots of people to help build support for apple and deezer.
2021-03-26 08536, 2021
Mr_Monkey
_lucifer: LGTM
2021-03-26 08554, 2021
_lucifer
thanks for the review, Mr_Monkey and ruaok :D !
2021-03-26 08527, 2021
_lucifer
I used VARCHAR because we use it elsewhere. I'll look into TEXT and how that differs from VARCHAR.
2021-03-26 08545, 2021
ruaok
see link above
2021-03-26 08520, 2021
Cyna[m]
bitmap: reosarevok is there a route on meb server I can check out for idea on implementing /getNotifications ?
2021-03-26 08554, 2021
Cyna[m]
*mb server
2021-03-26 08505, 2021
ruaok
alastairp: I'm trying to start the mbid_mapping_writer on gaga and the container starts, but the service isn't started.
2021-03-26 08508, 2021
ruaok
how is the docker/services/mbid_mapping_writer/mbid_mapping_writer.service file picked up and executed from the details of the container that was started?
