#metabrainz

/

      • _lucifer
      • 2021-03-30 08936, 2021

      • _lucifer
        1Mib for a js file looks large to me
      • 2021-03-30 08958, 2021

      • CatQuest
        sure I was just wondering what it literally meant (a cat apparently /s) and also saw that so was thinking it'd be interesting to see what people thoguht of it here
      • 2021-03-30 08935, 2021

      • alastairp
        _lucifer: I think it embeds the chart library too
      • 2021-03-30 08945, 2021

      • _lucifer
        makes sense then but in that case i think lazy loading the library would be better.
      • 2021-03-30 08954, 2021

      • alastairp
        it would mean that each time we make changes to that page you'd only have to download the code changes, not the chart library again
      • 2021-03-30 08958, 2021

      • alastairp
        which sounds good
      • 2021-03-30 08923, 2021

      • alastairp
        do all of these files also include the same bits of react?
      • 2021-03-30 08910, 2021

      • _lucifer
        i do not know if that's case but we definitely reuse some react components across pages so probably yes
      • 2021-03-30 08929, 2021

      • _lucifer
        when we add sentry to frontend, we should also look into not bundling it in our js files
      • 2021-03-30 08946, 2021

      • alastairp
        put it on the todo list :)
      • 2021-03-30 08949, 2021

      • Darkloke has quit
      • 2021-03-30 08913, 2021

      • ruaok
        alastairp: on the typesense front -- the problem is the same in docker and out. the second thing that was suggested was to log slow queries and possibly remove stop words from query terms. sigh.
      • 2021-03-30 08921, 2021

      • ruaok
        and it looks like that might be the problem. what I think I will do is use the recording artist pairs to do the exact lookup first and if that fails, go to typesense. I think that will drastically reduce the load on typesense. especially given the very large number of exact matches I was seeing.
      • 2021-03-30 08911, 2021

      • Zhele has quit
      • 2021-03-30 08907, 2021

      • _lucifer
        ruaok, alastairp: can we have nano or some another friendlier vi alternative on bono and prod servers?
      • 2021-03-30 08932, 2021

      • ruaok
        apt away, _lucifer
      • 2021-03-30 08943, 2021

      • _lucifer
        thanks! I just installed nano on lemmy.
      • 2021-03-30 08953, 2021

      • Zhele joined the channel
      • 2021-03-30 08940, 2021

      • ruaok
        `Copyright (C) 1998 Robert Kaye` woah.
      • 2021-03-30 08957, 2021

      • outsidecontext
        zas: https://community.metabrainz.org/t/musicbrainz-pi… :( I didn't know Chrome has finally pulled the plug on the FTP support
      • 2021-03-30 08946, 2021

      • Vera joined the channel
      • 2021-03-30 08909, 2021

      • reosarevok
        Vera: what's your API trouble?
      • 2021-03-30 08902, 2021

      • _lucifer
        ruaok, https://github.com/metabrainz/docker-server-confi… i'll begin updating the containers once you approve
      • 2021-03-30 08925, 2021

      • ruaok feels important all of the sudden
      • 2021-03-30 08937, 2021

      • ruaok
        _lucifer: just as an aside... the `start_listenbrainz_api_compat_nginx` container sometimes hiccups. it can do with regular restarting. so when you're doing a release, it can't hurt to restart that container.
      • 2021-03-30 08957, 2021

      • ruaok approves
      • 2021-03-30 08907, 2021

      • _lucifer
        understood, will do.
      • 2021-03-30 08911, 2021

      • ruaok
        thx
      • 2021-03-30 08924, 2021

      • Vera
        I got a list of songs with the spotify API which I want to add extra metadata to, specifically about the artists location/country. I'm working with python and tried the musicbrainzngs library, but I can't figure out how to get area info from that, and I haven't any experience with API's on the more basic level, like how to construct an API query
      • 2021-03-30 08924, 2021

      • Vera
        with the musicbrainz API. From spotify I have the ISRC btw. reosarevok
      • 2021-03-30 08954, 2021

      • ruaok
        Vera: ISRCs are not the best way to lookup data in MB, unfortunately.
      • 2021-03-30 08916, 2021

      • ruaok
        you may consider using this endpoint (it was a web and a API version): https://labs.api.listenbrainz.org/mbid-mapping?%5…
      • 2021-03-30 08940, 2021

      • ruaok
        this query gives you an recording_mbid of e97f805a-ab48-4c52-855e-07049142113d
      • 2021-03-30 08957, 2021

      • ruaok
        and an artist_credit_id of 65.
      • 2021-03-30 08953, 2021

      • ruaok
        reosarevok: is it possible to fetch artist credit ids from the WS?
      • 2021-03-30 08912, 2021

      • reosarevok
        Not at the moment
      • 2021-03-30 08926, 2021

      • ruaok
        bummer, one extra step then.
      • 2021-03-30 08932, 2021

      • ruaok
      • 2021-03-30 08903, 2021

      • ruaok
        which gives you an artist id, which allows you to: http://musicbrainz.org/ws/2/artist/8f6bd1e4-fbe1-…
      • 2021-03-30 08915, 2021

      • ruaok
        that response includes an area.
      • 2021-03-30 08924, 2021

      • ruaok
        does that make sense, Vera?
      • 2021-03-30 08932, 2021

      • reosarevok
      • 2021-03-30 08947, 2021

      • reosarevok
      • 2021-03-30 08912, 2021

      • reosarevok
        But not the artist area / country, for that you'd generally need to query the artist in question
      • 2021-03-30 08916, 2021

      • ruaok
        Vera: now you have two methods to use -- the IRSC method is easier, but not going to work as often.
      • 2021-03-30 08925, 2021

      • reosarevok
        Yeah, often we won't have the ISRC ourselves to match, sadly
      • 2021-03-30 08930, 2021

      • reosarevok
        Even if Spotify does
      • 2021-03-30 08902, 2021

      • Vera
        Thank you ! So  steps are: search artist + track name to get artist credit id, use this to get artist id, use that to get area info?
      • 2021-03-30 08946, 2021

      • ruaok
        yes, and you can choose to start with artist + track or IRSC.
      • 2021-03-30 08952, 2021

      • reosarevok
        Artist + track name give you artist ID already
      • 2021-03-30 08900, 2021

      • reosarevok
        But yeah, you'll need to then query the artist ID
      • 2021-03-30 08912, 2021

      • reosarevok
        One thing to keep in mind: artist areas aren't always countries :)
      • 2021-03-30 08919, 2021

      • reosarevok
        They can also be smaller locations (cities or whatnot)
      • 2021-03-30 08927, 2021

      • reosarevok
        That might or might not be a problem for you
      • 2021-03-30 08939, 2021

      • Vera
        oh that's a good one, that  might be a problem for visualisation
      • 2021-03-30 08948, 2021

      • Vera
        I'll see how it goes
      • 2021-03-30 08912, 2021

      • reosarevok
        Most cases do have the country, but say some NYC rappers have their district because that's what they "represent", stuff like that
      • 2021-03-30 08919, 2021

      • sumedh joined the channel
      • 2021-03-30 08920, 2021

      • reosarevok
        Some Catalonian artists have Catalonia, not Spain, etc
      • 2021-03-30 08934, 2021

      • ruaok
        Vera: what sort of visualisation are you working on, if I may ask?
      • 2021-03-30 08942, 2021

      • BharatKalluri has quit
      • 2021-03-30 08949, 2021

      • Vera
        I have to make a dashboard with bokeh. Not realtime, it can be made with a csv, but I do have to collect my own dataset. The exact visualisations will depend on how much time I have left when I have the data 😅
      • 2021-03-30 08934, 2021

      • ruaok
        how many artists are you looking up?
      • 2021-03-30 08954, 2021

      • Vera
        around 500 or so I think?
      • 2021-03-30 08933, 2021

      • _lucifer
        lb web updated. similar users and timeline fix working. :-D
      • 2021-03-30 08937, 2021

      • ruaok
        ok, not an insurmountable task. :)
      • 2021-03-30 08958, 2021

      • _lucifer
        ruaok, would you like to submit a playlist to test the notification feature?
      • 2021-03-30 08934, 2021

      • ruaok
        I'll do that in a bit. gotta finish my daily critical tasks first.
      • 2021-03-30 08940, 2021

      • _lucifer
        sure thanks!
      • 2021-03-30 08941, 2021

      • ruaok
        remind me in a bit, plz
      • 2021-03-30 08947, 2021

      • _lucifer
        will do.
      • 2021-03-30 08917, 2021

      • _lucifer
        is it safeto update the cron container rn?
      • 2021-03-30 08938, 2021

      • ruaok
        yes
      • 2021-03-30 08957, 2021

      • shivam-kapila
        _lucifer: dont forget to update beta too :)
      • 2021-03-30 08927, 2021

      • _lucifer
        will do.
      • 2021-03-30 08911, 2021

      • alastairp
        hi, I'm back
      • 2021-03-30 08914, 2021

      • ruaok starts working on MEB-121
      • 2021-03-30 08916, 2021

      • alastairp
        _lucifer: how's release going?
      • 2021-03-30 08930, 2021

      • _lucifer
        going well so far :)
      • 2021-03-30 08951, 2021

      • _lucifer
        just in time prepare for the next release :D
      • 2021-03-30 08904, 2021

      • alastairp
        great. tell me how I can help
      • 2021-03-30 08917, 2021

      • _lucifer
        the current release is done.
      • 2021-03-30 08941, 2021

      • _lucifer
        i checked with ps auxww that all process are running as well but i don't know how to check the cron container.
      • 2021-03-30 08924, 2021

      • alastairp
        there should be a process `cron -f`
      • 2021-03-30 08944, 2021

      • c1e0_ has quit
      • 2021-03-30 08950, 2021

      • _lucifer
        yup i see that. thanks.
      • 2021-03-30 08900, 2021

      • ruaok
        shivam-kapila: _lucifer `Users similar to you` buttons when I click on them switch to "Error!" :(
      • 2021-03-30 08918, 2021

      • _lucifer
        ruaok, i see the problem. the api url is wrong. i'll open a PR to fix that.
      • 2021-03-30 08924, 2021

      • alastairp
        _lucifer: this release that you just made is the "get all the pending stuff out of the way (including spotify reader)" one?
      • 2021-03-30 08909, 2021

      • _lucifer
        alastairp, yes except that spotify reader is pending.
      • 2021-03-30 08941, 2021

      • _lucifer
        that PR has a review pending from you.
      • 2021-03-30 08956, 2021

      • alastairp
        oh, sorry! I didn't realise that was the case
      • 2021-03-30 08958, 2021

      • alastairp
        looking now
      • 2021-03-30 08947, 2021

      • adhi001 joined the channel
      • 2021-03-30 08906, 2021

      • alastairp
        this was all the stuff we discussed the other week? moving all of the db interaction into one place, adding a 'broken' flag so that we could report error messages to users without deleting their config row, etc?
      • 2021-03-30 08945, 2021

      • _lucifer
        yes, we decided not to add a broken flag for now and add a ticket to get back to it later.
      • 2021-03-30 08915, 2021

      • alastairp
        fine by me
      • 2021-03-30 08917, 2021

      • sumedh has quit
      • 2021-03-30 08929, 2021

      • _lucifer
        so that we could move the spotify reader along for other upgrades
      • 2021-03-30 08911, 2021

      • alastairp
        and that was 2 weeks ago 🙊 sorry
      • 2021-03-30 08927, 2021

      • _lucifer
        no worries :)
      • 2021-03-30 08937, 2021

      • alastairp
        if it seems like I'm taking even longer than normal to respond to things please ping me here an explicitly tell me to look at something
      • 2021-03-30 08907, 2021

      • alastairp
        I added just a few small comments, but other than those it looks good to go
      • 2021-03-30 08952, 2021

      • _lucifer
        sure, i'll update the PR after working the fix for the follow button feed page.
      • 2021-03-30 08922, 2021

      • shivam-kapila
        _lucifer: if you are occupied I can help fix this
      • 2021-03-30 08938, 2021

      • _lucifer
        shivam-kapila: i think i have figured out the issue. if i turn out to be wrong, you can take over :). will let you know in ~10mins
      • 2021-03-30 08955, 2021

      • shivam-kapila
        cool
      • 2021-03-30 08907, 2021

      • culinko_ joined the channel
      • 2021-03-30 08916, 2021

      • culinko has quit
      • 2021-03-30 08909, 2021

      • c1e0 joined the channel
      • 2021-03-30 08942, 2021

      • _lucifer
        yup, its what i thought. we are not passing apiUrl down to follow button component.
      • 2021-03-30 08955, 2021

      • shivam-kapila
        exactly
      • 2021-03-30 08948, 2021

      • sumedh joined the channel
      • 2021-03-30 08905, 2021

      • shivam-kapila
        that was required before the follow APIs we moved to API namespace
      • 2021-03-30 08938, 2021

      • c1e0 has quit
      • 2021-03-30 08952, 2021

      • c1e0 joined the channel
      • 2021-03-30 08948, 2021

      • c1e0 has quit
      • 2021-03-30 08952, 2021

      • c1e0 joined the channel
      • 2021-03-30 08946, 2021

      • sampsyo has quit
      • 2021-03-30 08901, 2021

      • c1e0 has quit
      • 2021-03-30 08938, 2021

      • sumedh has quit
      • 2021-03-30 08953, 2021

      • sampsyo joined the channel
      • 2021-03-30 08949, 2021

      • culinko_ is now known as culinko
      • 2021-03-30 08942, 2021

      • c1e0 joined the channel
      • 2021-03-30 08931, 2021

      • BrainzGit
        [listenbrainz-server] amCap1712 opened pull request #1364 (master…hotfix): Pass API URL to FollowButton component https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-30 08914, 2021

      • c1e0 has quit
      • 2021-03-30 08925, 2021

      • _lucifer
        ruaok, i have updated beta with the fix. follow buttons work for me now. can you confirm?
      • 2021-03-30 08941, 2021

      • _lucifer
        i'll merge the fix PR then.
      • 2021-03-30 08959, 2021

      • ruaok
        confirmed.
      • 2021-03-30 08921, 2021

      • ruaok
        I looked at the PR, but it didn't make much sense, best to let some one else approve it.
      • 2021-03-30 08902, 2021

      • _lucifer
        since Mr_Monkey, isn't alastairp can you take a look?
      • 2021-03-30 08932, 2021

      • shivam-kapila
        The fix is accurate _lucifer. I left a tiny comment for consistency
      • 2021-03-30 08913, 2021

      • shivam-kapila
        once its done, I will approve it
      • 2021-03-30 08928, 2021

      • ruaok
        maybe tomorrow I can look why the user similarities are so low.
      • 2021-03-30 08958, 2021

      • shivam-kapila
        my similarity with myself is 85%
      • 2021-03-30 08903, 2021

      • _lucifer
        thanks shivam-kapila, i've made the change.
      • 2021-03-30 08926, 2021

      • _lucifer
        i'll deploy this to prod along with spotify reader PR later.
      • 2021-03-30 08915, 2021

      • shivam-kapila
        waiting for the tests to pass before waving the flag
      • 2021-03-30 08913, 2021

      • alastairp
        _lucifer: will this be replaced by the global prop later?
      • 2021-03-30 08931, 2021

      • _lucifer
        alastairp, yes.
      • 2021-03-30 08947, 2021

      • _lucifer
        i've a half done branch for that but its far from complete.
      • 2021-03-30 08951, 2021

      • alastairp
        sure, no problem
      • 2021-03-30 08940, 2021

      • _lucifer
        alastairp: regarding user friendly error messages, i checked the db its all "could not authenticate with spotify, please unlink and link again" or "could not refresh spotify api token"
      • 2021-03-30 08937, 2021

      • _lucifer
        i see those are our error messages from when we catch spotipy exception and raise SpotifyApiError.
      • 2021-03-30 08909, 2021

      • alastairp
        _lucifer: thanks for checking those. I don't know about emailing users "could not refresh", it doesn't make sense for them to know this
      • 2021-03-30 08923, 2021

      • alastairp
        "please unlink and link again" is fine though
      • 2021-03-30 08934, 2021

      • _lucifer
        alastairp, i have updated the PR.
      • 2021-03-30 08905, 2021

      • _lucifer
        while the tests run, do you want to discuss how we should proceed with the other upgrades tommorrow?
      • 2021-03-30 08910, 2021

      • BrainzGit
        [brainzutils-python] amCap1712 closed pull request #53 (master…msgpack): BU-32: PendingDeprecationWarning: msgpack.unpackb(... encoding=x) https://github.com/metabrainz/brainzutils-python/…