> <_lucifer> i do not understand how spotify knows the album name but not track or artist?
2021-04-06 09630, 2021
alastairp
is this output from spotify or from what we convert it to? Maybe we're converting it incorrectly? I see the "available_markets", so I assume it's spotify
2021-04-06 09648, 2021
alastairp
the fact that there's an album name, but no album id is really suspicious
2021-04-06 09636, 2021
_lucifer
alastairp, that's what i was thinking but that json came directly from spotify iirc. let me check it again
2021-04-06 09640, 2021
alastairp
potential question: you can load local files into spotify. what happens with the play history if you play one of those?
2021-04-06 09605, 2021
alastairp
> 3:44 PM <ruaok> sooo.. how do we feel about dealing with spamming users?
2021-04-06 09646, 2021
alastairp
I'm happy to flag them, and to maybe delete them, but I think to do either of that we should have explicit guidelines as to how we determine a spammer, and only ever follow those guides (or update them if we find that they're not sufficient)
2021-04-06 09606, 2021
alastairp
but I can see danger in just saying "oh, it feels spammy to me so I think we should delete it"
2021-04-06 09638, 2021
alastairp
_lucifer: where did you get to with the \0000 fix?
2021-04-06 09639, 2021
_lucifer
> you can load local files into spotify
2021-04-06 09645, 2021
_lucifer
i did not know that
2021-04-06 09603, 2021
reosarevok
Speaking of cleaning up spammers, we should probably run a removal based on the query on MBS-9356 at some point
_lucifer: I also had some thoughts about similarity/pearson, let me gather my thoughts on it and I'll ping you to have a discussion
2021-04-06 09634, 2021
_lucifer
yeah sure
2021-04-06 09611, 2021
_lucifer
the fix seems to work, the \0000 error hasn't returned yet
2021-04-06 09639, 2021
akshaaatt[m]
<_lucifer "akshaaatt: thanks for taking it "> Sure! I just checked and it isn't complete yet. I did fix an issue though. Will let you know when it's completely fixed.
2021-04-06 09649, 2021
_lucifer
👍
2021-04-06 09626, 2021
alastairp
reosarevok: oh, will the "no oauth tokens" make sure that people with an account at LB/etc don't get their account deleted?
2021-04-06 09655, 2021
reosarevok
I... dunno, tbh. I *think* that was the idea? But bitmap should confirm that before we run this :)
2021-04-06 09606, 2021
alastairp
yes right, It sounds like that's the reasoning behind it. sounds about right to me
because the idea is that these are unhandled errors, and we should get a notification so that we can handle them properly
2021-04-06 09619, 2021
_lucifer
yeah, i was thinking the same
2021-04-06 09644, 2021
_lucifer
once we merge this, we should get rid or the broad `Exception` clauses we have elsewehere
2021-04-06 09659, 2021
alastairp
we should never catch `Exception` broadly ;)
2021-04-06 09608, 2021
alastairp
all apps are running with the sentry-sdk upgrade now, right?
2021-04-06 09613, 2021
_lucifer
yes
2021-04-06 09614, 2021
alastairp
and the new sentry config in consul
2021-04-06 09619, 2021
_lucifer
yup
2021-04-06 09640, 2021
alastairp
so we should open a PR in docker-server-configs to remove the old public/private split, and then archive/delete the projects in sentry that are no longer used
2021-04-06 09647, 2021
_lucifer
yeah makes sense. i'll open a PR.
2021-04-06 09600, 2021
alastairp
🎉
2021-04-06 09636, 2021
alastairp
_lucifer: looking through tickets, I think you fixed LB-842 right?
quite nice those pictures. the delta was still very barren. In July the rice paddies will be flooded and everything will be green.
2021-04-06 09616, 2021
ruaok
THAT I want to see.
2021-04-06 09600, 2021
alastairp
many years ago we did a 3 day tour between figures and girona down the costa, and there was a _huge_ amount of rice and fruit. Kind of surprised me how much rice there was
2021-04-06 09631, 2021
alastairp
these little 2-stroke engines connected to a 200l plastic barrel of petrol going tick-tick-tick-tick-tick for pumping water around
alastairp: on #musicbrainz: "AcousticBrainz Extractor doesnt work anymore? Everytime "Submitted 0 feature file(s)" for albums, which dont have acouticbrainz data."?
2021-04-06 09644, 2021
alastairp
reosarevok: thanks. Did they say which submitter they were using?
2021-04-06 09648, 2021
reosarevok
No
2021-04-06 09600, 2021
alastairp
not clear if it's a problem with the files, the extractor, or submission
2021-04-06 09600, 2021
reosarevok
They're still there, you can ask :)
2021-04-06 09611, 2021
ruaok
alastairp: yes, so much water moving machinery and canals. must be amazing with all the green!
alastairp, there are a few small PRs open in BU. can you review those? i would prefer to merge them to avoid conflicts before working further
2021-04-06 09636, 2021
alastairp
_lucifer: yeah, sure. I'm just finishing up some stuff and then will look at those
2021-04-06 09651, 2021
_lucifer
sure, thanks!
2021-04-06 09650, 2021
BrainzGit
[musicbrainz-server] reosarevok opened pull request #2039 (schema-change-2021-q2…MBS-11459): MBS-11459: Create edit_data_type_info function on mirrors https://github.com/metabrainz/musicbrainz-server/…
2021-04-06 09626, 2021
adhi001
I'm looking to make a proposal for GSOC about adding html pages in listenbrainz that display data missing from MB. When matching msids and mbids, if we don't get a match then are those considered missing listens?
yes, _lucifer is right -- we have an endpoint that shows data that we know to be missing from LB.
2021-04-06 09659, 2021
ruaok
what we need now is a method to display this data to the user and to allow them to add the data to MB.
2021-04-06 09651, 2021
adhi001
So since we have that API the work would be to just use the API, show the user that these listens are missing and lead them to MB add data pages with some of the data prefilled right?
2021-04-06 09659, 2021
ruaok
and when the data is known to not be in MB, then we don't have MBIDs, only MSIDs
2021-04-06 09615, 2021
ruaok
adhi001: yes, exactly that.
2021-04-06 09648, 2021
ruaok
what would be nice is to make these pages work for both releases and for artists.
and you see that it is a list of listens that is missing. the data is not organized into artists or releases.
2021-04-06 09634, 2021
adhi001
ruaok: Thanks for the api url and the suggestions. I'll work on them.
2021-04-06 09651, 2021
ruaok
and recordings alone should only be added to MB in some cases -- ideally we would add whole albums to MB.
2021-04-06 09601, 2021
ruaok
adhi001: ok, ping me if you have more questions.
2021-04-06 09628, 2021
adhi001
sure
2021-04-06 09641, 2021
ruaok
adhi001: I guess what I am saying is that recordings need to be clustered into albums, so that albums can be submitted to MB
2021-04-06 09655, 2021
BrainzGit
[bookbrainz-site] MonkeyDo merged pull request #583 (master…fix/bug_blocking_profile_edit): fix(profile): Fix bug where profile page does not load due to undefined area (BB-600) https://github.com/bookbrainz/bookbrainz-site/pul…
2021-04-06 09606, 2021
ruaok
we'll clearly need a "nope, your missing data is bogus, I found it here" button.
2021-04-06 09617, 2021
adhi001
One more thing @ruaok , I made the api call and I see that for most songs returned, an entry in MusicBrainz is present but is not being matched properly. Should we give the user a feature to choose from possibly similar recordings?
2021-04-06 09647, 2021
ruaok
adhi001: that is exactly what I meant by "we'll clearly need a "nope, your missing data is bogus, I found it here" button. "
2021-04-06 09656, 2021
adhi001
Okay
2021-04-06 09620, 2021
ruaok
so, yes. and also the missing data we have now, will improve in the next few weeks. meaning that some of the obvious matches should go away.
alastairp: remember the MBID mapping table I've been talking about -- one that combines the mapping table and matching log into one? I think it might be good to add a "user" field to it, so that we can store user contributed matches, as a result from providing a matching MBID for a given track.
2021-04-06 09627, 2021
BrainzGit
[bookbrainz-site] MonkeyDo closed pull request #595 (master…feature/collection): Feat[BB-607] : display total number of entity present in a particular collection https://github.com/bookbrainz/bookbrainz-site/pul…
2021-04-06 09649, 2021
alastairp
yeah, tracking that seems like a good idea
2021-04-06 09640, 2021
alastairp
ruaok: oh, you just reminded me, this morning I added some thoughts to some comments that you made over the weekend (spam users) if you want to continue that discussion
2021-04-06 09602, 2021
ruaok
sure.
2021-04-06 09639, 2021
ruaok
_lucifer: if you ever find yourself bored and want to knock out an easy feature, we need a "report this user" button in LB.
2021-04-06 09644, 2021
ruaok
;D
2021-04-06 09655, 2021
_lucifer
👍
2021-04-06 09609, 2021
BrainzGit
[bookbrainz-site] MonkeyDo closed pull request #582 (master…snyk-fix-02fe85a6d90a8c24bb633f8362b39806): [Snyk] Security upgrade snyk from 1.385.0 to 1.465.0 https://github.com/bookbrainz/bookbrainz-site/pul…
.jpeg){kind=link}
