#metabrainz

[musicbrainz-android] akshaaatt opened pull request #65 (master…tagger-fix): Tagger Fix https://github.com/metabrainz/musicbrainz-andro...

_lucifer: I made a slight update to try and fix the tagger situation. However I cannot test it yet since I do not possess an Android 11 device yet.

akshaaatt[m]: thanks for taking it up. i don't have an Android 11 device either. i'll try to setup an emulator and test the fix in a day or two.

[musicbrainz-server] reosarevok opened pull request #2037 (master…MBS-11559): MBS-11559: Specify tracklist is empty in Remove medium edits https://github.com/metabrainz/musicbrainz-serve...

morning

> <_lucifer> i do not understand how spotify knows the album name but not track or artist?

is this output from spotify or from what we convert it to? Maybe we're converting it incorrectly? I see the "available_markets", so I assume it's spotify

the fact that there's an album name, but no album id is really suspicious

alastairp, that's what i was thinking but that json came directly from spotify iirc. let me check it again

potential question: you can load local files into spotify. what happens with the play history if you play one of those?

> 3:44 PM <ruaok> sooo.. how do we feel about dealing with spamming users?

I'm happy to flag them, and to maybe delete them, but I think to do either of that we should have explicit guidelines as to how we determine a spammer, and only ever follow those guides (or update them if we find that they're not sufficient)

but I can see danger in just saying "oh, it feels spammy to me so I think we should delete it"

_lucifer: where did you get to with the \0000 fix?

> you can load local files into spotify

i did not know that

Speaking of cleaning up spammers, we should probably run a removal based on the query on MBS-9356 at some point

MBS-9356: Remove existing editors with no confirmed email and no OAuth tokens/edits/votes https://tickets.metabrainz.org/browse/MBS-9356

_lucifer: I also had some thoughts about similarity/pearson, let me gather my thoughts on it and I'll ping you to have a discussion

yeah sure

the fix seems to work, the \0000 error hasn't returned yet

<_lucifer "akshaaatt: thanks for taking it "> Sure! I just checked and it isn't complete yet. I did fix an issue though. Will let you know when it's completely fixed.

👍

reosarevok: oh, will the "no oauth tokens" make sure that people with an account at LB/etc don't get their account deleted?

I... dunno, tbh. I *think* that was the idea? But bitmap should confirm that before we run this :)

yes right, It sounds like that's the reasoning behind it. sounds about right to me

this is interesting: https://github.blog/2021-04-05-behind-githubs-n...

alastairp, in context of https://github.com/metabrainz/listenbrainz-serv..., do we want to report these errors to sentry?

500 errors, yes

because the idea is that these are unhandled errors, and we should get a notification so that we can handle them properly

yeah, i was thinking the same

once we merge this, we should get rid or the broad `Exception` clauses we have elsewehere

we should never catch `Exception` broadly ;)

all apps are running with the sentry-sdk upgrade now, right?

yes

and the new sentry config in consul

yup

so we should open a PR in docker-server-configs to remove the old public/private split, and then archive/delete the projects in sentry that are no longer used

yeah makes sense. i'll open a PR.

🎉

_lucifer: looking through tickets, I think you fixed LB-842 right?

LB-842: Parse Retry-After header as int before using in sleep https://tickets.metabrainz.org/browse/LB-842

yes

alastairp: regarding https://travis-ci.org/github/metabrainz/brainzu..., it seems python2 does not have the builtins module?

😭

https://pypi.org/project/future/ maybe?

otherwise, we should seriously consider a final python 2 version of BU

do you think AB needs something more from BU?

I was thinking that with all of the changes to the caching API we could do a 2.0 release of BU, perhaps that's enough to cut py2 support too

it'll give me a kick to finally try and push the py3 upgrade here too

otherwise. let's merge other open BU PRs except redis sets and do the final release

I'm tempted to just say screw it, and do python 3 only from now on

we'll have to leave AB out in the cache upgrade then. though none of the changes affect it anyways i guess so its just a formality

yeah, right. it's a nice-to-have, but not absolutely required

ok, then let's drop python2 support from now in BU. 1.18.1 was the last python2 compatible release.

I guess nothing stopping us from branching 1.18 and making subsequent point releases if urgently needed

yeah right

now that we added exact versions of flask/etc to downstream apps we can upgrade there if there's a security update too

so for next BU release we go 2.0.*?

yes!

nice!

do we have some python2 specific things that can now be removed?

BU-28

BU-28: Caching a timezone aware datetime loses the timezone https://tickets.metabrainz.org/browse/BU-28

I use `six.ensure_text` in metrics, but I don't see any other usage of six

we can do types

also, i see we are are doing custom formatting of datetime. we can replace that with `toisofomat`

and the py2 tests

yup

hi ruaok

I thought you were going to garrotxa

we were in l'aldea for biking in the delta. yesterday we moved to Tarragona. doing some work this morning, but faffing about the city later

anything critical that needs my attention?

don't think so

[bookbrainz-site] trishnakalita660 opened pull request #597 (master…trishna): Trishna https://github.com/bookbrainz/bookbrainz-site/p...

a friend of mine was doing bike packing around the delta + inland over the weekend. some amazing scenery there

https://usercontent.irccloud-cdn.com/file/TEm1N... https://usercontent.irccloud-cdn.com/file/m9rM2...

quite nice those pictures. the delta was still very barren. In July the rice paddies will be flooded and everything will be green.

THAT I want to see.

many years ago we did a 3 day tour between figures and girona down the costa, and there was a _huge_ amount of rice and fruit. Kind of surprised me how much rice there was

these little 2-stroke engines connected to a 200l plastic barrel of petrol going tick-tick-tick-tick-tick for pumping water around

alastairp: on #musicbrainz: "AcousticBrainz Extractor doesnt work anymore? Everytime "Submitted 0 feature file(s)" for albums, which dont have acouticbrainz data."?

reosarevok: thanks. Did they say which submitter they were using?

No

not clear if it's a problem with the files, the extractor, or submission

They're still there, you can ask :)

alastairp: yes, so much water moving machinery and canals. must be amazing with all the green!

[musicbrainz-server] reosarevok opened pull request #2038 (master…MBS-11558): MBS-11558: Show current tracklist data on removal edits https://github.com/metabrainz/musicbrainz-serve...

alastairp, there are a few small PRs open in BU. can you review those? i would prefer to merge them to avoid conflicts before working further

_lucifer: yeah, sure. I'm just finishing up some stuff and then will look at those

sure, thanks!

[musicbrainz-server] reosarevok opened pull request #2039 (schema-change-2021-q2…MBS-11459): MBS-11459: Create edit_data_type_info function on mirrors https://github.com/metabrainz/musicbrainz-serve...

I'm looking to make a proposal for GSOC about adding html pages in listenbrainz that display data missing from MB. When matching msids and mbids, if we don't get a match then are those considered missing listens?

ruaok would be able to better answer that. also we already have an endpoint to fetch the missing data https://github.com/metabrainz/listenbrainz-serv...

hi adhi001.

hi @ruaok

yes, _lucifer is right -- we have an endpoint that shows data that we know to be missing from LB.

what we need now is a method to display this data to the user and to allow them to add the data to MB.

So since we have that API the work would be to just use the API, show the user that these listens are missing and lead them to MB add data pages with some of the data prefilled right?

and when the data is known to not be in MB, then we don't have MBIDs, only MSIDs

adhi001: yes, exactly that.

what would be nice is to make these pages work for both releases and for artists.

adhi001: that URL that _lucifer posted, here is the actual API URL: https://api.listenbrainz.org/1/missing/musicbra...

and you see that it is a list of listens that is missing. the data is not organized into artists or releases.

ruaok: Thanks for the api url and the suggestions. I'll work on them.

and recordings alone should only be added to MB in some cases -- ideally we would add whole albums to MB.

adhi001: ok, ping me if you have more questions.

sure

adhi001: I guess what I am saying is that recordings need to be clustered into albums, so that albums can be submitted to MB

[bookbrainz-site] MonkeyDo merged pull request #583 (master…fix/bug_blocking_profile_edit): fix(profile): Fix bug where profile page does not load due to undefined area (BB-600) https://github.com/bookbrainz/bookbrainz-site/p...

we'll clearly need a "nope, your missing data is bogus, I found it here" button.

One more thing @ruaok , I made the api call and I see that for most songs returned, an entry in MusicBrainz is present but is not being matched properly. Should we give the user a feature to choose from possibly similar recordings?

adhi001: that is exactly what I meant by "we'll clearly need a "nope, your missing data is bogus, I found it here" button. "

Okay

so, yes. and also the missing data we have now, will improve in the next few weeks. meaning that some of the obvious matches should go away.

Project bookbrainz-site build #3829: passed in 5 min 4 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

alastairp: remember the MBID mapping table I've been talking about -- one that combines the mapping table and matching log into one? I think it might be good to add a "user" field to it, so that we can store user contributed matches, as a result from providing a matching MBID for a given track.

[bookbrainz-site] MonkeyDo closed pull request #595 (master…feature/collection): Feat[BB-607] : display total number of entity present in a particular collection https://github.com/bookbrainz/bookbrainz-site/p...

yeah, tracking that seems like a good idea

ruaok: oh, you just reminded me, this morning I added some thoughts to some comments that you made over the weekend (spam users) if you want to continue that discussion

sure.

_lucifer: if you ever find yourself bored and want to knock out an easy feature, we need a "report this user" button in LB.

👍

[bookbrainz-site] MonkeyDo closed pull request #582 (master…snyk-fix-02fe85a6d90a8c24bb633f8362b39806): [Snyk] Security upgrade snyk from 1.385.0 to 1.465.0 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] MonkeyDo merged pull request #585 (master…dependabot/npm_and_yarn/y18n-3.2.2): chore(deps): bump y18n from 3.2.1 to 3.2.2 https://github.com/bookbrainz/bookbrainz-site/p...

[musicbrainz-server] reosarevok opened pull request #2040 (schema-change-2021-q2…MBS-11457): MBS-11457: Drop the series ordering_attribute column https://github.com/metabrainz/musicbrainz-serve...

> if you ever find yourself bored

So, in 2023 when _lucifer's todo list runs out? XD

lol

Mr_Monkey: no, I have my money on mid next week.

I think _lucifer runs at a higher clock speed somehow. Overclocking much?