#metabrainz

/

      • _lucifer
        alastairp: cool. let me know if there is something for me to do.
      • 2021-04-12 10247, 2021

      • _lucifer
        i was trying to add the `finish` files but then I thought to wait till the utils script with the common functions was added and then use it directly.
      • 2021-04-12 10241, 2021

      • Mr_Monkey
        CatQuest: Thanks for the ticket. I'm not 100% sure this one can be resolved but I'll have a look
      • 2021-04-12 10228, 2021

      • Mr_Monkey
        They're effectively not links and we're not navigating to a new page when these buttons are clicked, so I'm not expecting regular link use to work
      • 2021-04-12 10212, 2021

      • alastairp
        Mr_Monkey: but I should also be able to open https://listenbrainz.org/user/mr_monkey?max_ts=16… in a new tab and have it correct load that page, right?
      • 2021-04-12 10221, 2021

      • Mr_Monkey
        Yes
      • 2021-04-12 10222, 2021

      • alastairp
        which is what the URL changes to when I click Older
      • 2021-04-12 10246, 2021

      • Mr_Monkey
        We might be able to rewrite the button as an actual html link
      • 2021-04-12 10206, 2021

      • alastairp
        haha
      • 2021-04-12 10207, 2021

      • alastairp
        it's a link!
      • 2021-04-12 10226, 2021

      • alastairp
        I remember that discussion from a few weeks ago
      • 2021-04-12 10253, 2021

      • sumedh has quit
      • 2021-04-12 10210, 2021

      • Mr_Monkey
        Well, it's a link element but with an 'onclick' rather than an `href`, so not really a link
      • 2021-04-12 10238, 2021

      • alastairp
        can it have both?
      • 2021-04-12 10238, 2021

      • sumedh joined the channel
      • 2021-04-12 10201, 2021

      • Mr_Monkey
        How does one combine single page app-like buttons that don't navigate and actual navigating links? I don't know.
      • 2021-04-12 10215, 2021

      • Mr_Monkey
        A naive approach didn't work. if there's an href it'll navigate away. I'll see if there's a way to stop the regular event propagation.
      • 2021-04-12 10245, 2021

      • alastairp
        I remember at least in jquery days it was just a matter of e.preventDefault()
      • 2021-04-12 10203, 2021

      • Mr_Monkey
        Yeah, that's what I'm thinking, and might just work.
      • 2021-04-12 10235, 2021

      • Mr_Monkey
        Not sure how that plays with "open in a new tab" sort of thing though.
      • 2021-04-12 10245, 2021

      • alastairp
        I'm pretty sure it'll work in open in new tab
      • 2021-04-12 10255, 2021

      • MRiddickW has quit
      • 2021-04-12 10255, 2021

      • alastairp
        because it just takes the value of href and puts it in a new tab
      • 2021-04-12 10258, 2021

      • alastairp
        doesn't run the click handler
      • 2021-04-12 10238, 2021

      • sumedh has quit
      • 2021-04-12 10249, 2021

      • sumedh joined the channel
      • 2021-04-12 10212, 2021

      • reosarevok
        ruaok: I'll look
      • 2021-04-12 10223, 2021

      • ruaok
        thx
      • 2021-04-12 10210, 2021

      • yvanzo
        That can be a temporary load issue on CAA but there should be a way to check if that is the case.
      • 2021-04-12 10252, 2021

      • reosarevok
        yvanzo: that was 2 days ago, it worked fine today anyway :)
      • 2021-04-12 10212, 2021

      • alastairp
        hrm
      • 2021-04-12 10228, 2021

      • alastairp
        just had to look up how to say something in english that I knew in spanish
      • 2021-04-12 10231, 2021

      • alastairp
        that's a new feeling
      • 2021-04-12 10215, 2021

      • reosarevok
        Welcome to the next stage of bilingualism, "I speak two languages badly"!
      • 2021-04-12 10227, 2021

      • ruaok
        yep, been there a many times in my life, though with different languages, but hey
      • 2021-04-12 10222, 2021

      • rdswift_ joined the channel
      • 2021-04-12 10245, 2021

      • rdswift has quit
      • 2021-04-12 10247, 2021

      • rdswift_ is now known as rdswift
      • 2021-04-12 10248, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #1383 (master…monkey-pagination-links): LB-864: Fix html links used for pagination https://github.com/metabrainz/listenbrainz-server…
      • 2021-04-12 10206, 2021

      • Mr_Monkey
        CatQuest, alastairp : piece of cake ^
      • 2021-04-12 10226, 2021

      • _lucifer
        Mr_Monkey: currently i am doing something like this https://github.com/metabrainz/listenbrainz-server… to pass around youtube credentials. is the right way to do or should i do something else?
      • 2021-04-12 10228, 2021

      • Mr_Monkey
        alastairp: Re: loosing one's native language: The more languages you add in the mix, the worst it gets.
      • 2021-04-12 10230, 2021

      • Mr_Monkey
        _lucifer: That looks about right at first glance (seems like we do the same thing as with the spotify user), but I haven't looked at the PR yet so I'm not sure.
      • 2021-04-12 10230, 2021

      • Mr_Monkey
        We previously talked about app-wide props that we could use react context for (in another PR) so I assume this could change a bit in the future anyway as we refactor it.
      • 2021-04-12 10214, 2021

      • _lucifer
        Yeah, I want to make it some way which works for both youtube and spotify. currently we have to pass both separetely everywhere.
      • 2021-04-12 10200, 2021

      • loujine
        what's the procedure to register a bot? just asking here I guess? https://musicbrainz.org/user/loujin_bot
      • 2021-04-12 10247, 2021

      • _lucifer
        ruaok, alastairp: what should we do for migrating the existing spotify users to new schema ?
      • 2021-04-12 10221, 2021

      • alastairp
        _lucifer: this is for the new player?
      • 2021-04-12 10225, 2021

      • _lucifer
        yes.
      • 2021-04-12 10233, 2021

      • ruaok
        create a SQL update script.
      • 2021-04-12 10233, 2021

      • alastairp
        it is just as easy as moving some values to a new table?
      • 2021-04-12 10205, 2021

      • alastairp
        a python update script is OK too if we need to do more things (connect to spotify to get more data, etc)
      • 2021-04-12 10212, 2021

      • ruaok
      • 2021-04-12 10237, 2021

      • ruaok
        this script should create the new tables, move the data, but not delete the old tables yet.
      • 2021-04-12 10241, 2021

      • mckean has quit
      • 2021-04-12 10255, 2021

      • _lucifer
        we don't need to anything extra other than moving the data. so sql script should be enough.
      • 2021-04-12 10257, 2021

      • _lucifer
        👍
      • 2021-04-12 10259, 2021

      • ruaok
        this way we can run the migration and if something borks, we can re do it.
      • 2021-04-12 10207, 2021

      • _lucifer
        makes sense.
      • 2021-04-12 10222, 2021

      • ruaok
        then once we're happy with the migration, make a new PR to delete the old tables.
      • 2021-04-12 10230, 2021

      • mckean joined the channel
      • 2021-04-12 10235, 2021

      • reosarevok
        loujine: yes
      • 2021-04-12 10252, 2021

      • reosarevok
        loujine: marked with the bot flag. What are you planning to do with it?
      • 2021-04-12 10254, 2021

      • alastairp
        if you didn't know, sql has 'INSERT INTO .... SELECT FROM'
      • 2021-04-12 10230, 2021

      • _lucifer
        oh cool! yeah, i was wondering if we had to dump the data first from the existing table.
      • 2021-04-12 10238, 2021

      • _lucifer
        won't need to do that now.
      • 2021-04-12 10230, 2021

      • ruaok
        there is also SELECT ... INTO .. FROM -- a bit more flexible, I think. let me know if you run into issues.
      • 2021-04-12 10244, 2021

      • _lucifer
        sure, thanks!
      • 2021-04-12 10217, 2021

      • CatQuest
        :o that was fast
      • 2021-04-12 10219, 2021

      • CatQuest
        1m Mr_Monkey
      • 2021-04-12 10220, 2021

      • CatQuest
        erh
      • 2021-04-12 10223, 2021

      • CatQuest
        !m Mr_Monkey
      • 2021-04-12 10223, 2021

      • BrainzBot
        You're doing good work, Mr_Monkey!
      • 2021-04-12 10229, 2021

      • loujine
        reosarevok: adding bnf / doremus links, i.e. the todo lists on https://loujine.github.io/musicbrainz-sparql/
      • 2021-04-12 10203, 2021

      • CatQuest
        [13:05] <Mr_Monkey> alastairp: Re: loosing one's native language:
      • 2021-04-12 10204, 2021

      • CatQuest
        !me laughs in "wait how do I say this is norwegian"
      • 2021-04-12 10210, 2021

      • reosarevok
        Ok :) Ideally you'd have the code you'll run up on github
      • 2021-04-12 10216, 2021

      • reosarevok
        But the idea seems fine
      • 2021-04-12 10242, 2021

      • loujine
        starting conservatively i.e. where we already have trustworthy wd links in the middle, and possibly doing alignment on names later
      • 2021-04-12 10205, 2021

      • CatQuest facepalm
      • 2021-04-12 10217, 2021

      • loujine
        yes I'll have something on github first, I started converting parts of Freso's bot to python3 but I haven't pushed anything yet
      • 2021-04-12 10201, 2021

      • reosarevok
        Ok
      • 2021-04-12 10212, 2021

      • reosarevok
        I have some updated bits for fresobot too on my repo, if needed
      • 2021-04-12 10213, 2021

      • yvanzo
        Do not hesitate to use test.musicbrainz.org as a playground if needed :)
      • 2021-04-12 10219, 2021

      • reosarevok
        I updated the code to edit rels
      • 2021-04-12 10228, 2021

      • reosarevok
        I think you might not need it, but
      • 2021-04-12 10237, 2021

      • loujine
        I'll start with test.mb.o for sure (I tried https://test.musicbrainz.org/edit/70320463 waouh, already two months ago)
      • 2021-04-12 10252, 2021

      • BrainzGit
        [listenbrainz-server] amCap1712 opened pull request #1384 (master…youtube-db): Add SQL scripts for connecting new music services and migrating user data https://github.com/metabrainz/listenbrainz-server…
      • 2021-04-12 10258, 2021

      • _lucifer
        alastairp, ruaok, Mr_Monkey: i wanted to deploy the implementation and test on lb test or beta so would be nice to get the db changes in before the rest of the PR.
      • 2021-04-12 10258, 2021

      • ruaok
        good thinking.
      • 2021-04-12 10212, 2021

      • Mr_Monkey
        👍
      • 2021-04-12 10211, 2021

      • sumedh has quit
      • 2021-04-12 10254, 2021

      • MRiddickW joined the channel
      • 2021-04-12 10236, 2021

      • ruaok
        [OT] its an exciting time for microprocessors - I didn't understand the nvidia purchase of arm, but this explains it: https://www.nextplatform.com/2021/03/30/arms-v9-a…
      • 2021-04-12 10210, 2021

      • ruaok
        the Apple M1 processor is already proof that processors, rather then GPUs are becoming more specialised over time.
      • 2021-04-12 10201, 2021

      • alastairp
        Mr_Monkey spotify keeps recommending me the Coconut song now. thanks a lot
      • 2021-04-12 10215, 2021

      • Mr_Monkey
        Put the lime in the coconut
      • 2021-04-12 10221, 2021

      • Mr_Monkey
        And drink it all up
      • 2021-04-12 10233, 2021

      • ruaok says so while awaiting the delivery of an AMD based machine
      • 2021-04-12 10252, 2021

      • Mr_Monkey
      • 2021-04-12 10239, 2021

      • alastairp
        ruaok: yeah, people were laughing at the custom decode json instruction but it turns out when you can do micro optimisations like that then you get incredible performance/W in return
      • 2021-04-12 10200, 2021

      • alastairp
        I guess hardware video decode has been a thing for yonks now
      • 2021-04-12 10213, 2021

      • ruaok
        not I. our use of ujson makes it clear why this is no laughing matter.
      • 2021-04-12 10234, 2021

      • alastairp
        it'll be interesting to see if this will affect language and data design decisions in ~20 years
      • 2021-04-12 10245, 2021

      • ruaok
        yea and hardware video decode was the first obvious task. speech recognition and ML are next.
      • 2021-04-12 10217, 2021

      • alastairp
        if you have a dedicated low power core to evaluate tensorflow models, what does that make tensorflow?
      • 2021-04-12 10242, 2021

      • ruaok
        a lot more accessible?
      • 2021-04-12 10255, 2021

      • alastairp
        everyone's going to stick with the minimal compatible featureset to be able to continue to take advantage of custom silicon
      • 2021-04-12 10200, 2021

      • alastairp
        even if something better comes along?
      • 2021-04-12 10220, 2021

      • alastairp
        though perhaps that's no different from x86_64 -> x86 -> 80486 -> 8088
      • 2021-04-12 10237, 2021

      • alastairp
        hacks on top of hacks in order to keep supporting the past
      • 2021-04-12 10241, 2021

      • ruaok
        I love RISC V and that people can now dial up custom CPUs and ship them off to TSMC and presto make their own customer systems, often as SoC.
      • 2021-04-12 10245, 2021

      • ruaok
        super exciting.
      • 2021-04-12 10252, 2021

      • alastairp
        if you have a new hypothetical video codec that is half the size of h264, but you need to decode it in software instead of hardware, where's the tradeoff? will we just get complacent with what the CPUs can do and stop advancing?
      • 2021-04-12 10255, 2021

      • ruaok
        *custom
      • 2021-04-12 10227, 2021

      • ruaok
        I doubt it. I see this as an evolution that you cannot ignore.
      • 2021-04-12 10202, 2021

      • ruaok
        classic CPUs -> CPUS + floating point -> Multi core CPU -> Multi function, multi core CPU.
      • 2021-04-12 10217, 2021

      • alastairp
        yep, that's definitely true too
      • 2021-04-12 10228, 2021

      • alastairp
        got sse4? use it, otherwise emulate down to sse2
      • 2021-04-12 10242, 2021

      • ruaok
        its the 2nd evolutionary step past moore
      • 2021-04-12 10236, 2021

      • ruaok
        and given that more cores are not necessarily going to give increased performance because of software bottlenecks, custom CPUs have new and exciting possibilities for performance improvement.
      • 2021-04-12 10248, 2021

      • ruaok
        ignoring this trend would be fatal.
      • 2021-04-12 10214, 2021

      • ruaok
        heck, even the RPi now has 4 cores. my watch has 2. RPi pico has two for crying out loud!
      • 2021-04-12 10227, 2021

      • ruaok
        which of course, is massively cool.
      • 2021-04-12 10230, 2021

      • ruaok
        speaking of performance, alastairp, have you seen: https://suade.org/dev/12-requests-per-second-with…
      • 2021-04-12 10237, 2021

      • alastairp
        Jeff Geerling's pi hacks have been super cool. what you can do with such a small soc is neat
      • 2021-04-12 10242, 2021

      • alastairp
        ruaok: yeah, I did see it when it came up
      • 2021-04-12 10217, 2021

      • ruaok
        its something we need to look at before too long. I believe our performance for our python sites is quite shit too.
      • 2021-04-12 10222, 2021

      • alastairp
        though from what I can tell it seems to be a "Hey, we have a cool async web framework that is _soooo_ much faster than flask"
      • 2021-04-12 10252, 2021

      • alastairp
        I mean, this isn't making the python code itself any faster. and this is why we spin up 300 workers on uwsgi anyway
      • 2021-04-12 10232, 2021

      • ruaok
        I'm thining longer term with more scalability. I think a low hanging fruit is to try pypy
      • 2021-04-12 10233, 2021

      • alastairp
        my gut feel is it's one of those "this is a problem if you want everything to be perfect, but if 'meh, let's throw more uwsgis at the problem' is good enough for you then it's not really a practical issue"
      • 2021-04-12 10244, 2021

      • alastairp
        but I've not considered it in too much detail
      • 2021-04-12 10211, 2021

      • ruaok
        before too long I want to try running our web containers in pypy and if it is possible and what kind of change we can see.
      • 2021-04-12 10223, 2021

      • alastairp
        it's possible that if we get to the point where we need to set up a second web server, we could instead look at more detailed optimisations and see if that gets us some breathing room and how much
      • 2021-04-12 10236, 2021

      • ruaok
        yes, agreed.
      • 2021-04-12 10214, 2021

      • ruaok
        though, I think one usage pattern that is going to be different from last.fm vs LB is that many listens will come from services, rather than time critical WS requests.
      • 2021-04-12 10235, 2021

      • alastairp
        yeah, for sure
      • 2021-04-12 10251, 2021

      • ruaok
        in essence that makes the optimization of the spotify reader, which does not use a web framework key for us.
      • 2021-04-12 10207, 2021

      • ruaok
        and of course the ingestion pipeline which we know needs optimizing.
      • 2021-04-12 10236, 2021

      • alastairp
        oh, that reminds me
      • 2021-04-12 10252, 2021

      • alastairp
        I saw that _lucifer opened a ticket about the ujson upgrade
      • 2021-04-12 10207, 2021

      • alastairp
        LB-504
      • 2021-04-12 10207, 2021

      • BrainzBot
        LB-504: Upgrade ujson version in listenbrainz https://tickets.metabrainz.org/browse/LB-504
      • 2021-04-12 10224, 2021

      • alastairp
        I think I found out why we got so much confusion with "are we using timestamps or dates"
      • 2021-04-12 10246, 2021

      • alastairp
        because the current ujson that we have transparently converts python datetime objects to timestamps
      • 2021-04-12 10230, 2021

      • ruaok
        where do we use custom serialization?
      • 2021-04-12 10232, 2021

      • alastairp
        and I suspect at some time we had a specific class -> json deserialiser that took care of this, but at one point in time we forgot to use it and ujson magically converted it to timestamp
      • 2021-04-12 10246, 2021

      • ruaok
        for PG maybe?
      • 2021-04-12 10221, 2021

      • ruaok
        my gripes with timestamps in LB is that we have both datetime and epoch timestamps.