#metabrainz

/

      • alastairp
        to do the import we need all of the musicbrainz website + dependencies. I _think_ that's where some of the size comes from, though I had a look and thought that it was only a few hundred mb

        • 2021-04-12 10245, 2021

      • alastairp
        it may be the base image

        • 2021-04-12 10222, 2021

      • _lucifer
        i remember looking at the base image its just postgres i think

        • 2021-04-12 10228, 2021

      • _lucifer
        but let me check again

        • 2021-04-12 10230, 2021

      • prabal joined the channel

        • 2021-04-12 10236, 2021

      • yvanzo
        URLCleanup is already used by the current UI, ExternalLinksEditor must just be reworked (deeply or rewritten) to support new URLCleanup capabilities.

        • 2021-04-12 10254, 2021

      • prabal
        Mr_Monkey: ping

        • 2021-04-12 10255, 2021

      • alastairp
        https://github.com/wagoodman/dive this tool is useful for exploring the disk usage of various layers of an image

        • 2021-04-12 10203, 2021

      • Mr_Monkey
        pong

        • 2021-04-12 10212, 2021

      • yvanzo
        yyoung: this is what you wrote for "week 5" actually :)

        • 2021-04-12 10214, 2021

      • prabal
        hello how're you

        • 2021-04-12 10227, 2021

      • prabal
        i wanted to talk about notification service in my gsoc proposal

        • 2021-04-12 10251, 2021

      • prabal
        do you think it's alright to have a different application which will be run on the same machine as the webserver?

        • 2021-04-12 10251, 2021

      • yyoung
        yvanzo: Maybe 'make URLCleanup.js compatible with the new interface'?

        • 2021-04-12 10214, 2021

      • prabal
        or do you think it's better to integrate the notifcation functions in the webserver itself

        • 2021-04-12 10234, 2021

      • _lucifer
        oh nice, i didn't know about it.

        • 2021-04-12 10238, 2021

      • Mr_Monkey
        Better to have them separate

        • 2021-04-12 10239, 2021

      • _lucifer
        this is the base image, https://github.com/metabrainz/musicbrainz-server/…

        • 2021-04-12 10240, 2021

      • prabal
        making a different application seems lil bit of an overkill to me

        • 2021-04-12 10243, 2021

      • prabal
        oh okay

        • 2021-04-12 10249, 2021

      • ShivamAwasthi joined the channel

        • 2021-04-12 10251, 2021

      • prabal
        alright

        • 2021-04-12 10254, 2021

      • yvanzo
        yyoung: I suggest to split week 5: refactoring URLCleanup can take one full week (at least).

        • 2021-04-12 10228, 2021

      • Mr_Monkey
        But it can be done in the same way that we run the API separately (while the code lives in the same repo with some common code)

        • 2021-04-12 10254, 2021

      • Mr_Monkey
        In case the notifications system ever goes down we don't want it to take the website down along with it :)

        • 2021-04-12 10206, 2021

      • prabal
        yeah makes sense

        • 2021-04-12 10219, 2021

      • prabal
        also do you think we need a feature to follow another user?

        • 2021-04-12 10227, 2021

      • prabal
        or i should stick with collections and entity for now

        • 2021-04-12 10247, 2021

      • yyoung
        yvanzo: So I'll be refactoring URLCleanup in Week 5 and support new auto-select logic in Week 6, is that OK?

        • 2021-04-12 10256, 2021

      • Mr_Monkey
        I think that would be interesting, but out of scope for this project (especially with a shorter GSoC this year)

        • 2021-04-12 10216, 2021

      • prabal
        yeah only 175 hours this time :)

        • 2021-04-12 10218, 2021

      • alastairp
        https://usercontent.irccloud-cdn.com/file/9t6J6U1…

        • 2021-04-12 10232, 2021

      • alastairp
        _lucifer: actually I'm wrong, postgres is 3.6gb. that's interesting. when I did the docker pull it explicitly said it was pulling a 1gb layer, so I wonder where that was

        • 2021-04-12 10259, 2021

      • _lucifer
        alastairp: i had seen the 1.1g compressed in docker hub

        • 2021-04-12 10214, 2021

      • alastairp
        ah, it's compressed on docker hub?! that's great

        • 2021-04-12 10226, 2021

      • alastairp
        so it actually takes much less to download

        • 2021-04-12 10227, 2021

      • alastairp
        neat

        • 2021-04-12 10237, 2021

      • _lucifer
        https://hub.docker.com/r/metabrainz/brainzutils-m…

        • 2021-04-12 10246, 2021

      • prabal
        do you think we should give the user to ability to change the number of times they receive notifications using email?

        • 2021-04-12 10209, 2021

      • prabal
        i think we should send them one email a day and give them an option to unsubscribe notifications via email

        • 2021-04-12 10209, 2021

      • alastairp
        👍 because it compresses so well I'm happy with that, no need to make any further changes

        • 2021-04-12 10224, 2021

      • alastairp
        maybe I'll add a quick note to the readme describing this

        • 2021-04-12 10209, 2021

      • yvanzo
        yyoung: I don’t understand the label of week 6-7 either. :) Maybe make a simple list of things to do first (in a gist for example) so we can check if something is amiss, and only then you will be able to order these tasks properly and allocate weeks?

        • 2021-04-12 10238, 2021

      • prabal
        giving them the option to change the frequency of the emails they receive might increase the complexity of the project

        • 2021-04-12 10253, 2021

      • _lucifer
        regarding build image cache, i was thinking to use https://github.com/whoan/docker-build-with-cache-…

        • 2021-04-12 10258, 2021

      • _lucifer
        what do you think?

        • 2021-04-12 10218, 2021

      • alastairp
        is there a way that we can see how many people use that?

        • 2021-04-12 10232, 2021

      • Mr_Monkey
        I agree. Let's just keep the future in mind when designing that preference system, allowing for more options in the future.

        • 2021-04-12 10244, 2021

      • Mr_Monkey
        (That's for prabal)

        • 2021-04-12 10245, 2021

      • _lucifer
        i'll see if i can find number of users

        • 2021-04-12 10252, 2021

      • alastairp
        the action itself looks pretty complex... 350 lines of bash

        • 2021-04-12 10207, 2021

      • alastairp
        the other blog post we found is only a few extra lines of yaml, right? ;)

        • 2021-04-12 10226, 2021

      • alastairp
        but I agree that using something that someone else has set up working for us might be nice

        • 2021-04-12 10208, 2021

      • yyoung
        yvanzo: I mean we prepare URLCleanup for multiple relationship types validation and then embed it into the dialog

        • 2021-04-12 10218, 2021

      • prabal
        Alright thanks Mr_Monkey I will update my proposal tonight :)

        • 2021-04-12 10230, 2021

      • alastairp
        _lucifer: it's not super clear to me what this actually does when it says "cache"

        • 2021-04-12 10251, 2021

      • alastairp
        does it actually push layers of an image to a registry, and then "download" them from there for the resulting cached values?

        • 2021-04-12 10259, 2021

      • alastairp
        or does it use the github actions cache functionality

        • 2021-04-12 10252, 2021

      • yvanzo
        yyoung: just adapt ExternalLinksEditor to it, it's already being used, see: https://github.com/metabrainz/musicbrainz-server/…

        • 2021-04-12 10238, 2021

      • _lucifer
        yeah, it doesn't state anywhere that it uses actions cache.

        • 2021-04-12 10257, 2021

      • ShivamAwasthi has quit

        • 2021-04-12 10241, 2021

      • yyoung
        yvanzo: But what about the validation of multiple relationship types of a single link?

        • 2021-04-12 10227, 2021

      • alastairp
        I think I'd prefer to use the actions cache

        • 2021-04-12 10240, 2021

      • _lucifer
        yeah right

        • 2021-04-12 10252, 2021

      • alastairp
        keep the data all within actions, rather than random images being pushed to our repos

        • 2021-04-12 10255, 2021

      • yvanzo
        bitmap, reosarevok: I’m up for revewing more PRs this evening if needed to make a decent beta update.

        • 2021-04-12 10207, 2021

      • _lucifer
        there's also https://github.com/marketplace/actions/docker-lay… which explicitly says it uses actions cache

        • 2021-04-12 10223, 2021

      • alastairp
        cool, now we're talking

        • 2021-04-12 10235, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo merged pull request #1352 (master…monkey-alert-notifications-refactor): LB-843: Refactor alert notifications as higher-order component https://github.com/metabrainz/listenbrainz-server…

        • 2021-04-12 10241, 2021

      • bitmap
        yvanzo: same here

        • 2021-04-12 10202, 2021

      • yvanzo
        yyoung: you can add it to URLCleanup and use it in ExternalLinksEditor for example

        • 2021-04-12 10246, 2021

      • alastairp
        _lucifer: https://github.com/search?q=satackey%2Faction-doc…

        • 2021-04-12 10223, 2021

      • yyoung
        yvanzo: Yes that's what I mean in the schedule, I'll update the statement later :)

        • 2021-04-12 10224, 2021

      • yvanzo
        yyoung: The idea is to keep the auto-select/cleanup/validation logic in URLCleanup (that can be renamed URLHandler if that is more clear) and keep the UI stuff only in ExternalLinksEditor and such.

        • 2021-04-12 10231, 2021

      • alastairp
        _lucifer: https://github.com/search?q=whoan%2Fdocker-build-… in fact, this one has less :)

        • 2021-04-12 10233, 2021

      • _lucifer
        hah, just a simple search!

        • 2021-04-12 10249, 2021

      • _lucifer
        yup.

        • 2021-04-12 10248, 2021

      • alastairp
        cool, I'm happy to use that action cache

        • 2021-04-12 10255, 2021

      • v6lur joined the channel

        • 2021-04-12 10257, 2021

      • _lucifer
        also, thi seems to run using node so we can paint it as the scapegoat if something goes wrong easily 😜

        • 2021-04-12 10208, 2021

      • alastairp
        🤨

        • 2021-04-12 10254, 2021

      • yvanzo
        yyoung: the UI prototype is nice but will likely need to be revisited, so maybe include that in your to do list as well :)

        • 2021-04-12 10239, 2021

      • yyoung
        yvanzo: OK, so here is my todo list: https://gist.github.com/y-young/d8f3a0bede0696214…, did I miss something?

        • 2021-04-12 10251, 2021

      • yvanzo
        yyoung: I will review it through gist comments as the weekly meeting is about to start here.

        • 2021-04-12 10259, 2021

      • yyoung
        yvanzo: Sure. I'll have to go to sleep now, I'll get back to you after I wake up :)

        • 2021-04-12 10219, 2021

      • Freso
        <BANG>

        • 2021-04-12 10219, 2021

      • Freso
        It’s International Monday of Human Space Flight!

        • 2021-04-12 10219, 2021

      • Freso
        https://www.youtube.com/watch?v=VjjVg9zBnnw

        • 2021-04-12 10219, 2021

      • Freso
        People up for reviews: zas, reosarevok, alastairp, _lucifer, Freso, bitmap, Mr_Monkey, ruaok, yvanzo, shivam-kapila, CatQuest – anyone else who might want to give review, let me know ASAP! :)

        • 2021-04-12 10219, 2021

      • Freso
        zas: Go!

        • 2021-04-12 10225, 2021

      • zas
        hey

        • 2021-04-12 10237, 2021

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, FTP (zas), Weblate (outsidecontext)

        • 2021-04-12 10247, 2021

      • zas
        I configured the 5 new spark servers (aka Jackson5)

        • 2021-04-12 10208, 2021

      • zas
        Picard code review (we are on the way to next point release)

        • 2021-04-12 10237, 2021

      • zas
        I also upgraded grafana & discourse, plus usual maintenance & system upgrades

        • 2021-04-12 10250, 2021

      • zas
        that's it for me. reosarevok ?

        • 2021-04-12 10255, 2021

      • reosarevok
        Hi!

        • 2021-04-12 10210, 2021

      • reosarevok
        I looked into some more schema change tickets, then did more triaging + fixing small old tickets

        • 2021-04-12 10222, 2021

      • reosarevok
        Now looking into some log warnings to see if we can clear it up a bit more

        • 2021-04-12 10252, 2021

      • reosarevok
        That's about it for me

        • 2021-04-12 10257, 2021

      • reosarevok
        CatQuest: you?

        • 2021-04-12 10206, 2021

      • CatQuest
        Meow! `😺`

        • 2021-04-12 10207, 2021

      • reosarevok
        (oh, sorry, and added some genres!)

        • 2021-04-12 10210, 2021

      • reosarevok
        (now done)

        • 2021-04-12 10215, 2021

      • CatQuest
        A little bit of everything, adding books to bb, adding images to instruments

        • 2021-04-12 10223, 2021

      • CatQuest
        admiring the snowing outside

        • 2021-04-12 10229, 2021

      • CatQuest
        tomorrow there will be 10 degrees and sunshine

        • 2021-04-12 10229, 2021

      • CatQuest
        ahh #justaprilthings

        • 2021-04-12 10233, 2021

      • CatQuest
        feeling a bit groggy... we'll see.

        • 2021-04-12 10238, 2021

      • CatQuest

        • 2021-04-12 10239, 2021

      • CatQuest
        ♓

        • 2021-04-12 10239, 2021

      • CatQuest
        fin, go Mr_Monkey

        • 2021-04-12 10243, 2021

      • Mr_Monkey
        Hello !

        • 2021-04-12 10249, 2021

      • Mr_Monkey
        I was off the first week of the month, but found a bit of time to review GSoC proposals and a non GSoC project proposal to replace our current ORM with TypeORM, along with typescript support.

        • 2021-04-12 10206, 2021

      • Mr_Monkey
        Last week I worked on BB-615

        • 2021-04-12 10207, 2021

      • BrainzBot
        BB-615: Annotation text copy/paste doesn't work well in FireFox <= 60 https://tickets.metabrainz.org/browse/BB-615

        • 2021-04-12 10214, 2021

      • Mr_Monkey
        Some weird stuff Firefox does.

        • 2021-04-12 10238, 2021

      • Mr_Monkey
        Continued reviewing GSoC proposals and PRs

        • 2021-04-12 10243, 2021

      • shivam-kapila
        (Freso: nothing for review. Please put me off the list this time. Thanks)

        • 2021-04-12 10257, 2021

      • Mr_Monkey
        I started implementing a datepicker navigation tool for ListenBrainz (LB-656)

        • 2021-04-12 10258, 2021

      • BrainzBot
        LB-656: Provide coarser listen navigation tools (month/year) https://tickets.metabrainz.org/browse/LB-656

        • 2021-04-12 10218, 2021

      • Mr_Monkey
        It's up on test.listenbrainz.org (> My Listens) if anyone wants to have a go

        • 2021-04-12 10230, 2021

      • CatQuest goes

        • 2021-04-12 10253, 2021

      • Mr_Monkey
        Some useful discussion I had with ruaok about pagination, since my hand are all in there. We will continue that this week.

        • 2021-04-12 10208, 2021

      • Mr_Monkey
        And that's it for me ! _lucifer go !

        • 2021-04-12 10226, 2021

      • _lucifer
        Hi all!

        • 2021-04-12 10218, 2021

      • _lucifer
        I worked on some cache improvements in BU, we ended up dropping support python2.

        • 2021-04-12 10245, 2021

      • Freso
        🙌

        • 2021-04-12 10209, 2021

      • _lucifer
        Taking benefit of the opportunity, I and alastairp worked on improving thing in BU that were not earlier possible.

        • 2021-04-12 10250, 2021

      • _lucifer
        We also updated completed upgrading all applications to new sentry.

        • 2021-04-12 10217, 2021

      • _lucifer
        Further, I worked on the Youtube player implementation and some cache related improvements in CB.

        • 2021-04-12 10233, 2021

      • _lucifer
        Lastly, I worked on migrating BU from Travis CI to Github Actions.

        • 2021-04-12 10248, 2021

      • _lucifer
        That's it for me. alastairp: next?

        • 2021-04-12 10253, 2021

      • alastairp
        hi

        • 2021-04-12 10257, 2021

      • alastairp
        !m _lucifer

        • 2021-04-12 10257, 2021

      • BrainzBot
        You're doing good work, _lucifer!

        • 2021-04-12 10210, 2021

      • alastairp
        in the last weeks I worked a lot with _lucifer to release brainzutils 2.0, this will include only python 3 support, and a handful of changed APIs to remove a bunch of functionality that we never really used

        • 2021-04-12 10219, 2021

      • alastairp
        We released a new verison of BU that uses sentry-sdk instead of the old raven library, released this on all python apps that use it, and did a general cleanup of the way we use sentry

        • 2021-04-12 10228, 2021

      • alastairp
        I made a new docker image, https://hub.docker.com/r/metabrainz/brainzutils-m…, that is a postgres image with a full copy of the sample database. This helps to make brainzutils tests much faster, and is available for any other service that wants to test against a real database

        • 2021-04-12 10233, 2021

      • alastairp
        I did a bunch of LB reviews, and with _lucifer finished work on improving our consul startup scripts (https://github.com/metabrainz/listenbrainz-server…)

        • 2021-04-12 10237, 2021

      • alastairp
        I also reviewed some project proposals for GSoC for AB

        • 2021-04-12 10253, 2021

      • alastairp
        ruaok: next?

        • 2021-04-12 10258, 2021

      • ruaok
        yo

        • 2021-04-12 10218, 2021

      • shivam-kapila
        (applications close tomorrow. Right?)

        • 2021-04-12 10228, 2021

      • ruaok
        I spent some time negotiating and reviewing a contract for a new 🦄, so that is exciting.

        • 2021-04-12 10241, 2021

      • ruaok
        some accounting follow up from the previous week.

        • 2021-04-12 10244, 2021

      • shivam-kapila
        Woohoo!!!

        • 2021-04-12 10223, 2021

      • yvanzo
        (shivam-kapila: yes)

        • 2021-04-12 10232, 2021

      • ruaok
        some PR reviews and submitting a PR for some lb labs additions that are needed to finish off the work on the mbid_mapping_writer, which is a significant step for us to stop using MSIDs, which is super exciting.

        • 2021-04-12 10255, 2021

      • ruaok
        and I reviewed jasondk's proposal and now I need to get that feedback to him.