it offers a wide range of java versions and is updated often so we can switch easily if needed at anytime
2021-04-13 10318, 2021
_lucifer
ruaok, fine to add their repository and gpg key?
2021-04-13 10316, 2021
yyoung
yvanzo: That's a good point. But what I mean by 'ExternalLinksEditor UI' only includes the list of external links, without the dialog, is it OK that I implement the list first and then the dialog?
I dont think we need to do anything special at all. Since we're not using docker, which opens the firewall, whether you like it or not, and we have a firewall, any ports we open should not be accessible from the outside.
2021-04-13 10335, 2021
ruaok
so, for now lets just set it up with not special regard to which interfaces it binds to.
Ohh yea sorry. I initially thought of two plans and then made a third one
2021-04-13 10303, 2021
yvanzo
See bitmap’s comment about that topic
2021-04-13 10309, 2021
Cyna[m]
Ok
2021-04-13 10313, 2021
alekhya joined the channel
2021-04-13 10335, 2021
yvanzo
Also Transifex is not called at run time, translations are statically bundled at release time.
2021-04-13 10301, 2021
alastairp
!m reosarevok
2021-04-13 10301, 2021
BrainzBot
You're doing good work, reosarevok!
2021-04-13 10324, 2021
reosarevok
alastairp: do I need to do anything else with any CB PRs?
2021-04-13 10334, 2021
reosarevok
(request reviews, set labels or something)
2021-04-13 10347, 2021
alastairp
nope
2021-04-13 10302, 2021
alastairp
I think _lucifer should be taking over CB reviews and releases though :)
2021-04-13 10325, 2021
yvanzo
Cyna[m]: There is still one mention of "Mock API" even though you correctly removed it from other parts.
2021-04-13 10346, 2021
_lucifer
yeah, sure. I'll keep in mind to review CB PRs and releases, alastairp. but your reviews are more insightful and useful :D
2021-04-13 10304, 2021
alastairp
yeah, happy to continue giving feedback
2021-04-13 10311, 2021
_lucifer
thanks!
2021-04-13 10313, 2021
Cyna[m]
Hmm might be a left over. I'll quickly go throught the proposal again.
2021-04-13 10323, 2021
Cyna[m]
And remove any stragglers.
2021-04-13 10355, 2021
reosarevok
_lucifer, alastairp: I'm no python expert, so all my small fixes are "this works", not "I'm confident this is the best way" :) Feel free to suggest improvements whenever needed
2021-04-13 10347, 2021
reosarevok
Now that I know how to set the site up for testing I might send some more if I find more while browsing around from MB, who knows
2021-04-13 10356, 2021
alastairp
reosarevok: yeah, many of the "copy/paste and add another if statement" are mostly OK
2021-04-13 10312, 2021
alastairp
though sometimes I look at them and think "oh we could redo this better!"... if only we had the time
2021-04-13 10336, 2021
reosarevok
Yeah, the code for the titles seems like it could be improved, but "non-broken" is better than "broken until someone improves it more"
2021-04-13 10330, 2021
ruaok
similar users on LB are finally working better. :)
meaning that they show up, but the scores are still low until freso gets rid of spammers.
2021-04-13 10317, 2021
yvanzo
Hi RikkoM, your post looks nice (but okno_ is the best qualified to review it), thanks! It would be even nicer if you could get more involved too :) For example: give a try to using MusicBrainz/Picard for yourself, share about your activity at MeB weekly meetings, …
2021-04-13 10317, 2021
Cyna[m]
yvanzo: I've added some details to the translation part of the proposal. although I am a bit confused and dont understand the entire way its done currently... Plan on reading it through the community bonding period or maybe even before it.
interesting, after LB's big year last year, there is only one proposal this year. and I thought last year's proposals were tougher than what we proposed this year. huh
2021-04-13 10349, 2021
_lucifer
the number of proposals overall seems to have decreased as well ?
2021-04-13 10302, 2021
ruaok
only by a few.
2021-04-13 10310, 2021
Cyna[m]
Yea when i participated before... there were a lot of proposals that this time. Also many last year.
2021-04-13 10335, 2021
RikkoM has quit
2021-04-13 10315, 2021
shivam-kapila
Tbh I was expecting good LB candidates too
2021-04-13 10332, 2021
shivam-kapila
Many came and said but only jason continued
2021-04-13 10351, 2021
shivam-kapila
Idk why others left :/
2021-04-13 10324, 2021
Cyna[m]
There are still many last minute proposals to arrive I guess. Many people do them and hope to get selected as a candidate
_lucifer: a quickie PR fo you if you have some time
2021-04-13 10330, 2021
_lucifer
ruaok: lgtm
2021-04-13 10314, 2021
ruaok
thx
2021-04-13 10308, 2021
RikkoM joined the channel
2021-04-13 10341, 2021
ruaok
click the approve button, _lucifer ?
2021-04-13 10300, 2021
ruaok
I'll make sure the tests pass before merging.
2021-04-13 10305, 2021
ruaok
thanks!
2021-04-13 10312, 2021
_lucifer
done :D
2021-04-13 10301, 2021
flamingspinach has quit
2021-04-13 10320, 2021
flamingspinach joined the channel
2021-04-13 10321, 2021
prabal
Mr_Monkey: thanks for the review, sorry i got busy and couldn't get it done before :)
2021-04-13 10346, 2021
Mr_Monkey
Same here, too many things, not enough time !
2021-04-13 10346, 2021
prabal
2 more weeks left in college. lots of ongoing assignments :)
2021-04-13 10311, 2021
_lucifer
ruaok, i need to add ssh login from newleader to workers. what's the easiest way to do it? generate key pair on newleader, download and upload to workers?
