Freso: Please put me off the review list for today. Sorry
2021-04-26 11651, 2021
yvanzo
ruaok: pong
2021-04-26 11620, 2021
ruaok
yvanzo: hiya. if I need to remove an RMQ queue on prince, which credientials do I do that with? guest cannot do it.
2021-04-26 11656, 2021
yvanzo
let me check
2021-04-26 11616, 2021
sumedh has quit
2021-04-26 11630, 2021
yvanzo
ruaok: you need to set 'management' tag on 'lb' user, from prince: docker exec -it rabbitmq-prince rabbitmqctl set_user_tags lb management
2021-04-26 11609, 2021
ruaok
is that a one time task?
2021-04-26 11619, 2021
yvanzo
yes, see docker server configs
2021-04-26 11629, 2021
ruaok
yvanzo: thanks!
2021-04-26 11649, 2021
ruaok
yvanzo: thanks, queues cleared up.
2021-04-26 11611, 2021
ruaok
zas: I cleaned up the two queues with the weird names. and right now the unique queue will be collecting listens. it may trip an alert overnight, but we can safely ignore that. I'll continue this work in the morning.
2021-04-26 11627, 2021
zas
ok
2021-04-26 11606, 2021
nawcom has quit
2021-04-26 11646, 2021
_lucifer
alastairp: ruaok: the sentry sdk logging is failing.
alastairp, it seems like its sentry. it is trying to call an `attemptId` method which is not present and hence errors out. sentry catches this error occuring in itself and reports it.
2021-04-26 11650, 2021
alastairp
cool. maybe related to us being on an older version of spark? can we just run plain sentry with no spark integration?
2021-04-26 11657, 2021
_lucifer
i'll open a PR to try running sentry in test setup since that's on 2.. that might be helpful.
2021-04-26 11619, 2021
_lucifer
yes, i think regular sentry should work.
2021-04-26 11623, 2021
alastairp
(though if it doesn't work with the version of pyspark listed in the sentry requirements, that sounds like a sentry bug)
2021-04-26 11647, 2021
_lucifer
yeah, if it works in test. i'll open an issue with sentry.
2021-04-26 11623, 2021
_lucifer
also, i have updated the ratelimiting PR.
2021-04-26 11658, 2021
iliekcomputers
if someone wants to donate to help india's fucked covid situation:
This week is also World Immunization Week. If you have the opportunity, please go get vaccinated!
2021-04-26 11613, 2021
Freso
Anyway, on to business.
2021-04-26 11622, 2021
Freso
I haven’t received any mailed in reviews, so the usual suspects up are: ruaok, Mr_Monkey, Freso, alastairp, _lucifer, reosarevok, zas, yvanzo, bitmap, shivam-kapila, CatQuest. As usual, anyone else who want to give review, just let me know (explicitly, please) and I’ll add you.
2021-04-26 11622, 2021
Freso
For now… ruaok: Go!
2021-04-26 11612, 2021
Freso
Or… Mr_Monkey: Go!
2021-04-26 11615, 2021
Mr_Monkey
Hi !
2021-04-26 11618, 2021
ShivamAwasthi joined the channel
2021-04-26 11648, 2021
ruaok appears
2021-04-26 11654, 2021
Mr_Monkey
Last week i reviewed lots of PRs for Bb and LB — we had an LB PR marathon on Wednesday with the team.
2021-04-26 11617, 2021
Mr_Monkey
I also worked on fixing issues in the Youtube and Spotify players on LB
2021-04-26 11640, 2021
Mr_Monkey
Which were partly the result of setting up sentry to report front-end errors
2021-04-26 11616, 2021
CatQuest
:D
2021-04-26 11620, 2021
MRiddickW joined the channel
2021-04-26 11639, 2021
Mr_Monkey
I spent the rest of my time refactoring code on LB , mainly making Error boundaries catch async errors and using React context as a sort of API service injection.
2021-04-26 11651, 2021
Mr_Monkey
That's it for me! ruaok go !
2021-04-26 11600, 2021
ruaok
sorry for my delayed arrival....
2021-04-26 11632, 2021
ruaok
last week I participated in the PR bonanza and also go the speed/searching improvements for listens PR done.
2021-04-26 11633, 2021
Freso
You're here now. :)
2021-04-26 11651, 2021
ruaok
that will greatly improve the speed of the LB experience.
2021-04-26 11602, 2021
Mr_Monkey
and fix bugs !
2021-04-26 11612, 2021
ruaok
I also signed the contract for a new Unicorn, but it hasn't been counter signed yet, so I still can't talk about it.
2021-04-26 11619, 2021
CatQuest
:O
2021-04-26 11647, 2021
ruaok
now I'm back on the MBID mapping pipeline element, which I hope to finish in the next few days.. or at least before the end of the month.
most of what I did has already been said - lots of PRs in LB finished and merged, still a bunch to go though
2021-04-26 11638, 2021
alastairp
I also started looking at a new project that ruaok and I discussed last week, to get a huge bunch of tags of genres into MB
2021-04-26 11639, 2021
alastairp
and I also spent some time looking into what's necessary to finally merge our similarity database into AB.
2021-04-26 11601, 2021
alastairp
I've realised that with lots of my pending tasks that perfect is the enemy of good, and so instead of agonizing over if something is 100% complete, it's better to just get it out and breaking so that people can report it to us
2021-04-26 11605, 2021
Freso
🎉
2021-04-26 11622, 2021
alastairp
so I'm going to try and be less pedantic about some of my pending tasks going forward
2021-04-26 11632, 2021
alastairp
Freso: thanks for stepping up, next!
2021-04-26 11628, 2021
ruaok
+100 alastairp !
2021-04-26 11631, 2021
Freso
o/
2021-04-26 11651, 2021
alastairp
ruaok: I was sure that you'd like that ;) it's an interesting realisation
good enough is far better than what other sites/projects (esp banks) do.
2021-04-26 11602, 2021
Freso
(Technically I did this the week before, but I merged it last week after the MBS release.)
2021-04-26 11632, 2021
CatQuest
...
2021-04-26 11633, 2021
Freso
On the clock, not much happened. Uni work and personal things took way too much time and effort/energy than I had anticipated. I did poke a bit at LB-733 and partially as a result of that, got a bunch more mails sent in relation to that earlier today before my class.
I still have at least one more cluster of accounts I haven’t fully untangled, so I expect I’ll be poking even more at that this week.
2021-04-26 11618, 2021
ruaok
thank you!
2021-04-26 11622, 2021
Freso
(Also, first account deletion as a result of this today.)
2021-04-26 11652, 2021
Freso
Thanks to ruaok and reosarevok for answering questions. :)
2021-04-26 11606, 2021
Freso
fin, I guess.
2021-04-26 11617, 2021
Freso
_lucifer: Go!
2021-04-26 11655, 2021
ShivamAwasthi has quit
2021-04-26 11603, 2021
Freso
If _lucifer is here. 👀
2021-04-26 11612, 2021
_lucifer
Hi all! I spent most of the time last week on refactoring the spotify reader and oauth code to make it easier to add new integrations.
2021-04-26 11626, 2021
Freso
(People still up: reosarevok, yvanzo, bitmap, shivam-kapila, CatQuest. As usual, anyone else who want to give review, just let me know (explicitly, please) and I’ll add you.)
2021-04-26 11658, 2021
_lucifer
other than that, I reviewed 2-3 PRs and looked at some spark stuff ealrier today.
