17:21 PM
BrainzGit
2021-04-26 11656, 2021
17:21 PM
CatQuest
Meow! `😺`
2021-04-26 11610, 2021
17:22 PM
CatQuest
adding lots of works to bookbrainz and getting some fortgang :D on tickets
2021-04-26 11625, 2021
17:22 PM
CatQuest
♈
2021-04-26 11625, 2021
17:22 PM
CatQuest
fin, go bitmap ?
2021-04-26 11630, 2021
17:22 PM
bitmap
hey
2021-04-26 11639, 2021
17:22 PM
Freso
(Only yvanzo and shivam-kapila left on my list. Last call for anyone else who want to give review!)
2021-04-26 11651, 2021
17:22 PM
bitmap
last week I worked on various CAA issues discovered by ROpdebee
2021-04-26 11610, 2021
17:23 PM
bitmap
2021-04-26 11645, 2021
17:23 PM
bitmap
2021-04-26 11614, 2021
17:24 PM
bitmap
and also continued to work on pgtap tests for the schema change, which should be ready this week, and did some minor GSoC review
2021-04-26 11630, 2021
17:24 PM
bitmap
fin. go yvanzo
2021-04-26 11634, 2021
17:24 PM
yvanzo
Hi!
2021-04-26 11655, 2021
17:24 PM
yvanzo
Same week as before but shorter: Reviewed MBS PRs and worked on schema change.
2021-04-26 11604, 2021
17:25 PM
yvanzo
Fin. Go for last review shivam-kapila!
2021-04-26 11637, 2021
17:25 PM
Mr_Monkey
He asked to be removed from the list for today.
2021-04-26 11640, 2021
17:25 PM
CatQuest
he asked to not be included today, iirc?
2021-04-26 11643, 2021
17:25 PM
Freso
(If shivam-kapila is here, that is. 👀)
2021-04-26 11650, 2021
17:25 PM
Freso
CatQuest: Oh, I didn't see that.
2021-04-26 11622, 2021
17:26 PM
Freso
Well then. shivam-kapila can let us know if they want to go after… the one item we have on the agenda! Repeat from last week:
2021-04-26 11631, 2021
17:26 PM
Freso
2021-04-26 11651, 2021
17:26 PM
ruaok
right.
2021-04-26 11612, 2021
17:27 PM
ruaok
so, I hope that people have had a chance to read about the FLoC proposal.
2021-04-26 11633, 2021
17:27 PM
ruaok
does any one have any objections to us opting out of FLoC? and if so, what is it/are they?
2021-04-26 11645, 2021
17:27 PM
Freso
I’d say please do. :)
2021-04-26 11646, 2021
17:27 PM
yvanzo
none
2021-04-26 11656, 2021
17:27 PM
Mr_Monkey
I 100% think we should opt out
2021-04-26 11601, 2021
17:28 PM
yvanzo
:)
2021-04-26 11602, 2021
17:28 PM
shivam-kapila
(Freso: I had nothing for review. I think I posted here earlier. Please feel free to continue with other proceedings.)
2021-04-26 11608, 2021
17:28 PM
ruaok
I have a feeling I know the outcome of this, but I am just making sure that people can say their part.
2021-04-26 11615, 2021
17:28 PM
Freso
Pretty sure the majority of the community would also prefer us to opt-out.
2021-04-26 11630, 2021
17:28 PM
Freso
So as community manager, opting out gets my vote.
2021-04-26 11633, 2021
17:28 PM
ruaok
yeah, opting in might even be a disaster.
2021-04-26 11635, 2021
17:28 PM
reosarevok
I'm fine with opting out. But: when they say this is a replacement for cookies, what does that mean exactly?
2021-04-26 11645, 2021
17:28 PM
ruaok
ok, I have nothing supporting FLoC.
2021-04-26 11653, 2021
17:28 PM
Mr_Monkey
Less tracking = more better
2021-04-26 11656, 2021
17:28 PM
reosarevok
Will the cookies we use for MB itself stop being supported in any way in Chrome?
2021-04-26 11607, 2021
17:29 PM
ruaok
reosarevok: it means that google has devised a way to have some forms of tracking, but they are more anonymous.
2021-04-26 11609, 2021
17:29 PM
CatQuest
ok os "If you don’t declare anything, the default is to allow." that is hella creepy and by
2021-04-26 11615, 2021
17:29 PM
Freso
reosarevok: Doubt it. They’re not going to break the web.
2021-04-26 11627, 2021
17:29 PM
_lucifer
they'll phase out 3rd party cookies only.
2021-04-26 11627, 2021
17:29 PM
ruaok
but with google being more in control of it, with questionable competition impact.
2021-04-26 11629, 2021
17:29 PM
Freso
It’s just their own cookies.
2021-04-26 11633, 2021
17:29 PM
ruaok
to which I say: fuck. that.
2021-04-26 11648, 2021
17:29 PM
CatQuest
by principle i am agains that shit
2021-04-26 11652, 2021
17:29 PM
ruaok
so, motion carried. I will make a ticket for us to opt out.
2021-04-26 11657, 2021
17:29 PM
CatQuest
👍
2021-04-26 11600, 2021
17:30 PM
Freso
🙌
2021-04-26 11604, 2021
17:30 PM
Freso
Alright then.
2021-04-26 11607, 2021
17:30 PM
ruaok
Freso: please leave the topic item. it will serve as a reminder for me to open the ticket.
2021-04-26 11607, 2021
17:30 PM
_lucifer
🎉
2021-04-26 11609, 2021
17:30 PM
ruaok
fin
2021-04-26 11615, 2021
17:30 PM
Freso
Ha. Will do. :)
2021-04-26 11633, 2021
17:30 PM
Freso
Well, that rounds up tonight's meeting then!
2021-04-26 11652, 2021
17:30 PM
Freso
Thank you everyone who gave reviews and everyone who were around for your time!
2021-04-26 11605, 2021
17:31 PM
Mr_Monkey
Thank you!
2021-04-26 11609, 2021
17:31 PM
yvanzo
Thanks!
2021-04-26 11617, 2021
17:31 PM
Freso
Celebrate Immunization Week by getting vaccinated if you can! 🎉
2021-04-26 11627, 2021
17:31 PM
Freso
</BANG>
2021-04-26 11634, 2021
17:31 PM
_lucifer
oh lol! the spark tests workflow has never succeeded since we moved to GH actions and not once did we notice.
2021-04-26 11649, 2021
17:31 PM
travis-ci joined the channel
2021-04-26 11649, 2021
17:31 PM
travis-ci
2021-04-26 11649, 2021
17:31 PM
travis-ci has left the channel
2021-04-26 11640, 2021
17:32 PM
_lucifer
the power of the green tick!!
2021-04-26 11610, 2021
17:34 PM
_lucifer
2021-04-26 11613, 2021
17:35 PM
alastairp
_lucifer: oops
2021-04-26 11632, 2021
17:35 PM
alastairp
is that as a result of going from the jenkins test script to regular test.sh?
2021-04-26 11616, 2021
17:36 PM
_lucifer
yeah, jenkins probably used up so i copied that to GH but then jenkins reported the status from the xml files.
2021-04-26 11602, 2021
17:37 PM
_lucifer
jenkins script also copied the config.py to make it available in the tests. the GH one didn't so due to this the workflows never passed
2021-04-26 11638, 2021
17:37 PM
_lucifer
and but due to `up` the status was always reported incorrectly and hence the green tick
2021-04-26 11613, 2021
17:38 PM
CatQuest
oohh
2021-04-26 11621, 2021
17:38 PM
CatQuest
"Hi! We are Uku and Marko. We're building a lightweight, non-intrusive alternative to Google Analytics. "
2021-04-26 11630, 2021
17:38 PM
CatQuest
cool
2021-04-26 11614, 2021
17:39 PM
alastairp
CatQuest: yeah, I set it up for
freesound.org , we now have full analytics without needing to use google
2021-04-26 11630, 2021
17:39 PM
CatQuest
:O coool
2021-04-26 11651, 2021
17:39 PM
alastairp
_lucifer: right, handful of things mixed together then
2021-04-26 11602, 2021
17:40 PM
travis-ci joined the channel
2021-04-26 11602, 2021
17:40 PM
travis-ci
2021-04-26 11602, 2021
17:40 PM
travis-ci has left the channel
2021-04-26 11630, 2021
17:40 PM
_lucifer
yeah.
2021-04-26 11638, 2021
17:41 PM
_lucifer
lol, this probably deserves a blog post.
2021-04-26 11645, 2021
17:41 PM
alastairp
2021-04-26 11609, 2021
17:42 PM
alastairp
yeah, it's funny. half of this came about because of our crazy jenkins setup, too
2021-04-26 11623, 2021
17:42 PM
alastairp
if it wasn't as complex the migration to actions would have been simpler
2021-04-26 11634, 2021
17:42 PM
_lucifer
yup, true.
2021-04-26 11645, 2021
17:42 PM
alastairp
but I guess it can also be summed up as "remember that shell scripts swallow exit codes"
2021-04-26 11656, 2021
17:43 PM
_lucifer
ruaok, is meb blog using wordpress or jekyll?
2021-04-26 11646, 2021
17:46 PM
reosarevok
hah
2021-04-26 11646, 2021
17:46 PM
reosarevok
2021-04-26 11651, 2021
17:46 PM
reosarevok
Where have I heard of this place
2021-04-26 11601, 2021
17:48 PM
reosarevok
(ok, it's on the other side of town, but still)
2021-04-26 11645, 2021
17:48 PM
ruaok
WordPress. :-(
2021-04-26 11653, 2021
17:48 PM
_lucifer
alastairp, updated beta with 1404 + spotify player fix.
2021-04-26 11606, 2021
17:49 PM
_lucifer
i remember you having plans to move it?
2021-04-26 11631, 2021
17:49 PM
_lucifer
i have a couple of blog posts in mind to put on MeB blog :)
2021-04-26 11623, 2021
17:50 PM
ruaok
No concrete plans. Let me give you an account.
2021-04-26 11637, 2021
17:52 PM
reosarevok
2021-04-26 11659, 2021
17:52 PM
ruaok
_lucifer: check your email.
2021-04-26 11643, 2021
17:53 PM
bitmap
reosarevok: maybe we ought to mention what sort of alterations are made to the emails before searching in root/admin/EmailSearch.js. I'm sure people will forget
2021-04-26 11603, 2021
17:54 PM
reosarevok
I guess we could. Also specifically mention that they need to escape .
2021-04-26 11612, 2021
17:54 PM
reosarevok
Since that's easy to forget
2021-04-26 11624, 2021
17:54 PM
reosarevok
(and we're not ignoring them after the @ anymore)
2021-04-26 11632, 2021
17:54 PM
bitmap
yeah
2021-04-26 11657, 2021
17:54 PM
bitmap
remove the Dumper lines too :)
2021-04-26 11650, 2021
17:56 PM
reosarevok
... duh
2021-04-26 11637, 2021
17:57 PM
bitmap also accidentally pushed some to the caa pr
2021-04-26 11610, 2021
18:00 PM
reosarevok
2021-04-26 11611, 2021
18:00 PM
BrainzBot
MBS-11620: Sort results of admin's search_by_email tool newest first
2021-04-26 11654, 2021
18:01 PM
bitmap
reosarevok: makes sense
2021-04-26 11613, 2021
18:02 PM
reosarevok
Ok
2021-04-26 11622, 2021
18:03 PM
reosarevok
"Don’t forget to escape \. and \+! And keep in mind the search ignores periods and any sections after + in the user side of the address (before the @) to help you find address aliases."
2021-04-26 11634, 2021
18:03 PM
reosarevok
bitmap: ^ ?
2021-04-26 11640, 2021
18:04 PM
_lucifer
ruaok: accepted. thanks!
2021-04-26 11646, 2021
18:04 PM
yvanzo
reosarevok: I did not test my suggestions though :P
2021-04-26 11601, 2021
18:05 PM
reosarevok
yvanzo: I know, one bit was wrongly escaped :) I did now
2021-04-26 11619, 2021
18:05 PM
yvanzo
Thanks!
2021-04-26 11650, 2021
18:05 PM
reosarevok
yvanzo: does that message on the email search page seem sensible to you?
2021-04-26 11657, 2021
18:05 PM
bitmap
reosarevok: sounds good to me
2021-04-26 11615, 2021
18:06 PM
yvanzo
reosarevok: link to the documentation maybe?
2021-04-26 11636, 2021
18:06 PM
reosarevok
yvanzo: there's a link to the POSIX docs above
2021-04-26 11642, 2021
18:06 PM
reosarevok
2021-04-26 11656, 2021
18:06 PM
reosarevok
This is just a reminder because I keep forgetting to escape the stuff even though I know I should :D
2021-04-26 11620, 2021
18:07 PM
yvanzo
Cool, just add <code> tags if possible.
2021-04-26 11612, 2021
18:09 PM
reosarevok
yvanzo: sure! only to the two escaped bits on the first half or also to + and @ later?
2021-04-26 11645, 2021
18:11 PM
reosarevok
I'll do all I guess :)
2021-04-26 11616, 2021
18:12 PM
yvanzo
Thanks!
2021-04-26 11600, 2021
18:16 PM
reosarevok
yvanzo, bitmap: updated PR, added the change to make it DESC too
2021-04-26 11614, 2021
18:16 PM
reosarevok goes ride his bike a bit, if this is fine I can merge it later or in the morning and do a beta release
2021-04-26 11635, 2021
18:16 PM
reosarevok
If there's anything else that can go into beta, then I'll merge it too (haven't checked yet)
2021-04-26 11648, 2021
18:17 PM
yvanzo
Ok, I will review more PRs til tomorrow morning too.
2021-04-26 11621, 2021
18:32 PM
_lucifer
2021-04-26 11604, 2021
18:33 PM
_lucifer
this is still using old setup so can't attribute to spark upgrade.
2021-04-26 11647, 2021
18:35 PM
BrainzGit
2021-04-26 11623, 2021
19:09 PM
CatQuest
alastairp: neat! I'll make special notice to allow plausible in RequestPolicy
2021-04-26 11622, 2021
19:15 PM
_lucifer
ruaok: alastairp: the container has gone silent. no logs. i setup tunnel to Spark UI. the jobs appear running there. sentry shows nothing as well. this is when i removed SparkIntegration and just ran plain sentry.
2021-04-26 11651, 2021
19:15 PM
_lucifer
for now, I am leaving it like this because it is working. let's take a look into this tomorrow.
2021-04-26 11610, 2021
19:32 PM
yvanzo has quit
2021-04-26 11651, 2021
19:49 PM
yvanzo joined the channel
2021-04-26 11632, 2021
20:07 PM
BrainzGit
2021-04-26 11615, 2021
20:27 PM
_lucifer
2021-04-26 11611, 2021
21:22 PM
thomasross joined the channel
2021-04-26 11613, 2021
21:25 PM
thomasross has quit
2021-04-26 11641, 2021
21:25 PM
thomasross joined the channel
2021-04-26 11649, 2021
21:52 PM
d4rkie has quit
2021-04-26 11619, 2021
21:53 PM
d4rkie joined the channel
2021-04-26 11630, 2021
21:53 PM
D4RK joined the channel
2021-04-26 11621, 2021
21:55 PM
D4RK-PH0ENiX has quit
2021-04-26 11624, 2021
23:16 PM
yvanzo has quit
2021-04-26 11621, 2021
23:22 PM
yvanzo joined the channel
2021-04-26 11630, 2021
23:39 PM
d4rkie has quit
