need to add a flag to control whether to accept or reject listens if email is misisng.
2021-05-03 12353, 2021
alastairp
ah, cool
2021-05-03 12300, 2021
alastairp
_lucifer: do you need some tasks to work on tomorrow morning? If so, I can spend 15 minutes going through some stuff
2021-05-03 12317, 2021
_lucifer
yeah sure.
2021-05-03 12336, 2021
alastairp
(if you don't need things to work on, we can do it tomorrow when I turn up)
2021-05-03 12327, 2021
_lucifer
i am fine either way, i can review some PRs tomorrow morning then and prepare for upgrading apps to BU 2.
2021-05-03 12353, 2021
alastairp
I'd prefer that if you don't mind
2021-05-03 12319, 2021
_lucifer
sure. let's discuss AB tomorrow then.
2021-05-03 12330, 2021
alastairp
thanks
2021-05-03 12317, 2021
BrainzGit
[musicbrainz-server] mwiencek opened pull request #2082 (master…mbs-11438-2): MBS-10962, MBS-11438, MBS-11460: Speed up listing artist releases/release groups https://github.com/metabrainz/musicbrainz-server/…
I have received one mailed in review, so… ruaok: Go!
2021-05-03 12313, 2021
Freso
ruaok says…
2021-05-03 12314, 2021
Freso
"""
2021-05-03 12314, 2021
Freso
Last week I:
2021-05-03 12315, 2021
Freso
- Worked to coordinate GSoC applications
2021-05-03 12315, 2021
Freso
- Added revamped metrics submission support to BrainzUtils
2021-05-03 12316, 2021
Freso
- Did LB code reviews
2021-05-03 12316, 2021
Freso
- Fixed LB dumps since the spark cluster migration.
2021-05-03 12317, 2021
Freso
- did usual MeB admin tasks
2021-05-03 12317, 2021
Freso
"""
2021-05-03 12318, 2021
Freso
Other people up for review: _lucifer, Freso, alastairp, reosarevok, yvanzo, Mr_Monkey, bitmap, zas, shivam-kapila, CatQuest – if anyone else out there would like to give review, please just let me know. :)
2021-05-03 12351, 2021
Freso
_lucifer: Go!
2021-05-03 12301, 2021
_lucifer
Hi all!
2021-05-03 12332, 2021
_lucifer
I worked last week on testing the Youtube Player more and fixing bugs in it.
2021-05-03 12356, 2021
_lucifer
I added also some more tests and docs to it.
2021-05-03 12356, 2021
_lucifer
Further, I worked on diagnosing the build image workflow, spark tests workflow and spark logging.
2021-05-03 12304, 2021
_lucifer
that's it for me.
2021-05-03 12308, 2021
_lucifer
alastairp: next?
2021-05-03 12312, 2021
alastairp
hi
2021-05-03 12323, 2021
alastairp
Last week I cleaned up a few more open LB reviews. with ruaok we had a discussion finally figured out how to move ahead with capturing stats from BU, and reviewed and merged that PR
2021-05-03 12328, 2021
alastairp
I merged some final PRs and released BU 2.0, this is python 3-only and has some new features and some breaking API changes (hence the major version bump)
2021-05-03 12334, 2021
alastairp
I did some work with Mr_Monkey looking at some improvements to the way that we can pass data from the LB server to the react frontend. I helped _lucifer with some things around LB oauth login and email addresses, and spotify/youtube auth
2021-05-03 12338, 2021
alastairp
I did some further analysis of genres from this genre dataset that I created a few years ago, and will have it ready this week to propose to reosarevok to import into MB (allowing us to do genre-based recommendations in LB)
2021-05-03 12343, 2021
alastairp
Freso: next?
2021-05-03 12354, 2021
Freso
👋
2021-05-03 12301, 2021
Freso
I dealt with a number of reported editors, and other than that I’ve mostly been stressing over uni assignments.
2021-05-03 12304, 2021
Freso
fin.
2021-05-03 12312, 2021
Freso
reosarevok: Go!
2021-05-03 12333, 2021
CatQuest
hmm
2021-05-03 12308, 2021
Freso
CatQuest: Go!
2021-05-03 12308, 2021
reosarevok
Hi! I looked at some small patches, did some code review, improved schema change PRs
2021-05-03 12312, 2021
Freso
Oh.
2021-05-03 12343, 2021
reosarevok
Also sat on a meeting with ruaok that was interesting
2021-05-03 12300, 2021
reosarevok
Now it's mostly going to be schema change testing I expect :)
2021-05-03 12305, 2021
reosarevok
CatQuest: you?
2021-05-03 12308, 2021
CatQuest
Meow! `😺`
2021-05-03 12308, 2021
CatQuest
Still adding many works and books to BB
2021-05-03 12317, 2021
CatQuest
Been thinking about how best to write tickets.
2021-05-03 12319, 2021
Mr_Monkey
🎉
2021-05-03 12328, 2021
CatQuest
:D
2021-05-03 12330, 2021
CatQuest
Finally thinking about how to re-enable CotM, (this time for non-classical) hoping to get people on board for that eventually.
2021-05-03 12330, 2021
CatQuest
Hopefully after these book-works I'll have some time to add instruments too.
2021-05-03 12348, 2021
CatQuest
♈
2021-05-03 12348, 2021
CatQuest
fin, go Mr_Monkey ?
2021-05-03 12356, 2021
Mr_Monkey
Hi everyone!
2021-05-03 12328, 2021
Mr_Monkey
Last week I worked on refactoring the API service in ListenBrainz's front-end, and finished that today.
2021-05-03 12343, 2021
Mr_Monkey
Also finished another big refactor PR for LB
2021-05-03 12346, 2021
Freso
(People still up: yvanzo, bitmap, zas, shivam-kapila – if anyone else out there would like to give review, please just let me know.)
2021-05-03 12305, 2021
Mr_Monkey
Worked on fixing issues with BrainzPlayer and reviewed _lucifer 's work on the new Youtube search
also reviewed/merged pending PRs for 2.7 (most notably the huge patch for file naming editor by rdswift, a very nice improvement)
2021-05-03 12348, 2021
zas
I upgraded discourse (upgrade broke, small downtime, fixed)
2021-05-03 12305, 2021
BrainzGit
[listenbrainz-server] amCap1712 opened pull request #1422 (master…require-email): LB-849: Require users to have a confirmed email before creating an LB account https://github.com/metabrainz/listenbrainz-server…
2021-05-03 12307, 2021
zas
plus usual maintenance, supervision, upgrades, user support
(Only yvanzo and shivam-kapila are left on my list. Last call for anyone else who may want to give review!)
2021-05-03 12334, 2021
bitmap
finally finished the pgtap tests there and worked on manually testing the code a bit more
2021-05-03 12305, 2021
ShivamAwasthi
Can i also give review? '=D
2021-05-03 12314, 2021
bitmap
I had an idea of how to make the materialized tables a bit more efficient that unfortunately didn't work out, but I did make the triggers more lightweight, so less updates are needed per transaction
2021-05-03 12317, 2021
Freso
ShivamAwasthi: Yes, absolutely. :)
2021-05-03 12344, 2021
bitmap
other than that I worked on on the commits for upgrading Perl/Node, as we announced as part of the schema change blog post
2021-05-03 12351, 2021
bitmap
fin. yvanzo go
2021-05-03 12300, 2021
yvanzo
hi!
2021-05-03 12302, 2021
zas
bitmap: thanks for working on this
2021-05-03 12312, 2021
Freso
(Only shivam-kapila and ShivamAwasthi are left on my list. Last call for anyone else who may want to give review!)
2021-05-03 12319, 2021
yvanzo
Last week I reviewed more MBS PRs and continued to work on schema change.
2021-05-03 12346, 2021
yvanzo
I resolved an issue in musicbrainz-docker when recreating `mq` container.
2021-05-03 12359, 2021
yvanzo
That was mostly triggered when running `docker-compose down`.
2021-05-03 12318, 2021
yvanzo
Thanks to nelgin’s patience with reproducing that issue.
2021-05-03 12332, 2021
yvanzo
Plus usual support and tickets triage. Fin!
2021-05-03 12342, 2021
yvanzo
Go shivam-kapila!
2021-05-03 12351, 2021
shivam-kapila
Hi everyone
2021-05-03 12304, 2021
shivam-kapila
Long time since a review. Not much to report
2021-05-03 12328, 2021
shivam-kapila
I tested the android app a little and saw an bug which is already known
2021-05-03 12347, 2021
shivam-kapila
Apart from that gave a lil review for LB thing
2021-05-03 12356, 2021
shivam-kapila
Fin. ShivamAwasthi go!
2021-05-03 12359, 2021
ShivamAwasthi
Hi everyone!
2021-05-03 12303, 2021
CatQuest
hi!
2021-05-03 12306, 2021
ShivamAwasthi
Been lurking around these meetings since January, so I figured I'll also start saying Hi.
Almost done with it. This week, I'll see if there are more tickets I can work on.
2021-05-03 12331, 2021
ShivamAwasthi
That's it for me. Fin!
2021-05-03 12306, 2021
CatQuest
ShivamAwasthi: there are TONS of tickes <3 <3
2021-05-03 12328, 2021
Freso
Alright!
2021-05-03 12328, 2021
CatQuest
(and soon will be more :D)
2021-05-03 12337, 2021
Freso
Thank you everyone who gave review. :)
2021-05-03 12302, 2021
Freso
We technically have one more item on the agenda, but I’m pretty sure it’s only there to remind ruaok to add ticket(s) for it, so…
2021-05-03 12324, 2021
CatQuest
really short meeting today. really fast and streamline
2021-05-03 12324, 2021
CatQuest
!m us
2021-05-03 12324, 2021
BrainzBot
You're doing good work, us!
2021-05-03 12347, 2021
Freso
I will just throw this one out there for ruaok’s and other devs’ consideration when looking into this, since it seems to have some relevant insights: https://seirdy.one/2021/04/16/permissions-policy-…
2021-05-03 12358, 2021
Freso
And that about wraps up this meeting!
2021-05-03 12314, 2021
Mr_Monkey
Thanks !
2021-05-03 12323, 2021
Freso
Thank you everyone for your time! Stay safe and take care of yourselves and those around you! ❤️
