#metabrainz

/

      • Lotheric has quit
      • 2021-05-04 12404, 2021

      • Lotheric joined the channel
      • 2021-05-04 12402, 2021

      • heyoni has quit
      • 2021-05-04 12402, 2021

      • heyoni_ has quit
      • 2021-05-04 12446, 2021

      • thomasross has quit
      • 2021-05-04 12412, 2021

      • BrainzGit
        [musicbrainz-server] mwiencek opened pull request #2083 (schema-change-2021-q2…perl-5.30-node-16): Require Perl v5.30, Node v16 https://github.com/metabrainz/musicbrainz-server/…
      • 2021-05-04 12449, 2021

      • ephemer0l is now known as GeneralDiscourse
      • 2021-05-04 12437, 2021

      • Zhele has quit
      • 2021-05-04 12409, 2021

      • Zhele joined the channel
      • 2021-05-04 12429, 2021

      • sumedh joined the channel
      • 2021-05-04 12453, 2021

      • sumedh has quit
      • 2021-05-04 12421, 2021

      • sumedh joined the channel
      • 2021-05-04 12419, 2021

      • sumedh has quit
      • 2021-05-04 12408, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #2084 (schema-change-2021-q2…remove-sequence-26-checks): Remove checks for schema sequence 26 https://github.com/metabrainz/musicbrainz-server/…
      • 2021-05-04 12443, 2021

      • Etua joined the channel
      • 2021-05-04 12457, 2021

      • Etua has quit
      • 2021-05-04 12415, 2021

      • alastairp
        morning
      • 2021-05-04 12418, 2021

      • alastairp
        _lucifer: whenever you want
      • 2021-05-04 12423, 2021

      • ruaok
        mooooin
      • 2021-05-04 12437, 2021

      • ruaok
        any PRs I should pay attention to today?
      • 2021-05-04 12425, 2021

      • ruaok
        alastairp: it would be nice to get your input on #1421
      • 2021-05-04 12410, 2021

      • alastairp
        it's on my radar
      • 2021-05-04 12425, 2021

      • alastairp
        I'm just finishing a paper review, will be there in 30-60 mins
      • 2021-05-04 12442, 2021

      • ruaok
        thx
      • 2021-05-04 12405, 2021

      • ruaok
        zas: should we attempt to schedule gaga's fan replacement today?
      • 2021-05-04 12428, 2021

      • alastairp
        ruaok: going to do a db backup first?
      • 2021-05-04 12407, 2021

      • ruaok
        for the fan upgrade? I wasn't planning on. at least a full dump was just put out.
      • 2021-05-04 12430, 2021

      • ruaok
        and an incremental dump from 3am.
      • 2021-05-04 12422, 2021

      • _lucifer
        alastairp: hi! i am available.
      • 2021-05-04 12428, 2021

      • _lucifer
        ruaok: alastairp: can you take a look at https://github.com/metabrainz/listenbrainz-server… ? i need to apply the db changes in that to test on beta.
      • 2021-05-04 12411, 2021

      • alastairp
        cool, let me finish this review, then we can discuss AB, then I'll do 1421, then I'll do 1422
      • 2021-05-04 12435, 2021

      • _lucifer
        sure, thanks!
      • 2021-05-04 12450, 2021

      • ruaok
        _lucifer: #1422 done.
      • 2021-05-04 12439, 2021

      • _lucifer
        ruaok: thanks! i'll apply the db changes and test on beta.
      • 2021-05-04 12453, 2021

      • Freso
        If I delete a user from the LB admin interface, that also deletes all their listens? Just making sure before I go ahead with sockpuppet cleanup.
      • 2021-05-04 12421, 2021

      • reosarevok
        _lucifer, ruaok ^
      • 2021-05-04 12415, 2021

      • Freso
        https://github.com/metabrainz/listenbrainz-server… seems to call https://github.com/metabrainz/listenbrainz-server… - just not sure if that former method gets called when deleting from the admin interface.
      • 2021-05-04 12415, 2021

      • Mr_Monkey
        alastairp and _lucifer : Also waving PR #1390 so you remember it's here and waiting for review :)
      • 2021-05-04 12415, 2021

      • Mr_Monkey
      • 2021-05-04 12427, 2021

      • Mr_Monkey goes fix the file conflict on it
      • 2021-05-04 12434, 2021

      • Mr_Monkey
        Also, hello !
      • 2021-05-04 12426, 2021

      • ruaok
        why do we have two delete functions? that seems nonsense.
      • 2021-05-04 12453, 2021

      • ruaok
        Freso: do you have a user name that was previously deleted? I can check the DB to ensure that the listens are gone via that method. they should, but lets check.
      • 2021-05-04 12441, 2021

      • _lucifer
        I tested locally, the listens do no get removed if the user is removed through admin interface.
      • 2021-05-04 12402, 2021

      • ruaok
        that is odd.
      • 2021-05-04 12411, 2021

      • ruaok
        running query now. will take a few moments to get results.
      • 2021-05-04 12439, 2021

      • ruaok
        gah. confirming _lucifer. listens are not deleted.
      • 2021-05-04 12405, 2021

      • _lucifer
        the admin interface is a ui layer on SqlAlchemy. deleting from admin is equal to the db_user call only. it does not touch timescale.
      • 2021-05-04 12420, 2021

      • Freso
        I’m typing up a ticket now. :)
      • 2021-05-04 12449, 2021

      • ruaok
        for now, tell me which users need deleting, and I'll remove their listens manually.
      • 2021-05-04 12404, 2021

      • zas
        ruaok: ok for gaga, if ready
      • 2021-05-04 12440, 2021

      • zas
        any preference for time?
      • 2021-05-04 12442, 2021

      • ruaok
        zas: no yet. will need to wait for alastairp to approve a PR.
      • 2021-05-04 12449, 2021

      • zas
        ah ok
      • 2021-05-04 12435, 2021

      • ruaok
        but once we have that, we can schedule a time. perhaps this afternoon, maybe 4pm.
      • 2021-05-04 12444, 2021

      • _lucifer
        Mr_Monkey: thanks for reminding. i'll review it today soon.
      • 2021-05-04 12458, 2021

      • ruaok
        4471 listens deleted for user pjmkth
      • 2021-05-04 12446, 2021

      • Freso
      • 2021-05-04 12447, 2021

      • BrainzBot
        LB-876: Listens for a user do not get removed if user is deleted via admin interface
      • 2021-05-04 12401, 2021

      • Freso
        ruaok: Will do.
      • 2021-05-04 12411, 2021

      • _lucifer
        ruaok: starting beta fails with docker: Error response from daemon: error while creating mount source path '/mnt/dumps': mkdir /mnt/dumps: file exists.
      • 2021-05-04 12439, 2021

      • Sophist-UK joined the channel
      • 2021-05-04 12416, 2021

      • ruaok
        sounds like the mkdir is missing a `-p` option
      • 2021-05-04 12434, 2021

      • ruaok
        buy why fail now?
      • 2021-05-04 12407, 2021

      • _lucifer
        i restarted the container so probably it tried to create again?
      • 2021-05-04 12429, 2021

      • alastairp
        ok, I'm here
      • 2021-05-04 12454, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #2085 (master…MBS-11630): MBS-11630: Do not break on empty edits array https://github.com/metabrainz/musicbrainz-server/…
      • 2021-05-04 12408, 2021

      • alastairp
        that error message sounds like it might be related to the -v flag
      • 2021-05-04 12424, 2021

      • ruaok
        alastairp: it is.
      • 2021-05-04 12428, 2021

      • ruaok
        alastairp: #1421 please.
      • 2021-05-04 12453, 2021

      • alastairp
        which is a bit weird because I didn't even think that docker tried to make a directory passed as the first part of -v
      • 2021-05-04 12456, 2021

      • alastairp
        looking at 1421 now
      • 2021-05-04 12459, 2021

      • _lucifer
        ruaok, where should i add that?
      • 2021-05-04 12440, 2021

      • ruaok
        not sure. looking.
      • 2021-05-04 12410, 2021

      • ruaok
        at first I though it was related to dump logging, but its not. its dump output.
      • 2021-05-04 12449, 2021

      • ruaok
        hmm. something strange is going on with our storage box, methinks.
      • 2021-05-04 12401, 2021

      • ruaok
      • 2021-05-04 12448, 2021

      • ruaok
        I think it is time to ditch this storage box and have newlemmy have an extra spinning disk attached.
      • 2021-05-04 12457, 2021

      • ruaok
        _lucifer: hang on a few minutes.
      • 2021-05-04 12409, 2021

      • _lucifer
        sure
      • 2021-05-04 12429, 2021

      • ruaok
        storage box detached. try it now.
      • 2021-05-04 12457, 2021

      • ruaok
        for an extra 30eur we could get 1.92TB * 2 and 128GB of ram and 12/24 cores as a lemmy replacement.
      • 2021-05-04 12403, 2021

      • ruaok
        sounding pretty sexy.
      • 2021-05-04 12435, 2021

      • _lucifer
        works now, thanks!
      • 2021-05-04 12401, 2021

      • ruaok
        ah, yes, it is scheduled storage box maintenance.
      • 2021-05-04 12412, 2021

      • shivam-kapila
        128 gig ram noice
      • 2021-05-04 12432, 2021

      • _lucifer
      • 2021-05-04 12448, 2021

      • shivam-kapila
        *stop accepting your listen submissions? (Just being choosy ;))
      • 2021-05-04 12415, 2021

      • shivam-kapila
        _lucifer: does this come up on every page or only on homepage?
      • 2021-05-04 12435, 2021

      • ruaok
        if we stop using the storage box, we save 10eur. meaning that the extra server is only 25eur more a month. I think we should do that. will make everything a bit better.
      • 2021-05-04 12452, 2021

      • ruaok
        _lucifer: looks great.
      • 2021-05-04 12456, 2021

      • _lucifer
        shivam-kapila: only home page. once every time you login.
      • 2021-05-04 12426, 2021

      • shivam-kapila
        Cool cool.
      • 2021-05-04 12409, 2021

      • _lucifer
        we can show as many times as we want easily though, because LB will start storing emails when the PR is merged.
      • 2021-05-04 12453, 2021

      • Etua joined the channel
      • 2021-05-04 12430, 2021

      • shivam-kapila
        I was just thinking if we should show it on listens or "add data" page too?
      • 2021-05-04 12401, 2021

      • alastairp
        ruaok: reviewed. 2 points to address: 1) do we want to say in the html page that listen submission still works? 2) lastfm api uses xml not json. important for the duration of downtime that we expect?
      • 2021-05-04 12411, 2021

      • alastairp
        other points can be added to a ticket for future improvements
      • 2021-05-04 12455, 2021

      • ruaok
        skip the tickets. lets do it right.
      • 2021-05-04 12400, 2021

      • ruaok
        lets do it now.
      • 2021-05-04 12410, 2021

      • ruaok
        zas: we'll get this approved very soon.
      • 2021-05-04 12429, 2021

      • ruaok
        can you please contact hetzner and have the gaga fan scheduled for replacement at 16h CEST?
      • 2021-05-04 12451, 2021

      • alastairp
        ruaok: there's a can of worms related to how we call `timescale.init_db_connection` which I'm unclear about how easily we can resolve
      • 2021-05-04 12405, 2021

      • alastairp
        I can take on xml output for lastfm
      • 2021-05-04 12408, 2021

      • zas
        ruaok: ok
      • 2021-05-04 12437, 2021

      • ruaok
        alastairp: I'll start on the other little bits.
      • 2021-05-04 12402, 2021

      • ruaok
        return None and saving listens message fixed.
      • 2021-05-04 12406, 2021

      • Freso
        ruaok: Working on the more comprehensive list, but `WaxCastlez%` at least are good to wipe. They have a couple more usernames I’m digging out that doesn’t match that pattern. I’ll give a full report once I’ve compiled the full list.
      • 2021-05-04 12431, 2021

      • ruaok
        where % is the wildcard in PG SQL terms?
      • 2021-05-04 12453, 2021

      • Freso
        Yeah.
      • 2021-05-04 12450, 2021

      • ruaok
        k. I'm fetching a full list of user names that fit that bill for double checking.
      • 2021-05-04 12437, 2021

      • Freso
        https://musicbrainz.org/search?query=WaxCastlez&a… had 61 results when I started going through them. The cluster has a few more accounts that I’m getting to by other means.
      • 2021-05-04 12403, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #2086 (master…MBS-11622): MBS-11622: Clean up Apple Music label URLs https://github.com/metabrainz/musicbrainz-server/…
      • 2021-05-04 12438, 2021

      • reosarevok
        !m Freso
      • 2021-05-04 12438, 2021

      • BrainzBot
        You're doing good work, Freso!
      • 2021-05-04 12447, 2021

      • ruaok
        zas: thanks. we're on for 16h today.
      • 2021-05-04 12432, 2021

      • ruaok
        Freso: 43 distinct users have listens. will delete.
      • 2021-05-04 12417, 2021

      • reosarevok
        bitmap, yvanzo: I'm planning to be off for my birthday 11-13 May btw. Should be able to answer messages and whatnot but I'm not having my laptop with me
      • 2021-05-04 12428, 2021

      • reosarevok
        Let's try to make sure we have everything merged and in testing by then? ;)
      • 2021-05-04 12436, 2021

      • ruaok
        LB listendb downtime tweeted.
      • 2021-05-04 12452, 2021

      • alastairp
        reosarevok: 3 day birthday? lucky. mine is only 1 day
      • 2021-05-04 12458, 2021

      • reosarevok
        haha
      • 2021-05-04 12426, 2021

      • reosarevok
        What can I say, I'm a big guy, takes a while for the likes of us
      • 2021-05-04 12451, 2021

      • CatQuest is usually off for 2 days sooo
      • 2021-05-04 12455, 2021

      • CatQuest
        (re birthdays)
      • 2021-05-04 12457, 2021

      • CatQuest
        also
      • 2021-05-04 12400, 2021

      • CatQuest
        !m Freso !!
      • 2021-05-04 12400, 2021

      • BrainzBot
        You're doing good work, Freso !!!
      • 2021-05-04 12423, 2021

      • ruaok
        394456 listens deleted from waxcastlez*
      • 2021-05-04 12405, 2021

      • reosarevok
        Jeez
      • 2021-05-04 12456, 2021

      • CatQuest
        hmph. away with the spammers!
      • 2021-05-04 12407, 2021

      • alastairp
        just doing an integration test for lastfm api
      • 2021-05-04 12450, 2021

      • reosarevok
        Freso: btw, dunno if you saw, but I made the changes you wanted for the admin email search in MB, should be live now
      • 2021-05-04 12420, 2021

      • Freso
        reosarevok: I did. :) Already very useful!
      • 2021-05-04 12431, 2021

      • reosarevok
        Yay
      • 2021-05-04 12436, 2021

      • Freso
        CatQuest: From what I could tell, it seemed like each individual "WaxCastle" user was "promoting" a subset of artists/tracks. They didn’t seem to have a lot of overlap between them, IIRC. (Unlike some of the other spammer clusters.)
      • 2021-05-04 12410, 2021

      • CatQuest
        wait so like sb17 or what spammers voting that up?
      • 2021-05-04 12417, 2021

      • CatQuest
        (by submitting listens)
      • 2021-05-04 12402, 2021

      • Etua has quit
      • 2021-05-04 12438, 2021

      • Etua joined the channel
      • 2021-05-04 12441, 2021

      • Mr_Monkey
        And sure enough, WaxCastlez is a company that provides these sort of playcount bots.
      • 2021-05-04 12441, 2021

      • Mr_Monkey
        > Promote your music on one of our Premium, Genre Specific, Spotify playlists. These playlists are promoted, stay within 120 minutes and are listened to by our curators 24/7!
      • 2021-05-04 12446, 2021

      • Mr_Monkey
        And if anyone is looking for webdesign inspiration: https://waxcastlez.com/
      • 2021-05-04 12451, 2021

      • Higilopochtli[m] joined the channel
      • 2021-05-04 12431, 2021

      • sumedh joined the channel
      • 2021-05-04 12424, 2021

      • Guest68 joined the channel
      • 2021-05-04 12409, 2021

      • Guest68 has quit
      • 2021-05-04 12440, 2021

      • alastairp
        Newz
      • 2021-05-04 12451, 2021

      • alastairp
        they'd fit right in on *brainz
      • 2021-05-04 12420, 2021

      • alastairp
        wtf. seems like bits of the lastfm compat api never worked