Last week a new version of musicbrainz-docker has been released.
2021-05-10 13050, 2021
yvanzo
It requires specific steps if search live indexing is enabled.
2021-05-10 13059, 2021
yvanzo
Plus continued schema change code, reviews, and support.
2021-05-10 13000, 2021
Freso
I guess it’s one less attack surface, though not sure how big one it is. 🤷
2021-05-10 13002, 2021
CatQuest is now known as ChatQuest
2021-05-10 13013, 2021
yvanzo
Fin. Go ChatQuest!
2021-05-10 13017, 2021
ChatQuest
:D
2021-05-10 13035, 2021
ChatQuest
Meow! `😺`
2021-05-10 13036, 2021
ChatQuest
I don't really have anything today, but I want to use this opportunity to say that next monday is *both* Norway's National holiday (birthday, if you will) *and* the International Day Against Homophobia and Transphobia!
2021-05-10 13036, 2021
ChatQuest
so I /probably/ won't be here. then maybe, we'll see :D
2021-05-10 13043, 2021
ChatQuest
Freso: ^^for next monday!
2021-05-10 13050, 2021
ChatQuest
♈
2021-05-10 13050, 2021
ChatQuest
fin, go reosarevok
2021-05-10 13055, 2021
reosarevok
Hi!
2021-05-10 13056, 2021
Freso
Eh. Remind me closer to next Monday.
2021-05-10 13000, 2021
ChatQuest
oh no.
2021-05-10 13004, 2021
ChatQuest will try
2021-05-10 13021, 2021
Freso
(People still up: _lucifer, bitmap, Mr_Monkey, ruaok, Freso – anyone else who might want to give review, let me know ASAP.)
2021-05-10 13028, 2021
reosarevok
I spent the week mostly reviewing schema change code, fixing small issues in my schema change code, and working on a couple small tickets
So, I hope my implementation is good, because that'd be neat to have (for all those people who are disappointed they used "hip-hop" and it doesn't get seen as a genre)
2021-05-10 13026, 2021
ChatQuest
<3 <3 <3
2021-05-10 13051, 2021
reosarevok
Anyway. This week is my birthday so I'll be off from tomorrow, enjoying the 20ºC weather and looking at some birds
2021-05-10 13003, 2021
reosarevok
(inb4 unexpected storm and no birds)
2021-05-10 13005, 2021
Mr_Monkey
Enjoy birthday time !
2021-05-10 13012, 2021
reosarevok
Back on Thursday evening or Friday
2021-05-10 13016, 2021
Freso
birdday time? 🤔
2021-05-10 13021, 2021
ChatQuest
:D
2021-05-10 13024, 2021
reosarevok
Por qué no los dos
2021-05-10 13033, 2021
ChatQuest
:DDDD
2021-05-10 13034, 2021
reosarevok
I'll try to make sure I do all I can for schema changes tonight before I go tho :)
2021-05-10 13038, 2021
reosarevok
bitmap: what about you?
2021-05-10 13042, 2021
bitmap
hey
2021-05-10 13004, 2021
bitmap
I spent most of last week on schema change tasks. testing upgrade scripts & making sure ci is passing
2021-05-10 13025, 2021
bitmap
resolved some annoying selenium test failures related to the perl/node upgrades
2021-05-10 13049, 2021
bitmap
some of the upgrade scripts are quite complex, so I worked on some tests that run those and check it against the expected schema
2021-05-10 13012, 2021
bitmap
(as created fresh from the schema change branch)
2021-05-10 13031, 2021
bitmap
so far things look good. I'll run a full migration test this week and work on upgrade notes afterward :)
2021-05-10 13042, 2021
bitmap
fin! go Freso
2021-05-10 13044, 2021
Freso
o/
2021-05-10 13021, 2021
Freso
So, I’ve done a bunch of dealing with reported editors and also followed up on one of the clusters that’d been spamming LB and cleaned up a bunch of accounts together with Rob.
2021-05-10 13039, 2021
Freso
Other than that, mostly being around and about.
2021-05-10 13012, 2021
reosarevok
Yay, whackaspammer
2021-05-10 13043, 2021
Freso
Off-hours I’ve taken over maintainership of isrcsubmit (and, by extension, apparently python-discid 🙈 ), so been poking at that a bit too, getting a 2.1.1 release ready which will mark the end of Python 2(.6!!!!) support for that project.
2021-05-10 13027, 2021
Freso
isrcsubmit 3.0.0 will only support Python 3.
2021-05-10 13047, 2021
Freso
fin.
2021-05-10 13055, 2021
c1e0
Happy birthday in advance, reosarevok
2021-05-10 13059, 2021
Freso
_lucifer: Go!
2021-05-10 13005, 2021
reosarevok
Thanks!
2021-05-10 13013, 2021
_lucifer
hi all!
2021-05-10 13040, 2021
Freso
(Only Mr_Monkey and ruaok left on my list. Last call for anyone else who may want to give review!)
2021-05-10 13024, 2021
_lucifer
Last week, I helped with upgrading timescaledb. I also worked on adding a report user button and enforcing email requirements for users.
2021-05-10 13010, 2021
_lucifer
Other than that, I did some work on the youtube player and hope to release that in a couple of days. I also discussed working on AB with alastairp.
2021-05-10 13015, 2021
_lucifer
that's it for me.
2021-05-10 13017, 2021
_lucifer
ruaok: next?
2021-05-10 13024, 2021
ruaok
k
2021-05-10 13002, 2021
ruaok
last week I spent loads of time on the listen count and timestamps / speed improvements PR and finally got that merged on friday.
2021-05-10 13023, 2021
ruaok
and then a user imported their last.fm data and the results were truly far worse than expected.
2021-05-10 13029, 2021
ruaok
incorrect, but FAST!
2021-05-10 13056, 2021
ruaok
I also moved the MBID background mapper along and that appears to be running fairly stably now.
2021-05-10 13041, 2021
ruaok
lots of convos with the team, PRs and today reosarevok ended up on a conference call together discussing some ISNI nonsense things. we may have finally found an ally in this mess.
2021-05-10 13047, 2021
ruaok
fin. Mr_Monkey ?
2021-05-10 13054, 2021
Mr_Monkey
Hi everyone !
2021-05-10 13000, 2021
Mr_Monkey
Monday I finished reviewing the GSoC project applications for BookBrainz.
2021-05-10 13000, 2021
Mr_Monkey
I’m taking this opportunity to thank anyone reading this that submitted a proposal !
2021-05-10 13017, 2021
Mr_Monkey
I also worked on three big PRs for LB:
2021-05-10 13023, 2021
Mr_Monkey
- Fighting front-end tests on #1390 only to realize I’m hitting this old phantom bug that fails or passes depending on the version of Node: LB-756
- Upgrading Node version as a consequence and adapting a few things to work with the new version. Merged that today for Node Upgrade Week (🎉)
2021-05-10 13051, 2021
Mr_Monkey
And CI front-end tests are passing again !
2021-05-10 13010, 2021
Mr_Monkey
- Refactoring the React front-end to use a global context with some app-wide props and an API service instance (instead of passing down a url through the component tree and creating many many instances of the service…). Lots of fighting with babel and typescript configs, everyone's favorite.
2021-05-10 13028, 2021
Mr_Monkey
I also worked on the design of the new music services connection page for LB, and reviewed a handful of PRs
2021-05-10 13039, 2021
Mr_Monkey
That's it for me !
2021-05-10 13043, 2021
Freso
Alright!
2021-05-10 13054, 2021
Freso
Thank you everyone who gave reviews. :)
2021-05-10 13017, 2021
alastairp
!m Mr_Monkey for dealing with JS so that we don't have to
2021-05-10 13017, 2021
BrainzBot
You're doing good work, Mr_Monkey for dealing with JS so that we don't have to!
2021-05-10 13019, 2021
Freso
We have one more item on the agenda, which is a reminder for ruaok to make a ticket about FLoC. ;)
2021-05-10 13038, 2021
alastairp
Freso: there was some interesting stuff that came up in a discussion about this last week
2021-05-10 13045, 2021
ruaok
well, was there more discussion about it?
2021-05-10 13050, 2021
Mr_Monkey
Does that mean ruaok is our shepperd?
2021-05-10 13002, 2021
ruaok
I don't think we have a clear consensus yet.
2021-05-10 13004, 2021
Freso
Alright.
2021-05-10 13004, 2021
alastairp
that people only get added to a floc cohort if a script on the page calls document.joinCohort, or somesuch
2021-05-10 13010, 2021
ruaok fetches his sheep cattleprod
2021-05-10 13027, 2021
alastairp
this means that especially on LB we'll have to be careful with the youtube player, which will probably call this
2021-05-10 13035, 2021
Freso
I personally think we should still include the header for good measure.
2021-05-10 13042, 2021
Mr_Monkey
^the above is likely on LB where we use youtube javascript libraries from google, and the spotify one might too
2021-05-10 13043, 2021
reosarevok
Probably can't hurt
2021-05-10 13053, 2021
shivam-kapila
(Freso: sorry for weekly nudging. I will be returning after exams as I have some things on my list to contribute. I will add my name then.)
2021-05-10 13054, 2021
ruaok
one question: are we in agreement that we want to opt out of floc or has that changed?
2021-05-10 13056, 2021
Freso
If nothing else, as a statement that we explicitly want no part in this.
2021-05-10 13057, 2021
alastairp
right, so the header should prevent us from accidentally joining a user to a cohort
2021-05-10 13009, 2021
ruaok
read: are we only talking implementation details?
2021-05-10 13022, 2021
alastairp
ruaok: yes, I think we're at the implementation detail now
2021-05-10 13028, 2021
Mr_Monkey
My vote goes for opting out explicitly.
2021-05-10 13037, 2021
Freso
ruaok: That’s my understanding, which is why I didn’t think it was something that needed covering today. :)
2021-05-10 13056, 2021
yvanzo
it seems the agreement did not change, the header thing seems to be implementation details
2021-05-10 13008, 2021
ruaok
just making sure we're not trampling on someone's changed opinion.
2021-05-10 13025, 2021
Freso
👍
2021-05-10 13025, 2021
ruaok
ok, then lets leave it for now.
2021-05-10 13026, 2021
ChatQuest
deffo op-out
2021-05-10 13027, 2021
yvanzo
or we can have a poll with all options if that is needed
2021-05-10 13031, 2021
ruaok
take the menu item out.
2021-05-10 13038, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
2021-05-10 13041, 2021
Freso
Alright.
2021-05-10 13041, 2021
ruaok
and lets keep our eyes peeled for the definitive way to do this.
2021-05-10 13050, 2021
ruaok
once that is clear, we can follow suit.
2021-05-10 13029, 2021
ruaok
fin.
2021-05-10 13040, 2021
Freso
If you have a ticket, I can link a couple of CMS’s’ ways of implementing this (WordPress, Drupal, Joomla, Umbraco all seem to have implemented the opt-out in their cores).
2021-05-10 13056, 2021
ruaok
too lazy and done with this day for a ticket.
2021-05-10 13002, 2021
Freso
Fair. :)
2021-05-10 13013, 2021
sumedh has quit
2021-05-10 13016, 2021
Freso
Anyway.
2021-05-10 13046, 2021
Freso
That’s that for today’s meeting! Thank you all for your time! Remember to take of and be kind to yourselves. ❤️
2021-05-10 13051, 2021
Freso
</BANG>
2021-05-10 13053, 2021
yvanzo
Thanks!
2021-05-10 13009, 2021
yvanzo
And happy birthweek reosarevok!
2021-05-10 13009, 2021
shivam-kapila
BTW when is the GSoC squad joining 🤔
2021-05-10 13020, 2021
shivam-kapila
Happy birthweek reo
2021-05-10 13021, 2021
zas
ruaok: I'll look into cert issues (and renewals) tomorrow
2021-05-10 13024, 2021
Mr_Monkey
Thanks !
2021-05-10 13042, 2021
Freso
shivam-kapila: The meetings? Probably when GSoC starts, I reckon. Or when they get their accepts.
2021-05-10 13001, 2021
shivam-kapila
(Oh I always thought its for a day :p)
2021-05-10 13013, 2021
shivam-kapila
Freso: the acceptances I mean.
2021-05-10 13016, 2021
_lucifer
happy birthweek reosarevok! 🎉
2021-05-10 13051, 2021
c1e0
o/ Thanks
2021-05-10 13029, 2021
reosarevok
ruaok: do you remember if we had a set of relationship/link types baaack in the day, then we got rid of those and started from scratch somehow?
2021-05-10 13042, 2021
reosarevok
I'm seeing IDs in old edit relationship type edit data that make no sense at all to me
alastairp: Your idea for the connect services page worked splendidly :D
2021-05-10 13007, 2021
alastairp
sweet
2021-05-10 13000, 2021
_lucifer
i took it one step further, currently it was link -> frontend -> send to link to backend. now its just pass the button name to backend and then generate the link accordingly
Mr_Monkey, there's one issue with the font size of description being a bit small. ideas how to fix that?
2021-05-10 13012, 2021
c1e0 has quit
2021-05-10 13027, 2021
BrainzGit
[critiquebrainz] dependabot-preview[bot] opened pull request #361 (master…dependabot/npm_and_yarn/codemirror-5.61.0): [Security] Bump codemirror from 5.45.0 to 5.61.0 https://github.com/metabrainz/critiquebrainz/pull…
