[mbsssss] yvanzo merged pull request #58 (masterā¦search-644-orderingattribute): SEARCH-644 (schema): Drop ordering attribute from searchable fields for series https://github.com/metabrainz/mbsssss/pull/58
2021-05-11 13136, 2021
ruaok
we really do need to upgrade to TS 2.2.1 it will help even more.
2021-05-11 13150, 2021
_lucifer
sure, let's do that tomorrow?
2021-05-11 13109, 2021
ruaok
hmm. maybe. let me see if I feel like asking for trouble in the morning.
nope, that was me manipulating redis keys by hand to diagnose shit.
2021-05-11 13153, 2021
ruaok
resolve that one please
2021-05-11 13158, 2021
_lucifer
š
2021-05-11 13150, 2021
shivam-kapila
Good work akshaaatt[m] . I really liked it
2021-05-11 13104, 2021
alastairp
_lucifer: mmm, the job ran - but we still have the issue with it not finding the cache?
2021-05-11 13130, 2021
shivam-kapila
ruaok: so our decision to delete cache during deletion was wrong. Surprized it wasnt caught before
2021-05-11 13132, 2021
alastairp
ahhh, wait a moment. `{"key":"layer-docker-layer-caching-Build image and publish to Docker Hub-9375077d0892e8055e23ba157f6ab0610acf56920b7eded3c54a6d7bb96e7580","cacheId":75471}` the key contains the job name??
2021-05-11 13145, 2021
_lucifer
yes right
2021-05-11 13149, 2021
_lucifer
that's the default
2021-05-11 13113, 2021
_lucifer
but we didn't change the name so i'd expect it to find cache
2021-05-11 13122, 2021
alastairp
oh - but the hope is that we should pick up some layers from the last time that this job was run - we don't need to pick up the cache from the tests
2021-05-11 13141, 2021
alastairp
never mind me then
2021-05-11 13106, 2021
_lucifer
i didn't the concern but we can customize the key names if we want
secondly, there was a rate limit error while saving cache at the end
2021-05-11 13134, 2021
alastairp
I'm reading the cache restore logs of unit tests and of the deploy, and they're very different
2021-05-11 13136, 2021
alastairp
never mind. too late in the day to look at this in more detail. will look later
2021-05-11 13145, 2021
_lucifer
š
2021-05-11 13115, 2021
akshaaatt[m]
<shivam-kapila "Good work akshaaatt . I really l"> Thanks! š shivam-kapila
2021-05-11 13108, 2021
Mr_Monkey
I will add a third voice, nice job akshaaatt[m] the UI looks much better
2021-05-11 13150, 2021
ruaok
Mr_Monkey: I wanna bend yer ear for a second....
2021-05-11 13107, 2021
Mr_Monkey
ruaok: Thanks for reporting the BP issue. In theory it shouldn't do anything by itself before a user tries to play a track, but I've seen it happen too
2021-05-11 13108, 2021
ruaok
I'm still stuck on the having multiple BrainzPlayer enabled tabs open at the same time.
2021-05-11 13129, 2021
Mr_Monkey
Ah. stuck?
2021-05-11 13132, 2021
ruaok
yeah, that is what is motivating this discussion.
2021-05-11 13103, 2021
ruaok
well, the user experience is poor. it is too easy to bop around LB and unintentionally disrupt your playback.
2021-05-11 13121, 2021
akshaaatt[m]
<Mr_Monkey "I will add a third voice, nice j"> Thanks Mr_Monkey š
2021-05-11 13137, 2021
ruaok
and even bouncing around the site while exploring stuff, having different BP tabs stepping on each other is... jarring.
2021-05-11 13102, 2021
ruaok
and we're lacking a browser level coordination mechanism to improve this, right?
2021-05-11 13122, 2021
ruaok
we have one already, but are not using it. our websockets.
2021-05-11 13134, 2021
ruaok
what if we repuposed them to transport listens and BP events?
2021-05-11 13140, 2021
Mr_Monkey
Correct. We talked about a possible solution using cross-tab messaging (I forget the name), but I haven't looked into it a lot
2021-05-11 13107, 2021
ruaok
first tab for a user that opens, will be selected as the "main" player.
2021-05-11 13134, 2021
ruaok
a second tab that opens up, can report its presence. it will either be told: you're main or main is ID XXXX.
2021-05-11 13119, 2021
ruaok
then, when a user clicks on a tab, we could call a server API to send a message to the main player. the server takes that message and zips it down the web socket connection to the main player.
2021-05-11 13147, 2021
Mr_Monkey
I don't think playing everything through a main player is a great solution
2021-05-11 13148, 2021
ruaok
events at the very least should be "play this track now"
2021-05-11 13108, 2021
Mr_Monkey
For me it would be very counter-intuitive to click to play a track in a tab and have it start playing in another tab
2021-05-11 13110, 2021
ruaok
can yo u descibe a better solution and we'll see if we can make it work with websockets?
2021-05-11 13133, 2021
Mr_Monkey
Let's discuss it in more detail tomorrow at the office, if you don't mind
2021-05-11 13139, 2021
ruaok
tbh, I hadn't really thought about the right workflow for this. I was just solving the cross tab coorindation issue
2021-05-11 13142, 2021
ruaok
ok.
2021-05-11 13107, 2021
Mr_Monkey
But in short, I think we need a way for *a* player in a tab to tell all other BP to shut the hell up
2021-05-11 13124, 2021
Mr_Monkey
Websocket's isn't a bad idea.
2021-05-11 13125, 2021
ruaok
puurfect. taht is what I needed to know.
2021-05-11 13133, 2021
ruaok
goes into the noggin for processing before tomorrow.
2021-05-11 13141, 2021
Mr_Monkey
Da
2021-05-11 13103, 2021
shivam-kapila
Mr_Monkey: there are some solutions centered around local storage or state management too
2021-05-11 13144, 2021
shivam-kapila
In this case if the state is playing is true for a tabs others should be set to false
Probably won't be available on old IE, or, say Firefox 43, but it won't impeded the UX too much.
2021-05-11 13130, 2021
shivam-kapila
Yeah this sounds a straight forward way. You might wanna take a look at service workers too
2021-05-11 13135, 2021
shivam-kapila
> AĀ service workerĀ is a script that your browser runs in the background, separate from a web page, opening the door to features that don't need a web page or user interaction. Today, they already include features likeĀ push notificationsĀ andĀ background syncĀ and haveĀ ability to intercept and handle network requests, includingĀ programmatically managing a cache of responses.
2021-05-11 13151, 2021
ruaok
I'm weary of using things that might have a tendency to get depricated.
2021-05-11 13152, 2021
Mr_Monkey
Thanks
2021-05-11 13158, 2021
Mr_Monkey
ruaok: I don't see anything about deprecation. Which one were you talking about?
2021-05-11 13119, 2021
ruaok
nothing specific.
2021-05-11 13138, 2021
ruaok
more a general comment about using less used tools for this job. less used stuff tends to go away.
2021-05-11 13153, 2021
Mr_Monkey
OK. Theres are all pretty new features, so no eyes on deprecation yet
2021-05-11 13106, 2021
Mr_Monkey
These are all*
2021-05-11 13133, 2021
Mr_Monkey
As a matter of fact, Service workers are a "Working Draft" status
2021-05-11 13136, 2021
ruaok
"pretty new" makes me unhappy from the opposite site of that spectrum.
2021-05-11 13109, 2021
ruaok
websockets are well supported and widespread in use. also, already implemented in our system.
2021-05-11 13130, 2021
Mr_Monkey
Oh, well I stand corrected, BroadcastChannel is actually implemented in FireFox > 38, so not that new
2021-05-11 13108, 2021
shivam-kapila
ruaok: was just looking into ways to prevent a round trip via the server :)
2021-05-11 13116, 2021
Mr_Monkey
And also pretty well supportedā¦ except all versions of IE (expected) and Safari (including on phone). Gah.
2021-05-11 13120, 2021
CatQuest
[19:54] <Mr_Monkey> But in short, I think we need a way for *a* player in a tab to tell all other BP to shut the hell up <-- :D
2021-05-11 13135, 2021
Mr_Monkey
postMessage has better browser support and might totally be enough for what we want to do. My vote goes for that.
2021-05-11 13114, 2021
Mr_Monkey
and since I'll likely be implementing it, I guess the "one man one vote" system is like in Teryr Pratchett: I'm the man I have the vote.
2021-05-11 13139, 2021
shivam-kapila
:D
2021-05-11 13144, 2021
BrainzGit
[musicbrainz-server] mwiencek opened pull request #2099 (schema-change-2021-q2ā¦schema-change-upgrade-tests): Add a script to test schema change upgrade scripts https://github.com/metabrainz/musicbrainz-server/ā¦
2021-05-11 13103, 2021
ruaok receives a STFU event from Mr_Monkey
2021-05-11 13119, 2021
Mr_Monkey
Lolz
2021-05-11 13124, 2021
shivam-kapila
Lol
2021-05-11 13137, 2021
bitmap
yvanzo: ^ check that PR when you have a second
2021-05-11 13133, 2021
Mr_Monkey Sends True Friendship Unicorn to ruaok
2021-05-11 13140, 2021
Mr_Monkey
Is that not what it stands for?
2021-05-11 13145, 2021
ruaok
lol
2021-05-11 13156, 2021
ruaok sends back fresh 90% booze
2021-05-11 13106, 2021
shivam-kapila
You must have spend good amount of time figuring this Mr_Monkey
2021-05-11 13152, 2021
Mr_Monkey
My one gift in life is puns. No need to look for anything much, they just pop up in the brain.
