But it should prbably have a login button at least Mr_Monkey
2021-05-12 13221, 2021
_lucifer
please remove it if yes.
2021-05-12 13225, 2021
Mr_Monkey
That was it !
2021-05-12 13226, 2021
_lucifer
and works for me now.
2021-05-12 13245, 2021
_lucifer
yup, so this is due to token revocation.
2021-05-12 13246, 2021
Mr_Monkey
Auth worked for me too after removing the existing app permission^
2021-05-12 13249, 2021
Mr_Monkey
Phew
2021-05-12 13253, 2021
Mr_Monkey
!m _lucifer
2021-05-12 13253, 2021
BrainzBot
You're doing good work, _lucifer!
2021-05-12 13212, 2021
ruaok
still need help looking at props, _lucifer ?
2021-05-12 13214, 2021
_lucifer
i discussed it with alastairp a few days, spotify does not do this only youtube does.
2021-05-12 13233, 2021
_lucifer
ruaok, its a script with id "react-props"
2021-05-12 13241, 2021
shivam-kapila is eagerly waiting to test lucifer's YT magic
2021-05-12 13245, 2021
Mr_Monkey
The YT player works for me. Nice !
2021-05-12 13202, 2021
_lucifer
yeah, i didn't get any errors so it would be helpful to see why it errors for you
2021-05-12 13207, 2021
ruaok
_lucifer: found it. it has loads of data in it. what do you need?
2021-05-12 13227, 2021
_lucifer
does it have youtube_user field?
2021-05-12 13202, 2021
ruaok
the youtube subkey has subkeys of access_token and api_key, nothing else.
2021-05-12 13211, 2021
_lucifer
yup that's right
2021-05-12 13231, 2021
_lucifer
one more thing to check,is there any error in the network tab?
2021-05-12 13258, 2021
_lucifer
if its empty, reload the page while keeping it open and play the erroring tracks again
2021-05-12 13253, 2021
bitmap
yvanzo: no harm in skipping those for now if the gid is undef. does it fix the remaining test failures?
2021-05-12 13218, 2021
_lucifer
i rechecked, revocation works perfectly now. that refresh_token error happened because while migrating the tables, we deleted youtube tokens without reoking.
2021-05-12 13249, 2021
_lucifer
there will be no issue as long as the user disconnects using the UI.
2021-05-12 13232, 2021
ruaok
no errors. reloaded. no errors. let me find an erroring track.
2021-05-12 13246, 2021
_lucifer
only alastairp might have to revoke from google settings manually once.
2021-05-12 13201, 2021
ruaok
I'm seeing some 204 "errors"
2021-05-12 13239, 2021
_lucifer
not seen that one before
2021-05-12 13239, 2021
shivam-kapila
204 is NoContent IG
2021-05-12 13253, 2021
_lucifer
yes, right but no idea why it occuers
2021-05-12 13206, 2021
_lucifer
which track is it? i'll try playing it from your page
it works for me somehow. can you try invalidating the cache and retrying?
2021-05-12 13200, 2021
ruaok
only for you _lucifer. I was really digging music.
2021-05-12 13212, 2021
_lucifer
:D
2021-05-12 13242, 2021
ruaok
I cheekily switched to chromium which I've never used with LB before and did the exact same thing as before and got exact the same stack of error messages with nothing playing.
2021-05-12 13236, 2021
_lucifer
thanks for checking. we definitely have a problem somewhere but it doesn't happen to all users.
2021-05-12 13200, 2021
_lucifer
if you are still on that page, could you PM me the content of react-props?
2021-05-12 13258, 2021
_lucifer
and also share any errors in the console or network tab.
2021-05-12 13232, 2021
ruaok
done
2021-05-12 13252, 2021
ruaok bows down before _lucifer
2021-05-12 13203, 2021
ruaok
STRONG FUCKING WORK!
2021-05-12 13208, 2021
_lucifer
lol
2021-05-12 13212, 2021
_lucifer
thanks!
2021-05-12 13215, 2021
ruaok
when I am not being retarded, it WORKS GREAT.
2021-05-12 13233, 2021
ruaok
the matching is quite good. dare I say, this is more pleasant that with spotify.
2021-05-12 13208, 2021
ruaok
now it makes me want a super easy selection switch: [ Spotify | YouTube ]
2021-05-12 13219, 2021
_lucifer
Mr_Monkey improved that to not use album name for youtube iirc
2021-05-12 13246, 2021
ruaok
yes, albums are terrible for track level matching in this use case
2021-05-12 13207, 2021
ruaok
omfg omfg if we can only coordinate the players to STFU when a new player starts playing!
bitmap: It's slighly more complicated: CoreEntity role cannot be used as-is for ArtistCredit because it brings unnecessary 'name' and 'unaccented_name' attributes. Two possible solutions to use only the gid-related code from CoreEntity: Either move it to a new GID role, or copy it to ArtistCredit.
2021-05-12 13218, 2021
bitmap
I see. I think copying the gid attribute to ArtistCredit makes sense
2021-05-12 13252, 2021
Mr_Monkey
Error 606: Found but tricky
2021-05-12 13225, 2021
Mr_Monkey
If I'm playing through the spotify player in BP, that'll submit a listen and so will the spotify reader (but only if I'm connected for that). We should talk about that tomorrow ! :)
2021-05-12 13203, 2021
ShivamAwasthi joined the channel
2021-05-12 13251, 2021
ShivamAwasthi20 joined the channel
2021-05-12 13215, 2021
ShivamAwasthi20 has quit
2021-05-12 13251, 2021
ShivamAwasthi10 joined the channel
2021-05-12 13242, 2021
ShivamAwasthi has quit
2021-05-12 13251, 2021
ShivamAwasthi10 has quit
2021-05-12 13211, 2021
ShivamAwasthi joined the channel
2021-05-12 13220, 2021
ShivamAwasthi has quit
2021-05-12 13251, 2021
_lucifer
ruaok: is it possible that a user deleted their MB account but it didn;t get removed in LB?
2021-05-12 13221, 2021
_lucifer
that is the account didn't get deleted from LB
2021-05-12 13201, 2021
atj
thanks for tagging me on GH _lucifer, I had a quick look earlier and made a minor recommendation but functionally it all LGTM
2021-05-12 13250, 2021
_lucifer
atj: thanks for the review. i implemented your suggestion and pushed the changes.
2021-05-12 13237, 2021
adhi001 has quit
2021-05-12 13205, 2021
ruaok
_lucifer: yes, quite possible.
2021-05-12 13242, 2021
ruaok
the player is just playing my timeline, zero problems. :) :)
2021-05-12 13246, 2021
ruaok
a listen needs to have an "add to playlist" button. I'll curate a playlist called "favorites" and be happy.
2021-05-12 13252, 2021
aerozol joined the channel
2021-05-12 13246, 2021
aerozol
Kia ora, not sure how to report spam on tickets.metabrainz? Maybe if I leave this link here it will somehow amazingly solve itself :D
