_lucifer: you could always replace the [report] button with some text "report submitted"
2021-05-19 13930, 2021
alastairp
are we going to allow people to report more than once? We should probably have some anti-spam features tehre
2021-05-19 13944, 2021
_lucifer
the api errors if you submit a report again.
2021-05-19 13902, 2021
ruaok is really starting to lose it.
2021-05-19 13909, 2021
_lucifer
alastairp: that probably works. but then we have an issue where to show errors? as Mr_Monkey mentoined that the UserHeading isn't inside alerts
2021-05-19 13915, 2021
alastairp
what kind of error do you mean?
2021-05-19 13959, 2021
alastairp
like "report already submitted"
2021-05-19 13905, 2021
_lucifer
submitting twice. or any general server side error.
2021-05-19 13911, 2021
_lucifer
yes
2021-05-19 13909, 2021
alastairp
I'd be tempted to just replace the button with "report submitted" in all cases. success, already submitted, or general server error
2021-05-19 13932, 2021
alastairp
general server error - we should get a sentry notification. already submitted - the message isn't a lie...
2021-05-19 13951, 2021
_lucifer
i think that's a good starting point.
2021-05-19 13916, 2021
_lucifer
plus less work for me 😉
2021-05-19 13958, 2021
Mr_Monkey
I think that's a good solution with one caveat: if the error is "already submitted", then as alastairp suggest show "submitted" in the button. In case of another error, we can just show a generic error message in the button ("Error, please try again" sort of thing?)
2021-05-19 13917, 2021
alastairp
fine by me
2021-05-19 13927, 2021
_lucifer
in that case, let's just report success from the api in case of multiple submissions.
2021-05-19 13925, 2021
alastairp
when I've done this sort of reporting system before we do a query when showing the page and don't show the button if it's already been submitted
2021-05-19 13928, 2021
alastairp
is that easy or difficult?
2021-05-19 13942, 2021
alastairp
(if it's difficult, no problem. let's just do what you suggest)
2021-05-19 13936, 2021
_lucifer
currently we do not provide an endpoint to see whether the user has reported another user before.
2021-05-19 13939, 2021
_lucifer
if we want to do that, it should be similar to implementing follow user button. i do not know about the difficulty though. Mr_Monkey probably does
2021-05-19 13915, 2021
Mr_Monkey
Not really, I wasn't the one to implement the follow user button
is now the time to talk about moving away from IRC?
2021-05-19 13958, 2021
_lucifer
maybe another IRC network?
2021-05-19 13911, 2021
ruaok
matrix?
2021-05-19 13948, 2021
_lucifer
matrix seems nice. much better than the electron bloat slack and others are.
2021-05-19 13926, 2021
ruaok
worst case we move to irc.libera.chat and send them money.
2021-05-19 13938, 2021
shivam-kapila
_lucifer: how may I help
2021-05-19 13900, 2021
_lucifer
shivam-kapila, any ideas how much work would it to be implement the report user button? i think the impl would be almost similar to follow user button.
2021-05-19 13941, 2021
Rotab
libera sounds like a pretty good case to me
2021-05-19 13940, 2021
zas
ruaok: +1 for libera.chat
2021-05-19 13951, 2021
shivam-kapila
Umm we simply pass a prop `logged_in_user_follows_user` in case its the user listen page
2021-05-19 13915, 2021
shivam-kapila
For feed page we fetch followers and following and see if it the list includes the user name
2021-05-19 13904, 2021
shivam-kapila
The button lies on listen page correct _lucifer ?
2021-05-19 13921, 2021
ruaok
_lucifer: I was trying to verify the spark dump and the machine I did it on ran out of disk space when uncompressing data for 2020.
2021-05-19 13928, 2021
ruaok
lolsob
2021-05-19 13957, 2021
_lucifer
shivam-kapila: yes. will lie on the top right of page in UserPageHeading.
2021-05-19 13942, 2021
shivam-kapila
Cool. In that case just pass the prop from the python side or make an extra call from react side
2021-05-19 13959, 2021
shivam-kapila
In case reported set text to reported and disable the button
2021-05-19 13943, 2021
shivam-kapila
You will need to add a db function to check is the user reported already
2021-05-19 13947, 2021
_lucifer
ruaok: :(, no worries though. I am 99% sure i had mistake at that point.
2021-05-19 13916, 2021
ruaok
so, does spark now contain up to date data, you think?
2021-05-19 13946, 2021
_lucifer
yes, i copy the last file from spark to my local machine and explored it. it had listens from may 15.
2021-05-19 13900, 2021
ruaok
ok
2021-05-19 13940, 2021
_lucifer
shivam-kapila: ah yes, right. prop should do it without another endpoint. thanks!
2021-05-19 13922, 2021
shivam-kapila
Yeah. Sorry for being less descriptive. Mind fucked after exam :/
2021-05-19 13902, 2021
_lucifer
ruaok, are we going to switch to libera or wait for some more clarity?
2021-05-19 13935, 2021
Rotab
isnt Freso freenode staff?
2021-05-19 13948, 2021
shivam-kapila
Whats the charges for libera network
2021-05-19 13904, 2021
ruaok
_lucifer: wait.
2021-05-19 13917, 2021
_lucifer
👍
2021-05-19 13920, 2021
shivam-kapila
In case if its donation the irc pro membership fee can be submitted as donation
2021-05-19 13927, 2021
ruaok wants to close many many threads of stuff before picking up anything new at all.
2021-05-19 13948, 2021
shivam-kapila
Ah sorry the network is gonna change not the client. Ignore please
a few moving parts (including a consul change to make a variable easier to understand), during cron downtime this afternoon I can deploy and test it manually
not surprising, really. I'm really really sad to hear that things have gone this way.
2021-05-19 13936, 2021
ruaok
thank you for all your work over the years. we certainly benefitted from it.
2021-05-19 13950, 2021
ruaok
will you be helping libera?
2021-05-19 13900, 2021
kloeri
most likely but it will be a while then as I'm very busy with real life currently
2021-05-19 13914, 2021
ruaok
ok, good luck with life.
2021-05-19 13947, 2021
alastairp
ruaok: you're right - I missed the situation that when storagebox is in maintenance mode the contianer won't come up
2021-05-19 13906, 2021
alastairp
I've rolled that change back, but the check to see if /mnt/dumps is mounted over cifs will still work regardless
2021-05-19 13930, 2021
alastairp
so I'll test that this afternoon
2021-05-19 13936, 2021
kloeri has quit
2021-05-19 13936, 2021
kloeri joined the channel
2021-05-19 13952, 2021
ruaok
boom!
2021-05-19 13931, 2021
ruaok
I wonder if we should take pre-emptive steps for libera.chat .
2021-05-19 13905, 2021
ruaok
https://libera.chat/chanreg -- maybe create a #metabrainz community channel and then #bookbrainz, #musicbrainz project channels?
2021-05-19 13916, 2021
ruaok
once we figure out what we want, I can do the registering.
2021-05-19 13941, 2021
mckean_ has quit
2021-05-19 13910, 2021
Freso joined the channel
2021-05-19 13930, 2021
kloeri
ruaok: creating channels on libera.chat sounds like a sensible move even though I'm sure you could get the channels even if somebody else sniped them first
2021-05-19 13903, 2021
kloeri
not having to go through too much red tape would be nice though especially now that all the libera.chat people are quite busy I assume
2021-05-19 13942, 2021
ruaok
I dont see anything about registering nicks though.
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda (next meeting: 2021-05-24): Reviews, change of IRC network (Freso)
just sit on the channels for now then and I'm sure email will be sorted out later today
2021-05-19 13903, 2021
Freso has quit
2021-05-19 13903, 2021
Freso joined the channel
2021-05-19 13948, 2021
mckean joined the channel
2021-05-19 13947, 2021
captainepoch has quit
2021-05-19 13936, 2021
captainepoch joined the channel
2021-05-19 13944, 2021
Freso
ruaok: I’m going to bring BrainzBot into those channels, unless you have any objections?
2021-05-19 13910, 2021
ruaok
sure
2021-05-19 13913, 2021
sumedh has quit
2021-05-19 13935, 2021
alastairp
hi _lucifer
2021-05-19 13948, 2021
alastairp
are you around for a release?
2021-05-19 13947, 2021
_lucifer
alastairp: yup
2021-05-19 13916, 2021
_lucifer
Mr_Monkey: {loggedInUser && user.name !== loggedInUser.name && (Component 1) && (Component 2)} sometime doesn't render component 1. is that expected or known behaviour?
2021-05-19 13950, 2021
_lucifer
changing it to {loggedInUser && user.name !== loggedInUser.name && (Component 1)} and {loggedInUser && user.name !== loggedInUser.name && (Component 2)} however works fine
2021-05-19 13925, 2021
alastairp
_lucifer: I think we can get away with merging the top 4 open PRs
2021-05-19 13931, 2021
_lucifer
alastairp: yes, top 4 look fine to me.
2021-05-19 13914, 2021
Freso
Uhh… Is there something in syswiki about how to restart BrainzBot?
2021-05-19 13949, 2021
shivam-kapila
_lucifer: you can do `condition && ((comp 1 comp2))`
2021-05-19 13901, 2021
Freso
Wait, nevermind, it seems the bot has joined. :)
2021-05-19 13924, 2021
_lucifer
shivam-kapila: ah. thanks! :D
2021-05-19 13950, 2021
shivam-kapila
Brackets one time only
2021-05-19 13919, 2021
_lucifer
oh, i tried that already, eslint compalins
2021-05-19 13934, 2021
_lucifer
TS2695: Left side of comma operator is unused and has no side effects.
