do the templates (.tt) have access to the constants defined in lib/MusicBrainz/Server/Constants.pm?
2016-07-04 18653, 2016
Zastai
(and if so, via what syntax)
2016-07-04 18608, 2016
Zastai
also, in new edits, relationships will have at most 1 instrument or vocal attribute right? so "foo performs bass, drums, glockenspiel" would be 3 relationships when entered now, and only historic data would still have a single AR containing all 3?
2016-07-04 18630, 2016
bitmap
no, you have to add whatever variables you want into $c->stash to access them in the templates
2016-07-04 18607, 2016
Zastai
and I take it hardcoding the vocals/instrument root id would be frowned upon
2016-07-04 18608, 2016
bitmap
second question sounds correct
2016-07-04 18656, 2016
Zastai
am looking at MBS-8961; have a working prototype that groups non-instrument/vocal attrs first, followed by the others
2016-07-04 18639, 2016
Zastai
but that checks for "is a vocal/instrument" by looking at attr.type.root.id, and I'm not sure how immutable those values are
2016-07-04 18653, 2016
bitmap
I'd say it's fine to define a variable in the template holding the gid
2016-07-04 18601, 2016
bitmap
and compare against attr.type.root.gid
2016-07-04 18646, 2016
Zastai
is it also just 1 gid for all instruments? or is id 1 value plus a gid per instrument?
2016-07-04 18620, 2016
bitmap
every instrument has an id and gid
2016-07-04 18627, 2016
bitmap
actually...
2016-07-04 18644, 2016
Freso
Zastai: Do you want a slot during the reviews during the meeting? (In 11 minutes.)
2016-07-04 18611, 2016
Zastai
nah, it's not important enough for that
2016-07-04 18628, 2016
LordSputnik joined the channel
2016-07-04 18631, 2016
Freso
Sure it is.
2016-07-04 18645, 2016
bitmap
the instrument gid should be the same as the link_attribute_type gid, I think
2016-07-04 18652, 2016
LordSputnik is now known as Guest94438
2016-07-04 18657, 2016
Zastai
ok then freso
2016-07-04 18611, 2016
Zastai
will just emit the gid in the page to see if it varies
2016-07-04 18621, 2016
Zastai
if it doesn't i'll check that instead of id
2016-07-04 18654, 2016
Zastai
(i only got the idea for looking at the id because there's an INSTRUMENT_ROOT_ID constant that gets used for a similar purpose)
2016-07-04 18617, 2016
bitmap
yeah, the gids are constant for sure
2016-07-04 18605, 2016
bitmap
root gid should be 0abd7f04-5e28-425b-956f-94789d9bcbe2 for instruments
2016-07-04 18630, 2016
bitmap
d92884b7-ee0c-46d5-96f3-918196ba8c5b for vocals
2016-07-04 18624, 2016
Zastai
right. and will those be more or less constant than the id value? (if the same, a test for 14 is simpler than one for 0abd7f04-5e28-425b-956f-94789d9bcbe2)
2016-07-04 18651, 2016
Slurpee has quit
2016-07-04 18630, 2016
bitmap
well, the gid is intended to be constant, the id isn't
2016-07-04 18621, 2016
Freso
Guest94438: You may want to remember to check in with NickServ. ;)
2016-07-04 18612, 2016
bitmap
the id is effectively constant but can theoretically change in a schema change or something...
2016-07-04 18601, 2016
Zastai
fair enough, will check on the gid then
2016-07-04 18600, 2016
Freso
<BANG>
2016-07-04 18618, 2016
Freso
Hello all :)
2016-07-04 18625, 2016
Freso
Let's get right to it.
2016-07-04 18626, 2016
kartikgupta0909 joined the channel
2016-07-04 18656, 2016
Freso
We have Freso, zas, reosarevok, bitmap, Gentlecat, ruaok, LordSputnik, alastairp, Zastai, rahulr, QuoraUK, armalcolite, hellska, kartikgupta0909 up for reviews and 1 other agenda item. Let me know if you want on/off.
2016-07-04 18607, 2016
Freso
Freso: go!
2016-07-04 18617, 2016
Freso
Spent a good chunk of time looking into the circumstances about the non-renewal of chrisskye's contract, reading through e-mails, chat logs, etc.
2016-07-04 18620, 2016
Freso
Managed to actually be part of the BookBrainz meeting for the first time in a while.
2016-07-04 18622, 2016
Freso
Tried to upgrade the Discourse install, but it failed. Prodded zas, but not sure if I ever got a reply. I'll try again in a bit and re-prod.
2016-07-04 18624, 2016
Freso
Brought another open source project to the /supporters page, after Leo_Verto mentioned them in #musicbrainz (nusic, Android app: https://github.com/schnatterer/nusic )
2016-07-04 18626, 2016
Freso
Otherwise I've mostly been around and about, keeping up with forums and IRC to the best of my ability. Finally got the RPi2 back online yesterday, so keeping up with IRC should be much easier now. :)
2016-07-04 18628, 2016
Freso
(And I might actually be getting my 100/100 fiber connection this week too. We'll see.)
2016-07-04 18630, 2016
Freso
Freso: thanks!
2016-07-04 18632, 2016
Freso
zas: go!
2016-07-04 18633, 2016
Freso
I'm currently fighting with personal / family issues, i didn't do much
2016-07-04 18636, 2016
Freso
this week but overall monitoring and general maintenance
2016-07-04 18638, 2016
Freso
I hope to solve/push back those issues and come back during this week to
2016-07-04 18640, 2016
Freso
real work.
2016-07-04 18650, 2016
Freso
Thanks zas!
2016-07-04 18653, 2016
Freso
reosarevok: go!
2016-07-04 18632, 2016
reosarevok
I did support and editing, and decided I should stop slacking, so while I haven't decided on the hard style issue yet, at least I'm opening a couple smaller, hopefully simpler discussions to make *some* stuff happen
2016-07-04 18629, 2016
reosarevok
They'll be open for a week, then I'll decide what to do with them. No letting them sit there this time :p
2016-07-04 18638, 2016
Freso
Sure... ;)
2016-07-04 18606, 2016
reosarevok
This week I plan to finally take a decision on the boxset issue, or if I can't decide as such, then going for a second round of discussion with a more specific goal in mind
came up with a plan to move all the private chef-cookbooks/server-configs stuff into a new repo and make the docker setup use that
2016-07-04 18653, 2016
bitmap
mostly spent time testing that in vagrant
2016-07-04 18614, 2016
ruaok wants to compare vagrant/docker notes with bitmap later
2016-07-04 18626, 2016
bitmap
did gsoc code review and testing
2016-07-04 18632, 2016
bitmap
fin
2016-07-04 18640, 2016
Gentlecat
I spent some time trying to figure out what was causing issues with memcached in dockerizied CB
2016-07-04 18616, 2016
Gentlecat
couldn't, so I just ended up porting cache wrapper in python-brainzutils to redis
2016-07-04 18621, 2016
Gentlecat
that seems to be working now
2016-07-04 18647, 2016
jcazevedo joined the channel
2016-07-04 18612, 2016
Gentlecat
also upgraded sentry, and was trying to fix static file stuff in CB deployment with docker
2016-07-04 18630, 2016
Gentlecat
done some code review
2016-07-04 18633, 2016
Gentlecat
fin
2016-07-04 18647, 2016
ruaok
As you may have noticed last week I decided to not renew chrisskye’s contract, with immediate effect.
2016-07-04 18609, 2016
m8ram joined the channel
2016-07-04 18613, 2016
ruaok
Over the past 3 months communication started to break down and in the last week, I felt unnecessarily attacked, causing me lots more stress on top of the of stress I already had.
2016-07-04 18626, 2016
ruaok
I felt viciously attacked. I felt blackmailed.
2016-07-04 18658, 2016
ruaok
After taking a time-out walk to calm down from being lividly angry, I decided that I didn’t need the stress and didn’t need someone who made me feel like this on my team.
2016-07-04 18623, 2016
ruaok
I feel bad how I all of this went down, but this situation spiraled out of control with amazing speed and ferocity that I’ve never witnessed before.
2016-07-04 18640, 2016
ruaok
I was caught off guard several times and it is hard to be patient when you feel like you’re being attacked.
2016-07-04 18652, 2016
ruaok
This is all I am going to say about this topic.
2016-07-04 18608, 2016
ruaok
I’ve told Freso my side of the story and if Freso cares to say any more about this, that is up to him.
2016-07-04 18634, 2016
ruaok
aside from that I worked with armalcolite to get more PRs reviewed and merged and we're now on track. I'm quite happy with the progress on LB.
2016-07-04 18600, 2016
ruaok
I've also started working on musicbrainz-vm which is a docker/vagrant MB in a VM setup.
2016-07-04 18620, 2016
ruaok
the idea is that you install VB, Vagrant and then clone the repo.
2016-07-04 18623, 2016
ruaok
and then do install.sh
2016-07-04 18627, 2016
ruaok
and of course wait.
2016-07-04 18645, 2016
ruaok
it would work if it didn't run out of disk space. alas.
2016-07-04 18652, 2016
ruaok
I'll continue on this next week.
2016-07-04 18616, 2016
ruaok
but this week, I'm headed off to Nowhere for a much needed break of dust, hippies, crazy parties and weird art.
2016-07-04 18630, 2016
ruaok
I'm off grid 100% from Wednesday morning until Sunday late.
2016-07-04 18634, 2016
ruaok
and boy, do I need it!
2016-07-04 18637, 2016
ruaok
fin!
2016-07-04 18657, 2016
diana_olhovyk_ has quit
2016-07-04 18620, 2016
alastairp
this week mostly merging and working with SoC projects
2016-07-04 18644, 2016
chrisskye
I will post a link to my contract; has a Mediation clause, and Notice requirement (both breached). And, a copy of the draft of my email to the board, which seems to have triggered everything. And, any/all IRC chat logs, for any member of the community who might be interested in reviewing them. Transparency. Respect. Honesty.
2016-07-04 18604, 2016
alastairp
coming up this week is some new changes to be able to do search in the dataset edit
2016-07-04 18608, 2016
alastairp
editor. fin
2016-07-04 18625, 2016
Zastai
have been looking at MBS-8961 today (avoid text like "additional, drums, guest and percussion" in artist relationship overview); have a working prototype (http://imgur.com/w3ySWH1) that groups non-instrument/vocal attributes first (so "additional and guest: drums and percussion")
2016-07-04 18637, 2016
Zastai
will probably create a PR today
2016-07-04 18606, 2016
Zastai
so far, the small UI things I've looked at have been fairly easy; will continue to pick up jira tickets that seem doable
Hi. I added a few achievements this week for the time an edition is released, that is pretty fun
2016-07-04 18610, 2016
QuoraUK
Changed no of revisions to number of creations for the majority in order to make them a bit more meaningful
2016-07-04 18614, 2016
Freso
chrisskye: Keep in mind that your IRC chat logs may contain personally sensitive information that you have not been allowed to divulge before you share them.
2016-07-04 18631, 2016
QuoraUK
and am currently working on a nicer way of selecting the achievements you want to show off on your profile :D
2016-07-04 18634, 2016
QuoraUK
fin.
2016-07-04 18644, 2016
armalcolite
Hi!
2016-07-04 18650, 2016
armalcolite
Fixed the jenkins build for listenbrainz and fixed some existing tests.
2016-07-04 18601, 2016
armalcolite
Updated api_compat branch based on ruaok's feedback.
2016-07-04 18607, 2016
armalcolite
Addressed a ticket assigned to me, hopefully it did not need any work. :D
2016-07-04 18625, 2016
armalcolite
Update the description for api_compat and now it is ready for 1st official review!
2016-07-04 18634, 2016
armalcolite
Now that test-suite is ready, i can get tests for API-Compatible commited.
2016-07-04 18637, 2016
armalcolite
fin.
2016-07-04 18646, 2016
hellska
Hi
2016-07-04 18646, 2016
reosarevok
Zastai: that colon there feels kinda weird FWIW
2016-07-04 18605, 2016
Zastai
i know, it's the one thing I'm tweaking
2016-07-04 18613, 2016
hellska
fixed some problems in the PR 189
2016-07-04 18616, 2016
Zastai
currently I leave it out if the first list has 1 item
2016-07-04 18633, 2016
hellska
received code review and comments on jira tickets
2016-07-04 18602, 2016
chrisskye
Freso: I can’t dispute feelings, but the insinuation of “blackmail"...is very close to defamatory.
2016-07-04 18609, 2016
hellska
and that’s all, I was quite busy with the thesis work and the presentation is next week!
2016-07-04 18610, 2016
hellska
fin
2016-07-04 18635, 2016
Freso
chrisskye: No one has said you blackmailed anyone.
2016-07-04 18609, 2016
chrisskye
ruaok, just said that is how he felt.
2016-07-04 18614, 2016
Freso
Exactly.
2016-07-04 18620, 2016
chrisskye
insinuation
2016-07-04 18623, 2016
Freso
kartikgupta0909: Ping?
2016-07-04 18626, 2016
kartikgupta0909
Tested different formats on the lowlevel data for acousticbrainz. Will be making the report this week. Also got the pending PR merged.
2016-07-04 18656, 2016
kartikgupta0909
This week will be working on the server side API that is required for the offline dataset training tool.
2016-07-04 18606, 2016
kartikgupta0909
fin :)
2016-07-04 18619, 2016
Freso
And that concludes the reviews!
2016-07-04 18629, 2016
Freso
chirlu: Discogs http/https URL normalization!
2016-07-04 18602, 2016
Freso
Maybe...
2016-07-04 18628, 2016
Freso
He added it only a few hours before the meeting.
2016-07-04 18643, 2016
Freso
Anyone got anything else?
2016-07-04 18653, 2016
Freso
If not, we'll move this topic to next week.
2016-07-04 18600, 2016
armalcolite
wow! reviews were pretty fast today. 1.57 min/person. :D
2016-07-04 18608, 2016
Freso
armalcolite: :)
2016-07-04 18637, 2016
Freso
Alright. Thanks for your time everyone!
2016-07-04 18647, 2016
Freso
</BANG>
2016-07-04 18615, 2016
hellska
armacolite: summer time ;)
2016-07-04 18630, 2016
hellska
armalcolite: :P
2016-07-04 18600, 2016
armalcolite
:D
2016-07-04 18631, 2016
Zastai
reosarevok: how about http://imgur.com/eBTXOXt - when both lists exist I space-separate the first and use comma_list for the second. otherwise, i use comma_list for the list that exists
2016-07-04 18604, 2016
Zastai
so "guest, additional and solo" and "trumpet and bass" but "guest solo trumpet, glockenspiel and viola"
2016-07-04 18614, 2016
jesus2099 joined the channel
2016-07-04 18631, 2016
reosarevok
Sounds good to me
2016-07-04 18623, 2016
CallerNo6
chrisskye, fwiw, I look forward to hearing what you have to say. (also fwiw, I didn't read "blackmailed" as anything but a description of an emotional state)
