#metabrainz

/

      • kyan has quit
      • 2017-01-17 01730, 2017

      • anshuman73
        *sigh*. Thanks for fixing MEB-74 Gentlecat.
      • 2017-01-17 01731, 2017

      • BrainzBot
        MEB-74: Token generation is not working https://tickets.metabrainz.org/browse/MEB-74
      • 2017-01-17 01734, 2017

      • github joined the channel
      • 2017-01-17 01735, 2017

      • github
        [listenbrainz-server] paramsingh opened pull request #111: [LB-101] Add album to response sent by tracks.scrobble in api_compat. (master...lb-101-record-albums) https://git.io/vMiei
      • 2017-01-17 01735, 2017

      • github has left the channel
      • 2017-01-17 01739, 2017

      • jcazevedo joined the channel
      • 2017-01-17 01733, 2017

      • iliekcomputers
        I opened LB-115 for the api_sig bug I came across.
      • 2017-01-17 01733, 2017

      • BrainzBot
        LB-115: tracks.scrobble does not work when api_sig is passed in request data https://tickets.metabrainz.org/browse/LB-115
      • 2017-01-17 01723, 2017

      • iliekcomputers
        This one is an easy fix, but I think it points us to maybe using these signatures to validate the data sent in the request.
      • 2017-01-17 01735, 2017

      • dboys_ has quit
      • 2017-01-17 01744, 2017

      • anshuman73
        yvanz: would you like to keep the remaining sidebar tickets as potential tasks for GCI next year ? I wouldn't mind submitting PRs for them.
      • 2017-01-17 01754, 2017

      • iliekcomputers
        Maybe we should check the data for errors during transmission for each request in api_compat where the signature is required by last.fm?
      • 2017-01-17 01758, 2017

      • Quesito
        mayhem: ok sounds like a plan! shall I do the finishing?
      • 2017-01-17 01727, 2017

      • mayhem
        please do. just add a quick intro sentence that you're taking over and go for it.
      • 2017-01-17 01740, 2017

      • Quesito
        bueno
      • 2017-01-17 01728, 2017

      • dpmittal
        CallerNo6: ping
      • 2017-01-17 01754, 2017

      • Quesito sent
      • 2017-01-17 01719, 2017

      • armalcolite
        iliekcomputers: ignoring api_sig in the calls was done intentionally.
      • 2017-01-17 01753, 2017

      • armalcolite
        We do not know the client secret, so there is no way to verify api_sig
      • 2017-01-17 01701, 2017

      • iliekcomputers
        armalcolite: oh right, makes sense
      • 2017-01-17 01723, 2017

      • armalcolite
        refer to the last section, http://www.last.fm/api/webauth
      • 2017-01-17 01750, 2017

      • iliekcomputers
        Yea, I saw it, but I missed the secret at the end :D
      • 2017-01-17 01738, 2017

      • iliekcomputers
        armalcolite: the scrobbling didn't work when I pushed api_sig with the request
      • 2017-01-17 01715, 2017

      • iliekcomputers
        api_sig adds an extra "empty" track to the lookup dict
      • 2017-01-17 01758, 2017

      • iliekcomputers
        from what I see, that leads to the exception being thrown in messybrainz lookup for the empty track
      • 2017-01-17 01715, 2017

      • armalcolite
        that should not happen. I could not find any intance of api_sig in the source code so it should not make a difference
      • 2017-01-17 01749, 2017

      • armalcolite
        it should behave as if the field does not exist, but there might be a typo or something
      • 2017-01-17 01738, 2017

      • iliekcomputers
        armalcolite: when you make the lookup, you have continue for 'sk', 'api_key' etc but not for 'api_sig'
      • 2017-01-17 01708, 2017

      • iliekcomputers
        that's what adds the extra track
      • 2017-01-17 01711, 2017

      • iliekcomputers
        armalcolite: As far as I can see, it's a one line fix. I'll send a PR tomorrow fixing it.
      • 2017-01-17 01733, 2017

      • kyan joined the channel
      • 2017-01-17 01730, 2017

      • armalcolite
        iliekcomputers: feel free to fix it. LB is still in its early stages and there is a lot of scope for improvement.
      • 2017-01-17 01711, 2017

      • LordSput1 joined the channel
      • 2017-01-17 01736, 2017

      • iliekcomputers
        armalcolite: yeah, I'll do it tomorrow.
      • 2017-01-17 01735, 2017

      • LordSputnik has quit
      • 2017-01-17 01723, 2017

      • dboys_ joined the channel
      • 2017-01-17 01707, 2017

      • mihaitish has quit
      • 2017-01-17 01720, 2017

      • mihaitish joined the channel
      • 2017-01-17 01734, 2017

      • demonimin has quit
      • 2017-01-17 01709, 2017

      • demonimin joined the channel
      • 2017-01-17 01711, 2017

      • dboys_ has quit
      • 2017-01-17 01708, 2017

      • dboys_ joined the channel
      • 2017-01-17 01702, 2017

      • iliekcomputers
        armalcolite: is it okay if I reopen LB-115 because the bug is still there?
      • 2017-01-17 01702, 2017

      • BrainzBot
        LB-115: tracks.scrobble does not work when api_sig is passed in request data https://tickets.metabrainz.org/browse/LB-115
      • 2017-01-17 01754, 2017

      • armalcolite
        iliekcomputers: i guess it should remain open untill we are not sure if that bug is resolved. Since you say it is there, may be reopen it.
      • 2017-01-17 01751, 2017

      • iliekcomputers
        armalcolite: okay cool thanks
      • 2017-01-17 01746, 2017

      • iliekcomputers has quit
      • 2017-01-17 01758, 2017

      • LordSputnik joined the channel
      • 2017-01-17 01710, 2017

      • LordSput1 has quit
      • 2017-01-17 01736, 2017

      • Mineo joined the channel
      • 2017-01-17 01741, 2017

      • ferbncode has quit
      • 2017-01-17 01732, 2017

      • hellohi joined the channel
      • 2017-01-17 01731, 2017

      • samj1912
        zas what should I do about the rest of my PRs?
      • 2017-01-17 01724, 2017

      • hellohi has quit
      • 2017-01-17 01727, 2017

      • Gentlecat
        Mineo: testNoScoreException started failing for all entities after I switched to latest commit on mbsssss
      • 2017-01-17 01727, 2017

      • Gentlecat
      • 2017-01-17 01732, 2017

      • Gentlecat
      • 2017-01-17 01713, 2017

      • chirlu joined the channel
      • 2017-01-17 01734, 2017

      • Mineo
        looking at the pull request, I'd say yes - all SearchHandler's seem to have received a default fl containing just "score"
      • 2017-01-17 01757, 2017

      • mihaitish has quit
      • 2017-01-17 01701, 2017

      • mihaitish joined the channel
      • 2017-01-17 01735, 2017

      • suhas2go
        samj1912: are you currently working on PICARD-915?
      • 2017-01-17 01736, 2017

      • BrainzBot
        PICARD-915: In plugins list, some plugins don't show description https://tickets.metabrainz.org/browse/PICARD-915
      • 2017-01-17 01741, 2017

      • samj1912
        Yup, working on all plugin related stuff together
      • 2017-01-17 01724, 2017

      • suhas2go
      • 2017-01-17 01726, 2017

      • suhas2go
        :)
      • 2017-01-17 01753, 2017

      • samj1912
        Saw :) thanks
      • 2017-01-17 01717, 2017

      • Mineo
        Gentlecat: do you want me to update the tests?
      • 2017-01-17 01709, 2017

      • Gentlecat
        sure, I wouldn't mind
      • 2017-01-17 01722, 2017

      • SothoTalKer
        samj1912: all plugins show descriptions for me.
      • 2017-01-17 01700, 2017

      • demonimin has quit
      • 2017-01-17 01738, 2017

      • SothoTalKer
        but i reinstalled picard from scratch
      • 2017-01-17 01727, 2017

      • yvanz
        anshuman73: Please, go ahead, we will never lack tasks for GCI.
      • 2017-01-17 01702, 2017

      • demonimin joined the channel
      • 2017-01-17 01756, 2017

      • kyan has quit
      • 2017-01-17 01708, 2017

      • Freso
        mayhem: Gf is also vegetarian(/vegan), fwiw.
      • 2017-01-17 01733, 2017

      • Freso
        gcilou: Go as crazy as you feel like. :)
      • 2017-01-17 01755, 2017

      • gcilou
        Freso: awesome. I'll add some more later ;)
      • 2017-01-17 01727, 2017

      • gcilou
        But the main ones are in now
      • 2017-01-17 01737, 2017

      • mayhem
        well, which one? vegan or vegetarian? kinda makes a difference.
      • 2017-01-17 01756, 2017

      • gcilou is a vegetarian because real cheese is too important
      • 2017-01-17 01728, 2017

      • mayhem
        srsly. what is your favorite cheese? any cheese you won't eat?
      • 2017-01-17 01750, 2017

      • gcilou
        I'll eat mostly anything
      • 2017-01-17 01759, 2017

      • gcilou
        favorite is any type of blue
      • 2017-01-17 01719, 2017

      • mayhem
        nice. you'll help me go cheese shopping for the summit then?
      • 2017-01-17 01738, 2017

      • mayhem
        there are 8 cheese shops (more or less) with in walking crawling distance of my house.
      • 2017-01-17 01757, 2017

      • gcilou
        definitely if I can make it
      • 2017-01-17 01759, 2017

      • Freso
        gcilou: "finagle"? Was that intentional? I like it.
      • 2017-01-17 01701, 2017

      • dboys_ has quit
      • 2017-01-17 01728, 2017

      • gcilou
        Freso: yes, intentional :)
      • 2017-01-17 01735, 2017

      • mayhem
        Freso: is your GF vegan?
      • 2017-01-17 01741, 2017

      • Freso
        mayhem: She is vegetarian, but prefers to eat vegan.
      • 2017-01-17 01752, 2017

      • Freso
        If we go to the place Quesito it doesn't sound like it'll be an issue.
      • 2017-01-17 01708, 2017

      • mayhem
        problem with that place is that it is close for only one person.
      • 2017-01-17 01712, 2017

      • Freso
        Ah.
      • 2017-01-17 01723, 2017

      • mayhem
        and 4 people have to trek "halfway" across town.
      • 2017-01-17 01733, 2017

      • dboys_ joined the channel
      • 2017-01-17 01740, 2017

      • mayhem
        whereas the amazing italian place is nice and central.
      • 2017-01-17 01741, 2017

      • Freso
        If it's a place with vegan options, amazing. If not but it's vegetarian, that'll work just fine too.
      • 2017-01-17 01750, 2017

      • mayhem
        and conveniently near my house. :-p
      • 2017-01-17 01706, 2017

      • kyan joined the channel
      • 2017-01-17 01736, 2017

      • Quesito
        oh la la which italian place?
      • 2017-01-17 01739, 2017

      • mayhem
        I really dislike eating vegan, so I think we'll have to compromise on vegetarian. and I know the italian has decent veggie dishes -- chirlu had no issues finding food there.
      • 2017-01-17 01751, 2017

      • mayhem
        Cuina Mandrossa? hang on.
      • 2017-01-17 01709, 2017

      • Quesito
        Si, mandrossa is super goodz!
      • 2017-01-17 01711, 2017

      • mayhem
        Le Cucine Mandarosso
      • 2017-01-17 01726, 2017

      • mayhem
        k, you happy to saunter over then?
      • 2017-01-17 01733, 2017

      • mayhem
        easy for you with the L1.
      • 2017-01-17 01727, 2017

      • Freso
        SothoTalKer: Why are you trying to install python discid for Py2.6 anyway? Latest Picard (what will soon be 1.4) does not support Python <2.7, and 2.7 is also about 10 years old by now. There's really no reason for sticking to 2.6...
      • 2017-01-17 01749, 2017

      • SothoTalKer
        3.6
      • 2017-01-17 01752, 2017

      • Freso
        mayhem: Just because one person eats vegan doesn't mean everyone has to.
      • 2017-01-17 01759, 2017

      • Freso
        Oh.
      • 2017-01-17 01729, 2017

      • SothoTalKer
        but i might downgrade to 3.5 again. nothing really supports 3.6 right now
      • 2017-01-17 01753, 2017

      • Freso
        SothoTalKer: If there are issues with Py3.6 you should definitely file issues/tickets/bug upstream.
      • 2017-01-17 01712, 2017

      • Quesito
        I'm fine with sauntering that way!
      • 2017-01-17 01753, 2017

      • SothoTalKer
        the biggest issue is, nothing supports 3.6 yet :D
      • 2017-01-17 01719, 2017

      • Freso
        My system is on Py3.6 and I haven't encountered any issues.
      • 2017-01-17 01729, 2017

      • Freso ARCH!@!#21dsa 4eva
      • 2017-01-17 01745, 2017

      • SothoTalKer
        me windows 4eva :D
      • 2017-01-17 01739, 2017

      • mayhem
        please do!
      • 2017-01-17 01711, 2017

      • SothoTalKer
        i use ptvs and they won't even bother to release a version that supports py3.6 for visual studio 2015
      • 2017-01-17 01745, 2017

      • mayhem
        Quesito: minor nitpick on the verbiage for stereotheque... we use the format "Company X uses MusicBrainz. ... "
      • 2017-01-17 01704, 2017

      • mayhem
        the consistency police will come and hunt you down for this grave omission if you don't fix it.
      • 2017-01-17 01718, 2017

      • mayhem
        me personally I am cool with how it is. :) :)
      • 2017-01-17 01721, 2017

      • Quesito editing now, and thank you for the correction!
      • 2017-01-17 01753, 2017

      • mayhem doesn't like tousseling with the consistency police nor the ham-police.
      • 2017-01-17 01755, 2017

      • SothoTalKer
        i might install a virtual machine with py2.7 for testing
      • 2017-01-17 01742, 2017

      • Quesito
        LOL mayhem!
      • 2017-01-17 01725, 2017

      • mayhem
        well, I'm just to make everyone aware, especially the vegans, that many air quality samples in spain have been found to contain ham-vapour.
      • 2017-01-17 01734, 2017

      • Freso
        SothoTalKer: You could just install a Linux VM.
      • 2017-01-17 01737, 2017

      • mayhem
        hence the mention of the ham-police. those guys are mean.
      • 2017-01-17 01752, 2017

      • SothoTalKer
        Freso: go away, devil =D
      • 2017-01-17 01741, 2017

      • Freso has left the channel
      • 2017-01-17 01758, 2017

      • SothoTalKer
        :<
      • 2017-01-17 01706, 2017

      • Quesito
        mayhem: the air here contains more than just ham-vapor!
      • 2017-01-17 01725, 2017

      • mayhem
        lots of two-stroke scooter exhaust?
      • 2017-01-17 01744, 2017

      • Freso joined the channel
      • 2017-01-17 01759, 2017

      • mayhem
        or are you talking about the yet-not-scientifically-confirmed foi-gras vapours that waft in from france?
      • 2017-01-17 01731, 2017

      • SothoTalKer
        Freso: IF i ever do that it has to be beginner-friendly ;)
      • 2017-01-17 01752, 2017

      • reosarevok
        If you can deal with the mess that is developing in Windows, you don't need something beginner-friendly :D
      • 2017-01-17 01754, 2017

      • SothoTalKer
        but someone has to do it. :x
      • 2017-01-17 01726, 2017

      • reosarevok is stuck with Java in Windows in his internship and why. Just why.
      • 2017-01-17 01750, 2017

      • Quesito
        tweeted!
      • 2017-01-17 01731, 2017

      • SothoTalKer
        companies love java :D
      • 2017-01-17 01739, 2017

      • Quesito
        mayhem: definitely the foie-gras fumes!!!!
      • 2017-01-17 01714, 2017

      • mayhem
        I really like the independence flag that is a few blocks away. I can see when the wind blows from france. time to go outside and inhale deep!
      • 2017-01-17 01718, 2017

      • mayhem
        tweet looks good.
      • 2017-01-17 01733, 2017

      • mayhem
        feel free to mix it up with different language.
      • 2017-01-17 01746, 2017

      • mayhem
        we really don't want it to feel like we're a bunch of bots.