#metabrainz

/

      • D4RK-PH0ENiX has quit
      • 2017-10-15 28850, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-10-15 28853, 2017

      • D4RK-PH0ENiX has quit
      • 2017-10-15 28801, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-10-15 28839, 2017

      • heyoni joined the channel
      • 2017-10-15 28850, 2017

      • ZarkBit has quit
      • 2017-10-15 28852, 2017

      • heyoni
        I just downloaded and started up the VM but there's nothing on port 8080. Do I need to do anything to get that?
      • 2017-10-15 28859, 2017

      • kepstin has quit
      • 2017-10-15 28828, 2017

      • ZarkBit joined the channel
      • 2017-10-15 28808, 2017

      • kyan has quit
      • 2017-10-15 28815, 2017

      • heyoni
        I think I figured it out. had to start the docker image manually...
      • 2017-10-15 28850, 2017

      • Nyanko-sensei joined the channel
      • 2017-10-15 28807, 2017

      • D4RK-PH0ENiX has quit
      • 2017-10-15 28831, 2017

      • heyoni has quit
      • 2017-10-15 28807, 2017

      • heyoni joined the channel
      • 2017-10-15 28829, 2017

      • heyoni has quit
      • 2017-10-15 28818, 2017

      • heyoni joined the channel
      • 2017-10-15 28843, 2017

      • gcilou joined the channel
      • 2017-10-15 28812, 2017

      • agentsim_ has quit
      • 2017-10-15 28847, 2017

      • CatQuest has quit
      • 2017-10-15 28822, 2017

      • CatQuest joined the channel
      • 2017-10-15 28822, 2017

      • CatQuest has quit
      • 2017-10-15 28822, 2017

      • CatQuest joined the channel
      • 2017-10-15 28843, 2017

      • agentsim joined the channel
      • 2017-10-15 28840, 2017

      • agentsim has quit
      • 2017-10-15 28833, 2017

      • agentsim joined the channel
      • 2017-10-15 28830, 2017

      • heyoni has quit
      • 2017-10-15 28801, 2017

      • CatQuest has quit
      • 2017-10-15 28833, 2017

      • CatQuest joined the channel
      • 2017-10-15 28833, 2017

      • CatQuest has quit
      • 2017-10-15 28833, 2017

      • CatQuest joined the channel
      • 2017-10-15 28857, 2017

      • CatQuest has quit
      • 2017-10-15 28830, 2017

      • CatQuest joined the channel
      • 2017-10-15 28830, 2017

      • CatQuest has quit
      • 2017-10-15 28830, 2017

      • CatQuest joined the channel
      • 2017-10-15 28832, 2017

      • agentsim has quit
      • 2017-10-15 28848, 2017

      • agentsim joined the channel
      • 2017-10-15 28809, 2017

      • khan joined the channel
      • 2017-10-15 28821, 2017

      • sampsyo has quit
      • 2017-10-15 28845, 2017

      • sampsyo joined the channel
      • 2017-10-15 28831, 2017

      • reosarevok
        samj1912: I'll check soonish - have a deadline tomorrow so trying to finish that first :)
      • 2017-10-15 28803, 2017

      • reosarevok
        bitmap: please :) Instrument only of course
      • 2017-10-15 28816, 2017

      • samj1912
        No problem o/
      • 2017-10-15 28825, 2017

      • samj1912
        Good morning :D
      • 2017-10-15 28857, 2017

      • reosarevok
        Morning :)
      • 2017-10-15 28833, 2017

      • github joined the channel
      • 2017-10-15 28833, 2017

      • github
        [acousticbrainz-server] paramsingh opened pull request #237: Fix docstring of data dump function (master...docs-fix) https://git.io/vd17f
      • 2017-10-15 28833, 2017

      • github has left the channel
      • 2017-10-15 28840, 2017

      • reosarevok
      • 2017-10-15 28801, 2017

      • CatQuest has quit
      • 2017-10-15 28835, 2017

      • CatQuest joined the channel
      • 2017-10-15 28841, 2017

      • CatQuest has quit
      • 2017-10-15 28841, 2017

      • CatQuest joined the channel
      • 2017-10-15 28852, 2017

      • khan has quit
      • 2017-10-15 28805, 2017

      • CatQuest has quit
      • 2017-10-15 28838, 2017

      • CatQuest joined the channel
      • 2017-10-15 28840, 2017

      • CatQuest has quit
      • 2017-10-15 28840, 2017

      • CatQuest joined the channel
      • 2017-10-15 28853, 2017

      • Zastai|2 joined the channel
      • 2017-10-15 28850, 2017

      • CatQuest has quit
      • 2017-10-15 28823, 2017

      • CatQuest joined the channel
      • 2017-10-15 28823, 2017

      • CatQuest has quit
      • 2017-10-15 28823, 2017

      • CatQuest joined the channel
      • 2017-10-15 28847, 2017

      • samj1912
        reosarevok: bitmap can you point me to the logic of how type of a RG is determined when it has a secondary type?
      • 2017-10-15 28830, 2017

      • samj1912
        yvanzo: ^
      • 2017-10-15 28800, 2017

      • samj1912
      • 2017-10-15 28809, 2017

      • Zastai|2 has quit
      • 2017-10-15 28853, 2017

      • reosarevok
      • 2017-10-15 28840, 2017

      • Zastai joined the channel
      • 2017-10-15 28834, 2017

      • Zastai has quit
      • 2017-10-15 28813, 2017

      • github joined the channel
      • 2017-10-15 28813, 2017

      • github
        [sir] samj1912 opened pull request #40: SOLR-61: Bring Recording to search parity (master...solr61) https://git.io/vd1b0
      • 2017-10-15 28813, 2017

      • github has left the channel
      • 2017-10-15 28846, 2017

      • samj1912
        reosarevok: thanks
      • 2017-10-15 28816, 2017

      • reosarevok
        np :) (not sure if this is more relevant or not, but just in case it is)
      • 2017-10-15 28839, 2017

      • samj1912
        it was the same, but easier to read I guess
      • 2017-10-15 28801, 2017

      • samj1912
        I wanted to ask about a couple of things in SOLR-61
      • 2017-10-15 28801, 2017

      • BrainzBot
        SOLR-61: Recording is not upto parity https://tickets.metabrainz.org/browse/SOLR-61
      • 2017-10-15 28831, 2017

      • samj1912
        having artist-credit in release again
      • 2017-10-15 28835, 2017

      • samj1912
        is that needed?
      • 2017-10-15 28844, 2017

      • samj1912
        it is not shown in the current solr-search results
      • 2017-10-15 28853, 2017

      • samj1912
        s/solr-search/search
      • 2017-10-15 28813, 2017

      • samj1912
        although its there in the solr results and I have left it there for now
      • 2017-10-15 28832, 2017

      • reosarevok
        Yes, because they're different (it's the artist vs. album artist difference)
      • 2017-10-15 28855, 2017

      • reosarevok
        Like, if you check the example in https://musicbrainz.org/ws/2/recording?query=tid:… - the recording one is the band, release is Various Artists
      • 2017-10-15 28856, 2017

      • samj1912
        so the current search server is wrong ?
      • 2017-10-15 28805, 2017

      • samj1912
        yes, I saw cases where they were different
      • 2017-10-15 28810, 2017

      • samj1912
        but in a lot of cases its the same
      • 2017-10-15 28831, 2017

      • reosarevok
        I mean they represent different things
      • 2017-10-15 28838, 2017

      • reosarevok
        Is it not shown in search results if they're the same?
      • 2017-10-15 28809, 2017

      • samj1912
        its not shown in the current search at all
      • 2017-10-15 28859, 2017

      • reosarevok
        Huh? But that link up there is to the current search
      • 2017-10-15 28804, 2017

      • reosarevok
        Or what am I missing?
      • 2017-10-15 28816, 2017

      • samj1912
        oh sorry it is
      • 2017-10-15 28823, 2017

      • samj1912
        I meant the alias list
      • 2017-10-15 28854, 2017

      • samj1912
        alias list in the artist credit of a related release
      • 2017-10-15 28807, 2017

      • reosarevok
        Oh
      • 2017-10-15 28825, 2017

      • reosarevok
        Hmm
      • 2017-10-15 28834, 2017

      • reosarevok
        I think that might have been intentionally dropped at some point
      • 2017-10-15 28853, 2017

      • samj1912
        and also the current solr server outputs the artist on each release(even if its the same)
      • 2017-10-15 28859, 2017

      • samj1912
        I think I should fix that
      • 2017-10-15 28823, 2017

      • reosarevok
        Does the search not do that?
      • 2017-10-15 28827, 2017

      • reosarevok
        (the current search)
      • 2017-10-15 28835, 2017

      • reosarevok
        I haven't checked, but I'd expect it to be there
      • 2017-10-15 28850, 2017

      • samj1912
        nope, it doesn't show artist credit for a related release if it is the same as the original recording
      • 2017-10-15 28859, 2017

      • reosarevok
        Huh
      • 2017-10-15 28804, 2017

      • reosarevok
        Well, then you should keep that I guess, yeah
      • 2017-10-15 28826, 2017

      • samj1912
        okay
      • 2017-10-15 28808, 2017

      • reosarevok
        And the alias list thing should be kept as in the current search for now too I guess, concentrate on parity :)
      • 2017-10-15 28827, 2017

      • reosarevok
        (if someone thinks it should be added back to solr later, they can ask for it)
      • 2017-10-15 28850, 2017

      • arbenina_ joined the channel
      • 2017-10-15 28805, 2017

      • ruaok
        bitmap: > did someone delete Gentlecat's MB account? he asked what happened to it, and that also might explain what happened to the OAuth keys, since they were attached to his account
      • 2017-10-15 28836, 2017

      • ruaok
        it was the exact opposite way around. Gentlecat removed the oauth keys from meb.org, officebrainz and CB -- all the sites he created, which would've been fine, but he did not warn me about doing this. this disabled logins on those sites, which was a willful act of sabotage. Once I cleaned up the mess, I deleted his account.
      • 2017-10-15 28852, 2017

      • samj1912
        ruaok: please have a look at the pending PRs on sir when you have time :)
      • 2017-10-15 28807, 2017

      • ruaok
        I won't have time today, sorry.
      • 2017-10-15 28816, 2017

      • samj1912
        okay
      • 2017-10-15 28841, 2017

      • iliekcomputers
        Happy weekend😬
      • 2017-10-15 28805, 2017

      • CatQuest has quit
      • 2017-10-15 28838, 2017

      • CatQuest joined the channel
      • 2017-10-15 28838, 2017

      • CatQuest has quit
      • 2017-10-15 28838, 2017

      • CatQuest joined the channel
      • 2017-10-15 28830, 2017

      • github joined the channel
      • 2017-10-15 28830, 2017

      • github
        [mmd-schema] samj1912 closed pull request #11: Create definition for language (master...solr) https://git.io/vdV8O
      • 2017-10-15 28830, 2017

      • github has left the channel
      • 2017-10-15 28807, 2017

      • Nyanko-sensei has quit
      • 2017-10-15 28836, 2017

      • SothoTalKer
        maybe it was just a misunderstanding :x
      • 2017-10-15 28825, 2017

      • github joined the channel
      • 2017-10-15 28825, 2017

      • github
        [sir] mayhem closed pull request #38: SOLR-17: Remove tag count due to buggy JSON output (master...solr17) https://git.io/vd10m
      • 2017-10-15 28826, 2017

      • github has left the channel
      • 2017-10-15 28815, 2017

      • ruaok sneaks in some reviews
      • 2017-10-15 28832, 2017

      • ruaok
        samj1912: I realize I haven't answered you from a few days ago about how I do reviews.
      • 2017-10-15 28801, 2017

      • ruaok
        for the search stuff, I just read the code -- I don't have a complete setup to test things.
      • 2017-10-15 28844, 2017

      • ruaok
        whereas for LB I have the complete setup (it is very easy to setup) and then I can actually run the code through a few tests.
      • 2017-10-15 28834, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-10-15 28803, 2017

      • github joined the channel
      • 2017-10-15 28803, 2017

      • github
        [sir] mayhem closed pull request #39: SOLR-60: Bring Instruments to search parity (master...solr60) https://git.io/vd1EA
      • 2017-10-15 28803, 2017

      • github has left the channel
      • 2017-10-15 28850, 2017

      • D4RK-PH0ENiX has quit
      • 2017-10-15 28812, 2017

      • SothoTalKer
        i hope solr won't bring as much search errors as the current one :)
      • 2017-10-15 28840, 2017

      • samj1912
        ruaok: should I break https://github.com/metabrainz/sir/pull/40 into smaller commits?
      • 2017-10-15 28857, 2017

      • arbenina_ has quit
      • 2017-10-15 28833, 2017

      • reosarevok
        SothoTalKer: if it brings the exact same amount of errors, but with instant indexing, I'd already be kinda happy :D
      • 2017-10-15 28846, 2017

      • SothoTalKer
        :p
      • 2017-10-15 28832, 2017

      • agentsim has quit
      • 2017-10-15 28849, 2017

      • ruaok
        samj1912: I think that is too much work for nothing.
      • 2017-10-15 28816, 2017

      • ruaok
        how about making the bugs in the ticket more clear and labeling them and then also adding labels to the PR so I can see what fixes what issue.
      • 2017-10-15 28837, 2017

      • samj1912
        Okay
      • 2017-10-15 28832, 2017

      • samj1912
        I think we should reach search parity by the end of next week. Only 5 entities to go \o/. Then onto live indexing
      • 2017-10-15 28808, 2017

      • agentsim joined the channel
      • 2017-10-15 28858, 2017

      • reosarevok
        Whee!