0:02 AM
D4RK-PH0ENiX joined the channel
2019-04-08 09813, 2019
0:09 AM
baniket has quit
2019-04-08 09841, 2019
0:43 AM
code_master5 has quit
2019-04-08 09806, 2019
0:59 AM
Nyanko-sensei joined the channel
2019-04-08 09812, 2019
1:01 AM
D4RK-PH0ENiX has quit
2019-04-08 09848, 2019
1:40 AM
demonimin_ joined the channel
2019-04-08 09854, 2019
1:40 AM
demonimin has quit
2019-04-08 09804, 2019
1:48 AM
demonimin_ has quit
2019-04-08 09813, 2019
1:48 AM
ferbncode has quit
2019-04-08 09853, 2019
2:05 AM
demonimin joined the channel
2019-04-08 09830, 2019
2:47 AM
aliamo joined the channel
2019-04-08 09811, 2019
2:49 AM
ro0fka joined the channel
2019-04-08 09817, 2019
2:51 AM
ro0fka has left the channel
2019-04-08 09842, 2019
2:51 AM
aliamo has quit
2019-04-08 09818, 2019
3:04 AM
Nyanko-sensei has quit
2019-04-08 09856, 2019
3:04 AM
D4RK-PH0ENiX joined the channel
2019-04-08 09842, 2019
4:46 AM
spellew has quit
2019-04-08 09805, 2019
6:18 AM
baniket joined the channel
2019-04-08 09808, 2019
6:30 AM
gr0uch0mars joined the channel
2019-04-08 09817, 2019
7:15 AM
ferbncode joined the channel
2019-04-08 09807, 2019
7:40 AM
ruaok
moooooin!
2019-04-08 09832, 2019
7:40 AM
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | New GSoC students start here: https://goo.gl/7jsjG2 | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda (17:00 UTC): Reviews, Season of Docs (reo), next meetings (Freso), howto guides (ruaok)
2019-04-08 09815, 2019
7:41 AM
ruaok
pristine__: last night it became clear to me that it isn't obvious how to write data processing scripts that produce useful output.
2019-04-08 09837, 2019
7:41 AM
ruaok
kartekeya had problems with this as well. I've been doing it for so many years, I took this morning to collect my thoughts:
2019-04-08 09840, 2019
7:41 AM
ruaok
2019-04-08 09851, 2019
7:41 AM
ruaok
give it a read and the let's discuss, ok?
2019-04-08 09817, 2019
7:49 AM
pristine__
ruaok: hi. I will return in sometime after the class. Let's discuss then, okay? :)
2019-04-08 09829, 2019
7:49 AM
ruaok
no rush
2019-04-08 09825, 2019
7:52 AM
anshuman73
Is it a good idea to include non-development work as a part of GSoC ? For eg. I think designing of badges achievements for CB's gamification can be done in the timespan, maybe even alonside woth coding parts, but am not sure if that should be a part of the proposal. TBH I would like to make it a part of it.
2019-04-08 09858, 2019
7:53 AM
yvanzo
mo’’in’
2019-04-08 09815, 2019
7:54 AM
ruaok
moin yvanzo!
2019-04-08 09841, 2019
7:54 AM
ruaok
anshuman73: yes, that is fine. the main criteria is that the GSoC project needs some amount of coding -- it can't be all design.
2019-04-08 09837, 2019
8:04 AM
Lotheric has quit
2019-04-08 09853, 2019
8:04 AM
Lotheric joined the channel
2019-04-08 09852, 2019
8:29 AM
aliamo joined the channel
2019-04-08 09852, 2019
8:30 AM
reosarevok
ruaok: speaking of design - my MeB keyring died :(
2019-04-08 09828, 2019
8:31 AM
reosarevok
Feels the hole was a bit too close to the edge or something?
2019-04-08 09837, 2019
8:31 AM
anshuman73
ruaok: yes, ofc. Design is a small part of my proposed work
2019-04-08 09828, 2019
8:34 AM
aliamo has quit
2019-04-08 09809, 2019
8:35 AM
ruaok
reosarevok: the wooden one?
2019-04-08 09815, 2019
8:35 AM
reosarevok
Yeah
2019-04-08 09829, 2019
8:35 AM
ruaok
oops. good to know. I've got more, you can get another one.
2019-04-08 09827, 2019
8:37 AM
CatQuest
how does a keyring die??
2019-04-08 09828, 2019
8:37 AM
reosarevok
I mean, I used it for like half a year and it was in my pocket every day :)
2019-04-08 09819, 2019
8:38 AM
CatQuest
wait a wooden keyring? aren't those usually metal with optipnal dangly bits
2019-04-08 09808, 2019
8:39 AM
reosarevok
2019-04-08 09822, 2019
8:39 AM
reosarevok
The dangly bit was the problem :)
2019-04-08 09842, 2019
8:39 AM
reosarevok
The hole is very close to the edge, and that small strip in between just eventually broke
2019-04-08 09843, 2019
8:39 AM
CatQuest
yea. woddis not a good material for keurings
2019-04-08 09846, 2019
8:39 AM
anshuman73
okay, that is one really nice keyring
2019-04-08 09806, 2019
8:40 AM
CatQuest
atleast without some kind of metal reenforchment
2019-04-08 09810, 2019
8:41 AM
reosarevok
I guess it'd be hard to use a reinforcement while still making it with the fancy cutty machine
2019-04-08 09824, 2019
8:41 AM
reosarevok
But I feel if the hole was a biiit further down, it would be much more resistant
2019-04-08 09836, 2019
8:41 AM
CatQuest
rob has a fancy 3-d printer, no?
2019-04-08 09837, 2019
8:41 AM
reosarevok
I also have no clue how materials work though :D
2019-04-08 09842, 2019
8:41 AM
CatQuest
tsk
2019-04-08 09812, 2019
8:42 AM
outsidecontext joined the channel
2019-04-08 09817, 2019
8:42 AM
yvanzo
reosarevok, bitmap: is it a nice day for beta release?
2019-04-08 09837, 2019
8:42 AM
reosarevok
Possibly?
2019-04-08 09844, 2019
8:42 AM
reosarevok
I have no idea how releases work
2019-04-08 09855, 2019
8:42 AM
CatQuest
depends, how much are you gonna wreck this time? ;)
2019-04-08 09807, 2019
8:43 AM
reosarevok
It has a lot of my code, so god only knows
2019-04-08 09814, 2019
8:43 AM
yvanzo
Let me know which standalone PRs could still be merged today :)
2019-04-08 09819, 2019
8:43 AM
reosarevok
yvanzo: I would like to try doing one at some point myself, but today I'm going to the countryside again etc
2019-04-08 09828, 2019
8:43 AM
reosarevok
Unless you want to do it now :)
2019-04-08 09808, 2019
8:44 AM
CatQuest
wait. reosarevok doesn't know how releases work?!?
2019-04-08 09808, 2019
8:44 AM
CatQuest
2019-04-08 09814, 2019
8:44 AM
CatQuest
:D
2019-04-08 09816, 2019
8:44 AM
reosarevok slaps CatQuest with a trout
2019-04-08 09826, 2019
8:44 AM
CatQuest
:D
2019-04-08 09830, 2019
8:44 AM
CatQuest
fish!
2019-04-08 09833, 2019
8:44 AM
CatQuest noms
2019-04-08 09847, 2019
8:44 AM
yvanzo
Would be nice to have it done today so as to bring beta cycle back.
2019-04-08 09802, 2019
8:45 AM
yvanzo
CatQuest: nice one :)
2019-04-08 09803, 2019
8:45 AM
CatQuest
idk, cna you guys update test any time soon?
2019-04-08 09819, 2019
8:45 AM
CatQuest
with the new search for example etc
2019-04-08 09825, 2019
8:45 AM
CatQuest
yvanzo: :D
2019-04-08 09820, 2019
8:46 AM
yvanzo
reosarevok: if we get back to beta cycle, you will have the opportunity to do a release yourself every week :)
2019-04-08 09829, 2019
8:46 AM
CatQuest
oh no
2019-04-08 09840, 2019
8:46 AM
reosarevok
You mean every two weeks?
2019-04-08 09850, 2019
8:46 AM
reosarevok
Or ok, one beta one prod
2019-04-08 09851, 2019
8:46 AM
reosarevok
Sure
2019-04-08 09808, 2019
8:47 AM
reosarevok
Anyway, yvanzo: today is good, if you have the time. Is there something I can / should do?
2019-04-08 09816, 2019
8:47 AM
reosarevok
I'll check prs for a sec
2019-04-08 09823, 2019
8:47 AM
yvanzo
ok, thanks
2019-04-08 09825, 2019
8:47 AM
reosarevok
The sidebar ones are small
2019-04-08 09834, 2019
8:54 AM
reosarevok
2019-04-08 09859, 2019
8:54 AM
reosarevok
2019-04-08 09830, 2019
8:55 AM
reosarevok
2019-04-08 09855, 2019
8:55 AM
reosarevok
2019-04-08 09802, 2019
8:56 AM
reosarevok
2019-04-08 09807, 2019
8:56 AM
reosarevok
But none are super urgent or anything
2019-04-08 09839, 2019
8:56 AM
reosarevok
CatQuest: update test yes, with the new search dunno
2019-04-08 09854, 2019
8:56 AM
yvanzo
Yeah but we won’t be able to merge any during beta, so better take small fishes for now.
2019-04-08 09855, 2019
8:56 AM
reosarevok
AFAICT updating test is easy, but changing it to use SOLR might not be? yvanzo would know
2019-04-08 09809, 2019
8:58 AM
alastairp
iliekcomputers: thanks for the dump
2019-04-08 09818, 2019
9:00 AM
yvanzo
reosarevok: Why do we have both schema-change-2018-q4 and schema-change-2019-q2 branches? Shouldn’t the first one be renamed into the second one?
2019-04-08 09851, 2019
9:00 AM
reosarevok
Maybe? Probably? Ask bitmap :D
2019-04-08 09801, 2019
9:01 AM
yvanzo
schema-change-2018-q4 has never been released but still contain required changes for the next schema change release
2019-04-08 09809, 2019
9:01 AM
reosarevok
He said we didn't have a branch to point my PR into, so he created one
2019-04-08 09849, 2019
9:01 AM
BrainzGit
2019-04-08 09851, 2019
9:01 AM
BrainzBot
2019-04-08 09822, 2019
9:02 AM
reosarevok
2019-04-08 09830, 2019
9:02 AM
reosarevok
Oh, wait
2019-04-08 09832, 2019
9:02 AM
reosarevok
Commit message
2019-04-08 09835, 2019
9:02 AM
reosarevok
Ok, let me see
2019-04-08 09803, 2019
9:06 AM
yvanzo
reosarevok: Sorry I wanted to approve 989 instead of 999
2019-04-08 09819, 2019
9:06 AM
reosarevok
I got that, I was just trying to figure out what was missing because the code issues were fixed
2019-04-08 09826, 2019
9:06 AM
reosarevok
And then realized the commit message bit was left
2019-04-08 09853, 2019
9:06 AM
Gazooo joined the channel
2019-04-08 09857, 2019
9:06 AM
yvanzo
reosarevok: see GCIers commit messages for example ;)
2019-04-08 09821, 2019
9:07 AM
reosarevok
I'm always a bit confused about commit messages vs. PR messages vs. JIRA tickets
2019-04-08 09830, 2019
9:08 AM
reosarevok
2019-04-08 09843, 2019
9:08 AM
reosarevok
That ok? Specific examples are in the tests, but I guess I can add them there if needed?
2019-04-08 09809, 2019
9:09 AM
yvanzo
reosarevok: also remove subdomain and allow for +artist
2019-04-08 09832, 2019
9:09 AM
reosarevok
+artist was always allowed, I changed nothing there :)
2019-04-08 09843, 2019
9:09 AM
reosarevok
2019-04-08 09822, 2019
9:10 AM
yvanzo
I mean it was not specifically taken into account
2019-04-08 09855, 2019
9:10 AM
reosarevok
Ok I guess
2019-04-08 09858, 2019
9:10 AM
yvanzo
Btw, now that there is a 'clean' function, maybe the 'validate' function should allow clean URLs only.
2019-04-08 09802, 2019
9:13 AM
yvanzo
reosarevok: I prefer to wait for PR authors to merge their own PRs, just in case they have other changes in mind.
2019-04-08 09809, 2019
9:13 AM
reosarevok
Sure
2019-04-08 09854, 2019
9:13 AM
yvanzo
Anyway, I will probably make beta release in the evening only.
2019-04-08 09803, 2019
9:15 AM
reosarevok
yvanzo: how do we generally do the validate thing?
2019-04-08 09803, 2019
9:16 AM
reosarevok
(validate only if clean I mean)
2019-04-08 09822, 2019
9:16 AM
yvanzo
2019-04-08 09822, 2019
9:16 AM
reosarevok
Or do you just mean check it matches https:\/\/secondhandsongs\.com\/\w+\/[\d+]+ ?
2019-04-08 09838, 2019
9:16 AM
reosarevok
Sure, I just want to understand what that means
2019-04-08 09840, 2019
9:16 AM
yvanzo
it’s the same thing?
2019-04-08 09832, 2019
9:17 AM
reosarevok
Just means changing const m = /secondhandsongs\.com\/([a-z]+)\//.exec(url); to a more specific cleanup?
2019-04-08 09844, 2019
9:17 AM
reosarevok
eh. more specific *regex*
2019-04-08 09841, 2019
9:18 AM
yvanzo
more specific, as in, validate that URL is standardized
2019-04-08 09854, 2019
9:18 AM
reosarevok
So, const m = /^https:\/\/secondhandsongs\.com\/(\w+)\/[\d+]+$/.exec(url); ?
2019-04-08 09817, 2019
9:19 AM
yvanzo
yup :)
2019-04-08 09859, 2019
9:20 AM
reosarevok
2019-04-08 09813, 2019
9:21 AM
reosarevok
2019-04-08 09821, 2019
9:21 AM
reosarevok
That one we should try to merge
2019-04-08 09817, 2019
9:22 AM
reosarevok
2019-04-08 09822, 2019
9:23 AM
reosarevok
2019-04-08 09816, 2019
9:27 AM
reosarevok
2019-04-08 09844, 2019
9:28 AM
yvanzo
I did not get the comment about align-right, is it "generic" as in for every column?
2019-04-08 09800, 2019
9:29 AM
reosarevok
No, generic as "use this class for everything that should have right-align"
2019-04-08 09813, 2019
9:29 AM
reosarevok
We also have, say:
2019-04-08 09815, 2019
9:29 AM
reosarevok
2019-04-08 09853, 2019
9:32 AM
reosarevok
Also this:
2019-04-08 09854, 2019
9:32 AM
reosarevok
2019-04-08 09801, 2019
9:33 AM
reosarevok
Everything else for that seems to be barcode
2019-04-08 09827, 2019
9:38 AM
akhilesh joined the channel
2019-04-08 09814, 2019
9:40 AM
yvanzo
reosarevok: ok, added comment to the PR.
2019-04-08 09837, 2019
9:40 AM
letaiv joined the channel
